Re: [janitor] programs/wcmd -Wwrite-strings cleanup

2003-10-09 Thread Kevin Groeneveld
Alexandre Julliard wrote: In some cases parameters to API functions are not declared const even though they really are const; some of these could be fixed. Notably, all the 16-bit ones can be freely changed since no external code depends on them. Some 32-bit ones can probably be changed too, like a

Re: BuildCommDCB conformance test

2003-09-11 Thread Kevin Groeneveld
Dimitrie O. Paun wrote: On September 11, 2003 01:32 am, Kevin Groeneveld wrote: If my previous patch to BuildCommDCB is applied, then the test runs ok. Looks good. Send it over to wine-patches to be included in the tree. It's good to know I am on the right track. I want to add some more

BuildCommDCB conformance test

2003-09-10 Thread Kevin Groeneveld
-20030813/dlls/kernel/tests/build_dcb.c 1969-12-31 19:00:00.0 -0500 +++ wine-20030813.patched/dlls/kernel/tests/build_dcb.c 2003-09-11 01:00:19.0 -0400 @@ -0,0 +1,171 @@ +/* Unit test suite for BuildCommDCBA/W & BuildCommDCBAndTimeoutsA/W + * + * Copyright 2003 Kevin Groene

Re: BuildCommDCBAndTimeouts patch

2003-09-09 Thread Kevin Groeneveld
Jakob Eriksson wrote: Could you also make test.c into a regression test for inclusion into Wine? That is almost more important than the actual patch to Wine - if we have the conformance test, it ensures changes to Wine in the future does not destroy functionality. I agree that this would be a good