Re: [PATCH 3/3] gdiplus/test: Remove todos for tests that pass now [Try 4]

2010-02-25 Thread Justin Chevrier
On Thu, Feb 25, 2010 at 9:19 PM, Charles Davis wrote: > Justin Chevrier wrote: >> --- >>  dlls/gdiplus/tests/graphics.c |   22 +++--- >>  1 files changed, 11 insertions(+), 11 deletions(-) > You're still not getting it! > > Remember, when each p

Re: [PATCH 1/2] gdiplus/test: Add GdipGetNearestColor test [Try 3]

2010-02-25 Thread Justin Chevrier
Do I need that for the 1,4 and 8bpp tests? With my patch to GdipGetNearestColor these tests pass and behave like Windows 7. I did forget a todo_wine on the 16bpp grayscale test though... On Thu, Feb 25, 2010 at 7:53 PM, Vincent Povirk wrote: >> +        status = GdipGetNearestColor(graphics, &col

Re: [PATCH 1/2] gdiplus/test: Add GdipGetNearestColor test [try 2]

2010-02-24 Thread Justin Chevrier
> It would be worth trying your test on Windows 7, as some other > problems with paletted images were fixed in that version. > > You could also try creating an 8-bit device-independent bitmap using > gdi32 and selecting it into a compatible DC. > > On Wed, Feb 24, 2010 at

Re: [PATCH 1/2] gdiplus/test: Add GdipGetNearestColor test [try 2]

2010-02-24 Thread Justin Chevrier
make it > possible to test other depths, even though they can't yet be > implemented properly in Wine. > > Also, you should mark tests that fail in wine with todo_wine and > remove the todo_wine in any subsequent patches that fix them. > > On Tue, Feb 23, 2010 at 8:56 PM, J

Re: [PATCH 1/4] msctf: Add ITfLangBarMgr Interface [Try 3]

2010-02-16 Thread Justin Chevrier
On Tue, Feb 16, 2010 at 9:46 AM, Nikolay Sivov wrote: > On 2/16/2010 17:34, Justin Chevrier wrote: >> >> On Tue, Feb 16, 2010 at 7:25 AM, Alexandre Julliard >>  wrote: >> >>> >>> Justin Chevrier  writes: >>> >>> >>&

Re: [PATCH 1/4] msctf: Add ITfLangBarMgr Interface [Try 3]

2010-02-16 Thread Justin Chevrier
On Tue, Feb 16, 2010 at 7:25 AM, Alexandre Julliard wrote: > Justin Chevrier writes: > >> @@ -1357,3 +1362,52 @@ interface ITfThreadFocusSink : IUnknown >> >>      HRESULT OnKillThreadFocus(); >>  }; >> + >> +[ >> +    object, &

Re: [PATCH 4/4] msctf: Implement stubbed out TF_CreateLangBarMgr [Try 2]

2010-02-15 Thread Justin Chevrier
On Mon, Feb 15, 2010 at 9:34 AM, Aric Stewart wrote: > Hi, > >  I am really happy that you are helping with the msctf stuff I started. Very > cool! > >  2 quick things. > > 1) typedef struct tagACLMulti,   don't call it tagACLMulti.  I am sure this > is from copying from threadmgr.c where it is a

Re: [PATCH 1/7] msctf: Add langbarmgr.c

2010-02-11 Thread Justin Chevrier
Thanks for the feed back! I should have went with my gut on these and sent them through together. They were really meant to all be applied in one go. Justin On Thu, Feb 11, 2010 at 12:22 PM, Nikolay Sivov wrote: > On 2/11/2010 19:51, Justin Chevrier wrote: >> >> --- >>  dl

Re: [PATCH 1/7] msctf: Add langbarmgr.c

2010-02-11 Thread Justin Chevrier
Thanks for the feedback. Would submitting this as one patch be acceptable? My intention was really to have all this applied in one go. If not, I'll split as recommended. I've got some fixing up to do and I'll resubmit. Justin On Thu, Feb 11, 2010 at 1:27 PM, Justin Chevrier wro

Re: [PATCH 1/7] msctf: Add langbarmgr.c

2010-02-11 Thread Justin Chevrier
Thanks for the feed back! I should have went with my gut on these and sent them through together. They were really meant to all be applied in one go. Justin On Thu, Feb 11, 2010 at 12:22 PM, Nikolay Sivov wrote: > On 2/11/2010 19:51, Justin Chevrier wrote: >> >> --- >>  dl

Re: Create stub dosx.exe

2008-03-25 Thread Justin Chevrier
Dmitry Timoshkov wrote: > "Justin Chevrier" <[EMAIL PROTECTED]> wrote: > >> +#define WIN32_LEAN_AND_MEAN >> + >> +#include > > What's the reason to include anything in an empty stub? > >> +int main(int argc, char *argv[]) >> +{ >> +return 0; >> +} > Ya, that shouldn't be there. Thanks Dmitry.

Re: Create stub dosx.exe

2008-03-25 Thread Justin Chevrier
Alexandre Julliard wrote: > Justin Chevrier <[EMAIL PROTECTED]> writes: > > >> I've got a console app (Master of Orion 2 1.40p23 patch >> http://www.spheriumnorth.com/blog-images/Moo2v140b23.zip ) that >> crashes if it doesn't find dosx.exe in the sys

Re: Create stub dosx.exe

2008-03-25 Thread Justin Chevrier
Alexandre Julliard wrote: > Justin Chevrier <[EMAIL PROTECTED]> writes: > > >> Changelog: >> >> Create stub dosx.exe >> > > Why do you need this? > > I've got a console app (Master of Orion 2 1.40p23 patch http://www.spheriumnor

Re: DestroyWindow behavior differences between Win9x and Win2k/xp

2008-03-10 Thread Justin Chevrier
Juan Lang wrote: >> I'm looking into a crash of Master Of Orion II on exit (both in Wine and >> Windows XP). The problem appears to be that the program is attempting to >> do a DestroyWindow on a different thread. This is not allowed by our >> code and that behavior is backed up by MSDN documen

DestroyWindow behavior differences between Win9x and Win2k/xp

2008-03-10 Thread Justin Chevrier
ab to the console. Opinions on the correct course of action to resolve this? Thanks Justin Chevrier

Re: wine.inf: Create fake dll entry for dosx.exe

2008-02-29 Thread Justin Chevrier
> Changelog: > > Create a fake dll entry for dosx.exe Anything wrong with this one liner? Justin Chevrier

Re: USER32: Hide cursor when calling SetCursor with NULL HCURSOR

2006-02-09 Thread Justin Chevrier
Andreas Mohr wrote: Hi, On Fri, Feb 03, 2006 at 07:50:51PM -0500, Justin Chevrier wrote: Changelog: Hide cursor if SetCursor is called with a NULL HCURSOR Which obviously implies the question: What if the program does a SetCursor(something) later? Should it then re-show a cursor

Re: USER32: Sysparams unit tests fixes and additions

2005-03-01 Thread Justin Chevrier
Paul Vriens wrote: On Tue, 2005-03-01 at 05:53, [EMAIL PROTECTED] wrote: Changelog: * Created SPI_{GET,SET}KEYBOARDPREF and SPI_{GET,SET}SCREENREADER unit tests * Removed a trace that shouldn't have been there * Add return checking to SPI_{GET,SET}WHEELSCROLLLINES and SPI_{GET,SET}MENUSHOWDELAY

Re: [user32/tests/sysparams.c] Check for availability of SPI_GETICONTITLEWRAP

2005-01-26 Thread Justin Chevrier
Paul Vriens wrote: [EMAIL PROTECTED] wrote: It appears that for whatever reason that call isn't implemented there. I did a clean install of Windows 98SE here from CD to make sure my install wasn't tainted and the test passes fine (save for the non existant Registry value). I have not done an

Re: [user32/tests/sysparams.c] Check for availability of SPI_GETICONTITLEWRAP

2005-01-25 Thread Justin Chevrier
Paul Vriens wrote: On Tue, 2005-01-25 at 05:29, [EMAIL PROTECTED] wrote: Hi, SPI_{GET,SET}ICONTITLEWRAP is not implemented on a standard Win98 SE. Changelog Check for availability of SPI_GETICONTITLEWRAP Cheers, Paul. Hi Paul, I agree we definately should not be leaving keys/values in use

Close button on MFC dockable windows

2004-03-01 Thread Justin Chevrier
font drawn on the button from an Arial 'r' to a Webding close 'x' character. Unfortunately it was drawn well below the actual button. I am not sure of the correct way to fix this. I have included a changed line: if(ppem <= startsz || ppem > endsz) that corrects this but I

Fixing the SysParametersInfoW->A crosscall

2004-02-18 Thread Justin Chevrier
Just a note that i'm working on correcting the SysParametersInfoW -> SysParametersInfoA crosscall, so that there's no duplicated effort I thought i'd send a message to wine-devel. I hope to have a patch in the next couple of days