Re: [PATCH 3/3] gdiplus/test: Remove todos for tests that pass now [Try 4]

2010-02-25 Thread Justin Chevrier
On Thu, Feb 25, 2010 at 9:19 PM, Charles Davis wrote: > Justin Chevrier wrote: >> --- >>  dlls/gdiplus/tests/graphics.c |   22 +++--- >>  1 files changed, 11 insertions(+), 11 deletions(-) > You're still not getting it! > > Remember, when each p

Re: [PATCH 1/2] gdiplus/test: Add GdipGetNearestColor test [Try 3]

2010-02-25 Thread Justin Chevrier
Do I need that for the 1,4 and 8bpp tests? With my patch to GdipGetNearestColor these tests pass and behave like Windows 7. I did forget a todo_wine on the 16bpp grayscale test though... On Thu, Feb 25, 2010 at 7:53 PM, Vincent Povirk wrote: >> +        status = GdipGetNearestColor(graphics, &col

Re: [PATCH 1/2] gdiplus/test: Add GdipGetNearestColor test [try 2]

2010-02-24 Thread Justin Chevrier
else though. I don't have Windows 7 here, what's the easiest way to test that out? Get the test committed leaving the test expecting OutOfMemory and see if Win7 returns something else? Justin On Wed, Feb 24, 2010 at 8:12 PM, Vincent Povirk wrote: > Well, that's interesting. >

Re: [PATCH 1/2] gdiplus/test: Add GdipGetNearestColor test [try 2]

2010-02-24 Thread Justin Chevrier
t this function doesn't accept palettized images). Thoughts on how to test at these color depths? Justin On Tue, Feb 23, 2010 at 10:55 PM, Vincent Povirk wrote: > You should probably use a Bitmap object rather than the display for > this, since the pixel format is important. That should

Re: [PATCH 1/4] msctf: Add ITfLangBarMgr Interface [Try 3]

2010-02-16 Thread Justin Chevrier
On Tue, Feb 16, 2010 at 9:46 AM, Nikolay Sivov wrote: > On 2/16/2010 17:34, Justin Chevrier wrote: >> >> On Tue, Feb 16, 2010 at 7:25 AM, Alexandre Julliard >>  wrote: >> >>> >>> Justin Chevrier  writes: >>> >>> >>&

Re: [PATCH 1/4] msctf: Add ITfLangBarMgr Interface [Try 3]

2010-02-16 Thread Justin Chevrier
On Tue, Feb 16, 2010 at 7:25 AM, Alexandre Julliard wrote: > Justin Chevrier writes: > >> @@ -1357,3 +1362,52 @@ interface ITfThreadFocusSink : IUnknown >> >>      HRESULT OnKillThreadFocus(); >>  }; >> + >> +[ >> +    object, &

Re: [PATCH 4/4] msctf: Implement stubbed out TF_CreateLangBarMgr [Try 2]

2010-02-15 Thread Justin Chevrier
r, shouldn't have been there. > > thanks! > -aric > Thanks for the review and feedback Aric! I've resubmitted with the changes above. Justin

Re: [PATCH 1/7] msctf: Add langbarmgr.c

2010-02-11 Thread Justin Chevrier
Thanks for the feed back! I should have went with my gut on these and sent them through together. They were really meant to all be applied in one go. Justin On Thu, Feb 11, 2010 at 12:22 PM, Nikolay Sivov wrote: > On 2/11/2010 19:51, Justin Chevrier wrote: >> >> --- >>  dl

Re: [PATCH 1/7] msctf: Add langbarmgr.c

2010-02-11 Thread Justin Chevrier
Thanks for the feedback. Would submitting this as one patch be acceptable? My intention was really to have all this applied in one go. If not, I'll split as recommended. I've got some fixing up to do and I'll resubmit. Justin On Thu, Feb 11, 2010 at 1:27 PM, Justin Chevrier wro

Re: [PATCH 1/7] msctf: Add langbarmgr.c

2010-02-11 Thread Justin Chevrier
Thanks for the feed back! I should have went with my gut on these and sent them through together. They were really meant to all be applied in one go. Justin On Thu, Feb 11, 2010 at 12:22 PM, Nikolay Sivov wrote: > On 2/11/2010 19:51, Justin Chevrier wrote: >> >> --- >>  dl

Re: Ubuntu no longer works correctly without pulseaudio

2009-04-27 Thread Justin
Is this with the new version that just came out, Jaunty Jackalope? Just wondering, did you have problems with the default setup (pulseaudio enabled, using alsa in wine)? Bug 1813 is a really old bug for something else (fixed in 2003). Did you forget a digit? On Thu, Apr 23, 2009 at 6:39 AM, Susan

Re: Create stub dosx.exe

2008-03-25 Thread Justin Chevrier
Dmitry Timoshkov wrote: > "Justin Chevrier" <[EMAIL PROTECTED]> wrote: > >> +#define WIN32_LEAN_AND_MEAN >> + >> +#include > > What's the reason to include anything in an empty stub? > >> +int main(int argc, char *argv[]) >> +{ >> +return 0; >> +} > Ya, that shouldn't be there. Thanks Dmitry.

Re: Create stub dosx.exe

2008-03-25 Thread Justin Chevrier
Alexandre Julliard wrote: > Justin Chevrier <[EMAIL PROTECTED]> writes: > > >> I've got a console app (Master of Orion 2 1.40p23 patch >> http://www.spheriumnorth.com/blog-images/Moo2v140b23.zip ) that >> crashes if it doesn't find dosx.exe in the sys

Re: Create stub dosx.exe

2008-03-25 Thread Justin Chevrier
Alexandre Julliard wrote: > Justin Chevrier <[EMAIL PROTECTED]> writes: > > >> Changelog: >> >> Create stub dosx.exe >> > > Why do you need this? > > I've got a console app (Master of Orion 2 1.40p23 patch http://www.spheriumnor

Re: DestroyWindow behavior differences between Win9x and Win2k/xp

2008-03-10 Thread Justin Chevrier
any version) allows it, and an app > depends on it, then we have to emulate it. A test case that passes on > Win9x that demonstrates the problem is probably sufficient to show > that the check should be removed. > > --Juan > > > > Okay, that will be my next stop. Thanks Juan and Dan. Justin

DestroyWindow behavior differences between Win9x and Win2k/xp

2008-03-10 Thread Justin Chevrier
ab to the console. Opinions on the correct course of action to resolve this? Thanks Justin Chevrier

Re: wine.inf: Create fake dll entry for dosx.exe

2008-02-29 Thread Justin Chevrier
> Changelog: > > Create a fake dll entry for dosx.exe Anything wrong with this one liner? Justin Chevrier

Re: USER32: Hide cursor when calling SetCursor with NULL HCURSOR

2006-02-09 Thread Justin Chevrier
Andreas Mohr wrote: Hi, On Fri, Feb 03, 2006 at 07:50:51PM -0500, Justin Chevrier wrote: Changelog: Hide cursor if SetCursor is called with a NULL HCURSOR Which obviously implies the question: What if the program does a SetCursor(something) later? Should it then re-show a cursor

a more native host environment

2005-12-28 Thread Justin Lesarge
I'd like to see wine produce real PE dll files that use unix system calls as a back end. For example, a real kernel32.dll in PE format that maps at the same addresses as the windows XP version, and so on. PE executables could be seamlessly loaded with an ibcs extension and properly linked agains

Re: USER32: Sysparams unit tests fixes and additions

2005-03-01 Thread Justin Chevrier
) and bailing on the test instead of failing outright. I hope to look into getting both issues covered after I do some tests on an NT4 box. Justin

Re: [user32/tests/sysparams.c] Check for availability of SPI_GETICONTITLEWRAP

2005-01-26 Thread Justin Chevrier
it an English (North American) version of Windows? Colour depth? I'll do the updates through Windows Updates next and see if that changes anything. Did you just do critical updates? Yep. Justin Paul Yeah, you can't go wrong there (adding a trace after the call). I am more in

Re: [user32/tests/sysparams.c] Check for availability of SPI_GETICONTITLEWRAP

2005-01-25 Thread Justin Chevrier
I would like to create something that covers the entire sysparams suite of tests to stop this across the board. Thanks for the heads up on this! Justin Hi Justin, it appears we should do both then? If I put in an extra trace: trace("testing SPI_{GET,SET}ICONTITLEWRAP\n");

Re: D3D8

2004-11-06 Thread Justin
[EMAIL PROTECTED] seems to be the most informed D3D around at the moment. Kevin - Original Message - From: "Joel Konkle-Parker" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Sent: Saturday, November 06, 2004 5:03 PM Subject: Re: D3D8 Vincent Béron wrote: Wine has D3

Close button on MFC dockable windows

2004-03-01 Thread Justin Chevrier
font drawn on the button from an Arial 'r' to a Webding close 'x' character. Unfortunately it was drawn well below the actual button. I am not sure of the correct way to fix this. I have included a changed line: if(ppem <= startsz || ppem > endsz) that corrects this but I

Fixing the SysParametersInfoW->A crosscall

2004-02-18 Thread Justin Chevrier
Just a note that i'm working on correcting the SysParametersInfoW -> SysParametersInfoA crosscall, so that there's no duplicated effort I thought i'd send a message to wine-devel. I hope to have a patch in the next couple of days