Huw Davies writes:
> ---
> dlls/wsock32/protocol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This doesn't build on MingW:
protocol.o: In function `WSOCK32_inet_network@4':
/home/julliard/wine/build/obj-pe32/dlls/wsock32/../../../wine/dlls/wsock32/protoc
station.html
--
Alexandre Julliard
julli...@winehq.org
e the default window from a different
thread.
--
Alexandre Julliard
julli...@winehq.org
t shows a build failure for this one, and I don't see any
> failures on testbot for it so assuming something it fails on your
> machine. So what's the exact failure you get?
It's compiler warnings, you have several uninitialized or unused
variables. Please review your changes carefully.
--
Alexandre Julliard
julli...@winehq.org
icode=0x1, phresult=0x32fbdc)
[/home/julliard/wine/wine/dlls/riched20/editor.c:4029] in riched20 (0x0032fb98)
1 0x7ac3d3ab CreateTextServices+0x11a(pUnkOuter=,
pITextHost=, ppUnk=)
[/home/julliard/wine/wine/dlls/riched20/txtsrv.c:417] in riched20 (0x0032fbf8)
2 0x686569cb func_txtsrv+0x2fa()
[/
27;s any evidence that the existing version is
identical to Windows. It's probably just what happened to be the current
version when the code was written. As long as it passes reasonable
tests, it shouldn't be an issue to use a more recent version.
--
Alexandre Julliard
julli...@winehq.org
_WRITE_TO_END_OF_FILE
> */
> +offset = &offset_eof;
> +}
> +
Please add a test for the file position after the write, to show that
this is the correct behavior.
--
Alexandre Julliard
julli...@winehq.org
E_VALUE, "CreateIoCompletionPort (%d)",
> GetLastError());
> +
> +JobObject = pCreateJobObjectW(NULL, NULL);
> +ok(JobObject != INVALID_HANDLE_VALUE, "CreateJobObject (%d)\n",
> GetLastError());
These functions don't return INVALID_HANDLE_VALUE.
--
Alexandre Julliard
julli...@winehq.org
-
Alexandre Julliard
julli...@winehq.org
+
That's ugly. If you are using the index for validity checking then you
should put some appropriate value in there, there's no reason to put
garbage in the whole structure.
--
Alexandre Julliard
julli...@winehq.org
e unchanged
font.c:1133: Test succeeded inside todo block: RTL 1 advanced: abcA's sign
should be unchanged
font.c:1141: Test succeeded inside todo block: RTL 1 advanced: abcfA's sign
should be unchanged
--
Alexandre Julliard
julli...@winehq.org
Dmitry Timoshkov writes:
> The tests show that this is how fully up to date Windows versions starting
> from XP behave, isn't that convincing enough? If not, what else do you need
> to see?
An application that breaks because of this.
--
Alexandre Julliard
julli...@winehq.org
Ralf Habacker writes:
> On 01.10.2013 12:12, Alexandre Julliard wrote:
>> Ralf Habacker writes:
>>
>>> With other patches i have been told to implement such stuff in the dib
>>> driver. Unfortunally this do not works in this case, because in the top
>&g
ts to accept both values so that they pass
> under Wine.
Well, the tests fail mostly because you have decided that this behavior
is broken. I'm not convinced.
--
Alexandre Julliard
julli...@winehq.org
7; ','P','a','c','k',' ','3',0},
> 3, 0, VER_SUITE_SINGLEUSERTS, VER_NT_WORKSTATION, 30 /* FIXME:
> Great, a reserved field with a value! */
> },
> +#endif
This would mean that the 32-bit side sees a different version. I don't
think that's correct.
--
Alexandre Julliard
julli...@winehq.org
y have to be in the driver, though maybe the
driver would not be calling that exact entry point. In any case, you
can't change the DC transform like this. and you'll need test cases.
--
Alexandre Julliard
julli...@winehq.org
Dmitry Timoshkov writes:
> Alexandre Julliard wrote:
>
>> I don't see the point. Do you actually have an app that depends on this?
>
> When I started to work on this I had an app that has one of the reasons to
> require running under Vista+ was the difference in overla
Dmitry Timoshkov writes:
> ---
> dlls/ntdll/file.c | 3 ++-
> dlls/ntdll/tests/file.c | 5 +++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
I don't see the point. Do you actually have an app that depends on this?
--
Alexandre Julliard
julli...@winehq.org
Huw Davies writes:
> ---
> dlls/setupapi/fakedll.c | 13 -
> 1 file changed, 12 insertions(+), 1 deletion(-)
I don't think that's correct. The datadir is for platform-independent
files, but the fakedlls are platform specific.
--
Alexandre Julliard
julli...@winehq.org
etLastError(WSAEINVAL);
> +goto cleanup;
> +}
> +
> +ret = WS2_sendto( s, msg->lpBuffers, msg->dwBufferCount,
> lpNumberOfBytesSent,
> + dwFlags, msg->name, msg->namelen,
> + lpOverlapped, lpCompletionRout
[1]: *** [dib.ok] Error 19
--
Alexandre Julliard
julli...@winehq.org
Y ret;
> +UINT_PTR idx = (UINT_PTR)hkey >> 2;
> +opened_hkcr_t *hkcr;
> +if (idx <= nb_hkcr_handles)
> +{
> +EnterCriticalSection( &hkcr_handles_cs );
The count needs to be protected by the critical section too.
Also please write a better subject line for the commit.
--
Alexandre Julliard
julli...@winehq.org
RUE;
> +}
> +else
> +{
> +rect.left = left;
> +rect.top = top;
> +rect.right = right;
> +rect.bottom = bottom;
> +}
I don't think that you want to draw arcs in logical space, that can be
very inefficient.
--
Alexandre Julliard
julli...@winehq.org
would be a good idea.
--
Alexandre Julliard
julli...@winehq.org
o it. Also
GetLastError won't do anything useful here.
--
Alexandre Julliard
julli...@winehq.org
; 6;
> abc->abcB = (right - left) >> 6;
> +if (abc->abcB == 0)
> +abc->abcB = 1;
> abc->abcC = adv - abc->abcA - abc->abcB;
It would be a good idea to add tests for the ABC metrics too.
--
Alexandre Julliard
julli...@winehq.org
_IGNORENOCONTEXT:
> if (GetPropW(hWnd,szwWineIMCProperty))
You shouldn't be accessing thread data outside of the critical section.
--
Alexandre Julliard
julli...@winehq.org
0060, blocked by 005c, retrying (60
sec)
--
Alexandre Julliard
julli...@winehq.org
doesn't make sense without
it.
--
Alexandre Julliard
julli...@winehq.org
rn FALSE;
> +}
> +
> +if ((*thread_data)->defaultContext) /* someone beat us */
> +IMM_DestroyContext(defaultContext);
> +else
> +(*thread_data)->defaultContext = defaultContext;
> +}
> +return TRUE;
> +}
That's fairly inelegant, try to find a better way.
--
Alexandre Julliard
julli...@winehq.org
b=0x14e23c, rect_count=0, rects=(nil), draw_rect=0x32f9e0, flags=0x1,
color=0x6875e2bc, depth=1.00, stencil=0)
[/home/julliard/wine/wine/dlls/wined3d/device.c:219] in wined3d (0x0032f978)
1 0x686b0b67 wined3d_device_clear+0x136(device=0x142208, rect_count=0,
rects=(nil), flags=0x1, c
x27;t have any parent (which only has the disadvantage that wine
> cannot track the correct window position).
I think you really should make it work like the systray and keep track
of the hierarchy. You'll run into a lot of hard to fix bugs otherwise.
--
Alexandre Julliard
julli...@winehq.org
; -thread_data = IMM_GetThreadData(0);
> +thread_data = IMM_GetThreadDataForWindow(hWnd);
> thread_data->defaultContext = defaultContext;
> }
You have multiple race conditions here.
--
Alexandre Julliard
julli...@winehq.org
"typedef LONG COMPATIBLE_LONG;")
> +cpp_quote("#endif")
> +#else
> +cpp_quote("#ifdef _WIN64")
> +cpp_quote("typedef LONGLONG COMPATIBLE_LONG;")
> +cpp_quote("#else")
> +typedef LONG COMPATIBLE_LONG;
> +cpp_quote("#endif")
> +#endif
You can't do that, _WIN64 is not meaningful in idl.
--
Alexandre Julliard
julli...@winehq.org
Error 6
--
Alexandre Julliard
julli...@winehq.org
type = lpProtocolInfo->iSocketType;
> -if (protocol == FROM_PROTOCOL_INFO)
> +if (protocol <= 0)
> protocol = lpProtocolInfo->iProtocol;
I don't see anything in the tests that would justify checking for
negative values here.
--
Alexandre Julliard
julli...@winehq.org
to
Windows APIs. Instead you should request the info when you need it.
--
Alexandre Julliard
julli...@winehq.org
touch file.ok
file.c:810: Tests skipped: CopyFile2 is not available
file.c:1173: Tests skipped: Either no authority to volume, or is todo_wine for
C:\users\julliard\Temp\ err=5 should be 3
file.c:1173: Tests skipped: Either no authority to volume, or is todo_wine for
C:\users\julliard\Temp\re
ruct->codepage = CP_UTF8;
> + }
That struct belongs to the caller, you can't change it.
--
Alexandre Julliard
julli...@winehq.org
at they need to be moved to kernel32
> or that they are doing something wrong.
Using kernel32 APIs in order to test the ntdll ones is fine. But a test
that only calls kernel32 has no reason to be in ntdll.
--
Alexandre Julliard
julli...@winehq.org
Dmitry Timoshkov writes:
> This matches what NtWriteFile does.
>
> I assume that this patch is in 'pending' state because of a test failure
> caused
> by 2/2, if the reason is different - please let me know.
It would need some test cases for other file types.
--
elper_ABC(a) (winetest_set_location(__FILE__,__LINE__), 0) ? 0 :
> helper_ABCWidths(hdc, glyphs, abc, abcw, abcf, a)
Please avoid that sort of macro. You can pass a description string, or
simply print the current extents in the helper function, so that we can
figure out the failing code without r
Dmitry Timoshkov writes:
> Alexandre Julliard wrote:
>
>> > This matches WriteFile behaviour and ensures that invalid parameters are
>> > properly handled and fields in the OVERLAPPED structure are initialized.
>>
>> This is again causing test failur
Dmitry Timoshkov writes:
> This matches WriteFile behaviour and ensures that invalid parameters are
> properly handled and fields in the OVERLAPPED structure are initialized.
This is again causing test failures. Please do a full test run before
sending patches.
--
Alexandre Julliard
S.po $@
> +
You can't create links in the source tree, and in any case this should
be done directly in wrc, with some sort of alias mechanism.
--
Alexandre Julliard
julli...@winehq.org
to use MAX_PATH you
then have to check for overflow when building the string, which is
probably worse.
--
Alexandre Julliard
julli...@winehq.org
Dmitry Timoshkov writes:
> Alexandre Julliard wrote:
>
>> Why do you need that? It doesn't look to me like an improvement.
>
> IMO it simplifies the code and avoids using two different code paths
> for normal files.
At the cost of two extra seeks, plus introducin
Dmitry Timoshkov writes:
> ---
> dlls/ntdll/file.c | 31 +++
> 1 file changed, 15 insertions(+), 16 deletions(-)
Why do you need that? It doesn't look to me like an improvement.
--
Alexandre Julliard
julli...@winehq.org
also did not
> see a response.
It can't happen (and removing the last char unconditionally is broken
anyway).
--
Alexandre Julliard
julli...@winehq.org
set ? offset->QuadPart : (off_t)-2 /*
> FILE_USE_FILE_POINTER_POSITION */;
> +
> +if (off == (off_t)-1 /* FILE_WRITE_TO_END_OF_FILE */)
> +off = lseek( unix_handle, 0, SEEK_END );
You are not supposed to change the position for the asynchronous case.
--
Alexandre Julliard
julli...@winehq.org
Dmitry Timoshkov writes:
> ---
> dlls/ntdll/file.c | 13 ++---
> dlls/ntdll/tests/file.c | 15 ---
> 2 files changed, 10 insertions(+), 18 deletions(-)
This is causing test failures all over the place.
--
Alexandre Julliard
julli...@winehq.org
ventmask | (serial->generation << 16);
It would be better to return it as a separate field, particularly since
eventmask is already an int.
--
Alexandre Julliard
julli...@winehq.org
Bruno Jesus <00cp...@gmail.com> writes:
> On Mon, Sep 9, 2013 at 6:39 AM, Alexandre Julliard
> wrote:
>> Bruno Jesus <00cp...@gmail.com> writes:
>>
>>> +fd = get_sock_fd( s, FILE_READ_DATA, NULL );
>>> +if (fd == -1)
>>> +{
&g
fd if you are not using it. The handle
should be checked at the point where you are doing something with it.
--
Alexandre Julliard
julli...@winehq.org
TODOs all over the place.
--
Alexandre Julliard
julli...@winehq.org
Amine Khaldi writes:
> On 06/09/2013 16:28, Alexandre Julliard wrote:
>> Amine Khaldi writes:
>>
>>> @@ -18,15 +18,7 @@
>>> * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301,
>>> USA
>>> */
>>>
>&
nclude "winbase.h"
> -#include "winuser.h"
> -#include "winnt.h"
> #include "aclui.h"
That's not useful. The headers will be included anyway.
--
Alexandre Julliard
julli...@winehq.org
t; +}
> +SERVER_END_REQ;
You need to check the server return status and set the correct error
code.
--
Alexandre Julliard
julli...@winehq.org
offset->QuadPart = lseek( unix_handle, 0, SEEK_END );
> +
This looks very wrong, offset belongs to the caller.
--
Alexandre Julliard
julli...@winehq.org
h is covered by test_GetExtendedTcpTable()
> + */
The tests are supposed to test the behavior on Windows. The details of
the Wine implementation are irrelevant. You can't assume that the
functions share an implementation.
--
Alexandre Julliard
julli...@winehq.org
x27;o','b','O','b','j','e','c','t',0 };
> +
> +GetEnvironmentVariableW(envName, val, 32);
> +
> + if(lstrcmpW(envVal, val) == 0)
> +/* Wait forever, we've been created for a process handle */
> +while(1) Sleep(INFINITE);
> +
> +SetEnvironmentVariableW(envName, envVal);
> +}
That's ugly. Again, check how child processes are handled in
other tests.
--
Alexandre Julliard
julli...@winehq.org
2: Test failed: got 80040154
make[1]: *** [database.ok] Error 1
--
Alexandre Julliard
julli...@winehq.org
piosb->Information = 0;
> if (!(status = wait_on(hDevice, fd, hEvent, piosb, lpOutBuffer)))
> sz = sizeof(DWORD);
> +else if (status == STATUS_PENDING)
> +return status;
Status is not supposed to be set until th
uot;, status);
> -todo_wine
> ok(iob.Status == -1, "expected -1, got %#x\n", iob.Status);
> -todo_wine
> ok(iob.Information == -1, "expected -1, got %ld\n", iob.Information);
A test for a non-magic negative value would be a good idea.
--
Alexandre Julliard
julli...@winehq.org
Bruno Jesus <00cp...@gmail.com> writes:
> On Tue, Sep 3, 2013 at 3:16 PM, Bruno Jesus <00cp...@gmail.com> wrote:
>> On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard
>> wrote:
>>> Bruno Jesus <00cp...@gmail.com> writes:
>>>
>>>> tr
Bruno Jesus <00cp...@gmail.com> writes:
> try 2:
> Narrow the loop for the specified protocol
> Add a new test for invalid sockets
Considering what WSAEnumProtocols does, the loop doesn't seem necessary
at all.
--
Alexandre Julliard
julli...@winehq.org
}
> +break;
> + }
> +}
> +}
There's no reason to enumerate the protocols since you already know the
one you want.
--
Alexandre Julliard
julli...@winehq.org
Dmitry Timoshkov writes:
> Alexandre Julliard wrote:
>
>> >> > Printing complete lsr value in the log may help with diagnosing
>> >> > test failures on Alexandre's machine.
>> >>
>> >> I don't see how, since TIOCSER_TEMT is
Dmitry Timoshkov writes:
> Alexandre Julliard wrote:
>
>> > Printing complete lsr value in the log may help with diagnosing
>> > test failures on Alexandre's machine.
>>
>> I don't see how, since TIOCSER_TEMT is the only defined bit. Do you
>&
Dmitry Timoshkov writes:
> Printing complete lsr value in the log may help with diagnosing
> test failures on Alexandre's machine.
I don't see how, since TIOCSER_TEMT is the only defined bit. Do you
actually have a driver that returns other status?
--
Alexandre Julliard
julli...@winehq.org
again and compiles just fine here. What kind of build failure is that?
You are using TIOCSER_TEMT outside of the corresponding ifdef.
--
Alexandre Julliard
julli...@winehq.org
André Hentschel writes:
> Am 29.08.2013 23:15, schrieb Alexandre Julliard:
>> André Hentschel writes:
>>
>>> Am 29.08.2013 19:52, schrieb André Hentschel:
>>>> Hi,
>>>> thank you both for the comments, i'll see what i can do.
>>>
&g
André Hentschel writes:
> Am 29.08.2013 19:52, schrieb André Hentschel:
>> Hi,
>> thank you both for the comments, i'll see what i can do.
>
> How about that?
I don't see the point at all. There's no reason to add all that
complexity for a purely cosmetic d
Ralf Habacker writes:
> see http://bugs.winehq.org/show_bug.cgi?id=34381
> ---
> dlls/gdi32/painting.c | 18 --
> 1 Datei geändert, 16 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-)
This would have to be done in the drivers.
--
Alexandre Julliard
julli...@winehq.org
Dmitry Timoshkov writes:
> Dmitry Timoshkov wrote:
>
>> Alexandre Julliard wrote:
>>
>> > It doesn't work here:
>> >
>> > ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p
>> > kernel32_test.exe.so comm.c &&
0
comm.c:865: Test failed: WaitCommEvent used 1000 ms for waiting
comm.c:1895: Tests skipped: interactive tests (set WINETEST_INTERACTIVE=1)
make: *** [comm.ok] Error 5
--
Alexandre Julliard
julli...@winehq.org
> len)
> +c = 1;
> +}
Actually, memcmp is not a good choice for comparing Unicode strings. It
doesn't make a difference for ASCII-only strings, but it would still be
cleaner to do it right. strncmpW is preferable (as long as you use it
correctly...)
--
Alexandre Julliard
julli...@winehq.org
Wolfgang Walter writes:
> Am Montag, 26. August 2013, 17:13:46 schrieb Alexandre Julliard:
>>
>> You probably don't want to fail just because there's no unix fd.
>
> What is the correct behaviour if there ist no such handle? Should I only fail
> in the ca
k) {
> +IoStatusBlock->u.Status = ret;
> }
This is an unrelated change and should be a separate patch, with tests
(also for failures cases),
--
Alexandre Julliard
julli...@winehq.org
Nikolay Sivov writes:
> +while (min <= max)
> +{
> +int n, c;
> +
> +n = (min+max)/2;
> +
> +c = strncmpW(olemisc_values[n].name, str, len);
strncmp isn't enough.
--
Alexandre Julliard
julli...@winehq.org
Dmitry Timoshkov writes:
> Alexandre Julliard wrote:
>
>> It's a blocking call, you can't do that on the server side.
>
> Can then something like in the patch from Wolfgang Walter be done
> instead?
Something like that, yes.
--
Alexandre Julliard
julli...@winehq.org
transmitted.
It's a blocking call, you can't do that on the server side.
--
Alexandre Julliard
julli...@winehq.org
inside todo block: D3DXLoadVolumeFromMemory
returned 0x8876086c, expected 0x8876086c
make: *** [volume.ok] Error 1
--
Alexandre Julliard
julli...@winehq.org
status, unsigned int information )
> + apc_param_t information, unsigned int status )
There's no reason to change the parameter order. That's only adding
noise to the patch, and potential bugs.
--
Alexandre Julliard
julli...@winehq.org
iled with error 0x8007000e
wine: Unhandled page fault on read access to 0x at address 0x68640714
(thread 003a), starting debugger...
--
Alexandre Julliard
julli...@winehq.org
Dmitry Timoshkov writes:
> Alexandre Julliard wrote:
>
>> > +if (type == FD_TYPE_FILE)
>> > +{
>> > +io_status->u.Status = status;
>> > +io_status->Information = total;
>> > +}
>&
0x0032f7bc: 687c05d8 0001
0x0032f7cc: 4d430003
0x0032f7dc: 4d430001 00164268
0x0032f7ec: 0010
Backtrace:
=>0 0x7bc4a5cf HEAP_CreateFreeBlock+0x36f(subheap=0x110014, ptr=0x164268,
size
ailed: read returned 2, expected 1
make[1]: *** [file.ok] Error 1
--
Alexandre Julliard
julli...@winehq.org
his would have to be specific to files.
--
Alexandre Julliard
julli...@winehq.org
Nikolay Sivov writes:
> http://bugs.winehq.org/show_bug.cgi?id=32169
>
> Locale info to override is stored as REG_SZ and supposed to be
> null-terminated,
They are supposed to, but it's not guaranteed. The code should be able
to cope with non-terminated strings.
--
Alexand
Kai Tietz writes:
> 2013/8/19 Alexandre Julliard :
>> Kai Tietz writes:
>>
>>> diff --git a/tools/widl/widl.c b/tools/widl/widl.c
>>> index 5df99fc..6d8ec87 100644
>>> --- a/tools/widl/widl.c
>>> +++ b/tools/widl/widl.c
>>> @@ -139,7
on that does the same with
> heap_realloc and wide strings (heap_strcatW in msxml_private.h.)
That's a very inefficient way to build a string. Adding this as a helper
is even worse since it will encourage other places to use it too. Please
try to allocate a large enough buffer from the start, or if
gt; +unsigned int pointer_size = sizeof(void*);
> syskind_t typelib_kind = sizeof(void*) == 8 ? SYS_WIN64 : SYS_WIN32;
This is wrong, the host pointer size shouldn't have any influence on the
generated code.
--
Alexandre Julliard
julli...@winehq.org
Kai Tietz writes:
> 2013/8/16 Alexandre Julliard :
>> Kai Tietz writes:
>>
>>> diff --git a/dlls/msvcrt/dir.c b/dlls/msvcrt/dir.c
>>> index 44802b3..3b9e3c7 100644
>>> --- a/dlls/msvcrt/dir.c
>>> +++ b/dlls/msvcrt/dir.c
>>>
t();
> +
> wine_switch_to_stack( start_process, kernel_start,
> NtCurrentTeb()->Tib.StackBase );
This would have to run on the thread stack. Also please try to add some
tests.
--
Alexandre Julliard
julli...@winehq.org
-1;
>}
> +
> + _unlock (_ENV_LOCK);
> +
>return 0;
> }
Please add test cases at least for the error values.
--
Alexandre Julliard
julli...@winehq.org
provide a script that sorts by last name.
--
Alexandre Julliard
julli...@winehq.org
t's specific
> language extensions.
>
> ---
> tools/widl/widl.c |6 ++
> tools/widl/widl.h |1 +
> 2 files changed, 7 insertions(+), 0 deletions(-)
Please update the usage message and the manpage accordingly.
--
Alexandre Julliard
julli...@winehq.org
ithout-v4l],[do not use v4l1 (v4l
> support)]))
> +AC_ARG_WITH(winemac, AS_HELP_STRING([--without-winemac],[do not build
> native Mac (Cocoa) driver]))
It should be --disable-winemac.drv, and it should work fine already,
same as with any other dll.
--
Alexandre Julliard
julli...@winehq.org
n is L"v1.1.4322" , expected L"v2.0.50727"
mscoree.c:187: Test failed: GetRequestedRuntimeInfo returned 80131700
mscoree.c:188: Test failed: version is L"" , expected L"v2.0.50727"
make: *** [mscoree.ok] Error 3
--
Alexandre Julliard
julli...@winehq.org
1 - 100 of 5807 matches
Mail list logo
