Re: [2/3] kernel32/tests: test CopyFileEx callback and cancellation (resend)

On Sun, Sep 29, 2013 at 11:10 PM, Daniel Jeliński wrote: > 2013/9/30 Nikolay Sivov > >> On 9/30/2013 00:51, Daniel Jeliński wrote: >> >> >> +struct progress_list { >>> +const DWORD progress_retval_init; /* value to return from progress >>> routine */ >>> +const BOOL cancel_init;

Re: crypt32: Support HCCE_LOCAL_MACHINE.

Hi Ben, thanks for having a whack at this. Some tests would be nice. -static HCERTCHAINENGINE CRYPT_defaultChainEngine; +/* There are two default chain engines which correspond to HCCE_CURRENT_USER and + * HCCE_LOCAL_MACHINE. +*/ +static HCERTCHAINENGINE CRYPT_defaultChainEngine[2] = { NULL, NULL

Re: RFC: HKCR merge implementation

Hi George, On Tue, Sep 10, 2013 at 3:55 PM, George Stephanos wrote: > I'm proposing my HKEY_CLASSES_ROOT implementation patches for review. Feel > free to comment. > So far, I've written code for all functions except for the RegEnum family. > > General description: > > HKCR handles are special. A

Re: Patch for bug 34388

On Fri, Sep 6, 2013 at 9:17 PM, Charles Davis wrote: > > On Sep 6, 2013, at 5:01 PM, Juan Lang wrote: > > On Fri, Sep 6, 2013 at 3:54 PM, Charles Davis wrote: > >> Maybe then the real fix is to make Wine accept either a constructor SET >> or the custom tag (ASN_CO

Re: Patch for bug 34388

On Fri, Sep 6, 2013 at 3:54 PM, Charles Davis wrote: > Maybe then the real fix is to make Wine accept either a constructor SET or > the custom tag (ASN_CONTEXT | ASN_CONSTRUCTOR) it currently accepts, for > either attribute set. I should come up with a test case first, though, to > see if that's

Re: Patch for bug 34388

monName 20:d=5 hl=2 l= 9 prim: PRINTABLESTRING :Juan Lang 31:d=2 hl=2 l= 1 prim: INTEGER :01 34:d=1 hl=2 l= 6 cons: SEQUENCE 36:d=2 hl=2 l= 2 prim: OBJECT:1.2.3 40:d=2 hl=2 l= 0 prim: NULL 42:d=1 hl=2 l= 96 cons: SET 44:d=2 hl=2 l

Re: crypt32 patch review

[+wine-devel] Hi Jacek, I've added the list so the discussion can take place in public. On Tue, Sep 3, 2013 at 8:50 AM, Jacek Caban wrote: > I have a patch for crypt32. I'd appreciate your review before I submit > it to Wine. It has high potential to be insecure... This should fix Wine bug 280

Re: ws2_32/tests: Fix a comment

Hi Andre, -/* this is a io heavy test, do it at the end so the kernel doesn't start dropping packets */ +/* this is a heavy io test, do it at the end so the kernel doesn't start dropping packets */ To my eyes, this isn't an improvement. A slight improvement might be "this is a io-heavy te

Re: Possible help or direction to build Win to Linux pass through device - resent

Hi Vincent, Pavel, On Tue, Jul 2, 2013 at 8:44 AM, Vincent Povirk wrote: > Since you're not prepared to spend a lot of time improving Wine's > driver support, it sounds like modifying core parts of Wine > specifically to support your application is the best approach. > An alternative is to modif

Re: Need help with a rsaenh bug

On Fri, Jun 28, 2013 at 9:16 AM, Qian Hong wrote: > Dear Juan, > > Thanks for reviewing! > > On Fri, Jun 28, 2013 at 11:31 PM, Juan Lang wrote: > > It's more in line with most C code to use !memcmp(...) instead of > > memcmp(...)==0. I find it easier to scan

Re: Need help with a rsaenh bug

Hi Qian, On Fri, Jun 28, 2013 at 3:44 AM, Qian Hong wrote: > Hi Daniel, new patches sent with improving from your hints, would you > mind have a look? Thanks in advance! > nice work! These look fine to me, but a stylistic nit: + ok(memcmp(pbData,cTestData[i].decstr,cTestData[1].enclen)==0,"dec

Re: [PATCH] Tests that prove ntdll has no notion of HKCR.

Hi George, static void test_classesroot(void) > { > +static const WCHAR reg_user[] = { > '\\','R','E','G','I','S','T','R','Y','\\','U','S','E','R' }; > +static const WCHAR reg_machine[] = { > '\\','R','E','G','I','S','T','R','Y','\\','M','A','C','H','I','N','E' }; > Almost, but these ha

Re: [PATCH] Tests that prove ntdll has no notion of HKCR.

> > (consider subscribing to wine-devel so your emails don't get stuck in >> moderation.) >> > Hmm but I am already! > Ok, that's strange. Maybe I just got it late. > I think Alexandre will object to using msvcrt functions (wcsncmp in this >> case), but I don't have a straightforward alternative

Re: [PATCH] Tests that prove ntdll has no notion of HKCR.

Hi George, (consider subscribing to wine-devel so your emails don't get stuck in moderation.) On Sat, May 11, 2013 at 7:43 AM, George Stephanos wrote: > As instructed, I added a few lines to the already written tests that > confirm my claim. > > Part of the research of the registry merging proje

Re: GSoC 2013 - Registry Merging Project

Hi Guo, On Tue, May 14, 2013 at 1:32 PM, Guo Jian wrote: > I just found that the REG_OPTION_VOLATILE of create_key in hkcr may > have some tricks. Not surprisingly found a strange situation when > testing on windows. See my test here please : > http://newtestbot.winehq.org/JobDetails.pl?Key=932

Re: Ask for mentor - Improve Bcrypt

Hi Kaiyi Zhang, (or is Zhang Kaiyi?) I think there's a little misconception in your proposal. Bcrypt the algorithm is not the same as the BCrypt functions in crypt32. I believe that Microsoft redesigned their CryptoAPI and more or less renamed their functions BCrypt*. I don't believe they have an

Re: [PATCH] msvcrt: fix character/byte confusion in buffer overflow branch

On Tue, May 7, 2013 at 9:10 AM, Piotr Caban wrote: > On 05/07/13 17:46, Juan Lang wrote: > >> In general, I think you want to send this to wine-patches, not here. >> > This patch was also sent to wine-patches. > > On Mon, May 6, 2013 at 12:26 PM, Max Kellermann

Re: [PATCH] msvcrt: fix character/byte confusion in buffer overflow branch

In general, I think you want to send this to wine-patches, not here. On Mon, May 6, 2013 at 12:26 PM, Max Kellermann wrote: > The first memcpy() call in puts_clbk_str_w() confuses character count > and byte count. It uses the number of characters (out->len) as number > of bytes. This leaves ha

Re: GSoC 2013 - Registry Merging Project

Hi Guo Jian, just so you know, there's another application for the same project. This doesn't mean that yours can't be accepted, but it does impact your chances. Thank you for your interest. Good luck, --Juan On Fri, May 3, 2013 at 1:05 AM, orzhvs wrote: > Hi. > I'm applying for the Google

Re: GSoC proposal

Hi George, On Wed, May 1, 2013 at 8:14 AM, George Stephanos wrote: > Hello wine-devel! > > This is my proposal as a student for Google Summer of Code 2013. > I'm George Stephanos from the "Arab Academy for Science and Technology" > situated in Egypt. gsteph on #winehackers > I'm currently about t

Re: [2/4] include: added transact.idl (resend)

Type it yourself. Refer to MSDN, public descriptions, and publicly available headers, but don't copy/paste from any of them. --Juan On Wed, May 1, 2013 at 3:56 AM, Daniel Jeliński wrote: > It probably is, I downloaded it somewhere. Had to remove some stuff to get > it to compile. I think saw som

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

Hi Jacek, On Sat, Mar 30, 2013 at 8:36 AM, Jacek Caban wrote: > Most of the argument could be used against enabling TLS 1.1 and TLS 1.2, > because it's not present on older Macs (nor enabled by default on Windows), > so we'll have different behaviour. That's sadly something we have to live > wi

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

Hi Jacek, thanks for the detailed reply. On Fri, Mar 29, 2013 at 3:02 AM, Jacek Caban wrote: > Each protocol has two kinds of enable/disable flags: "enabled" and > "disabled by default". Those have different default values for each > protocol and there are registry setting allowing to change e

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

On Thu, Mar 28, 2013 at 12:31 PM, Ken Thomases wrote: > On Mar 28, 2013, at 6:05 AM, Jacek Caban wrote: > > > --- a/dlls/secur32/schannel_macosx.c > > +++ b/dlls/secur32/schannel_macosx.c > > @@ -630,6 +630,11 @@ static OSStatus schan_push_adapter(SSLConnectionRef > transport, const void *buff, >

Re: ntdll: make NtDelayExecution a bit more efficient

On Fri, Mar 8, 2013 at 6:11 AM, Graham Knap wrote: > Michael Stefaniuc wrote: > >> i.e. commit 8099c2b9. JW says "... to more closely resemble Windows > >> behavior. The key is to yield in a Sleep..." > > > > JW is Jeremy White so us old timers chuckle now ;) > > I know the name, but nothing mor

Re: iphlpapi: Let C look like C.

Hi Michael, this isn't actually a problem with your patch, just something I spotted: On Wed, Feb 6, 2013 at 3:15 PM, Michael Stefaniuc wrote: > On 02/06/2013 11:16 PM, Austin English wrote: > > On Feb 6, 2013 11:13 PM, "Michael Stefaniuc" > > wrote: > >> > >> --- > >>

Re: [PATCH] cryptui: use add_oid_to_usage correctly (Coverity)

On Sat, Feb 2, 2013 at 5:05 AM, Marcus Meissner wrote: > On Fri, Feb 01, 2013 at 03:48:27PM -0800, Juan Lang wrote: > > On Fri, Feb 1, 2013 at 3:45 PM, Juan Lang wrote: > > > > > Hi Marcus, > > > > > > -add_oid_to_usage(usage, ptr); > &g

Re: [PATCH] cryptui: use add_oid_to_usage correctly (Coverity)

On Fri, Feb 1, 2013 at 3:45 PM, Juan Lang wrote: > Hi Marcus, > > -add_oid_to_usage(usage, ptr); > +usage = add_oid_to_usage(usage, ptr); > > This looks fine, but would you mind making the same change on line 337? > > Actually, perhaps I hit sent t

Re: [PATCH] cryptui: use add_oid_to_usage correctly (Coverity)

Hi Marcus, -add_oid_to_usage(usage, ptr); +usage = add_oid_to_usage(usage, ptr); This looks fine, but would you mind making the same change on line 337? Thanks, --Juan

Re: [PATCH 8/8] wininet: Get rid of WORKREQ* types

Hi Jacek, just wanted to say these series of patches make me happy :) lpfnHungarianNotationDieDieDie ;) --Juan

Re: Wine Wiki needs your help!

Hi Kyle, On Tue, Jan 15, 2013 at 8:10 AM, Kyle Auble wrote: > The one thing that would probably help a lot is if there was a regularly > updated tarball of the wiki content either at WineHQ or Lattica's FTP > again. I > haven't messed with cron itself much, but my archive.cron script should > pa

Re: [PATCH] crypt32: free the encoded msg (Coverity)

In case this was awaiting an ACK from me, this looks good. Thanks. --Juan

Re: [website] Are we doing something wrong with our secure connections?

Hi André, On Wed, Jan 2, 2013 at 8:08 AM, André Hentschel wrote: > Hi, > FWIW i have just seen: > > > https://www.ssllabs.com/ssltest/analyze.html?d=testbot.winehq.org&hideResults=on > > https://www.ssllabs.com/ssltest/analyze.html?d=test.winehq.org&hideResults=on > > https://www.ssllabs.com/ss

Re: wininet: Don't perform revocation checks when verifying a certificate.

On Wed, Dec 12, 2012 at 12:32 AM, Hans Leidekker wrote: > On Tue, 2012-12-11 at 12:59 -0800, Juan Lang wrote: > > Getting the client to trust the server cert can be as easy as ignoring > untrusted > > root errors, if you don't think this impacts the revocation res

Re: wininet: Don't perform revocation checks when verifying a certificate.

On Tue, Dec 11, 2012 at 12:37 PM, Hans Leidekker wrote: > On Tue, 2012-12-11 at 11:52 -0800, Juan Lang wrote: > > On Tue, Dec 11, 2012 at 6:10 AM, Hans Leidekker > wrote: > > On Tue, 2012-12-11 at 14:52 +0100, Jacek Caban wrote: > > > On 12/11/12

Re: wininet: Don't perform revocation checks when verifying a certificate.

On Tue, Dec 11, 2012 at 6:10 AM, Hans Leidekker wrote: > On Tue, 2012-12-11 at 14:52 +0100, Jacek Caban wrote: > > On 12/11/12 09:45, Hans Leidekker wrote: > > > https://testbot.winehq.org/JobDetails.pl?Key=23300 is a test which > shows that > > > revocation checks fail for the certificate on outl

Re: Bug#566351: libgcrypt11: should not change user id as a side effect

On Wed, Nov 7, 2012 at 3:22 AM, Dan Kegel wrote: > After gstreamer, gcrypt is also dropping support for alternative > thread libraries. > Good thing secur32/schannel_gnutls.c doesn't use it. (Right?) > Right. If someone were motivated, we could begin to transition winhttp and wininet to schann

Re: iphlapi: Fix some leaks (coverity)

Hi Frédéric, thanks for the patch. Allow me to elaborate: On Tue, Nov 6, 2012 at 6:05 AM, Alexandre Julliard wrote: > Frédéric Delanoy writes: > > > @@ -1520,8 +1521,8 @@ DWORD WINAPI GetIpAddrTable(PMIB_IPADDRTABLE > pIpAddrTable, PULONG pdwSize, BOOL > > sizeof(MIB_IPADDRROW), IpA

Re: [PATCH] iphlpapi: Set DhcpEnabled to TRUE for all interfaces.

Hi Qian, > There is a winpcap based network authentication client which check for the > DhcpEnabled value, this patch make the app happy and then the app works with > André's pcap wrapper [1]. > > Please let me know if this is acceptable, or we have to correctly implement > DhcpEnabled status?

Re: shell32: Add tests for ShellExecute()'s handling of file URLs.

Hi Francois, pretty sure you didn't mean to leave this hunk in: @@ -2296,9 +2406,13 @@ START_TEST(shlexec) init_test(); +#if 0 test_argify(); test_lpFile_parsed(); test_filename(); +#endif +test_fileurl(); +#if 0 test_find_executable(); test_lnks(); test_ex

Re: [PATCH 21/21] jscript: Pack jsval_t to 64-bit structure on i386

Hi Jacek, + * that NaN value representation has 52 (almost) free bytes. You mean bits, yes? While you're at it, + * jsval_t structure is used to represent JavaScript dynamicaly-typed values. dynamically is spelled with two l's. Thanks, --Juan

Re: dssenh: implementing the dssenh cryptographic service provider

Hi Marek, On Wed, Sep 12, 2012 at 2:57 PM, Marek Chmiel wrote: > Hello all, > over the summer I had a chance to complete the regression test suite > for the DSSENH cryptographic provider; thank you to those that helped > along the way. I am currently researching how to implement the actual > prov

Re: Fix the FIXME message to reflect the real problem.

On Mon, Jun 4, 2012 at 2:19 AM, Piotr Caban wrote: > On 06/02/12 13:35, m...@mtew.isa-geek.net wrote: >> >> @@ -2735,7 +2735,7 @@ static BOOL CommitUrlCacheEntryInternal( >>              goto cleanup; >>          } >> >> -        FIXME("entry already in cache - don't know what to do!\n"); >> +    

Re: [3/3] iphlpapi: Check for the right TCP statistics structure name (for DragonFly BSD)

Hi André, +#if HAVE_STRUCT_TCPSTAT_TCPS_CONNATTEMPT +struct tcpstat tcp_stat; +#elif HAVE_STRUCT_TCP_STATS_TCPS_CONNATTEMPT +struct tcp_stats tcp_stat; +#endif struct tcpstat tcp_stat; I think you meant to remove the declaration outside of the #if. --Juan

crypt32/tests(1/6): Don't shadow a variable with a variable of a different type

--Juan From 728b013f2ca52de878dc65633a9c6cbcb1a9002c Mon Sep 17 00:00:00 2001 From: Juan Lang Date: Thu, 17 May 2012 15:55:16 -0700 Subject: [PATCH 2/7] Don't shadow a variable with a variable of a different type --- dlls/crypt32/tests/cert.c | 36 ++

Re: func or pFunc in tests ?

Hi Alexandre, On Sun, May 27, 2012 at 6:22 AM, GOUJON Alexandre wrote: > Some tests call directly the function by its name (i.e. GetWindowsDirectory, > CreateFileA, CloseHandle...) while others declare a pointer to the function > (prefixing its name by 'p' and followed by a capital letter) retrie

Re: kernel32: Correct WideCharToMultiByte and MultiByteToWideChar error codes and conditions (try 4)

Hi Alex, first, thanks for taking the time to respond to feedback. Showing responsiveness helps a great deal. Next, on your patch: I'm trying to help you get this committed, so this is meant to be constructive feedback. +static void test_WideCharToMultiByte_error(UINT page, DWORD flags, LPCWSTR

urlcache: what all are you working on?

Hi Morten and Piotr, I notice both of you are working on wininet's url cache. That's great: it's largely bitrot, and has been for years. My question is, what are you planning to fix? It seems like you're both running into some of the same issues right now, and it would be nice if you could coor

Re: Programmatically determining arguments to a WinAPI function

Hi Roger, On Mon, Apr 2, 2012 at 10:41 AM, Roger Cruz wrote: > I'm looking for a way to determine programmatically what the arguments to a > Win32 API implemented in Wine are.  I'm trying to implement an API > redirection stub that I can use to trace calls into all of the > Wine-implemented DLLs.

Re: Would like to get some feedback on GSOC idea

Hi Marek, On Tue, Mar 27, 2012 at 9:13 AM, M C wrote: > Hi everyone, > > My name is Marek Chmiel, I am a student a NEIU. I am studying computer > science and network security related topics. This semester I had spent > a fair amount of time writing crypt related functions with java, and > became

Re: Major mmdevapi and winmm audio bugs

Hi Andrew, one small contribution: > Winmm's timer functions use poll() with a timeout value, subtracting > the time elapsed curing the callback. This works quite well in dsound. > > The Win32 API also provides the SetTimer API. But that depends on a > message queue, which is a hassle I don't kno

Re: SourceForge forbids download

Hi Aidin, On Mon, Feb 6, 2012 at 11:01 AM, Aidin Gharibnavaz wrote: > SourceForge blocked download for some countries by default, such as Iran. > (More detail can be found here) > > So, if it's not illegal to you to let Iranians download your software, > please go to the SourceForge's ProjectAdmi

Re: [2/3] msi: Use the return value of IXMLDOMNode_get_text (clang).

Hi Hans, hr = IXMLDOMNode_get_text( node, &s ); IXMLDOMNode_Release( node ); -if (!strcmpW( s, product_code )) r = ERROR_SUCCESS; -SysFreeString(s); +if (hr == S_OK && !strcmpW( s, product_code )) r = ERROR_SUCCESS; +SysFreeString( s ); Is it real

Re: crypt32: Only accept trailing NULLs in a certificate common name.

> Wow, I clearly didn't read that you moved the code over to > match_common_name.  Apparently I'm not quite conscious today, my > apologies! Clearly I wasn't quite conscious when I reviewed your patch in the first place :) No worries, for security fixes lots of checking is always worthwhile! --Ju

Re: crypt32: Only accept trailing NULLs in a certificate common name.

Hi Erich, On Tue, Jan 31, 2012 at 9:34 AM, Erich E. Hoover wrote: > On Tue, Jan 31, 2012 at 10:23 AM, Erich E. Hoover wrote: >> On Tue, Jan 31, 2012 at 10:04 AM, Juan Lang wrote: >>> Sorry I didn't spot this earlier.  Without this, someone who registers >>> a

Re: [PATCH 1/1] crypt32: Fix domain component length check.

Hi Erich, On Fri, Jan 27, 2012 at 10:33 AM, Erich E. Hoover wrote: > On Fri, Jan 27, 2012 at 11:16 AM, Austin English > wrote: >> ... >> Forgot the patch. > > Thanks!  I don't know how I missed that, apparently I'm blind today. surely this needs a test. Ping me if you need help creating one.

Re: In-process wineserver

Hi Daniel, On Mon, Jan 23, 2012 at 3:15 AM, Alexandre Julliard wrote: > Daniel Santos writes: > >> I've updated my in-process wineserver hack, cleaned it up a bit more and >> fixed a few problems.  So, at least in Star Wars Battlefront II, the >> sound and HID problems are fixed (the "select" se

Re: richedit: v1.0 richedit uses CR and LF for enter

> Whats the difference between a typecast and &var[0]? I wasn't advocating for a typecast, merely admitting that we use them from time to time. What's the compile warning you're actually seeing on gcc? I don't think we care what warnings are produced in MSVC. --Juan

Re: richedit: v1.0 richedit uses CR and LF for enter

> This was deliberate - I did that originally and I got a compile warning as > one is const WCHAR * and one is const WCHAR[2] (Not sure if that error was > from a MSVC windows or Linux compile, but I was trying to avoid it, and a > typecast was a bit pointless as the above is accurate as well, isnt

Re: richedit: v1.0 richedit uses CR and LF for enter

Hi Jason, + ME_InsertTextFromCursor(editor, 0, &endlv10[0], 2, style); you want to use endlv10 instead, i.e.: + ME_InsertTextFromCursor(editor, 0, endlv10, 2, style); --Juan

Re: crypt32: Cryptic string resources

Hi Francois, On Tue, Jan 17, 2012 at 10:34 AM, Francois Gouget wrote: > On Mon, 26 Sep 2011, Ben Peddell wrote: > >> On 25/09/2011 6:29 PM, Francois Gouget wrote: >> > >> > Are these strings seem to be lacking spaces a bit. Are they real names >> > or mere identifiers? Are they actually translata

Re: Debugging Wine with Lightroom 3.5

Hi Roland, On Sun, Dec 18, 2011 at 6:46 AM, Roland Baudin wrote: > Yes, I suspected such a mechanism. Now if I understand well I have to find > which one is the "builtin mechanism" and which one is the "fallback > mechanism". > Is there some documentation around about the differences between Vist

Re: crypt32: Avoid reading unitialized variables (Coverity)

> On second thought, coverity would still complain even with the > TRACEs adapted, so I'll mark these defects as Ignored in Coverity Does the attached patch address one of the Coverity complaints? --Juan From 13115c8ab68550b38f992eba04c9a05e88696f73 Mon Sep 17 00:00:00 2001 From: Juan

Re: crypt32: Avoid reading unitialized variables (Coverity)

> Should the TRACE (e.g. on crypt32:2435) be adapted so it conditionally > prints the value instead? Or be removed altogether? I'd prefer a conditional print if it's not too ugly. There haven't been too many decoding bugs in a while, but the trace can sometimes help identify them. Thanks, --Juan

Re: Re: Re: added remaining functions, data structures, definitions required by http api to include/

Hi Arash, >> I'm also concerned whether this was the product of copy/paste, which >> isn't allowed.  Was it? > about that copy/paste stuff, > well I guess we eventually produce an almost identical header file with one > in the SDK > I mean everything in the header file is already exposed to the u

Re: Re: added remaining functions, data structures, definitions required by http api to include/http

> can you be more specific please? Yes: +#ifndef __HTTP_H__ +#define __HTTP_H__ Don't do that, it's already #ifdef protected. +/*#if _WIN32_WINNT >= 0x0501*/ Dead code, just leave it out. +typedef struct _HTTP_REQUEST_V2 +{ +/* TODO : anonymous structure is not supported by C standard */

Re: added remaining functions, data structures, definitions required by http api to include/http.h

> That's a lot of stuff.  What needs it? It's also obviously incorrect in places. --Juan

Re: [PATCH 1/1] ws2_32: Selectively bind UDP sockets to interfaces while still allowing broadcast packets (try 2, resend).

Hi Erich, + * Bind the given socket exclusively to a specific interface. I know the style around here is to comment minimally, but I didn't find it clear what the behavior of this function is. For one thing, +static int interface_bind( int fd, struct sockaddr *addr ) (snip) +int ret = FALSE

RFH: Solaris users with IPv6

Hi all, in the tidy up I've been doing to iphlpapi, I notice that on Solaris it's possible to enumerate IPv6 addresses using SIOCGIFCONF. I've got a patch written that does that, but I have no way to test it myself. If anyone here has some version of Solaris with a machine with IPv6 addresses, eve

Re: Antw.: RFC: depending on getifaddrs in iphlpapi

> Why? AFAIK getifaddr was added to at least openSolaris Last year and you > still can use the old Code as fallback Yes, by "keeping the current code" I meant alongside a getifaddrs-based implementation. --Juan

Re: RFC: depending on getifaddrs in iphlpapi

>> I'm thinking of replacing the current IPv4 enumeration code, which >> uses ioctl/SIOCGIFCONF, with getifaddrs.  The reason I'm leaning >> toward replacing, rather than adding side-by-side with the current >> code, is that getifaddrs is commonly available:  it's available on all >> recent version

RFC: depending on getifaddrs in iphlpapi

Hi folks, right now iphlpapi uses autoconf to detect if getifaddrs is available, and only uses it to enumerate IPv6 addresses. I'm thinking of replacing the current IPv4 enumeration code, which uses ioctl/SIOCGIFCONF, with getifaddrs. The reason I'm leaning toward replacing, rather than adding si

Re: [PATCH 4/4] kernel32, ntdll: implement most of GetNamedPipeHandleState

Hi Bernhard, nit: -todo_wine -ok(!ret && GetLastError() == ERROR_INVALID_PARAMETER, +todo_wine ok(!ret && GetLastError() == ERROR_INVALID_PARAMETER, This change is a no-op. --Juan

Re: Governance of Wine with respect to the Software Freedom Conservancy (update October 2011)

> As I said, our overlords are kind and benevolent and I'm sure that the > mention of "evil plans" was simply a joke as such wise and noble > developers could need harbor a malevolent thought. But, unless I've > been misreading this mailing list, all patches have to go through our > current enlight

Re: Governance of Wine with respect to the Software Freedom Conservancy (update October 2011)

Hi Michael, > Not that I have any problems with our benevolent overlords, and not > that I would likely achieve franchise with a scant 2 patches under my > belt, but I can't help wondering how such a revolt would succeed > seeing as the only method to achieve franchise-hood is controlled by > the

Re: todo_wine, broken() and a SW anti-pattern

Hi Joerg, > hr = IAudioClient_GetService(ac, &IID_IAudioStreamVolume, (void**)&out); > ok(hr == AUDCLNT_E_NOT_INITIALIZED, "... call returns %08x\n", hr); > todo_wine ok(broken(out != NULL), "GetService %08x &out pointer %p\n", hr, > out); > > 1. broken() documents that I consider native's observ

Re: [1/4] cmd: Avoid checking handle type when already known in WCMD_ReadFile

> OK but the purpose is to avoid checking the handle type for every line > read. Granted, one could use '((DWORD_PTR)h) & 3 == 3' instead of > GetConsoleMode or similar function. > (there's currently code like "BOOL is_console = GetConsoleMode(...); > ...; while WCMD_fgets(..., is_console)" and the

crypt32(1/2): Test CertCreateCertificateContext, and fix an error code in a failure case

--Juan From 544fb76b6da191c8e5c665be11357706acae9be0 Mon Sep 17 00:00:00 2001 From: Juan Lang Date: Thu, 22 Sep 2011 05:20:50 -0700 Subject: [PATCH 17/18] Test CertCreateCertificateContext, and fix an error code in a failure case --- dlls/crypt32/cert.c |6 + dlls/crypt32/tests

Re: Old imagehlp patches

Hi Thomas, wrong mailing list. You wanted wine-devel instead (now cc'ed.) > I don't know about wine development, but are these patches still likely to > work? What would need to happen for them to be merged in? To your first question, try them and see! To your second question, a lot. They're m

crypt32: Test/correct CertGetNameString with NULL pvTypePara

Fix for bug 23287. --Juan From 1114085290c2ada360a02bae154b7167a0f2b0ca Mon Sep 17 00:00:00 2001 From: Juan Lang Date: Thu, 8 Sep 2011 11:10:08 -0700 Subject: [PATCH 2/2] Test/correct CertGetNameString with NULL pvTypePara --- dlls/crypt32/str.c | 18 - dlls/crypt32/tests/str.c

Re: RFC - ws2_32/socket.c: SIO_KEEPALIVE_VALS vs TCP_KEEPIDLE/TCP_KEEPINTVL

Hi Bruno, > The SIO_KEEPALIVE_VALS message on windows takes parameters as > miliseconds, on some other systems there are the equivalent > TCP_KEEPIDLE/TCP_KEEPINTVL which takes the parameters as seconds. To > solve this there is a division by 1000 on wine source code but the > problem is that valu

Re: mshtml: Use the last colon in proxy url as port separator

> just sent a patch doing that. Looks good to me, thanks! --Juan

Re: mshtml: Use the last colon in proxy url as port separator

> Is the ProxyServer specified as an URL? If yes then use the proper API > to dissect the URL instead of cobbling something together. Just to follow up in this idea, you could use InternetCrackUrl. mshtml delay loads wininet, but it also loads urlmon, which also loads wininet, so in effect wininet

mshtml: Use the last colon in proxy url as port separator

Hi André, > http://domain\user:passw...@server.com:8080 makes it visible that it's > intended to get the last colon What about http://domain\user:passw...@server.com? password isn't the port number. --Juan

Re: Best way to get Program Files/Common Files?

> I need to get the user configured path to Program Files/Common Files > to save the dinput action mapping settings. > > What are the my options for doing this? > > One way I found is the SHGetSpecialFolderPath function, but it > requires me to link to shell32 and I suspect there's a better way. I

Re: Possible off-by-1 in crypt32/chain.c match_common_names

Hi William, > trace:chain:match_common_name CN = L"*.battle.net\" > warn:chain:match_domain_component domain component L"net" too short for > L"net\" That CN is coming from the certificate. > Any thoughts or ideas on whether this is actually a bug and if so, how to > fix it? It's partly

Re: gsoc mentor summit

>> I'd be interested if there's a space going free. We just get to send 2 >> mentors though as I understand it? > Yes. I'd be interested as well, that's why I started this thread. I've been > there already in 2009, so if anyone else wants to go I'd be happy to yield. Whoever does go, I'll be happy

Re: NtQuerySystemInformation needs a little bit more flesh for SystemProcessorPerformanceInformation

> This Reserved1[0] is the DPC Time but I'm wondering what values from > /proc/stat to use here (remainder[0] is I/O wait). We could always make up > something of course but being accurate would be nicer. DPC Time has no equivalent in /proc/stat. It's an NT thing. Making something up is the only

Re: [PATCH 02/12] wscript: added helper function for tests

Hi Michal, please combine this with patch 3, it doesn't make sense on its own. --Juan

Re: [PATCH 1/6] kernel32: Fix PROFILE_Load (try 4)

Hi Christian, this isn't quite what Alexandre meant. *What* did you fix? Saying you did so isn't enough. Thanks, --Juan

Re: [PATCH 2/2] mshtml: Mark some functions as cdecl.

> BTW, the current plan is to do the new Gecko release together with Firefox 6 > release, which is about 6 weeks from now. The first beta version should be > out in a week or two, depending on how Firefox beta will behave. Then shouldn't the beta have the calling convention change anyway? In this

Re: [PATCH 2/2] mshtml: Mark some functions as cdecl.

Hi Jacek, > These are functions that I missed when revieweing Gecko headers. I will > probably change their calling convention in the next Gecko release. In that case, why not change the calling convention now? The matrix of possible configurations is much simpler that way. Right now, we have:

Re: Glitch-free iTunes?

Hi Keith, > WINE in general does many things, and you've got a big team now. Your > contributor list shows 1250 and you've got 2M lines of code. Few of these contributors remain active. Most had small contributions. The total number of contributors obviously can only increase over time, but the

Re: gcc 4.6 warning report

> David is right, the address is not stored as a pointer but as a DWORD in > place of the chars. Like this: > > gethostbyname("winehq.org"): > wrong: (DWORD) host->h_addr_list[i] = 0x00cbd1c8 = 200.209.203.0 > right: *(DWORD*) host->h_addr_list[i] = 0x86192ed1 = 209.46.25.134 Patch welcome ;) --Ju

Re: [PATCH 1/4] shell32: Implement erasing and restoring items from the trash

Hi Jay, +HRESULT TRASH_RestoreItem(LPCITEMIDLIST pidl){ Nit: the brace should be on its own line. +HRESULT TRASH_RestoreItem(LPCITEMIDLIST pidl) DECLSPEC_HIDDEN; +HRESULT TRASH_EraseItem(LPCITEMIDLIST pidl) DECLSPEC_HIDDEN; These two functions are never called in this patch, so you're introduci

Re: gcc 4.6 warning report

>> This is a false positive.  h_addr_list is declared as a char **, and >> technically it is, but gethostbyname only returns IPv4 addresses, i.e. >> ones that can fit in a DWORD. > > That doesn't sound like a problem that would give that warning. Why not? A cast of a pointer to a DWORD with 64-bi

Re: gcc 4.6 warning report

../../../dlls/netapi32/nbt.c:580:30: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] This is a false positive. h_addr_list is declared as a char **, and technically it is, but gethostbyname only returns IPv4 addresses, i.e. ones that can fit in a DWORD. --Juan

Re: [PATCH 1/4] Check for null pointers before strcmp. (LLVM/Clang)

> It would be a lot easier to find and fix real things if there weren't a > thousand false ones hanging around. But if you feel it's better to have a > lot of warnings and some possible bugs than a lot of checks and no bugs, > then maybe I'll not waste any more time "fixing" them. This is a false

Re: [PATCH 1/4] Check for null pointers before strcmp. (LLVM/Clang)

Hi Lauri, ok(pdst != NULL, "inet_ntoa failed %s\n", dst); -ok(!strcmp(pdst, addr0_Str),"Address %s != %s\n", pdst, addr0_Str); +ok(pdst && !strcmp(pdst, addr0_Str),"Address %s != %s\n", pdst, addr0_Str); This change doesn't accomplish anything. In the first place, the previous ok whi

Re: setupapi: Make sure machine name is non-empty before failing

> What's wrong with 'if (MachineName && *MachineName)' ? Nothing, it's my brain that's lacking. Thanks. --Juan

  1   2   3   4   5   6   7   8   9   10   >