On Wed, 13 Feb 2013 19:18:42 +0100
wrote:
> Johannes Kroll wrote:
> >It is in the log line that you deleted.
> Oops.
>
> >No, I don't have wineOSS. Does it require a proper OSSv4?
> Currently, yes. You'd have to try out wine-1.3.24 or older.
>
> I'l
On Wed, 13 Feb 2013 09:29:19 +0100
wrote:
> Hi,
>
> Johannes Kroll wrote:
>
> 9.532:003a:trace:midi:modLongData dwBufferLength=88 !
> f0 42 41 00 01 11 01 7f 4b 40 7a 01 7f 02 7f 7f .BA.K@z.
> 7f 7f 71 7f 40 01 7f 7f 7f 7f 03 7f 7f 01 01 00 ..q.@...
>
On Tue, 12 Feb 2013 15:49:18 +0100
wrote:
> Hi,
>
> Johannes Krol wrote:
> >Joerg, if you want the complete log I can send it to you by PM, it's
> >about 1.7M.
> I don't need that for now. What I need are the 119 missing bytes between
> 17.015:003b:trace:midi:modLongData dwBufferLength=125 !
> 1
On Mon, 11 Feb 2013 19:41:27 +0100
wrote:
> Johannes Kroll asked:
> >Did this patch get through? I don't see it on
> >http://source.winehq.org/patches/ ...
>
> It did.
> You looked too late in patches/. Committed patches are deleted sooner than
> rejected ones
On Thu, 24 Jan 2013 10:33:58 +0100
wrote:
> Compare with wineoss which uses poll <= 0 already...
>
> Johannes Kroll mentioned that MIDIIn takes a long time to end.
> Indeed, our testsuite ran 3 times into the "kill after 5s" timeout due to
> this bug.
> No
On Thu, 24 Jan 2013 10:33:58 +0100
wrote:
> Compare with wineoss which uses poll <= 0 already...
>
> Johannes Kroll mentioned that MIDIIn takes a long time to end.
> Indeed, our testsuite ran 3 times into the "kill after 5s" timeout due to
> this bug.
> Now the t
On Mon, 14 Jan 2013 11:42:46 +0100
wrote:
> Hi,
>
> Johannes Kroll wrote:
> >+for(i = 0; i < lpMidiOutHdr->dwBufferLength; i++)
> >+if((unsigned char)lpMidiOutHdr->lpData[i] == 0xF7 && i <
> >lpMidiOutHdr->dwBufferLength-1)
&g
On Thu, 10 Jan 2013 12:04:02 +0100
Christian Costa wrote:
> In your code you stop checking F7 just before the last byte (until
> position lpMidiOutHdr->dwBufferLength-2);
> You can check the last byte as well. This is also valid and simplify the
> condition.
> The missing F7 byte case is handled
On Thu, 10 Jan 2013 01:05:28 +0100
Johannes Kroll wrote:
> On Thu, 10 Jan 2013 00:38:06 +0100
> Christian Costa wrote:
>
>
> > After a better look the changes seem correct.
> > The condition i < lpMidioutHdr->dwBufferLength-1 is not necessary tough.
>
> Wi
On Thu, 10 Jan 2013 00:38:06 +0100
Christian Costa wrote:
> After a better look the changes seem correct.
> The condition i < lpMidioutHdr->dwBufferLength-1 is not necessary tough.
Without the buffer length check, there would be a buffer overflow when
an application tries to send a SysEx withou
On Wed, 9 Jan 2013 19:04:03 +0100
Christian Costa wrote:
> I would say consistency would be 2 spaces or none.
You are, of course, entitled to your opinion.
> Using only 1 space for assignment does not seem very common in wine AFAIK.
> In general it's better to follow the file style or the func
On Wed, 9 Jan 2013 16:10:18 +0100
Christian Costa wrote:
> 2013/1/9 Johannes Kroll
>
> > On Wed, 09 Jan 2013 10:19:54 +0100
> > Christian Costa wrote:
> >
> > > Le 09/01/2013 04:26, Johannes Kroll a écrit :
> > > > Hi,
> > > >
> >
On Wed, 09 Jan 2013 10:19:54 +0100
Christian Costa wrote:
> Le 09/01/2013 04:26, Johannes Kroll a écrit :
> > Hi,
> >
> > On Wed, 09 Jan 2013 03:55:25 +0100
> > Christian Costa wrote:
> >
> >> Hi,
> >>
> >> Please be consiste
Hi,
On Wed, 09 Jan 2013 03:55:25 +0100
Christian Costa wrote:
> Hi,
>
> Please be consistent when using space. 1 space before and after
> operators (<, ==, =, ...).
spaces inserted. HTH.
J.>From edd15d7d71e7309937c27dd9e6eab56bf42cc589 Mon Sep 17 00:00:00 2001
From: Jo
14 matches
Mail list logo
