On Sat, 2 Oct 2010, James McKenzie wrote:
> Looks like you got 'bit' by the way that a finite storage method mangles
> floating information. There was a lengthy discussion on how to 'overcome'
> this on the Wine-Development list a short while ago.
No, those tests aleady account for that.
/* Whe
ually documentation of a .NET method, but see the Remarks
section for a description of the format.
On Fri, 1 Oct 2010, Jeremy Drake wrote:
> I recently read an article () mentioning some of the oddities that show up
> in negative variant dates with non-zero (midnight) times, and I noticed
> that wi
On Wed, 14 Jan 2009, Alexandre Julliard wrote:
> Yes, it's better to avoid it, because then you may be testing things
> that you know the function is doing internally but that may not actually
> matter. Tests have to treat the target dll as a black box, and if you
> looked inside then it's no long
On Wed, 14 Jan 2009, Alexandre Julliard wrote:
> Jeremy Drake writes:
>
> > Is there anything wrong with these two patches? I'd really like to see
> > these tests go in, so hopefully someone will decide to tackle this
> > olepicture stuff. At the very le
On Mon, 5 Jan 2009, Jeremy Drake wrote:
>
> ---
> dlls/oleaut32/tests/olepicture.c | 321
> ++
> 1 files changed, 321 insertions(+), 0 deletions(-)
>
Is there anything wrong with these two patches? I'd really like to see
these te
On Tue, 9 Dec 2008, Nikolay Sivov wrote:
> + case PICTYPE_NONE:
> + case PICTYPE_UNINITIALIZED:
> + /* undocumented code */
> + return 0x800A017C;
This code looks suspiciously like CTL_E_INVALIDPROPERTYVALUE (from
olectl.h) to me...
On Sun, 7 Dec 2008, Nikolay Sivov wrote:
> Changelog:
> - fix OleLoadPicturePath behavior on wrong path
> - some cosmetic changes on module and test (spaces, tabs, ..)
Cool, this is related to what I was trying to get done. Please take a
look at the more complete tests for OleLoadPicutre
In order to implement OleLoadPictureFile and OleLoadPictureFileEx, it will
be necessary to change their entries in oleaut32.spec from stub to
stdcall. The stdcall syntax wants a list of parameter types, which puts
these functions in an unususal situation: they take a VARIANT (which is a
struct, in
On Tue, 18 Nov 2008, Michael Karcher wrote:
> Looks OK to me, but what happened to your finding about
> INET_E_RESOURCE_NOT_FOUND? Was it a red herring?
I saw that on XP, but I couldn't reproduce it on Windows 2000. I need to
investigate this further. Is there a mechansim to do
windows-version-
On Tue, 18 Nov 2008, Michael Karcher wrote:
> > Note that the IDL defines the VARIANT parameter as "optional". If the
> > filename is not specified, you should pass a NULL stream to
> > OleLoadPicture.
> How do I know? I think you shouldn't have told these detail. I might
> know what happens if I
On Mon, 17 Nov 2008, Michael Karcher wrote:
> The best way to do this is (in my oppinion) submitting the testcase
> again, but without the implementation, and marking the test todo_wine. A
> bug might be useful, but wouldn't a mail that contains the testcase as
> patch and the description in the c
On Sun, 16 Nov 2008, Juan Lang wrote:
> Do you have a bug open? Sorry, I've forgotten. If not, please do open
> one. You can describe your findings there.
No, but a quick search on bugzilla for OleLoadPictureFile turned up bug
10156. A comment on that bug suggests changing the summary to
"Ole
On Thu, 13 Nov 2008, Juan Lang wrote:
> > Any feedback on the spec file or the debug trace?
>
> I'm afraid I don't know what substantive difference there is between
> looking at one small portion of the disassembly (to verify a function
> is being called) and learning something more substantial.
On Wed, 12 Nov 2008, Austin English wrote:
> Can you add a testcase to show that this behavior is correct?
Yeah. I'll do that for the next version of the patch, as well as
implement OleLoadPictureFileEx.
Any feedback on the spec file or the debug trace?
Thanks,
Jeremy
--
If you cannot convin
On Wed, 12 Nov 2008, Juan Lang wrote:
> >> This patch implements OleLoadPictureFile based on the MSDN docs
> >> (http://msdn.microsoft.com/en-us/library/ms221680.aspx) and what I saw
> >> when stepping through in windbg on XP.
>
> Stop right there. Implementing stuff based on looking at disassemb
15 matches
Mail list logo
