Re: ddraw: Don't release ddraw if a surface is still using it.

2008-06-01 Thread Jens Albretsen
> Am Samstag, 31. Mai 2008 17:03:13 schrieb Michael Karcher: >> > Anyway it makes wine stop crashing when programs tries to do something >> > crazy like this. Stefan Dösinger asked me to put a HeapAlloc all >> memory >> > between the two Release's to check if the memory of ddraw object would >> be

Re: ddraw: Don't release ddraw if a surface is still using it.

2008-05-31 Thread Jens Albretsen
On Saturday 31 May 2008 14:57:25 Michael Karcher wrote: > Am Samstag, den 31.05.2008, 12:08 +0200 schrieb Jens Albretsen: > The patch looks like it would work as advertised, but the following > > snippet in the testcase smells fishy: > > +static unsigned long getRefcou

Re: ddraw: [3/3] Fix for regression bug #13277

2008-05-24 Thread Jens Albretsen
On Saturday 24 May 2008 17:30:47 Stefan Dösinger wrote: > > +ref = getRefcount(lpDD); > > +ok(ref == 1, "Got refcount %ld, expected 2\n", ref); > > + > > +IDirectDraw_Release(lpDD); > > + > > +ref = getRefcount(lpDD); > > +ok(ref == 0, "Got refcount %ld, expected 1\n", ref); > >

Re: ddraw: Fixed in part regression bug #13277

2008-05-22 Thread Jens Albretsen
On Friday 23 May 2008 06:35:22 you wrote: > Jens Albretsen wrote: > > On Thursday 22 May 2008 23:56:42 you wrote: > >> I don't have a compiler on my windows box, nor do I have cross > >> development tools on my linux box, but if you get me an exe I can test >

Re: ddraw: Fixed in part regression bug #13277

2008-05-22 Thread Jens Albretsen
ll see if the test fails or what? Anyway without the patch we just get a crash. > On 5/22/08, Jens Albretsen <[EMAIL PROTECTED]> wrote: > > On Thursday 22 May 2008 23:39:33 you wrote: > >> On 5/22/08, Jens Albretsen <[EMAIL PROTECTED]> wrote: > >> > I

Re: ddraw: Fixed in part regression bug #13277

2008-05-22 Thread Jens Albretsen
On Thursday 22 May 2008 21:46:03 Alexander Dorofeyev wrote: > Jens Albretsen wrote: > > Changelog: > > > > Fixed Failure when texture was loading onto itself. > > Fixes in part d3d7 regression bug #13277. > > Still need to find a way to make d3d7 stay aliv

Re: ddraw: Fixed last part of regression bug #13277

2008-05-22 Thread Jens Albretsen
<< snip >> > > of course even if CreateSurface doesn't addref the publically visible > > refcount, it could still hold some internal reference to prevent the > > ddraw object from beeing destroyed. If that's the case, we need an > > additional test showing that the ddraw object survives even thoug

Re: ddraw: Fixed last part of regression bug #13277

2008-05-22 Thread Jens Albretsen
On Thursday 22 May 2008 20:08:57 you wrote: > Am Donnerstag, 22. Mai 2008 19:17:34 schrieb Jens Albretsen: > > Well, as remember this the normal procedure of d3d, textures, surfaces > > and streams is to hold on to ddraw/d3d until everything is destroyed or > > the

Re: ddraw: Fixed last part of regression bug #13277

2008-05-22 Thread Jens Albretsen
On Thursday 22 May 2008 16:55:31 Stefan Dösinger wrote: > Am Donnerstag, 22. Mai 2008 16:17:26 schrieb Jens Albretsen: > > Changelog: > > d3d1-7 surfaces was not ref counting ddraw so if there was surface and > > ddraw was released, wine would kill everything. Now the Ret

Re: wined3d: Fix for buggy programs using ortho matrix with no z range

2008-04-29 Thread Jens Albretsen
On Tuesday 29 April 2008 22:25:48 Stefan Dösinger wrote: > Am Dienstag, 29. April 2008 19:04:55 schrieb Jens Albretsen: > > Changelog: > > Fix for old games that sets a Ortho matrix with z range from 0-0 or in > > other word with no range, which does'nt make any sense

Re: wined3d: Fix for buggy programs using ortho matrix with no z range

2008-04-29 Thread Jens Albretsen
On Tuesday 29 April 2008 22:25:48 Stefan Dösinger wrote: > Am Dienstag, 29. April 2008 19:04:55 schrieb Jens Albretsen: > > Changelog: > > Fix for old games that sets a Ortho matrix with z range from 0-0 or in > > other word with no range, which does'nt make any sense