Re: [1/2] include: Implement part of nserror.h

2013-03-11 Thread Jeff Latimer
On 11/03/13 17:43, Nikolay Sivov wrote: > On 3/11/2013 10:27, Jeff Latimer wrote: >> --- >> include/nserror.h | 226 >> ++ >> 1 file changed, 226 insertions(+) >> create mode 100644 include/nserror.h &

Re: 'Pending' patches state

2012-04-09 Thread Jeff Latimer
On 09/04/12 16:50, Dmitry Timoshkov wrote: > It should be in the best ineterests of the project to provide as much > feedback as possible, and should improve not only amount of accepted > code (by encouraging developers provide more > comments/explanations/tests/etc. and more actively discuss possi

Re: winscard

2011-09-30 Thread Jeff Latimer
On 30/09/11 19:42, Vincent Hardy wrote: > > Are these 4 patches good enough to be sent to wine-patch ? Vincent, normally you would start by adding tests that can confirm the same behaviour in Windows. If you can do that and get the test accepted then you are a long closer to get your patches accep

Re: TaskDialog implementation

2011-06-15 Thread Jeff Latimer
On 11/06/11 17:45, Hans Leidekker wrote: > On Fri, 2011-06-10 at 23:29 -0500, Vincent Povirk wrote: >> Well, I think you may be right that changing it to E_NOTIMPL at this >> point would break something and might be a bad idea. Sadly, Hans >> didn't say what the stub was originally for. Hopefully,

Re: usp10/tests: add tests for CR and LF chars and remove some trailing white space

2010-04-17 Thread Jeff Latimer
On 17/04/10 17:36, Greg Geldorp wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Yes that happens for me now too but not immediately in t

Re: comctl32: [Bug 17251] cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-03-15 Thread Jeff Latimer
On 15/03/10 23:33, Nikolay Sivov wrote: On 3/15/2010 15:08, Jeff Latimer wrote: LISTVIEW_GetItemW Hm, actually EditLabel and EndEditLabel looks quite different. EditLabel uses static buffer, and EndEditLabel doesn't even set a buffer pointer. That's most likely a real problem here,

Re: comctl32: [Bug 17251] cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-03-15 Thread Jeff Latimer
On 13/03/10 20:30, Nikolay Sivov wrote: On 3/13/2010 06:35, Jeff Latimer wrote: If not set then no value is returned and in the case of uTorrent the next entry selected is renamed. http://bugs.winehq.org/show_bug.cgi?id=17251 No value returned from what? LISTVIEW_GetItemW

Re: usp10: Bug 17324 change default glyph returned from 0xffff to 0

2010-03-12 Thread Jeff Latimer
On 12/03/10 00:37, Hans Leidekker wrote: It doesn't apply cleanly: Sorry, there are a couple patches ahead of this in my tree. Will re-baseline before resubmitting. And it has compile warnings: I will have a look. They disd not appear in my compile. It would be better to add this te

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-01-02 Thread Jeff Latimer
On 03/01/10 08:29, Jeff Latimer wrote: On 03/01/10 01:12, Nikolay Sivov wrote: On 1/2/2010 13:52, Jeff Latimer wrote: On 02/01/10 21:34, Nikolay Sivov wrote: On 1/2/2010 12:48, Jeff Latimer wrote: --- dlls/comctl32/listview.c |1 + 1 files changed, 1 insertions(+), 0 deletions

Re: comctl32: Get the test in the correct format

2010-01-02 Thread Jeff Latimer
On 02/01/10 21:25, Nikolay Sivov wrote: On 1/2/2010 12:47, Jeff Latimer wrote: --- dlls/comctl32/listview.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) You don't need this. Conversion is done next lines if needed: --- if (isW) bSame = (lst

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-01-02 Thread Jeff Latimer
On 03/01/10 01:12, Nikolay Sivov wrote: On 1/2/2010 13:52, Jeff Latimer wrote: On 02/01/10 21:34, Nikolay Sivov wrote: On 1/2/2010 12:48, Jeff Latimer wrote: --- dlls/comctl32/listview.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) +dispInfo.item.cchTextMax = textlenT

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-01-02 Thread Jeff Latimer
On 02/01/10 21:42, Nikolay Sivov wrote: On 1/2/2010 12:48, Jeff Latimer wrote: --- dlls/comctl32/listview.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Actually setting buffer count is noop here, cause buffer pointer is not set up for dispInfo.item. Because it is tied up with

Re: comctl32: cchTextMax needs to be set for LVS_OWNERDATA as it uses LVN_GETDISPINFO notifications

2010-01-02 Thread Jeff Latimer
On 02/01/10 21:34, Nikolay Sivov wrote: On 1/2/2010 12:48, Jeff Latimer wrote: --- dlls/comctl32/listview.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) +dispInfo.item.cchTextMax = textlenT(pszText, isW)+2; What does this '2' mean? +1 adds the trailing null and

Re: listview: Fix LISTVIEW_CancelEditLabel to not save the changed text

2009-12-06 Thread Jeff Latimer
On 06/12/09 18:56, Nikolay Sivov wrote: Jeff Latimer wrote: --- dlls/comctl32/listview.c |2 +- dlls/comctl32/tests/listview.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Hi, Jeff. This is obviously wrong. Test will fail on native systems after your patch. Why do

Re: ws2_32: Handle the formatting of IPV6 addresses and use inet_ntop function

2009-07-29 Thread Jeff Latimer
On 29/07/09 01:21, Juan Lang wrote: This makes the expression rather long, and also makes it hard to extend beyond two address families. ws2_32 also supports IPX, and with any luck it'll soon support IrDA. I'll send mine in shortly, and you can complain if you like :) That's ok. I had a ve

Re: Which virtualization software should I choose

2009-06-12 Thread Jeff Latimer
Paul Vriens wrote: The problem with both VirtualBox and QEMU/KVM seems to be supporting older Windows versions as guests (< NT4). I don't understand VirtualBox says it supports up to Windows 7 and I have XP running. I have had QEMU/KVM running XP. What annoyed me about VMWare Server was the b

Re: winebrowser: Fix unicode recognition

2009-05-28 Thread Jeff Latimer
Dmitry Timoshkov wrote: "André Hentschel" wrote: Please add a test case which uses mixed ansi/unicode DDE client/server and only then start fixing the code. For winebrowser? Do we test any of our programs? Or for DDE? Quoting above: "mixed ansi/unicode DDE client/server". I put tests for

Re: include: Define IN6ADDR_ANY_INIT and IN6ADDR_LOOPBACK_INIT and code for IN6_IS_ADDR_LOOPBACK

2009-04-25 Thread Jeff Latimer
Jeff Latimer wrote: This patch enables putty to compile and run using IPv6. I meant to say that André Hentschel was doing the hard work with putty and merely ask me to do this little bit. Jeff

Re: [1/4] Resend: ws2_32/tests: add tests for Inet_Ntop and inet_ntoa

2009-04-24 Thread Jeff Latimer
There's no point in resending if you don't fix the reason it was rejected the first time. My apology, I corrected what I thought was the problem but did not see the others. Have resubmitted it.

Re: Article on wine development strategy

2009-04-18 Thread Jeff Latimer
Scott Ritchie wrote: Reece Dunn wrote: 2009/4/18 Kai Blin : On Saturday 18 April 2009 05:21:20 Dan Kegel wrote: The one that worked out best was to pick some random user who's almost happy, fix the last few bugs that are keeping his apps from working, and then once he's happy, move on to the n

Re: [1/5] resend include: bring in6_addr into line with the MS definition

2009-04-13 Thread Jeff Latimer
Alexandre Julliard wrote: You need the WS prefix on all definitions that can potentially conflict with Unix. Fixed it up and resubmitted.

Re: [1/5] resend include: bring in6_addr into line with the MS definition

2009-04-08 Thread Jeff Latimer
Kai Blin wrote: This version is based on the Vista PSDK and places the definition in in6addr.h. Is there any reason you're putting this into an extra header? The PSDK I have around keeps this in ws2ipdef.h My Vista PSDK breaks into the extra header. It does the same for the IPV4 addr

Re: [1/5] resend include: bring in6_addr into line with the MS definition

2009-04-02 Thread Jeff Latimer
Rob Shearman wrote: This looks right, but in recent PSDKs it has moved from ws2tcpip.h to in6addr.h. Thanks, I knew that the latest PSDK had split this out but as none of the PSDK other changes had been worked into the tree, I was reluctant and unsure of whether that PSDK should be used. I hav

Re: [1/5] resend include: bring in6_addr into line with the MS definition

2009-04-01 Thread Jeff Latimer
Alexandre Julliard wrote: Jeff Latimer writes: diff --git a/include/ws2tcpip.h b/include/ws2tcpip.h index a38ccda..9ddb3d1 100644 --- a/include/ws2tcpip.h +++ b/include/ws2tcpip.h @@ -85,26 +85,41 @@ struct WS(ip_msfilter) { struct WS(in_addr) imsf_slist[1]; }; -typedef struct WS

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)

2009-03-30 Thread Jeff Latimer
Andreas Rosenberg wrote: Were you intending to send this to wine-patches?

Re: [1/5] resend include: bring in6_addr into line with the MS definition

2009-03-27 Thread Jeff Latimer
Alexandre Julliard wrote: Jeff Latimer writes: diff --git a/include/ws2tcpip.h b/include/ws2tcpip.h index a38ccda..9ddb3d1 100644 --- a/include/ws2tcpip.h +++ b/include/ws2tcpip.h @@ -85,26 +85,41 @@ struct WS(ip_msfilter) { struct WS(in_addr) imsf_slist[1]; }; -typedef struct WS

Re: Disabling File attachments on Wiki

2009-03-13 Thread Jeff Latimer
Dmitry Timoshkov wrote: If a user has found a typo, probably he/she is aware of bugzilla or irc. That's a lot thinking for a user to do given bugzilla is not an intuitive approach to correcting grammar. There does not appear to be an easy way to decide that a user is valid and spammers will cr

Re: [2/5] resend ws2_32/tests: add tests for Inet_Ntop and inet_ntoa

2009-03-09 Thread Jeff Latimer
Paul Vriens wrote: Hi, There is no need to have two if (pInetNtop) statements right after each other, this could be just one. You than don't need to indent the code anymore. You are right. I tidied up the code organising in IPV4 and IPV6 and did not notice I had removed the code between the

Re: [5/5] ws2_32/tests: Tests for invalid conditions in InetNtop

2009-03-09 Thread Jeff Latimer
Paul Vriens wrote: Jeff Latimer wrote: MSDN defines an number of conditions that inet_ntop will return errors. This patch tests for them. - Secondly you shouldn't use magic number if you no the name: WSASetLastError(0xc00d); In the tests you do: +ok(WSAGetLast

Re: [2/5] resend ws2_32/tests: add tests for Inet_Ntop and inet_ntoa

2009-03-08 Thread Jeff Latimer
Paul Vriens wrote: Two minor things: There is no need to to check the return value of GetModuleHandle as ws2_32 is already imported. Could you add a win_skip() somewhere so we know that some tests are skipped on some platforms? Done. Have resubmitted the set again.

Re: [2/6] ws2_32/tests: add tests for Inet_Ntop and inet_ntoa

2009-03-07 Thread Jeff Latimer
James Hawkins wrote: Like every other test: function pointers and GetProcAddress. Ta. I have not had this problem before.

Re: [2/6] ws2_32/tests: add tests for Inet_Ntop and inet_ntoa

2009-03-07 Thread Jeff Latimer
James Hawkins wrote: On Sat, Mar 7, 2009 at 5:56 PM, Jeff Latimer wrote: Note that Inet_Ntop is only available in Vista and Windows 2008. Hence the testing of version to avoid breaking the test suite on earlier OS's. Checking the windows version is not allowed in the tests. How

Re: Problem cross compiling after adding tests for inet_ntop

2009-02-20 Thread Jeff Latimer
Jeff Latimer wrote: > Any ideas on what I need to do to get crosstest to work? > Problem fixed. When in doubt read the documentation ie. I searched went to the wiki http://wiki.jswindle.com/index.php/Coding_Hints:Test_Cases which had a post from Hans.

Problem cross compiling after adding tests for inet_ntop

2009-02-20 Thread Jeff Latimer
I have been writing some tests for InetNtop/inet_ntop and placed them in dlls/ws2_32/tests/sock.c (snip of the code is below) but when I cross compile I get: make crosstest i386-mingw32-gcc -c -I. -I. -I../../../include -I../../../include-g -O2 -o sock.cross.o sock.c i386-mingw32-gcc protoc

Re: user32: Resend: Move character conversion logic to dde_server.d &remove todo's

2009-01-26 Thread Jeff Latimer
Dmitry Timoshkov wrote: > "Jeff Latimer" wrote: >> The issue is that the client passes data using messaging or DDEML >> there is no method in the api to inform the server whether the data >> is Unicode or not. The only method I have determined is to use >>

Re: user32: Resend: Move character conversion logic to dde_server.d &remove todo's

2009-01-25 Thread Jeff Latimer
Dmitry Timoshkov wrote: >> It highlights the problem and that the translation should take place >> in the server. In earlier discussions last year this was an issue. > Again, do you have a test case for that as a proof? When solving the winebrowser problem, I was fixing the existing translation

Re: user32: Resend: Move character conversion logic to dde_server.d &remove todo's

2009-01-24 Thread Jeff Latimer
Dmitry Timoshkov wrote: > DDE and DDEML are supposed to interchangeable. A DDE client can talk to a DDEML server and turnabout. >>> DDEML is just a wrapper around raw DDE messages, and raw DDE messages >>> don't have a translation layer in the user32 messaging system. >> Agreed, the poi

Re: user32: Resend: Move character conversion logic to dde_server.d &remove todo's

2009-01-24 Thread Jeff Latimer
Dmitry Timoshkov wrote: >> DDE and DDEML are supposed to interchangeable. A DDE client can talk >> to a DDEML server and turnabout. > DDEML is just a wrapper around raw DDE messages, and raw DDE messages > don't have a translation layer in the user32 messaging system. Agreed, the point I was maki

Re: user32: Resend: Move character conversion logic to dde_server.d &remove todo's

2009-01-23 Thread Jeff Latimer
Dmitry Timoshkov wrote: > "Jeff Latimer" wrote: > >> The issue is that the client passes data using messaging or DDEML >> there is no method in the api to inform the server whether the data >> is Unicode or not. The only method I have determined is to u

user32: Resend: Move character conversion logic to dde_server.d & remove todo's

2009-01-23 Thread Jeff Latimer
I have resubmitted this patch for discussion purposes. Patch "user32/tests: Clarify the msgs to differentiate Unicode and ASCII in tests" cleans up existing tests for this situation and demonstrates the functionality. The problem remains that the application passes to the dde/ddeml data that i

Re: [user32] Allocate buffer on heap (Bug 17076)

2009-01-23 Thread Jeff Latimer
Paul Vriens wrote: > > > Some called functions assume that buffer is always on heap. That isn't > the case > anymore. If you do +local_buffer = HeapAlloc(GetProcessHeap(), 0, buffer_size); shouldn't there be a HeapFree() added to match? Jeff

Re: [3/5] user32: Resend: Move character conversion logic to dde_server.d & remove todo's

2009-01-15 Thread Jeff Latimer
Dmitry Timoshkov wrote: Then the first thing to do is to write some test cases. I have had another look at the existing test cases that I added a few months ago. I have rerun the tests before and after the patch "[3/5] user32: Resend: Move character conversion logic to dde_server.d & remove t

Re: [3/5] user32: Resend: Move character conversion logic todde_server.d & remove todo's

2009-01-14 Thread Jeff Latimer
Dmitry Timoshkov wrote: > Then the first thing to do is to write some test cases. I will set some up.

Re: [3/5] user32: Resend: Move character conversion logic to dde_server.d & remove todo's

2009-01-14 Thread Jeff Latimer
Hans Leidekker wrote: > On Wednesday 14 January 2009 08:29:33 Jeff Latimer wrote: > > >> I have tested this a number of ways and I can not see a mechanism that >> DDE can determine whether data passed is UNICODE (pData is of type >> LPBYTE). In my tests, the

Re: user32: Resend Check for NULL pData in DdeClientTransAction expectingto be passed a handle

2008-09-08 Thread Jeff Latimer
Dmitry Timoshkov wrote: >> +if (pData == NULL) >> +{ >> +if (cbData == (DWORD)-1) >> +pConv->instance->lastError = DMLERR_INVALIDPARAMETER; >> +else >> +pConv->instance->lastError = DMLERR_MEMORY_ERROR; >> +return NULL; >> +} > > Alexandre

Re: user32: Resend Check for NULL pData in DdeClientTransAction expectingto be passed a handle

2008-09-07 Thread Jeff Latimer
Dmitry Timoshkov wrote: >> +if (pData == NULL) >> +{ >> +if (cbData == (DWORD)-1) >> +pConv->instance->lastError = DMLERR_INVALIDPARAMETER; >> +else >> +pConv->instance->lastError = DMLERR_MEMORY_ERROR; >> +return NULL; >> +} > > Alexandre

Re: [5/5] user32: Move character conversion logic to dde_server.d & remove todo's

2008-09-05 Thread Jeff Latimer
Alexandre Julliard wrote: > Jeff Latimer <[EMAIL PROTECTED]> writes: > > >> @@ -772,12 +774,51 @@ static WDML_QUEUE_STATE >> WDML_ServerHandleExecute(WDML_CONV* pConv, WDML_XACT* pX >> >> if (ptr) >> { >> -hDdeData =

Re: user32: DdeClientTransaction should return 0 in the last paramforDDE_DATA

2008-08-08 Thread Jeff Latimer
Dmitry Timoshkov wrote: > > I don't see how changing Wine internal implementation could lead to > failing tests under Windows. My confusion. Late at night. Found the problem, the inside the if block. Resent the patch. Jeff

Re: user32: DdeClientTransaction should return 0 in the last param forDDE_DATA

2008-08-07 Thread Jeff Latimer
Dmitry Timoshkov wrote: > "Jeff Latimer" <[EMAIL PROTECTED]> wrote: > >> MSDN does not show DdeCientTransaction as returning in res >> DDE_FNOTPROCESSED. Is this the standard test to see if it is zero? >> Otherwise an actual test for 0 would be just a

Re: user32: DdeClientTransaction should return 0 in the last param forDDE_DATA

2008-08-07 Thread Jeff Latimer
Dmitry Timoshkov wrote: > "Jeff Latimer" <[EMAIL PROTECTED]> wrote: > >> >> + if (ack) *ack = ERROR_SUCCESS; >> >> >> ok(ret == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", ret); >> -todo_wine >> -{ &g

Re: [resent] [WideChar conversion improvements - 5/5] Add a lot of WideCharToMultiByte tests

2008-07-31 Thread Jeff Latimer
Colin Finck wrote: > Add a lot of new tests for the actual WideCharToMultiByte string > conversion as well. Are you planning to move on to MultiByteToWideChar tests? I was planning on adding a few and don't want to get into your way. Jeff

ntoskrnl tests - where to write them?

2008-07-18 Thread Jeff Latimer
I have been looking at writing a couple of tests for ntoskrl functions but I have had difficulty locating a suitable place. It sort of looks like ntdll/tests is the place but it is not clear. Is there a guide for locating this one? Jeff

Re: [winehq] broken link

2008-07-12 Thread Jeff Latimer
Stefan Leichter wrote: > when i click on the "Development" link in the "Development" section i get an > 404 error. Can someone please fix this. > Its been in bugzilla for a while, [Bug 13898] Busted Development link.

Re: Fixing crashes in Tests (OS version check)

2008-05-31 Thread Jeff Latimer
James Hawkins wrote: > On Fri, May 30, 2008 at 11:18 PM, Alistair Leslie-Hughes > <[EMAIL PROTECTED]> wrote: > >> Hi, >> >> I've being investigating crashes that occur on Win98 when the tests run. I >> have fixed a couple already which where trivial. When I attempted to fix the >> snmpapi tests

Re: [PATCH 2/3] shell32: implement make new folder UI changes.

2008-05-16 Thread Jeff Latimer
Lei Zhang wrote: > Hi, > > This implements the treeview UI changes to show users the newly created > folder. > > > > I can't apply the patch. Is there one missing? Jeff Latimer

Re: Wine Security Disclosure

2008-03-15 Thread Jeff Latimer
Dmitry Timoshkov wrote: > "TheBlunderbuss" <[EMAIL PROTECTED]> wrote: > > [skipped] > > >> This level of security info is something everyone should have easy >> access to and know before starting Wine. Of course, wherever I'm not >> accurate, feel free to fill in! >> > There is nothing spec

Re: Resend pdh[3:3]: remove unnecessary test done in PdhLookupPerfNameByIndexW

2008-02-14 Thread Jeff Latimer
Hans Leidekker wrote: > On Thursday 14 February 2008 09:57:32 am Jeff Latimer wrote: > > >> +machineW = pdh_strdup_aw( machine ); >> + >> +if (!(ret = PdhLookupPerfNameByIndexW( machineW, index, bufferW, &sizeW >> ))) >> > > In the

Re: pdh[3:3]: remove unnecessary tests doneinPdhLookupPerfNameByIndexW

2008-02-11 Thread Jeff Latimer
Dmitry Timoshkov wrote: > That's true for index, but not for machine. You are correct. I will resubmit. I think it will be better to pass machine in this case. Jeff

Re: pdh[3:3]: remove unnecessary tests done inPdhLookupPerfNameByIndexW

2008-02-11 Thread Jeff Latimer
Dmitry Timoshkov wrote: > "Jeff Latimer" <[EMAIL PROTECTED]> wrote: > >>>> -if (machine) >>>> -{ >>>> -FIXME("remote machine not supported\n"); >>>> -return PDH_CSTATUS_NO_MACHINE; >>>

Re: pdh[3:3]: remove unnecessary tests done in PdhLookupPerfNameByIndexW

2008-02-10 Thread Jeff Latimer
Dmitry Timoshkov wrote: > "Jeff Latimer" <[EMAIL PROTECTED]> wrote: > >> --- a/dlls/pdh/pdh_main.c >> +++ b/dlls/pdh/pdh_main.c >> @@ -837,14 +837,7 @@ PDH_STATUS WINAPI PdhLookupPerfNameByIndexA( >> LPCSTR machine, DWORD index, LPSTR >> >

Re: Review comparing Wine and Vista for running games

2008-02-01 Thread Jeff Latimer
Bang Jun-young wrote: > I think this kind of a silly game doesn't help Wine as much... > It may not be a help but like they say "there's not such thing as bad publicity". A lot more people hear of Wine is better than not hearing about it.

Re: [PATCH] Wine's ChangeDisplaySettingsEx is too strict

2008-01-20 Thread Jeff Latimer
Szombathelyi György wrote: > if ((devmode->dmFields & (DM_PELSWIDTH | DM_PELSHEIGHT)) != > (DM_PELSWIDTH | DM_PELSHEIGHT)) > { > WARN("devmode doesn't specify the resolution: %04x\n", > devmode->dmFields); > -return DISP_CHANGE_BADMODE; > } Is this warning still v

Re: Indentation

2008-01-11 Thread Jeff Latimer
Maarten Lankhorst wrote: > Some of wine's code is a mess with indentation, but alexandre won't > commit indentation patches. > This explains some frustrations with patches. Do we have the policy on the web? > Cheers, > Maarten > Jeff

Dereference of null ptrs after an ERR has been executed

2008-01-11 Thread Jeff Latimer
What is the policy for handling the dereferencing of pointers that have previously been determined to be NULL and an ERR message has been issued. It seems that there are many cases where Coverity has found that the test is made but the code falls through to the dereference. In a number of cas

Re: pdh: Remove or fix tests that fail on Windows.

2007-10-23 Thread Jeff Latimer
Hans Leidekker wrote: > On Monday 22 October 2007 14:43:59 Jeff Latimer wrote: > >> to test with and hence the delay. The current patch I submitted was >> cleaning up the Null reference issue before moving on to sorting out the >> > I don't see any cras

Re: pdh: check for NULL pointer reference

2007-10-22 Thread Jeff Latimer
>> In this case the fix is for a Null reference as indicated in the >> accompanying tests. The test prangs in the current build and the patch >> for pdh_main.c fixes the behaviour on XP. As I said, I can't tell if it >> > > How can a fix to pdh_main.c (which is Wine's implementation) fix

Re: pdh: check for NULL pointer reference

2007-10-22 Thread Jeff Latimer
> > I don't think we want to emulate the broken XP behaviour of requiring a > buffer, even when querying the buffer size. Apps written to comply with > this behaviour should work on the current implementation. And MSDN mentions > only XP, which implies that it has been fixed in Win2k3 and up. In t

Re: pdh: add tests for XP variant of api call

2007-09-26 Thread Jeff Latimer
Hans Leidekker wrote: >> I am happy with that though the tests I added relate to the following >> paragraph where it says that XP requires the buffer parameter as well as >> the size at all times and testing shows that it returns >> PDH_INVALID_ARGUMENT. It also returns PDH_INSUFFICIENT_BUFFER ins

Re: pdh: add tests for XP variant of api call

2007-09-25 Thread Jeff Latimer
Hans Leidekker wrote: >> From this we should write tests to accept all values. It would seem >> that the wine dll still needs to implement the API accurately, so you >> are saying, code the API correctly but make the tests generic? >> > > Quote from MSDN on PdhLookupPerfNameByIndex: > > PD

Re: pdh: add tests for XP variant of api call

2007-09-24 Thread Jeff Latimer
Hans Leidekker wrote: > On Monday 24 September 2007 12:13:50 Jeff Latimer wrote: > > All tests succeed here on 2003 without your patch. That means that they must be XP specific. I noticed some vista specfic bugs bugs being reported. > Even if APIs return > different valu

Re: pdh: add tests for XP variant of api call

2007-09-24 Thread Jeff Latimer
Hans Leidekker wrote: > On Monday 24 September 2007 12:13:50 Jeff Latimer wrote: > >> I will get on with adding the variations to pdh.c >> > To prevent you doing any duplicate work, I have implementations > of PdhCalculateCounterFromRawValue, PdhCollectQueryDataEx a

Re: Monster and Me in wine

2007-09-04 Thread Jeff Latimer
Nguyễn Thành Trung wrote: Hi ! I'm playing Monster and Me (www.monsterandme.com) in wine. In wine 0.9.7, there's a small bug when login, but every else work fine. In other newer versions of wine, login screen works fine, the game's performance is better - nearly like in windows. Bu

Re: todo_wine problems

2006-10-01 Thread Jeff Latimer
Dmitry Timoshkov wrote: The switch '-P wine' specifies a Wine platform, and todo_wine will work properly. Hopefully I correctly understood the problem :-) Thanks Dimitry, that explains it exactly. Jeff

Re: Governance revisited (Wineconf report)

2006-09-24 Thread Jeff Latimer
present, nobody is obliged to write a 10 second reply and often don't. There has to be feedback to keep the process moving. I don't receive it and patches languish unapplied, delaying me considerably on tackling new work as I wait for acceptance before proceeding. Jeff Latimer

Re: Governance revisited (Wineconf report)

2006-09-24 Thread Jeff Latimer
Vitaliy Margolen wrote: The next question is how long does someone wait till resorting to Bugzilla. Depending on the criteria it could generate a fair bit of -several days :) As in if some one wants to fix something, they should either provide a test (best choice) or open bug and describ

Re: Governance revisited (Wineconf report)

2006-09-21 Thread Jeff Latimer
tabase with a lot of patches that would normally be accepted after a couple of goes. Who is responsible for clearing the bug report after acceptance? Unless you are actually actively pushing the patch for acceptance, the submitter of a patch to Bugzilla would probably be unaware that it had b

Re: Status of dlls that you maintain

2006-09-21 Thread Jeff Latimer
n wine and the problems mentioned in WWN #292 have been fixed. Jeff Latimer

Re: Text Layout Summit

2006-09-21 Thread Jeff Latimer
earer architecture would be great. Jeff Latimer

Re: Recovering a patch accidentally removed by git reset

2006-09-20 Thread Jeff Latimer
Saulius Krasuckas wrote: * On Wed, 20 Sep 2006, Jeff L wrote: How do you get a patch back that you have managed to remove completely from your system with a git reset HEAD^ git reset git checkout patchname ? What branch you were on during this? This was the Origin or Master Hmm,

Re: usp10: Match output of WinXP for ScriptGetProperties.

2006-09-14 Thread Jeff Latimer
Hans Leidekker wrote: -Hans Changelog Match output of WinXP for ScriptGetProperties. Add a test for ScriptGetProperties. +static const SCRIPT_PROPERTIES script_0 = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }; +static const SCRIPT_PROPERTIES script_1 = { 0, 0, 0, 0, 0, 0, 0,

Re: RTL language support in usp.dll

2006-09-13 Thread Jeff Latimer
Vijay Kiran Kamuju wrote: Hi, Your patch for RTL support in usp10.dll. http://www.winehq.org/pipermail/wine-patches/2006-September/030571.html Only includes support for Arabic. If you could include for other RTL languages esp Hebrew (other RTL languages are Farsi and Urdu). I think that would

Re: LOSTWAGES: Replace references to CVS with Git

2006-08-25 Thread Jeff Latimer
Jeff Latimer wrote: Mike I suppose that the problem is that wrapping your mind around git and working out how to handle patches, especially as it takes time to get them accepted, revert them and manage trees etc is difficult. I don't know about other but I have had a number of perplexin

Re: resend add missing glyph code to GetGlyphIndices

2006-08-23 Thread Jeff Latimer
Dmitry Timoshkov wrote: As an additional optimization, probably it would be better to call WineEngGetTextMetrics instead of GetTextMetricsW to avoid introducing hdc as another parameter of WineEngGetGlyphIndices. Sounds good and simpler, will give it a try. Jeff

Re: gdi: resend add missing glyph code to GetGlyphIndices

2006-08-23 Thread Jeff Latimer
Alexandre Julliard wrote: Jeff L <[EMAIL PROTECTED]> writes: +/* Note that the call to GetTextMetricsW is made in the loop * + * because it is less likely to have non existant glyphs * + * and hence we should have few calls to Ge

Re: LOSTWAGES: Replace references to CVS with Git

2006-08-21 Thread Jeff Latimer
Mike McCormack wrote: Jeff Latimer wrote: If CVS goes, is there another way to see what patches have been applied to the tree? The git does not seem to do that for me and cvs.winehq.org is a fairly easy lookup. If you have a local git tree, "git whatchanged" will give you the

Re: LOSTWAGES: Replace references to CVS with Git

2006-08-21 Thread Jeff Latimer
Alexandre Julliard wrote: Michael Stefaniuc <[EMAIL PROTECTED]> writes: Are there any plans to get rid of CVS? I would guess keeping the CVS tree sync from the git tree is low maintanance so it can be kept around "forewever". Yes, as long as it doesn't require any maint

Re: resend add missing glyph code to GetGlyphIndices

2006-08-14 Thread Jeff Latimer
thing else that isn't obvious". Maybe something like /* called in a loop, but missing glyph shouldn't happen often so we don't want to call it outside the loop, always */ Andreas Mohr Makes sense now that you mention it. Jeff Latimer

Re: resend add missing glyph code to GetGlyphIndices

2006-08-14 Thread Jeff Latimer
Dmitry Timoshkov wrote: "Jeff L" <[EMAIL PROTECTED]> wrote: +DWORD WineEngGetGlyphIndices(HDC hdc, GdiFont font, LPCWSTR lpstr, INT count, LPWORD pgi, DWORD flags) { INT i; - +TEXTMETRICW textm; for(i = 0; i < count; i++) +{ pgi[i] = get_glyph_index(font, lpstr[i]); -

Re: usp10: Remove a test that fails on Windows.

2006-08-01 Thread Jeff Latimer
Good call Hans :-D , I made the the HDC global and it seems to work in both windows and wine now.  Will format a patch for this one. Jeff Hans Leidekker wrote: On Monday 31 July 2006 13:20, Jeff Latimer wrote: times out of 20 on my 32 bit system. Obviously there is an

Re: usp10: Remove a test that fails on Windows.

2006-07-31 Thread Jeff Latimer
Hans, the test does fail on windows but that is becuase it is checking gylphs that are different between the windows and wine (ie. while the unicode is the same the gylphs are  different).  I don't know how to overcome that issue.  What is it is supposed to do is check that there is a consisten

Re: usp10: Resend - Add funtionality for ScriptStringAnalyse

2006-07-30 Thread Jeff Latimer
Vitaliy Margolen wrote: This one implements the checks described in the API. I think that we need to reproduce those checks but I can make the message more clear though. Jeff Can you use something that every other person would understand? if (cString < 1 || !pString) { Please use WARN i

Re: Indentifying Unicode scripts

2006-07-29 Thread Jeff Latimer
page http://msdn2.microsoft.com/en-us/library/3hd1xf60.aspx I will try to find more info on it. Thanks, VJ On 7/29/06, Jeff Latimer <[EMAIL PROTECTED]> wrote: Vijay, do you have some examples on these functions to get me started? Jeff Vijay Kiran Kamuju wrote: > Hi, > > In window

Re: Indentifying Unicode scripts

2006-07-29 Thread Jeff Latimer
Vijay, do you have some examples on these functions to get me started? Jeff Vijay Kiran Kamuju wrote: Hi, In windows the identification of the unicode strings is handled by msvcrt. I think we should put helper functions so that we can use them in msvcrt. Which will be inturn used in usp10

Re: usp10: Implement ScriptGetGlyphABCWidth.

2006-07-26 Thread Jeff Latimer
Hans, I will look at this one.  Seems to be intermittent. :-\ Jeff Hans Leidekker wrote: On Wednesday 26 July 2006 11:19, Alexandre Julliard wrote: ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p usp10_test.exe.so usp10.c && touch usp10.ok usp10.c:273: Test failed

Re: Drive mapping of Z:

2006-07-24 Thread Jeff Latimer
Marcus Meissner wrote: as we've heard from our Austrian colleague, this is not improving sec (which was a freshening shock for me). Since the symlink is in a directory controlled by the user, the user should be able to remove it. If not, something is broken. ls -la ~/.wine

Re: usp10: Add funtionality for ScriptStringAnalyse

2006-07-24 Thread Jeff Latimer
Ta, I will redo the patch. =-O Jeff Detlef Riekenberg wrote: Jeff wrote: +if (psssa->pssap->psva) +HeapFree(GetProcessHeap(), 0, psssa->pssap->psva); +if (psssa->pssap->piAdvance) +HeapFree(GetProcessHeap(), 0, psssa->ps

Re: usp10: Implement and test ScriptCacheGetHeight. (rediffed)

2006-07-23 Thread Jeff Latimer
I use Fedora core 4 to develop this code.  The version of ScriptStringAnalyse you have does not actually do anything other than return various values.  The problem occurs after the second call to ScriptStringAnalyse but the only difference is that hdc is specified.  In theory it should drop thr

Re: usp10: Implement and test ScriptCacheGetHeight. (rediffed)

2006-07-23 Thread Jeff Latimer
Do you have the trace WINEDEBUG=+uniscribe wine usp10_test.exe? It may help withmailing down where the problem is. Jeff Hans Leidekker wrote: It doesn't look very useful to me: Unhandled exception: page fault on read access to 0x70697263 in 32-bit code (0x70697263). Register dump: CS:0073

Re: usp10: Implement and test ScriptCacheGetHeight. (rediffed)

2006-07-23 Thread Jeff Latimer
Interesting. I have not had any problem with them. They also compile and run under Windows. Have you got anymore info, a trace? Jeff Hans Leidekker wrote: On Sunday 23 July 2006 00:42, Jeff Latimer wrote: Hans, I don't think that your test was applied, only the functio

Re: usp10: Implement and test ScriptCacheGetHeight. (rediffed)

2006-07-22 Thread Jeff Latimer
Hans, I don't think that your test was applied, only the function was. Jeff Hans Leidekker wrote: Lotus Notes calls this one. See bug 4944. -Hans Changelog Implement and test ScriptCacheGetHeight. bd39fa31f57846d1

  1   2   >