James Hawkins wrote:
On 6/27/07, Jeff Latimer <[EMAIL PROTECTED]> wrote:
Coverity CID 43 Forward_Null is false. This adds a comment explaining
the NULL pass is ok.
Why do we need a comment for that?
Mainly because the logic is a bit difficult. It depends on the length
being 0 to terminate th
James Hawkins wrote:
On 5/25/07, Andrey Turkin <[EMAIL PROTECTED]> wrote:
James Hawkins wrote:
> On 5/25/07, Mounir IDRASSI <[EMAIL PROTECTED]> wrote:
>> Hi,
>> You also have to modify other files in order to integrate your stub
>> implementation to the wine build chain: Makefile.in, configure a
James Hawkins wrote:
On 5/25/07, Andrey Turkin <[EMAIL PROTECTED]> wrote:
James Hawkins wrote:
> On 5/25/07, Mounir IDRASSI <[EMAIL PROTECTED]> wrote:
>> Hi,
>> You also have to modify other files in order to integrate your stub
>> implementation to the wine build chain: Makefile.in, configure a
Robert Shearman wrote:
Jeff Latimer wrote:
+OUR_GUID_ENTRY(IID_INetFwMgr,0xf7898af5,
0xcac4, 0x4632, 0xa2, 0xec, 0xda ,0x06, 0xe5, 0x11, 0x1a, 0xf2)
+OUR_GUID_ENTRY(CLSID_NetFwMgr, 0x304ce942,
0x6e39, 0x40d8, 0x94, 0x3a, 0xb9, 0x13, 0xc4, 0x0c, 0x9c
Michael Stefaniuc wrote:
Jeff Latimer wrote:
---
dlls/hnetcfg/hnetcfg_dll.h | 70
+
+/* __stdcall HNETCFG_HNetDeleteRasConnection(); */
It's only the comments but why don't you use WINAPI instead of __stdcall?
bye
michael
This is more a ca
For dlls, should the GUID's be put in uuids.h or kept local to the dll.
In this case I don't think anything else cares about them, so they could
be local.
Jeff Latimer
Jeff Latimer wrote:
Add public uuids for the interface.
---
Alexandre Julliard wrote:
There's no reason to initialize the enum values explicitly,
particularly since all your values are wrong...
My mistake. I had not got to a point where they were used, so they were
untested. The reason I initialised them in the first place I was
worried about copyrigh
James Hawkins wrote:
On 4/20/07, Jeff L <[EMAIL PROTECTED]> wrote:
James Hawkins wrote:
>>
>> Is there a reason why we should not just create a Desktop directory?
>> Seems neater than cluttering up the home.
>>
> I sure wouldn't want some app creating a De
James Hawkins wrote:
Is there a reason why we should not just create a Desktop directory?
Seems neater than cluttering up the home.
I sure wouldn't want some app creating a Desktop directory in my home
folder if it didn't exist before.
I don't know which is better, a lot of files appearing in
Lei Zhang wrote:
Hi,
As reported in bug 7373, some people do not have a Desktop directory
in their home directory. Wineshelllink should fall back to putting
.desktop files in the home directory if the Desktop directory does not
exist.
Is there a reason why we should not just create a Desktop dir
There seems to be two ways to do this, add the entries to wine.inf or
set the dll up as self registering. There are examples of both in wine
and the discussion seems to favour self registering but people still
seem to be adding registry entries to wine.inf. A bit of guidance would
be apprecia
Robert Shearman wrote:
Jeff L wrote:
I am looking at writing a piece of IDL and a header file I am
wrestling with how to do it without infringing copyright. IDL looks
particularly hard to write from first principles and is probably hard
to write in a different way as the functions being
I am looking at writing a piece of IDL and a header file I am wrestling
with how to do it without infringing copyright. IDL looks particularly
hard to write from first principles and is probably hard to write in a
different way as the functions being implemented are defined and require
IDL sim
[EMAIL PROTECTED] wrote:
> Microsoft
> appears to be pushing people away from NtClose.
I'd suggest you to find a reason why.
That particular documentation happens to be part of the API released
under court order. They didn't want to give it out to begin with, and
they don't want people using i
Eric Pouech wrote:
Jeff Latimer a écrit :
Establish the framework for testing NtCreateMailslotFile. Have fixed
issues with NTSTATUS return codes etc.
those tests belong to dlls/ntdll, not dlls/kernel32
also, if the test is for ntdll functions, it shouldn't use kernel32
ones... hence, NtClose
Dmitry Timoshkov wrote:
"Jeff L" <[EMAIL PROTECTED]> wrote:
To close the handle returned by an NT API you have you use an NT API
as well.
What is not apparent in the explanation above?
I have no problem with what you have said though I did have a bit of
difficulty marrying
Dmitry Timoshkov wrote:
"Jeff Latimer" <[EMAIL PROTECTED]> wrote:
+ok( CloseHandle(hslot), "CloseHandle failed\n");
To close the handle returned by an NT API you have you use an NT API
as well.
Have reread MSDN http://msdn2.microsoft.com/en-us/library/ms648410.aspx
and it seems that NtClos
Joris Huizer wrote:
git fetch; git rebase origin
Have you committed all updates before you git rebase origin? git commit
-a -m "all"; git rebase origin; git reset HEAD^
Jeff Latimer
This change came about when a friend described his problems in getting
wine going to see if it would help him with making a Windows app run
under Linux. He did not want to get into the details of wine as his was
a opportunistic need and his comment that hit home was "that many a
newbie expects
Vitaliy Margolen wrote:
Jeff Latimer wrote:
This is the first of some tests for NtCreateMailslotFile. I have
included them in kernel32/tests as I thought it better that the Mailslot
tests be collocated.
Why do you need to test NtCreateMailslotFile directly? Why can't you use
CreateMai
Can anyone point me the location of the code that implements the
IDropTarget class used by OLE2?
Jeff
* * wrote:
"If the device context is passed as NULL and Uniscribe needs to access
it for any reason, Uniscribe returns the error code E_PENDING. This
code is returned quickly, allowing the application to avoid
time-consuming SelectObject calls."
Whereas the current implementation will silently a
* * wrote:
According to MSDN, the "pending" error is to give the calling app a
chance to select the matching font back into the DC if the information
wasn't cached. I think that the get_script_cache function is broken,
in that it should return the pending error if the HDC isn't provided,
since
Dmitry Timoshkov wrote:
NtCreateMailslotFile is a public API, so probably it should handle the
case
when attr is NULL. I see the same problem at least in
NtCreateNamedPipeFile.
In general, handling of OBJECT_ATTRIBUTES in ntdll is not consistent, but
fixing it properly most likely a test is n
Jeff L wrote:
Dmitry Timoshkov wrote:
Yes, 'attr' is used without a NULL check earlier, but that's an actual
bug, and that's where the code needs to be fixed.
So in this case my change is ok for the tidy up that it is, it just
that there is another problem. Is this
Dmitry Timoshkov wrote:
"Jeff Latimer" <[EMAIL PROTECTED]> wrote:
Coverity Cid:344 highlighted a REVERSE-INULL. This patch removes the
redundant null tests as it is clear from the code above that the
pointer has already been used to dereference and can't be null.
Yes, 'attr' is used without
Rob, as the HandleTable was your suggestion, could you provide a comment
on whether these patches are a practical way forward?
Jeff Latimer
Jeff Latimer wrote:
These 2 patches implement HandleTables for tracking memory usage for
the SCRIPT_STRING_ANALYSIS pointer. The problem is that the ssa
Robert Shearman wrote:
although it sounds as though handle tables aren't really the way to go
for what you need.
I have the this working now. Ta. Table may be ok for the function.
Will submit a patch soon and see whether it is elegant enough as a way
forward.
Jeff Latimer
Robert Shearman wrote:
Yes, it does. You can look at dlls/ntdll/tests/rtl.c to see how the
functions can be used.
Looking at the tests as example it seems that you need to run
InitFunctionPtrs() to set up pointers to the functions. I would want to
do this in DllMain() as part of DLL_PROCESS_AT
Robert Shearman wrote:
Jeff L wrote:
Robert Shearman wrote:
Yes, it does. You can look at dlls/ntdll/tests/rtl.c to see how the
functions can be used.
Yep can see how that works now.
If I run out of handles, how do I reallocate the table or add to it?
You can't. It is intended
Robert Shearman wrote:
Jeff L wrote:
It seems that this would not be a unique problem in wine, is there a
standard way to handle memory tracking so that if memory is freed, at
a later time we can check to see if the pointer is still valid?
It sounds like you could benefit from using the
I am looking at how to track whether memory has been allocated or
freed. The SCRIPT_STRING_ANALYSIS opaque point in usp10 can be freed in
a number of places. It seems that Windows handles this by checking a
list of allocated storage as the passed value of a
SCRIPT_STRING_ANALYSIS could be inv
I am having trouble with getting todo_wine working. It seems to be
ignored and the test is being executed on wine and failing as expected.
Is there a trick to setting todo up?
According to all the examples and the text this should work:
todo_wine
{
ok(hr == S_OK, "Scr
How do you get a patch back that you have managed to remove completely
from your system with a
git reset HEAD^
git reset
git checkout patchname ?
git fetch does not seem to refresh the patch from the repository. I was
going fairly well with git then stuffed this up.
Jeff
When compiling dlls/gdi/tests/metafile.c on line 1357 I get a warning
C4013: "snprintf" is undefined. Looking around, it seems that snprinft
is in fact _snprintf in Visual C++. I have found a define
#if !defined(HAVE_SNPRINTF) && defined(HAVE__SNPRINTF)
#define snprintf _snprintf
People, I am working on ScriptStringXtoCP etc in usp10. In setting up
the tests for this I notice that ABC widths returned ScriptPlace (GetCharABCWidthsI)
is not the same as Windows does. Have tried an couple of fonts
and the results are the subtly different. Before I get too carried
away wi
This patch fixes a problem where a test fails in windows. It may also
fix a problem with 64 bit code but I am unable to test that. I does
this by declaring the HDC as global so it can be reused between test
runs in test_ScriptItemIzeShapePlace and test_ScriptGetCMap.
Change log:
Fix glyph compa
This patch fixes a problem where a test fails in windows. It may also
fix a problem with 64 bit code but I am unable to test that. I does
this by declaring the HDC as global so it can be reused between test
runs in test_ScriptItemIzeShapePlace and test_ScriptGetCMap.
Change log:
Fix glyph co
As part of implementing uniscribe, I am looking at breaking down strings
into their various unicode scripts (ie. numeric, arabic etc). The first
step is to identify the scripts in the string. The simple approach is
for me to code some ranges and check which script a character belongs
to. I a
This patch uses GetCharABCWidthsI to remove the need to pass chars from
ScriptShape to ScriptPlace in the scriptcache work space.
Change log:
Remove the need to pass chars from ScriptShape to ScriptPlace
Jeff Latimer
Index: dlls/usp10/usp10.c
I have started to get a floating point problem "First chance exception:
invalid float operation in 32-bit code (0x00e6b6f9).". I don't know a
lot about floating point but from what I have read, the FLDCW most
likely is unmasking an interrupt when it reloads the control word.
Winedbg does not
Is there anything wrong with this patch? It does not seem to have been
applied.
Jeff L
I need a bit of help with the correct way to do this. In usp10.c I need
to access GetGlyphIndicesW. Given that it is part of gdi32, I assume
that I will need to reference the function in the gdi32.dll rahter than
linking it into usp10.dll. What is the approved method of setting up
the access
I need a bit of help with the correct way to do this. In usp10.c I need
to access GetGlyphIndicesW. Given that it is part of gdi32, I assume
that I will need to reference the function in the gdi32.dll rahter than
linking it into usp10.dll. What is the approved method of setting up
the access?
44 matches
Mail list logo
