Re: wined3d: Use backup swapchain DC for devices created with desktop window. (try 2)

2012-11-14 Thread Jeff Cook
Hello Is there a status update on this patch? I am curious to know if it will be merged, and if not, what correction is needed to make it mergeable. Thanks Jeff On Mon, Sep 3, 2012 at 1:51 PM, Adam Jakubek wrote: > On Mon, Sep 3, 2012 at 6:29 PM, Stefan Dösinger > wrote: >> >> I skimmed bug #1

Re: Status on SetPixelFormat patch from May 2010

2011-12-31 Thread Jeff Cook
On Fri, Dec 30, 2011 at 11:43 PM, Henri Verbeet wrote: > On 30 December 2011 22:15, Chris Robinson wrote: >> years ago. I think a better fix would be for wined3d to use a dummy surface, >> or a renderless context (available with OpenGL 3.0), if it's asked to use the >> desktop window. >> > Yes, w

Status on SetPixelFormat patch from May 2010

2011-12-30 Thread Jeff Cook
Hello all I am curious about the patch on http://bugs.winehq.org/show_bug.cgi?id=18490 and why it's not in vanilla. http://bugs.winehq.org/show_bug.cgi?id=18490#c9 seems to be a pretty cogent explanation of the issue and the patch appears reasonable enough. It prevents a major crasher in Empire: T

LLVM compilation

2010-10-11 Thread Jeff Cook
Just wondering if anyone has experimented building WINE with LLVM instead of GCC. For those who haven't been following it closely, LLVM/Clang is fairly mature now and can now build some really mammoth projects. Has anyone experimented in building WINE with LLVM/Clang? If so, what results were gotte

Re: [PATCH] winealsa.drv: Count micelem in mixer chans, don't add spare capture input for half-duplex mics.

2010-10-11 Thread Jeff Cook
On Wed, Sep 1, 2010 at 9:40 AM, Alexandre Julliard wrote: > This statement wasn't exactly clear before, but now it's really > impossible to follow. Please rewrite this in a way that makes sense to a > casual reader. I have rewritten this in a more readable way and submitted the result to wine-pat

Re: DIB clarification

2010-08-29 Thread Jeff Cook
On Sun, Aug 29, 2010 at 7:12 PM, Jeremy White wrote: >> This could also help.  If I recall correctly, Jeremy White mentioned >> at Wineconf 2008 that this was a major reason they haven't invested >> serious energy into one themselves:  they had a hard time finding an >> application that they cared

DIB clarification

2010-08-29 Thread Jeff Cook
I hate to stir the pot, especially as an unknown in the community, but I've spent the last few hours reading WINE's history regarding DIB engines and it is pretty distressing. I have seen expressions of frustration from many regarding the handling of the mostly-functional DIB engine that Massimo w

Re: [PATCH 4/6] winealsa.drv: Append hw address to handle to prevent name collision. (resend)

2010-08-28 Thread Jeff Cook
On Tue, Aug 3, 2010 at 7:49 AM, Vitaliy Margolen wrote: >> +    memcpy(ww->ds_desc.szDesc, description, >> +            min( (sizeof(ww->ds_desc.szDesc) - 1), strlen(description)) >> ); > > This does not guarantee that ww->ds_desc.szDesc will be \0 terminated. > > Vitaliy. > What do you want me to

Re: [PATCH 5/6] winealsa.drv: Don't open the same card on every loop. (resend)

2010-08-28 Thread Jeff Cook
On Tue, Aug 3, 2010 at 3:57 AM, Alexandre Julliard wrote: > Jeff Cook writes: > >> @@ -753,7 +753,7 @@ static int ALSA_ScanDevices(int directhw, >>              char *pcmname = NULL; >>              snd_pcm_t *pcm; >> >> -            sprintf(defaultpcmname,

Re: Help with 6120d7cc145, causing bugs

2010-08-28 Thread Jeff Cook
Wylda reported success with the attached patch on bug 23902. Does it seem OK to everyone else? In this case, the extra channel needed for capture is not added when a micelem is found, because micelem should only be found when there is no other suitable playback or capture controls (i.e. "Mic" eleme

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

2010-08-28 Thread Jeff Cook
On Tue, Aug 17, 2010 at 3:00 AM, sudemon wrote: > On 03.08.2010 04:36, Jeff Cook wrote: >> >> What compiler are you running? It works fine for me and I don't see >> any errors or warnings. > > I also don't see any errors or warnings. > > Аfter 6120d7cc1

Help with 6120d7cc145, causing bugs

2010-08-24 Thread Jeff Cook
o it makes this harder. If you have the time, please review the patch and let me know what errors you notice that may be causing the aforementioned bug. I am new to Wine dev so please forgive anything really stupid. :) Thanks From Jeff. -- Jeff Cook (801) 231-3157 j...@deserettechnology.com

Re: Inviting Mono and pulseaudio to wineconf?

2010-08-24 Thread Jeff Cook
On Wed, Aug 25, 2010 at 12:10 AM, Roderick Colenbrander wrote: > I'm not against inviting Pulseaudio guys. Sure, Pulseaudio was added > to distributions way too early and there still are a lot of issues but > sound servers like pulseaudio are really the way to go for the future. > People want to b

Re: [PATCH 1/6] winealsa.drv: Init mixer on cards with a single Mic control, like snd_usb_audio mics (try 2)

2010-08-02 Thread Jeff Cook
What compiler are you running? It works fine for me and I don't see any errors or warnings. On Mon, Aug 2, 2010 at 6:05 AM, Alexandre Julliard wrote: > Jeff Cook writes: > >> @@ -245,6 +245,10 @@ static void fillcontrols(mixer *mmixer) >>      for (id = 0; i

[PATCH] winealsa.drv: Always scan devices, even if a default device exists.

2010-07-17 Thread Jeff Cook
Let me know what you guys think of this one, I think it will be somewhat controversial. There is a registry key to enable this currently, but it should really occur by default and maybe be unchangeable. If you have multiple cards, like a USB mic for capture, scan_devices to 0, as would occur on ma

If we can't open a device as stereo, try mono. This is necessary for snd-usb-audio mics.

2010-07-17 Thread Jeff Cook
--- dlls/winealsa.drv/waveinit.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/winealsa.drv/waveinit.c b/dlls/winealsa.drv/waveinit.c index 4da53c9..4ae93bb 100644 --- a/dlls/winealsa.drv/waveinit.c +++ b/dlls/winealsa.drv/waveinit.c @@ -106,6 +106,10 @@ static

Init mixer on cards with a single Mic control, like snd_usb_audio mics

2010-07-17 Thread Jeff Cook
This patch fixes bug #12706 and creates a mixer for snd-usb-audio cards, which have only a single Mic control and nothing else. Subsequent patches may be needed to make this useful depending on configuration. I am including this here for commentary before I submit to wine-patches. This is my f

Fwd: Possible patch for #12706

2010-06-25 Thread Jeff Cook
test it out and confirm, I would really appreciate that. Thanks to all in IRC who helped me get things this far, especially mlankhorst. This patch is based against the current git HEAD, eaa227c12d8bb. I've also posted it at the aforementioned bug. -- Jeff Cook (801) 231-3157 j...@deserett