FW: [Bug 25654] Anarchy Online 18.4.x unable to mouse-look or mouse-steer

2011-02-18 Thread Janne Hakonen
problem because of the > relative/absolute mouse position issue? It seems a lot of games each has its > own patch to support RawDeviceInput. > Hi, Could someone kindly comment to Llies's questions about raw mouse input? Thanks in advance, Janne Hakonen

Re: [PATCH 3/4] urlmon: Properly handle BINDSTATUS_BEGINDOWNLOADDATA.

2011-02-15 Thread Janne Hakonen
verification, emulate prot)... protocol.c:3535: Testing file binding (use IUri, impl StartEx, mime verification, emulate prot)... protocol.c:3537: Testing file binding (impl StartEx, mime verification, emulate prot)... protocol: 5135 tests executed (0 marked as todo, 0 failures), 0 skipped. Best Regards, Janne Hakonen

Re: comctl32/tests: Add two casts to avoid comparisons of differentint types.

2011-02-13 Thread Janne Hakonen
is a 64 bit pointer and right side is 32 bit value. Best Regards, Janne Hakonen

Re: iphlpapi: Hint what to do when icmp does not work

2011-02-11 Thread Janne Hakonen
Maybe this information could be added to http://wiki.winehq.org/FAQ instead? Janne -Original Message- From: Charles Davis Sent: Friday, February 11, 2011 8:17 PM To: wine-devel@winehq.org Subject: Re: iphlpapi: Hint what to do when icmp does not work On 2/11/11 11:12 AM, André Hentsch

Re: iphlpapi: Changed return value of NotifyAddrChange() stub and added test cases. (try 2)

2011-02-08 Thread Janne Hakonen
This test is safe, but it depends on the caller setting handle to some value other than INVALID_HANDLE_VALUE. I think it might be safer to have NotifyAddrChange set the handle value instead, and to mark the test todo_wine. I'm worried that some other app might assume that the call to NotifyAddrC

RE: iphlpapi: Changed return value of NotifyAddrChange() stub and added test cases.

2011-02-07 Thread Janne Hakonen
st like it was, then someone might wonder why it is still in the list even though it used in the tests with NotifyAddrChange. Best Regards, Janne Hakonen

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-02-04 Thread Janne Hakonen
> You can't use exception handlers in tests I'm not sure why not, but I'll take you word of this. Without exception handling the test cases for RtlCaptureStackBackTrace would also always crash on Win 2000/NT so that makes all of the tests useless, I think. Well, at least I learned how to (/ n

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-02-03 Thread Janne Hakonen
Ah, I see you had already corrected the stack overflowing, and found better way even. :) I tested the correction with the test cases and they passed. I also tried AwesomiumGL and I couldn't get it to crash, so looks to me that this bug is fixed. The test cases at http://source.winehq.org/pat

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-02-01 Thread Janne Hakonen
> > It doesn't need a try-except block, just better wrap-around handling. > Ah, you mean to enhance the if-check? Well..., to me it seems that there is a problem with the 2nd check: "(void *)(frame + 1) >= NtCurrentTeb()->Tib.StackBase" If frame is 0x or close to it (e.g.

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-01-31 Thread Janne Hakonen
Hi Alexandre Julliard, I see you had another idea of how to correct the RtlCaptureStackBackTrace() function. I tested your implementation with Anarchy Online's item store (ingame web browser based on Awesomium) and with AwesomiumGL (sample app from Awesomium's SDK). With AwesomiumGL I did

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-01-30 Thread Janne Hakonen
> > If I need to make changes to, say, test cases, should I also send bug fix > > patch again even if there is no changes to that? > > Please. If it is two separate patches, be sure to make it a series > (label them 1/2, 2/2) and that the tests pass before/after each patch. > Ok, thanks for the

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-01-30 Thread Janne Hakonen
> Did you try this on WindowsXP or Windows7 to make sure that the win_skip did not function on those platforms? My understanding is that win_skip works on all Windows platforms not just WindowsNT or Windows2000. Well, I did test that skip doesn't happen on my home computer, whic

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-01-28 Thread Janne Hakonen
> Now, when I ran these tests on Testbot using all base VMs, the tests were run > also on W2KPROSP4 and WNT4WSSP6. However, the > function seems to buggy in those. It throws access violation whenever it is > not skipping frames. > Is there some way I could prevent/skip these tests to be run on

RE: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-01-27 Thread Janne Hakonen
on line 92 crashed the test. In other VMs the tests succeeded and none crashed. Is there some way I could prevent/skip these tests to be run on Windows NT4 and 2000? Best Regards, Janne Hakonen

Re: Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-01-23 Thread Janne Hakonen
f through winebot before posting and verify that it passes on all flavors of windows. Ok, I will try it out when I have fixed the test case. Thanks, Janne Hakonen

Correction to crash inside RtlCaptureStackBackTrace() + test case

2011-01-23 Thread Janne Hakonen
Awesomium’s SDK. The crash (among other problems) is reported to bugzilla at: http://bugs.winehq.org/show_bug.cgi?id=25206. Best Regards, Janne Hakonen diff --git a/dlls/ntdll/signal_i386.c b/dlls/ntdll/signal_i386.c index aff4509..e80a0af 100644 --- a/dlls/ntdll/signal_i386.c +++ b/dlls/ntdll