I recommend writing unit tests to answer the open questions.
Thanks,
James
On Sat, Sep 24, 2011 at 2:46 PM, Gerald Pfeifer wrote:
> Hi James,
>
> On Thu, 13 May 2010, Gerald Pfeifer wrote:
>> Would you feel more comfortable leaving the documentation as is and
>> me just suggesting the following?
I'm very hesitant about this. MSDN has no documentation about
RegisterOCX, so I'm not sure how you're justifying this change. It's
been a long time since I worked on this, so I don't remember much, but
I do remember testing this method and documenting the parameters
correctly. Where are you gett
RunMode);
> + FIXME("unimplemented run mode\n");
> r = TRUE;
> }
>
It's nice to see which run mode we're not handling by quickly looking
at the FIXME. Any reason you removed this? Keep in mind most general
user logs won't have +msi logging, if any.
--
James Hawkins
ent install state */
>>> comp->Action = comp->Installed;
>>
>> Where do you see that crash? Are you sure ERROR_INSTALL_FAILURE is
>> appropriate?
>>
>> -Hans
> thought twice(and digging into the code some more), maybe returning a success
> is a better idea.
>
And writing a test to determine the correct behavior is an even better idea.
--
James Hawkins
On Mon, Jan 18, 2010 at 4:09 AM, Hans Leidekker wrote:
> ---
> dlls/msi/join.c | 7 +--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
Tests please?
Thanks,
James
es in the source already.
wchar* unicode_str; or
LPWSTR unicode_str;
TRACE("%s\n", debugstr_w(unicode_str));
--
James Hawkins
On Sun, Jan 10, 2010 at 12:57 PM, Paul Vriens
wrote:
> On 01/05/2010 11:50 AM, Paul Vriens wrote:
>>
>> On 01/05/2010 02:46 AM, James Hawkins wrote:
>>>
>>> ---
>>> dlls/advpack/tests/advpack.c | 7 +--
>>> 1 files changed, 1 insertions(+), 6
> Also if anyone can shed more light on the current idea behind the code, this
> would be welcome!
>
> Thanks a lot in advance,
> Julius
>
Write and submit tests that show the correct behavior, then submit a
patch that makes Wine match that behavior. In general, questions like
"What's the right fix?" can be answered by thorough, well-thought out
tests.
--
James Hawkins
On Fri, Jan 8, 2010 at 11:28 AM, Alexandre Julliard wrote:
> The Wine development release 1.1.36 is now available.
>
> What's new in this release (see below for details):
> - Completion of the 16-bit separation.
Congrats Alexandre and co.!
--
James Hawkins
x27;t show up in the logs after he adds the suppression.
Thanks,
James Hawkins
codeEx(
> DWORD dwFlag,
> WCHAR* lpFallBack)
> {
> - FIXME("\n");
> + if (dwFlag || (lpFallBack != NULL))
> + FIXME("Ignoring dwFlag (0x%x/%d) and lpFallBack (%p)\n",
> + dwFlag, dwFlag, lpFallBack);
> +
if (dwFlag || lpFallBack)
seems to be simpler and easier to read.
--
James Hawkins
On Tue, Jan 5, 2010 at 9:11 AM, Nate Gallaher wrote:
> James Hawkins wrote:
>>
>> On Mon, Jan 4, 2010 at 7:05 AM, Nate Gallaher
>> wrote:
>>
>>>
>>> James Hawkins wrote:
>>>
>>>>
>>>> On Sat, Jan 2, 2010 at 10:36 AM,
On Mon, Jan 4, 2010 at 7:05 AM, Nate Gallaher wrote:
> James Hawkins wrote:
>>
>> On Sat, Jan 2, 2010 at 10:36 AM, Nathan Gallaher
>> wrote:
>>
>>>
>>>
>>
>>
>> +struct cond_mem {
>> + struct list entry;
>> + vo
p\n", ptr);
+}
This won't fly. cond_free needs to be an O(1) operation, like your
original patch.
--
James Hawkins
On Tue, Dec 22, 2009 at 1:10 PM, Nathan Gallaher
wrote:
> Seeing if there was anything I can do to help either of these patches move
> along. Don't want them to get lost.
>
I have a modified patch that I'll submit by the end of the day.
Thanks,
James Hawkins
On Thu, Dec 17, 2009 at 1:25 PM, Jason Green wrote:
> We both work for TransGaming, and these patches are officially from the
> company.
>
Ok, thanks for the info!
On Thu, Dec 17, 2009 at 1:19 PM, Jason Green wrote:
> Sorry, should have copied Eric van Beurden on this earlier. His name & email
> are in the patch on the From: line.
>
To clarify my question, are you guys working at a company that is
contributing to Wine, or are you contributing for fun, etc
to WineHQ."
>
I'm just curious. Who is we?
Thanks,
James Hawkins
e);
I believe the construct you're looking for is LIST_FOR_EACH_SAFE.
grep through the code for examples on using that to safely free and
remove elements from a list.
--
James Hawkins
What if FAILED
were defined as:
FAILED(x) (x & MASK1) | (x & MASK2)
?
--
James Hawkins
On Thu, Dec 10, 2009 at 2:28 AM, Dan Kegel wrote:
> On Wed, Dec 9, 2009 at 9:51 PM, James Hawkins wrote:
>> I was wondering why you were getting so many msi test failures and
>> errors! Now I know. Yes, the msi tests can't be run in parallel,
>> even on windows.
>
On Wed, Dec 9, 2009 at 9:51 PM, James Hawkins wrote:
> On Wed, Dec 9, 2009 at 9:01 PM, Dan Kegel wrote:
>> On Sat, Dec 5, 2009 at 7:39 AM, Dan Kegel wrote:
>>> With those changes, I now see 457 non-leak errors,
>>> (~134 of which are due to the fresh regression
uld do the trick...
> - Dan
>
I was wondering why you were getting so many msi test failures and
errors! Now I know. Yes, the msi tests can't be run in parallel,
even on windows. Vincent stated that he thinks the
StorageImpl_Construct bug is fixed, yet I'm still seeing the errors.
Vincent, can you take a look at the results?
Thanks,
James Hawkins
ll into
ExtractFilesA, with an appropriate comment as to why this is
happening.
--
James Hawkins
; {HOME}, followed by {SHIFT}{END}), it's interesting that the script
> allows us to find such subtle bugs.
>
Good catch! Hopefully the scripts will find many more bugs like this,
as well as keep Wine from regressing.
--
James Hawkins
On Sun, May 3, 2009 at 1:52 PM, Mike Kaplinskiy
wrote:
> On Thu, Apr 30, 2009 at 1:08 PM, James Hawkins wrote:
>> On Thu, Apr 30, 2009 at 4:03 AM, Austin English
>> wrote:
>>> On Tue, Apr 28, 2009 at 9:27 PM, Mike Kaplinskiy
>>> wrote:
>>>> I w
;re right or wrong ;-).
>
Not really. If you grep through the msi tests, you'll see that we
call MsiViewExecute with NULL hRec all over the place. That doesn't
mean there isn't a bug, just saying.
--
James Hawkins
On Wed, Apr 22, 2009 at 12:44 PM, Nicolas Le Cam wrote:
> 2009/4/22 James Hawkins :
>> On Wed, Apr 22, 2009 at 12:05 PM, Nicolas Le Cam
>> wrote:
>>> Try2: Use helper function added in second patch, as suggested by James.
>>>
>>> This one finally
go over
your patches before submitting them. Your subject says try2, but I
know it's been more than that, so we've seen at least 12-16
emails/patches for this set now.
--
James Hawkins
On Tue, Apr 21, 2009 at 2:51 PM, Nicolas Le Cam wrote:
> 2009/4/21 James Hawkins :
>> On Tue, Apr 21, 2009 at 2:30 PM, Nicolas Le Cam wrote:
>>> This one finally fixes current relative path test to expect correct
>>> value.
>>>
>>
>> + drives
_FILE_ATTRIBUTES && (attr &
FILE_ATTRIBUTE_DIRECTORY))
+{
+if (path[lstrlenA(path)-1] != '\\')
+lstrcatA(path, "\\");
+break;
+}
+path[3] = '\0';
+}
Same as 2/4. Please refactor and add many nice comments detailing
exactly what is happening in native msi to make this necessary.
--
James Hawkins
i;
+
+if (GetDriveType(path) == DRIVE_FIXED)
+break;
+}
+path[0] = '\0';
+}
Please refactor this into a helper function. A comment describing
exactly what is being tested and why this bit of code is needed would
be beneficial.
--
James Hawkins
On Wed, Apr 15, 2009 at 5:21 PM, Nicolas Le Cam wrote:
> 2009/4/16 James Hawkins :
>> On Wed, Apr 15, 2009 at 4:34 PM, Nicolas Le Cam wrote:
>>> While trying to solve ACTION_AppSearchDr problem revealed by my previous
>>> patch, I discovered that MSI_RecordGetStr
.
>
> Tested on WinXP and Wine.
>
This patch has 39 lines of test code without a single empty line.
Unit tests test one thing at a time and should be well documented and
easy to read.
--
James Hawkins
On Fri, Apr 10, 2009 at 2:36 PM, Nicolas Le Cam wrote:
> 2009/4/10, James Hawkins :
>> On Fri, Apr 10, 2009 at 6:15 AM, Nicolas Le Cam
>> wrote:
>>> Try2: This time with the patch.
>>>
>>> Tested on Win2k/WinXP. Marked two tests as todo_wine.
>>>
On Fri, Apr 10, 2009 at 6:15 AM, Nicolas Le Cam wrote:
> Try2: This time with the patch.
>
> Tested on Win2k/WinXP. Marked two tests as todo_wine.
>
I was serious before. You can't change the old tests. Please add new
tests for the exposed bugs. Same goes for patch 3/4.
--
James Hawkins
andle another case
(running on root drive directory). Adding more tests to reveal an
existing problem is fine.
--
James Hawkins
7;t remember the last
>>estimate we had of how much work it would take, but it's on the order
>>of tens of thousands of dollars. That's assuming it's not impossible
>>to get the ipod touch/iphone driver working in Wine.
>
>>--
>>James Hawkins
>
of thousands of dollars. That's assuming it's not impossible
to get the ipod touch/iphone driver working in Wine.
--
James Hawkins
Thanks Francois (I asked on IRC a while back). I get these dialogs in
2k3 as well. Do you think we should add a check for
winetest_interactive before the calls that bring up the permission
dialog? If anyone else knows of a better way, let us know.
--
James Hawkins
On Wed, Mar 25, 2009 at 1:09 PM, Paul Vriens wrote:
> On Mar 25, 2009, at 20:44, James Hawkins wrote:
>
>> On Wed, Mar 25, 2009 at 11:50 AM, Paul Vriens
>> wrote:
>>>
>>> James Hawkins wrote:
>>>>
>>>> On Wed, Mar 25, 2
On Wed, Mar 25, 2009 at 11:50 AM, Paul Vriens
wrote:
> James Hawkins wrote:
>>
>> On Wed, Mar 25, 2009 at 8:25 AM, Paul Vriens
>> wrote:
>>>
>>> Hi,
>>>
>>> This fixes bug 17843 but I'm not sure it's a 100% correct. James did
On Wed, Mar 25, 2009 at 11:15 AM, James Hawkins wrote:
> On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins wrote:
>> On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins wrote:
>>> On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart wrote:
>>>>
>>>> fixes bug
orary );
>
> returns a row of 0
>
> then under the temporary case we do
> idx -= tv->table->row_count
>
> which is generating an idx of less than 0;
>
>
> It looks like a wine bug. I can look into writing a test.
>
Thanks! I appreciate it.
--
James Hawkins
On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins wrote:
> On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins wrote:
>> On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart wrote:
>>>
>>> fixes bug Bug 17600
>>> ---
>>> dlls/msi/table.c | 3 ++-
>&
On Wed, Mar 25, 2009 at 11:14 AM, James Hawkins wrote:
> On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart wrote:
>>
>> fixes bug Bug 17600
>> ---
>> dlls/msi/table.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>
> Please add a t
ing in a negative index, then
there's a bug somewhere else.
--
James Hawkins
hout your patch and succeeds with your patch.
--
James Hawkins
On Tue, Mar 24, 2009 at 3:50 PM, Alexandre Julliard wrote:
> James Hawkins writes:
>
>>> This cannot be right. What happens to the original first_section then?
>>>
>>
>> I don't really understand your question. By original first_section,
>> do yo
On Tue, Mar 24, 2009 at 3:42 AM, Alexandre Julliard wrote:
> James Hawkins writes:
>
>> ---
>> dlls/kernel32/profile.c | 2 +-
>> dlls/kernel32/tests/profile.c | 30 ++
>> 2 files changed, 7 insertions(+), 25 deletions(-)
&g
tation, which
> has been refered as not reliable :D
>
Please bottom-post on this mailing list. My patch is correct except
for what I said earlier, so just take it, remove that bit and resubmit
it.
--
James Hawkins
hat the patch does, but I did mistakenly leave an extra
copy of requiredSize > params->PathBufferSize in the top if statement.
Feel free to send a correct patch.
--
James Hawkins
On Sun, Mar 22, 2009 at 2:57 PM, Henri Verbeet wrote:
> 2009/3/22 James Hawkins :
>> ---
>> dlls/wined3d/vertexshader.c | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
> I guess the nicer way to make Coverity shut up would be to replace
> &q
On Sat, Mar 7, 2009 at 8:14 PM, Jeff Latimer wrote:
> James Hawkins wrote:
>>
>> On Sat, Mar 7, 2009 at 5:56 PM, Jeff Latimer wrote:
>>
>>>
>>> Note that Inet_Ntop is only available in Vista and Windows 2008. Hence
>>> the
>>> testing of
On Sat, Mar 7, 2009 at 5:56 PM, Jeff Latimer wrote:
> Note that Inet_Ntop is only available in Vista and Windows 2008. Hence the
> testing of version to avoid breaking the test suite on earlier OS's.
>
Checking the windows version is not allowed in the tests.
--
James Hawkins
>>
>>
>> configure | 9
>> configure.ac | 1 +
>>
>
> I thought we're suppose to add them.
>
> http://source.winehq.org/git/wine.git/?a=history;f=configure
>
No, Julliard generates them for you and adds them in your name.
--
James Hawkins
On Fri, Feb 20, 2009 at 9:56 AM, Aric Stewart wrote:
> Ok i am following you but.
>
> James Hawkins wrote:
>>
>> On Fri, Feb 20, 2009 at 4:45 AM, Aric Stewart
>> wrote:
>>>
>>> Hello,
>
> .
> .
> .
>>
>> No, I think the patc
hould not be needed. Am I right there?
>
No, I think the patch is wrong in that if you remove the original
media and the stored cabs, the install will fail.
--
James Hawkins
On Thu, Feb 19, 2009 at 11:30 PM, Hans Leidekker wrote:
> On Thursday 19 February 2009 22:36:25 James Hawkins wrote:
>
>> > I don't see how it would hurt if we do match the sort order on Windows,
>> > even if we achieve it by other means.
>> >
>>
>&g
iding all of the rest of the bugs.
I'm not sure if you got the email I sent Jer about this problem, but
the real bug is that we aren't handling the REINSTALL variable
correctly (or REINSTALLMODE for that matter.) Can you please describe
the exact case for why this patch is needed?
--
James Hawkins
On Thu, Feb 19, 2009 at 4:14 PM, Detlef Riekenberg wrote:
>
> James: A fixed path is broken by design.
>
A "Thanks for spending weeks of your time laboriously testing and
implementing fusion" would have sufficed.
--
James Hawkins
h the sort order on Windows,
> even if we achieve it by other means.
>
The reason it hurts in this case is because the sorting happens at the
File/Directory API level and not in fusion itself. If the same logic
applies, why don't we match sorting at that level in Wine?
--
James Hawkins
The fix is to check for all N results N times, where N is the number
of assemblies enumerated.
--
James Hawkins
On Fri, Feb 13, 2009 at 12:43 AM, Hans Leidekker wrote:
> On Friday 13 February 2009 09:31:54 James Hawkins wrote:
>
>> It would be a lot easier if you just took over my patches that
>> implement this properly:
>
> Hmm, I missed those. I'll integrate them with mine.
>
Thanks!
--
James Hawkins
On Fri, Feb 13, 2009 at 12:34 AM, Hans Leidekker wrote:
> On Friday 13 February 2009 09:22:31 James Hawkins wrote:
>
>> > Office 2007 SP1 installer depends on this.
>>
>> Please write a test case.
>
> Sure. Note that it's documented here http://support.micro
Fix how? Both cases should be accepted...
--
James Hawkins
2009/2/13 Hans Leidekker :
>
> diff --git a/dlls/msi/action.c b/dlls/msi/action.c
> index fd38f7a..38d2484 100644
> --- a/dlls/msi/action.c
> +++ b/dlls/msi/action.c
> @@ -5870,11 +5870,11 @@ static UINT parse_assem
ordering (or lack-thereof) into account.
http://winehq.org/pipermail/wine-devel/2009-January/071727.html
--
James Hawkins
On Fri, Feb 13, 2009 at 12:14 AM, Hans Leidekker wrote:
>
> diff --git a/dlls/fusion/asmcache.c b/dlls/fusion/asmcache.c
> index 73756b3..2ce1995 100644
> --- a
This definitely needs a test.
--
James Hawkins
On Fri, Feb 13, 2009 at 12:14 AM, Hans Leidekker wrote:
>
> diff --git a/dlls/fusion/asmname.c b/dlls/fusion/asmname.c
> index acf0411..ebf76af 100644
> --- a/dlls/fusion/asmname.c
> +++ b/dlls/fusion/asmname.c
> @@ -45,7 +45,7
On Fri, Feb 13, 2009 at 12:12 AM, Hans Leidekker wrote:
>
> Office 2007 SP1 installer depends on this.
>
Please write a test case.
--
James Hawkins
On Wed, Feb 11, 2009 at 3:27 PM, Alexandre Julliard wrote:
> James Hawkins writes:
>
>> We should leave the failing files percentage up (note the name change)
>> and add a failing tests percentage next to it. The failing tests
>> percentage should be total_test_fa
reflected somewhere at
> a quick glance. Thoughts?
>
We should leave the failing files percentage up (note the name change)
and add a failing tests percentage next to it. The failing tests
percentage should be total_test_failures / total_tests_run.
--
James Hawkins
the app doesn't work as expected and
Wine should be fixed. Adding a global exception handler doesn't fix
anything and will more than likely break a handful of apps.
--
James Hawkins
On Wed, Jan 28, 2009 at 3:12 PM, Dan Kegel wrote:
> On Wed, Jan 28, 2009 at 12:14 PM, James Hawkins wrote:
>>> http://test.winehq.org/data/8f829034f3fe4da3e7adce2f4685e10ba2e2fe82/xp_fg-winxp-ie7/msi:msi.html
>>> says
>>> dlls/msi/tests/msi.c
>>> m
; Say, can winetest retrieve and display the msi log file on failure? That
> might be informative...
>
It wouldn't be useful. There error is ERROR_INSTALL_ALREADY_RUNNING
because the test before msi.c timed out (but is still running).
--
James Hawkins
KDIR;
> +
> +retval = SHFileOperationA(&shfo);
> +ok(retval == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", retval);
> +ok(DeleteFileA("abcdefghi.abc"), "Expected file to exist\n");
> +ok(DeleteFileA("one\\abcdefghi.abc"), "Expected file to exist\n");
> +ok(RemoveDirectoryA("one"), "Expected dir to exist\n");
> }
>
> /* tests the FO_MOVE action */
> --
> 1.5.6.5
>
>
>
>
>
>
--
James Hawkins
erent platforms, then do
like we do for other tests and add them to the check.
--
James Hawkins
On Thu, Jan 15, 2009 at 12:48 PM, Austin English
wrote:
> RTF_MULTICAST isn't available on NetBSD/OpenBSD (possibly others)
>
> Changelog:
> Moved to a #define 0 at the top of the file to get rid of ugly ifdef's
>
Forgot the patch.
--
James Hawkins
%w2k8= (name => "2008");
> +my %w7 = (name => "7");
> my %unknown = (name => "Other");
> my %wine= (name => "Wine");
>
I'm behind on my emails this weekend, so I don't know if this has been
committed yet or not, but it seems like win7 is a better name than w7.
--
James Hawkins
too so it's on
> standby...
>
There is no way to test the setting of environment variables by msi.
You can't query the changed environment variable until the process
exits. Using a child process doesn't help either.
--
James Hawkins
On Tue, Jan 6, 2009 at 7:04 PM, Austin English wrote:
> Adds a note discouraging use of UNIX paths, since there's seems to
> have been a rash of it in recent bug reports.
>
If we don't recommend it, and usually advise against it, why not just
remove that line from the README?
--
James Hawkins
'%','0','2','x',0 };
>
> - pUuidCreate = GetProcAddress(lib,
> "UuidCreate");
> +pUuidCreate = (void *)GetProcAddress(lib,
> "UuidCreate");
> rs = pUuidCreate(&uuid);
> if (rs == S_OK)
> {
Inadvertent change?
--
James Hawkins
. These "wars" between open source licenses make me sick.
>
http://winehq.org/pipermail/wine-devel/2008-December/071145.html
--
James Hawkins
On Fri, Jan 2, 2009 at 4:30 PM, Vincent Povirk wrote:
> This makes it possible to get feedback when something goes wrong starting a
> non-exe file through a Linux gui.
>
Forgot the patch.
--
James Hawkins
On Thu, Dec 18, 2008 at 3:07 PM, Michael Ost wrote:
> Michael Karcher wrote:
>>
>> Am Donnerstag, den 18.12.2008, 14:53 -0800 schrieb James Hawkins:
>>>
>>> I don't understand the problem. If you have the proper permissions,
>>> wine should be abl
On Thu, Dec 18, 2008 at 2:47 PM, Michael Ost wrote:
> James Hawkins wrote:
>>
>> On Thu, Dec 18, 2008 at 12:31 PM, Michael Ost
>> wrote:
>>>
>>> wine-devel-requ...@winehq.org wrote:
>>>>
>>>> Date: Tue, 16 Dec 2008 13:52:00 +0100 F
tring is
internal, so we should probably crash if str is NULL instead of hiding
the error. What is this patch for?
--
James Hawkins
looking for a CD of a
> certain label. I can't fudge in the label because it's a CD that I can't
> write to.
>
> Is anyone working on this issue, or agree/disagree? ... mo
>
The label of the CD is read from the disk. If you're using a mounted
ISO, you have to fix the access rights of the loopback file
representing the ISO file.
--
James Hawkins
aps one of you has an idea where this might come from and how to
> avoid it?
>
You can use git offline to do a regression test. Might give you some
better clues.
--
James Hawkins
ately, this
patch cannot be committed and you won't be able to submit patches for
the imm32 module anymore.
--
James Hawkins
ith
tests and to keep it from regressing.
--
James Hawkins
On Tue, Dec 16, 2008 at 9:11 AM, Aric Stewart wrote:
> ---
> dlls/msi/record.c |7 ---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
Can you add tests for this please?
Thanks,
James Hawkins
On Mon, Dec 15, 2008 at 3:36 PM, Henri Verbeet wrote:
> 2008/12/15 James Hawkins :
>> Why would you remove any of them? That's like removing stub functions
>> because we don't know if they're ever called.
>>
> Although it probably doesn't make sens
emented. The APIs that provide access to
the objects are stubs as well, which is why you're saying they're not
being used.
> AssemblyCacheItemVtbl fusion/asmcache.c
> AssemblyEnumVtblfusion/asmcache.c
--
James Hawkins
letely as this is hit if the row already exists in the db
(common). Please don't send in a patch for that change, as I'm
waiting till I write an exhaustive set of tests for transforms before
removing the message.
--
James Hawkins
On Wed, Dec 10, 2008 at 8:49 AM, Paul Vriens <[EMAIL PROTECTED]> wrote:
> James Hawkins wrote:
>>
>> ---
>> dlls/msi/tests/package.c | 232
>> ++
>> 1 files
r = pMsiEnumPatchesExA("", usersid, MSIINSTALLCONTEXT_USERUNMANAGED,
MSIPATCHSTATE_ALL, 0, patchcode,
targetprod, &context,
targetsid, &size);
Please align the extra parameter lines with the extra character in the
first line.
--
James Hawkins
can call
> SHAppBarMessage to see how I should report this to the app. But how do
> I get a windows machine without a taskbar?
>
In, at least, the wine community, we have images of most known
versions of windows. And like you said, you can also figure out how
to replace the shell as an alternative.
--
James Hawkins
);
}
Extraneous change.
--
James Hawkins
x compiler bugs,
> and there are several compiler specific bugs in bugzilla, but no easy
> way to group/search them.
>
Do we really need to be that specific? In other words, what does a
compiler keyword add that the build-env component doesn't cover?
--
James Hawkins
On Fri, Nov 21, 2008 at 4:54 PM, Krzysztof Drewniak
<[EMAIL PROTECTED]> wrote:
> What header is
>
> LPD3DXMESH supposed to be declared in?
>
http://letmegooglethatforyou.com/?q=LPD3DXMESH
--
James Hawkins
1 - 100 of 1350 matches
Mail list logo
