Re: [PATCH 1/2] ntdll: Implement NtQuerySystemInformation class 0x37

2013-07-29 Thread James Eder
On Mon, Jul 29, 2013 at 5:29 PM, Chris Moeller wrote: > > You should add a FIXME() for the SystemNumaHighestNodeNumber case since you are not implementing the full behavior. QEMU may be able to emulate NUMA so that may be worth a look (although the man page sucks on the topic). It's been a whi

Re: [PATCH] kernel32: Actually return a PERFORMANCE_INFORMATION structure in K32GetPerformanceInfo (try 2)

2013-04-24 Thread James Eder
On Wed, Apr 24, 2013 at 6:58 AM, Christian Costa wrote: > Hi James, > > That would be better to change the trace at the beginning by FIXME( "(%p, > %d): semi-stub\n", info, size ); or FIXME( "(%p, %d): partial stub\n", > info, size ); > instead of adding another fixme (which is not really correct

Re: user32: add assembly wrapper for calling hook procedures.

2013-04-22 Thread James Eder
Dan, the patch doesn't build for 64-bit Wine. On the #else side you have an unwanted semicolon. -- Jim

Re: Fun with GCC 4.8

2013-04-18 Thread James Eder
On Mon, Apr 15, 2013 at 3:58 PM, Marcus Meissner wrote: > On Mon, Apr 15, 2013 at 02:37:27PM -0600, James Eder wrote: > > As many of you no doubt know, GCC recently released 4.8.0. This new > > version introduces a new optimization level enabled by -Og with the > > follow

Fun with GCC 4.8

2013-04-15 Thread James Eder
As many of you no doubt know, GCC recently released 4.8.0. This new version introduces a new optimization level enabled by -Og with the following description (from the man page): "Optimize debugging experience. -Og enables optimizations that do not interfere with debugging. It should be the opti

Re: dplayx: Reorder some code to avoid memory leaks (coverity)

2012-10-29 Thread James Eder
On Mon, Oct 29, 2012 at 2:20 AM, Rico Schüller wrote: > On 28.10.2012 16:13, André Hentschel wrote: >> >> - lpGData->lpRemoteData = lpNewData; >> + lpGData->lpRemoteData = HeapAlloc( GetProcessHeap(), >> HEAP_ZERO_MEMORY, sizeof( dwDataSize ) ); >> + CopyMemory( lpGData->lpRemot

Re: [PATCH 6/8] ntdll: Standardize on sysconf to detect the number of processors for all platforms.

2012-10-22 Thread James Eder
> Have you verified that this works correctly on all the platforms you are > changing? > > -- > Alexandre Julliard > julli...@winehq.org Having another look, some of the BSDs are lacking or gained support only somewhat recently. I had thought the BSDs weren't so different. For Apple we need 10.4

Re: [PATCH 5/8] ntdll: Add detection for PF_SSE_DAZ_MODE_AVAILABLE

2012-10-21 Thread James Eder
Hmmm... the GCC docs say: http://gcc.gnu.org/onlinedocs/gcc-4.7.2/gcc/Type-Attributes.html#Type-Attributes "Note that the alignment of any given struct or union type is required by the ISO C standard to be at least a perfect multiple of the lowest common multiple of the alignments of all of the m

Re: [PATCH 5/8] ntdll: Add detection for PF_SSE_DAZ_MODE_AVAILABLE

2012-10-21 Thread James Eder
Gah... hit the wrong reply button so here we go again for some. On Sun, Oct 21, 2012 at 10:06 AM, Joris Huizer wrote: > On 10/21/2012 05:49 PM, James Eder wrote: >> >> On Sat, Oct 20, 2012 at 7:06 PM, Chris Robinson >> wrote: >>> >>> O

Re: [PATCH 5/8] ntdll: Add detection for PF_SSE_DAZ_MODE_AVAILABLE

2012-10-21 Thread James Eder
On Sat, Oct 20, 2012 at 7:06 PM, Chris Robinson wrote: > On 10/20/2012 05:40 PM, James Eder wrote: >> >> +/* Intel says we need a zeroed 16-byte aligned buffer */ >> +char buffer[512 + 16]; >> +XMM_SAVE_AREA32 *state = (XMM_SAVE_AREA32 *)(((ULON

ntdll feature detection patch set

2012-10-20 Thread James Eder
I've been kicking this patch set around in my local git tree for a while and I want to get it out there for comments and maybe even inclusion in Wine. Seeing some comments in another thread about wineboot made me think I should get these patches out rather than holding onto them much longer. I fe

Re: [PATCH 5/5] ntdll: Add more complete implementation of NtPowerInformation

2012-09-11 Thread James Eder
On Mon, Sep 10, 2012 at 11:16 PM, Ken Thomases wrote: > First, there are some compiler warnings: Fixed > Then, you are off by an order of magnitude. You're dividing by 10 million > rather than 1 million to go from Hz to MHz. and fixed > I would say you should probably remove that semi-stub warni

Re: [PATCH 5/5] ntdll: Add more complete implementation of NtPowerInformation

2012-09-10 Thread James Eder
I've sent a patch set that I need some help testing. The first four in the series should be fine as they don't change anything specific to a particular platform. The last one however makes some changes which are platform specific (affects Linux, Apple, and various BSDs). I've tested the Linux co

Re: http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono

2012-06-05 Thread James Eder
>> >> You obviously have absolutely no idea what the wine-mono package is for. >> You should read up and apologize. >> >> > NO APOLOGY!  You are missing the point. > You are missing the point. You're argument lacks weight because you clearly have no idea what you're talking about. One cannot bas

Re: Wine in Humble Indie Bundle

2012-06-04 Thread James Eder
On Sun, Jun 3, 2012 at 6:16 PM, Jerome Leclanche wrote: > This comes up in one form or the other very often, though, doesn't it? > Company x releases software y with a Wine wrapper advertising "native linux > support" and users get upset. Personally, I'm glad they're thinking about > Linux and I t

Re: [appdb] Applications working flawlessly using patched wine should be rated Gold

2012-05-18 Thread James Eder
IMO, AppDB should gather enough information form the user to assign the rating automatically. For example, answering "no" for "Installs?" should automatically lower the rating. "Runs?" might be a bit too is a bit too ambiguous. More over, the ratings should not be something you have to click on

Re: dead link on directdraw wiki to directdrawrenderer

2011-06-16 Thread James Eder
On Thu, Jun 16, 2011 at 11:16 PM, Jarek Czekalski wrote: > There's a dead link on the page http://wiki.winehq.org/DirectDraw pointing > to http://wiki.winehq.org/DirectDrawRenderer as DirectDrawRenderer. Is there > any better place for such reports? > That's just the MoinMoin Wiki software at wor

kernel32: Correctly parse the input strings for advanced keys.

2011-01-19 Thread James Eder
On systems without the appropriate curses development files, compilation is broken here: gcc -m32 -c -I/home/james/build/wine/wine-git/dlls/kernel32 -I. -I/home/james/build/wine/wine-git/include -I../../include -D__WINESRC__ -D_KERNEL32_ -D_NORMALIZE_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-ali

[PATCH] ntdll: Increase size of buffer used to read lines of /proc/cpuinfo

2010-11-28 Thread James Eder
On 11/26/10 12:15 AM, Damjan Jovanovic wrote: > On Fri, Nov 26, 2010 at 6:56 AM, Vitaliy Margolen > wrote: >> On 11/24/2010 07:19 PM, James McKenzie wrote: >>> On 11/24/10 6:56 PM, Vitaliy Margolen wrote: >>>> On 11/24/2010 12:23 PM, jimportal at gmail.