Re: wininet: Don't assume that end of chunk means end of stream. (try 2)

Hi Hans, Sorry for the delay, I wanted to test it a bit more before answering. On 09/23/13 10:50, Hans Leidekker wrote: > On Thu, 2013-09-19 at 17:38 +0200, Jacek Caban wrote: >> I was hoping for a test like the attached one, which shows that there is >> still more work to do. But

Re: Wine Gecko 2.24-beta1

On 08/18/13 04:14, Zhenbo Li wrote: > I've tested some websites, and found that these pages have problems: > > http://mail.163.com (it will make gecko crash) > http://huaban.com (nothing can be shown) > http://douban.com (no pictures) > http://html5test.com/ (can't

Re: add ualapi directory (try 9

Hi Akira, On 09/23/13 10:00, Akira Nakagawa wrote: > From 2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699 Mon Sep 17 00:00:00 2001 > Message-Id: > <2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699.1379923234.git.matyapir...@gmail.com> > From: Akira Nakagawa > Date: Mon, 23 Sep 2013 17:00:04 +0900 > Subject: [P

Re: wininet: Don't assume that end of chunk means end of stream. (try 2)

; InternetOpenRequest_test(); > test_http_cache(); > InternetOpenUrlA_test(); I was hoping for a test like the attached one, which shows that there is still more work to do. But it's a step in the right direction, so I'm fine with your patch. Thanks, Jacek commit

Re: wininet: Don't assume that end of chunk means end of stream.

On 09/11/13 17:32, Hans Leidekker wrote: > On Wed, 2013-09-11 at 16:38 +0200, Jacek Caban wrote: >> Hi Hans, >> >> On 09/11/13 13:50, Hans Leidekker wrote: >>> static DWORD chunked_get_avail_data(data_stream_t *stream, http_request_t >>> *req) >>

Re: wininet: Don't assume that end of chunk means end of stream.

On 9/11/13 7:09 PM, Hans Leidekker wrote: On Wed, 2013-09-11 at 17:53 +0200, Jacek Caban wrote: Network traces tell me that native also performs a read on the first call to InternetQueryDataAvailable. Are you sure it's not an asynchronous read from a separated thread that is order

Re: wininet: Don't assume that end of chunk means end of stream.

Hi Hans, On 09/11/13 13:50, Hans Leidekker wrote: > static DWORD chunked_get_avail_data(data_stream_t *stream, http_request_t > *req) > { > -/* Allow reading only from read buffer */ > +chunked_stream_t *chunked_stream = (chunked_stream_t*)stream; > +DWORD res; > + > +if(!chunke

Re: [PATCH 2/2] d3d11.idl: Added some missing declarations.

On 09/11/13 14:22, Michael Stefaniuc wrote: > On 09/11/2013 02:11 PM, Henri Verbeet wrote: >> On 11 September 2013 12:09, Jacek Caban wrote: >>> +typedef enum D3D11_RESOURCE_MISC_FLAG >>> +{ >>> +D3D11_RESOURCE_MISC_GENERATE_

Re: crypt32 patch review

On 09/05/13 18:53, Juan Lang wrote: > [+wine-devel] > > Hi Jacek, > I've added the list so the discussion can take place in public. > > On Tue, Sep 3, 2013 at 8:50 AM, Jacek Caban <mailto:ja...@codeweavers.com>> wrote: > > I have a patch for crypt32. I&#x

Re: [2/2] rpcrt4: Clear the connection pool when closing an http connection.

On 09/04/13 15:01, Hans Leidekker wrote: > --- > dlls/rpcrt4/rpc_transport.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c > index d0857fa..1eb0151 100644 > --- a/dlls/rpcrt4/rpc_transport.c > +++ b/dlls/rpcrt4/rpc_transport.c

Re: [2/2] rpcrt4: Clear the connection pool when closing an http connection.

On 09/04/13 15:36, Hans Leidekker wrote: > On Wed, 2013-09-04 at 15:28 +0200, Jacek Caban wrote: >> On 09/04/13 15:01, Hans Leidekker wrote: >>> --- >>> dlls/rpcrt4/rpc_transport.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>>

Re: wininet: Don't start the next chunk if the read is satisfied.

On 09/04/13 14:38, Hans Leidekker wrote: > On Wed, 2013-09-04 at 13:11 +0200, Jacek Caban wrote: >> On 09/04/13 09:22, Hans Leidekker wrote: >>> --- >>> dlls/wininet/http.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>>

Re: wininet: Don't start the next chunk if the read is satisfied.

Hi Hans, On 09/04/13 09:22, Hans Leidekker wrote: > --- > dlls/wininet/http.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c > index 1832b4f..521e4aa 100644 > --- a/dlls/wininet/http.c > +++ b/dlls/wininet/http.c > @@ -2795,7

Re: [PATCH try3] atl110: Added new DLL.

On 09/03/13 13:51, Qian Hong wrote: > On Tue, Sep 3, 2013 at 7:42 PM, Jacek Caban wrote: >> Not really, good catch. We should make them consistent. Honestly, I'm >> not sure which one is better. Both have their problems. Some functions >> are forwarded, others are not, s

Re: [PATCH try3] atl110: Added new DLL.

On 09/03/13 13:28, Qian Hong wrote: > On Tue, Sep 3, 2013 at 7:27 PM, Qian Hong wrote: >> Hi Jacek, we already have a debug channel atl100 for atl100.dll, but >> we currently use atl for both atl.dll and atl80.dll, do you think it >> is better to use atl for all, or one debug channel per each dll?

Re: mshtml: Use winehq snapshot instead of the main page in tests.

On 08/18/13 13:44, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/

Wine Gecko 2.24-beta1

Hi all, It's time to do another update of Wine Gecko, so I prepared a new beta build. It's already on Sourceforge [1]. Until server-side support for auto install of the package is committed [2], its manual installation is required [3]. I attached a patch to Wine that is required for the new Gecko.

Wine Gecko repo

Hi, A few months ago, SourceForge did some deep changes in their Git (and not only) repo hosting. While doing it, the location of repos has changed (which is extremely stupid, if you ask me). The problem is that while doing the update, they also switched to their own Web interface for git. And thi

Re: [PATCH 01/11] widl: New option --rt for enabling rt's specific language extensions.

On 08/08/13 19:56, Kai Tietz wrote: > 2013/8/8 André Hentschel : >> Am 08.08.2013 17:51, schrieb Kai Tietz: >>> Hi, >>> >>> this patch adds new --rt option to widl. By it you can control, if >>> RT's IDL-language-extension(?s) getting active. >>> This initial patch just adds the option-scanning an

Re: [1/2] msxml3: Implement IMXAttributes_removeAttributes()

Hi Nikolay, On 07/30/13 12:42, Nikolay Sivov wrote: > +dst = &This->attr[index]; > +src = &This->attr[index+1]; > + > +memmove(dst, src, This->length-index-1); *sizeof(*dst) Cheers, Jacek

Re: riched20: ITextDocument stubs for ITextServices (retry)

On 07/29/13 17:55, Caibin Chen wrote: >> +struct tagReTxtDoc { >> + IUnknown *outerObj; >> + ME_TextEditor *editor; >> + ITextDocument iTextDocumentIface; >> +}; >> >> Do you really need a separated structure for that? Wouldn't adding >> ITextDocument implementation to ITextServicesImpl be enou

Re: riched20: ITextDocument stubs for ITextServices (retry)

Hi Caibin, On 07/29/13 01:52, Caibin Chen wrote: > Hi, > > It has been 2 weeks since I sent this patch[1]. It's still new status > in the patches list. I'm working on following patches based on it. I > appreciate your reviews and will work on the patch to get it > submitted. You sent the patch du

Re: Duplicate UUID in oleaut32:tmarshal test

On 06/30/13 23:29, Thomas Faber wrote: > I just tried running midl on dlls/oleaut32/tests/tmarshal.idl and it > complained: > tmarshal.idl(83) : error MIDL2270 : duplicate UUID. Same as : ItestDual [ > Interface 'ITestSecondDisp' ] > > This doesn't seem like it's intentional. But just giving > IT

Re: widl: Do not generate C structure for empty interfaces. (try 2)

On 06/30/13 23:14, Thomas Faber wrote: > On 2013-06-27 13:33, Jacek Caban wrote: >> That >> said, if such interfaces are just obscure special case, I would say we >> shouldn't care. We may easily avoid them (I just sent a patch avoiding >> it in mshtml). > Ah, I

Re: widl: Do not generate C structure for empty interfaces. (try 2)

Hi Thomas, I tested what midl does in this case and I think the solution should be different. When I tried to compile an empty interface, I got an error saying that '[object] interface must derive from another [object] interface'. That requirement is mostly enough to avoid empty vtbl. I was wonde

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt

Hi Zhan, On 05/17/13 16:53, Zhan Jianyu wrote: > This patch is built based on Jaceks's newly-submitted patch: > > commit 48a862306288d69d3623d5ecdc0f5a5a40addafe > ( vbscript: Round half to even in to_int) > > Thanks, Jacek. :-) > > With his patch, CInt could be implementd in a clean way,

Re: msvcrt.h: Use inline function to forward hypot to _hypot.

On 04/26/13 16:18, Alexandre Julliard wrote: > Jacek Caban writes: > >> On 04/26/13 14:46, Alexandre Julliard wrote: >>> Jacek Caban writes: >>> >>>> This fixes compiling msvcp* DLLs with recent mingw-w64 trunk version. >>>> Previous version

Re: msvcrt.h: Use inline function to forward hypot to _hypot.

On 04/26/13 14:46, Alexandre Julliard wrote: > Jacek Caban writes: > >> This fixes compiling msvcp* DLLs with recent mingw-w64 trunk version. >> Previous versions had a separated library that contained forwards from >> underscored functions to non-underscored, which I bel

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

On 04/26/13 12:02, Henri Verbeet wrote: > On 26 April 2013 10:27, Jacek Caban wrote: >> - round is not portable. As I mentioned you before, Wine needs to be C89 >> compatible. If we need some features that are not part of C89, we need >> to be careful about that and it often

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

Hi Zhan, It's better, thanks, but still needs more work. On 04/25/13 23:37, Zhan Jianyu wrote: > } > > + > + While we're at this, please put more attention into whitespace changes, esp. useless ones. > static HRESULT to_double(VARIANT *v, double *ret) > { > switch(V_VT(v)) { > @@ -217

Wine Gecko 2.21-beta1

Hi all, As some of you might have noticed, the final Wine Gecko 2.20 was never been released, although it was scheduled for about three weeks ago. This is mostly due to my lack of time, combined with the fact that part of that time I was busy with some Gecko work that would be nice to have in Wine

Re: Clang static analyzer results / wine-1.5.28-66-g6899279

On 04/24/13 11:35, Frédéric Delanoy wrote: > On Wed, Apr 24, 2013 at 7:40 AM, Austin English > mailto:austinengl...@gmail.com>> wrote: > > On Fri, Apr 19, 2013 at 1:52 AM, Michael Stefaniuc > mailto:mstef...@redhat.com>> wrote: > > > > On 04/19/2013 12:43 AM, Austin English wrote: >

Re: oledb32: Implement DataConvert DBTYPE_BOOL->VARIANT

On 04/24/13 10:41, Alistair Leslie-Hughes wrote: > +case DBTYPE_BOOL: > +V_VT(v) = VT_BOOL; > +V_BOOL(v) = *(BOOL*)src; You're mixing BOOL and VARIANT_BOOL here. This can't work, they even have a different size. From your test I guess that you meant to cast src to V

Re: Application for GSoC 2013

On 04/18/13 12:06, larmbr zhan wrote: >> You're going to have to be (much) more specific with your application, what >> modules do you plan to implement, what applications does this help (if you >> know of any), etc. > Actually I am a huge fan of underlying stuff like OS, programming > language int

Re: [PATCH 3/3]vbscript: Implemented builtin function CBool

On 04/17/13 18:18, larmbr zhan wrote: > +double tmp; > +WCHAR trueW[] = {'T','r','u','e','\0'}; > +WCHAR falseW[] = {'F','a','l','s','e','\0'}; > + > +TRACE("%s\n", debugstr_variant(arg)); > + > +assert(args_cnt == 1); > + > +switch(V_VT(arg)) { > +case VT_I2: > +

Re: [PATCH 2/3]vbscript: Implemented builtin function CInt

On 04/17/13 18:17, larmbr zhan wrote: > +static HRESULT to_int_banker_rounding(VARIANT *v, int *ret) > +{ I wonder if this conversion is used in any other place as well. I think this does not need a helper function until we find other use cases as well, esp. since you could simplify that to: if(V

Re: Application for GSoC 2013

On 04/17/13 18:38, larmbr zhan wrote: > Hi all, > > I'm a junior student from a non-famous college, > I apply to parcitipate in GSoC , to help do some > vbscript module implementation. I've just submitted > a patchset on this. No worries, no collage name can give you as much as a patch. That's a

Re: [PATCH 6/6] ieframe: Added DISPID_WINDOWCLOSING tests.

On 04/15/13 18:08, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

Hi Ken, On 04/10/13 16:16, Ken Thomases wrote: > Hi Jacek, > > On Apr 10, 2013, at 4:24 AM, Jacek Caban wrote: > >> On 3/28/13 8:31 PM, Ken Thomases wrote: >>> Mac OS X 10.8 introduced support for TLS 1.1 and 1.2. >> Can someone with Mac OS X 10.8 test the att

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

are listed as supported protocol. Thanks, Jacek commit 78f9768f8d6759af1df99c4b67b8fd6a93369da4 Author: Jacek Caban Date: Tue Apr 9 12:35:33 2013 +0200 secur32: Added support for TLS 1.1 and TLS 1.2 on Mac. diff --git a/dlls/secur32/schannel_macosx.c b/dlls/secur32/schannel_macosx.c

Re: Wine Gecko 2.20-beta1

On 03/07/13 12:07, Jacek Caban wrote: > Hi all, > > I've uploaded a new Gecko builds to SourceForge [1]. This one is based on > Firefox 20 beta and, other than usual update of Gecko, it should fix some > crashes like bug b*ug 32753* <http://bugs.winehq.org/show_bug.cgi?id=

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

Hi Juan, On 03/29/13 18:19, Juan Lang wrote: > Hi Jacek, > > thanks for the detailed reply. > > On Fri, Mar 29, 2013 at 3:02 AM, Jacek Caban <mailto:ja...@codeweavers.com>> wrote: > > Each protocol has two kinds of enable/disable flags: "enabled" and

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

Hi Juan, On 03/28/13 21:55, Juan Lang wrote: > On Thu, Mar 28, 2013 at 12:31 PM, Ken Thomases <mailto:k...@codeweavers.com>> wrote: > > On Mar 28, 2013, at 6:05 AM, Jacek Caban wrote: > > > --- a/dlls/secur32/schannel_macosx.c > > +++

Re: secur32: Take schannel backend capabilities into account when configuring enabled protocols.

Hi Ken, On 03/28/13 20:31, Ken Thomases wrote: > On Mar 28, 2013, at 6:05 AM, Jacek Caban wrote: > >> --- a/dlls/secur32/schannel_macosx.c >> +++ b/dlls/secur32/schannel_macosx.c >> @@ -630,6 +630,11 @@ static OSStatus schan_push_adapter(SSLConnectionRef >&g

Re: urlmon: Fix handling of mailto URIs in CoInternetCombineUrlEx.

Hi Hans, On 03/27/13 10:43, Hans Leidekker wrote: > --- > dlls/urlmon/tests/uri.c | 63 > +++ > dlls/urlmon/uri.c | 15 --- > 2 files changed, 69 insertions(+), 9 deletions(-) > > diff --git a/dlls/urlmon/tests/uri.c b/dlls/urlmon/tes

Wine Gecko 2.20-beta1

Hi all, I've uploaded a new Gecko builds to SourceForge [1]. This one is based on Firefox 20 beta and, other than usual update of Gecko, it should fix some crashes like bug b*ug 32753* . To test them, you need recent Wine Git version with the attach

Re: [1/3] wininet: Remember that headers were not received.

Hi Ričardas, On 02/27/13 00:07, Ričardas Barkauskas wrote: > @@ -5708,6 +5708,7 @@ static INT HTTP_GetResponseHeaders(http_request_t > *request, BOOL clear) > > heap_free(request->rawHeaders); > request->rawHeaders = heap_strdupW(szDefaultHeader); > +reques

Re: [PATCH 1/2] wininet: Address string should never be converted to UNICODE in status notifications

On 02/18/13 15:50, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/

Re: IE 6 related urlmon:protocol failures

On 02/18/13 12:49, Francois Gouget wrote: > On Sat, 16 Feb 2013, Jacek Caban wrote: > >> On 2/16/13 1:28 AM, Francois Gouget wrote: >>> However I think the test should still not fail. So I'm looking for a >>> volunteer to either get the test to succeed with urlm

Re: IE 6 related urlmon:protocol failures

On 2/16/13 1:28 AM, Francois Gouget wrote: However I think the test should still not fail. So I'm looking for a volunteer to either get the test to succeed with urlmon 6.0, or find a way to detect it and skip these three tests. I believe it's time to skip those tests on IE6 then. I will send a

Re: [PATCH 2/2] wininet: Set available bytes in InternetQueryDataAvailable even if it ends up in async call

On 02/14/13 18:13, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/

Re: [PATCH 2/4] urlmon: Fixed QueryInfo tests during BINDSTATUS_PROXYDETECTING notification

On 02/12/13 17:32, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/

Re: Makedll.rules.in: Explicitly specify DLL name when building importlib

On 01/30/13 20:09, Alexandre Julliard wrote: > Jacek Caban writes: > >> --- >> dlls/Makedll.rules.in | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > Why do you need this? My use case is not really valid as is for Wine. I was experimenting with runni

Re: [PATCH 1/8] winhttp: Use schannel in netconn_secure_connect if OpenSSL is not available

On 01/22/13 20:21, Alexandre Julliard wrote: > Jacek Caban writes: > >> The following patch makes winhttp use schannel instead of OpenSSL for >> SSL (HTTPS) connections. It is made to be as minimal change as possible >> (but complete enough to replace all OpenSSL fun

Re: [PATCH 6/8] winhttp: Added schannel-based netconn_get_cipher_strength implementation

On 01/22/13 17:22, Hans Leidekker wrote: > On Tue, 2013-01-22 at 16:49 +0100, Jacek Caban wrote: >> @@ -1460,6 +1460,13 @@ int netconn_get_cipher_strength( netconn_t *conn ) >> pSSL_CIPHER_get_bits( cipher, &bits ); >> return bits; &

Re: [PATCH 2/3] vbscript: Added VBScript.RegExp version 5.5 typelib

Hi Piotr, On 01/18/13 11:48, Piotr Caban wrote: > +#define DISPID_SUBMATCHES_ITEM 0 > +#define DISPID_SUBMATCHES_COUNT 1 > +#define DISPID_SUBMATCHES__NEWENUM -4 > + > +#define DISPID_MATCHCOLLECTION_ITEM 0 > +#define DISPID_MATCHCOLLECTION_COUNT1 > +#define D

Re: [PATCH (try2)] ieframe: Strip 'file://' from file URLs in BEFORENAVIGATE2 callbacks

Hi Andrew, On 01/09/13 16:56, Andrew Eikum wrote: > --- > > This should fix the Office 2007 half of Bug 17271. > > try2: Fix test failures on XP by expanding the expected path name. > > dlls/ieframe/navigate.c | 7 +- > dlls/ieframe/tests/webbrowser.c | 56 >

Re: [PATCH 1/7] d3dx9: Handle invalid byte code in D3DXFindShaderComment().

On 01/02/13 14:38, Matteo Bruni wrote: > 2013/1/1 Rico Schüller : >> --- >> dlls/d3dx9_36/shader.c | 16 +++- >> dlls/d3dx9_36/tests/shader.c | 21 + >> 2 Dateien geändert, 32 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-) >> > +static inline BOOL is_valid_byteco

Re: msxml3: Add custom handling for DISPID_VALUE for node map

Hi Nikolay, On 12/20/12 11:29, Nikolay Sivov wrote: > On 12/19/2012 17:22, Jacek Caban wrote: >> On 12/19/12 08:24, Nikolay Sivov wrote: >>> Add custom handling for DISPID_VALUE for node map >> If this has to be done for all IDispatchEx objects with DISPID_VALUE, it >

Re: msxml3: Add custom handling for DISPID_VALUE for node map

On 12/19/12 08:24, Nikolay Sivov wrote: > Add custom handling for DISPID_VALUE for node map If this has to be done for all IDispatchEx objects with DISPID_VALUE, it may be worth considering changing dispex.c. Something like: if(id == DISPID_VALUE && wFlags == DISPATCH_METHOD) wFlags |= DISPAT

Re: wininet: Don't perform revocation checks when verifying a certificate.

Hi Hans, On 12/11/12 09:45, Hans Leidekker wrote: > https://testbot.winehq.org/JobDetails.pl?Key=23300 is a test which shows that > revocation checks fail for the certificate on outlook.com when passed straight > to CertVerifyRevocation. The reason is that a CRL link specified in the > certificate

Re: mshtml: Added support for converting (some) argument types in builtin function calls using script engine

Hi Marvin, On 12/04/12 15:14, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, Yeah, I can see that... > so I might be wrong, but could you please double-check? Sure, there you go:

Re: wshom: Basic support for REG_SZ values in RegRead() (try2)

Hi Nikolay, On 12/04/12 10:33, Nikolay Sivov wrote: > +if (name[len] != '\\') > +return HRESULT_FROM_WIN32(ERROR_PATH_NOT_FOUND); > +/* skip '\' after root name */ > +len++; > + > +/* at this point we have at least one '\' in path */ > +val = strrchrW(name, '\\'); > +

Re: wshom: Basic support for REG_SZ values in RegRead()

Hi Nikolay, On 12/03/12 12:29, Nikolay Sivov wrote: > +/* skip '\' after root name */ > +if (name[len] == '\\') len++; It looks like if name[len] != '\\', then name should be considered invalid. > + > +val = strlenW(name); > +while (name[--val] != '\\' && val) > +; > +

Re: Wine Gecko versioning

On 11/27/12 16:33, Nikolay Sivov wrote: > On 11/27/2012 17:26, Rosanne DiMesio wrote: >> On Tue, 27 Nov 2012 13:32:02 +0100 >> Jacek Caban wrote: >> >>> The idea is that Wine Gecko version could be just something based on >>> other versions, that are more in

Re: Wine Gecko versioning

On 11/27/12 14:53, André Hentschel wrote: > Am 27.11.2012 13:32, schrieb Jacek Caban: >> The idea is that Wine Gecko version could be just something based on >> other versions, that are more informative. It's not really possible to >> use Wine version, because the first

Wine Gecko versioning

Hi all, Since Wine Gecko 1.9 branching, the tip should bump to 1.10, but I think it's time to clean up the situation a bit. Such things usually don't bring much attention, but it should be decided in public. Right now we have three versioning schemes involved in Wine Gecko: - Wine version that app

Re: msvcp60: Remove superfluous semicolons

On 11/26/12 22:35, Andrew Talbot wrote: > Jacek Caban wrote: > >> It's probably better to change the macro to require the semicolon. >> >> Jacek > The reason I did it that way was because there are two variants of the > DEFINE_CXX_DATA macro, surrounded by a

Re: msvcp60: Remove superfluous semicolons

On 11/26/12 8:42 PM, Andrew Talbot wrote: Changelog: msvcp60: Remove superfluous semicolons. diff --git a/dlls/msvcp60/exception.c b/dlls/msvcp60/exception.c index 761075e..b8c6921 100644 --- a/dlls/msvcp60/exception.c +++ b/dlls/msvcp60/exception.c @@ -137,7 +137,7 @@ void * __thiscall MSV

Wine Gecko 1.9-beta1

Hi all, Firefox 17 was released lately, meaning that Firefox 18 goes to beta channel and it's the next target for out Gecko package update. I've uploaded new Gecko builds to SourceForge [1]. To test them, you need recent Wine Git version with the attached patch. As usually, grab the build from Sou

Re: [PATCH 2/4] [cmd] Prevent external env vars causing tests to fail

On 11/20/12 16:00, Ann and Jason Edmeades wrote: > On 20 November 2012 12:15, Jacek Caban <mailto:ja...@codeweavers.com>> wrote: > > On 11/20/12 12:39 AM, Ann and Jason Edmeades wrote: > > (I'll make this change in try 2, as I need to fix the broken >

Re: [PATCH 2/4] [cmd] Prevent external env vars causing tests to fail

On 11/20/12 12:39 AM, Ann and Jason Edmeades wrote: (I'll make this change in try 2, as I need to fix the broken NT4 stuff from patch 1 anyway) I think it's time to consider skipping all cmd tests on NT4. Adding @or_broken@ for NT4 mostly pollutes those tests. Jacek

Re: [PATCH 7/9] ieframe: Forward more DocHost::Exec calls to embedders

On 11/12/12 13:21, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/

Re: vbscript/tests: Skip some of the weekday tests if the first day of the week is not Sunday.

Hi Huw, On 10/31/12 12:04, Huw Davies wrote: > --- > dlls/vbscript/tests/api.vbs | 17 + > 1 files changed, 9 insertions(+), 8 deletions(-) Did you see those failures on Windows? test.winehq.org shows only some Linux failures, which suggests that the problem is in implementatio

Re: [PATCH 4/5] include: Don't add d3d8 LP* interface typedefs for __WINESRC__.

On 10/30/12 12:01, Alexandre Julliard wrote: > Henri Verbeet writes: > >> We can certainly generate some more d3d headers from idl, and we >> probably should anyway, but I'm not sure how that's going to make the >> mechanism any more generic. I suppose we could do something like >> "DECL_WINELIB_T

Re: [PATCH] Potential reference count races

On 10/29/12 01:25, Max TenEyck Woodbury wrote: > On 10/28/2012 12:06 PM, Nikolay Sivov wrote: >> On 10/28/2012 17:44, Max TenEyck Woodbury wrote: >>> On 10/28/2012 02:40 AM, Nikolay Sivov wrote: On 10/28/2012 04:59, m...@mtew.isa-geek.net wrote: > From: Max TenEyck Woodbury > > I

Re: [PATCH 1/5] d3dx9_36: Implement D3DXFileCreate.

On 10/22/12 10:13 PM, Rico Schüller wrote: > On 22.10.2012 21:27, Christian Costa wrote: >> +static HRESULT WINAPI ID3DXFileImpl_QueryInterface(ID3DXFile *iface, REFIID riid, LPVOID *ret_iface) >> +ID3DXFileImpl *This = impl_from_ID3DXFile(iface); >> +ID3DXFileImpl* object; > Please be a b

Re: ntdll: Don't use strncasecmp for _strnicmp implementation

On 10/16/12 13:21, Jacek Caban wrote: >> How exactly? Do you know more details / urls? >> >> Does it return -n ... +n values? Like the memcmp optimization that caused >> mysql security issue? >> In that case my patch should work. > From what I know following call

Re: jscript: Don't release possible NULL pointer (coverity)

Hi André, On 10/18/12 00:14, André Hentschel wrote: > CID 735258 > > --- > dlls/jscript/regexp.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/dlls/jscript/regexp.c b/dlls/jscript/regexp.c > index bdff445..71474c7 100644 > --- a/dlls/jscript/regexp.c > +++ b/dll

Re: ntdll: Don't use strncasecmp for _strnicmp implementation

On 10/16/12 13:16, Marcus Meissner wrote: > On Tue, Oct 16, 2012 at 01:12:50PM +0200, Jacek Caban wrote: >> On 10/16/12 13:08, Marcus Meissner wrote: >>> On Tue, Oct 16, 2012 at 12:38:51PM +0200, Jacek Caban wrote: >>>> --- >>>> dlls/ntdll/string.c

Re: ntdll: Don't use strncasecmp for _strnicmp implementation

On 10/16/12 13:08, Marcus Meissner wrote: > On Tue, Oct 16, 2012 at 12:38:51PM +0200, Jacek Caban wrote: >> --- >> dlls/ntdll/string.c | 12 +++- >> dlls/ntdll/tests/string.c | 33 + >> 2 files changed, 44

Re: [PATCH 1/4] jscript: Use custom string container instead of BSTR.

On 10/11/12 19:12, Charles Davis wrote: > On Oct 11, 2012, at 4:16 AM, Jacek Caban wrote: >> This patch alone makes SunSpider 0.9 17x faster. > Seems to me that something is really wrong with our BSTR implementation if > replacing it with a home-grown implementation speeds this up

Re: [PATCH 1/4] jscript: Use custom string container instead of BSTR.

On 10/11/12 12:39, Henri Verbeet wrote: > On 11 October 2012 12:16, Jacek Caban wrote: >> +struct _jsstr_t { >> +unsigned length_flags; >> +unsigned ref; >> +WCHAR str[1]; >> +}; > It's probably much too late for jscript, and perhaps Wine i

Re: [PATCH 2/2] mshtml: Added ActiveX event binding test

On 10/04/12 15:02, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.winehq.org/

Re: [PATCH] reg.exe: comparing the names of registry keys

On 10/04/12 08:03, Mieczyslaw Nalewaj wrote: > +static BOOL strings_equal(LPWSTR lpString1, const WCHAR *lpString2) > +{ > +int cchCount; Please avoid Hungarian style variable names. Also is seems like the function not exactly compares strings, so something like is_subkey could be more appropr

Re: [PATCH] rpcrt4: wait_async_request: return error if we received an error

On 10/03/12 14:57, Marcus Meissner wrote: > On Tue, Oct 02, 2012 at 01:19:37PM +0200, Jacek Caban wrote: >> Hi Marcus, >> >> On 10/01/12 23:00, Marcus Meissner wrote: >>> Hi, >>> >>> Various coverity issues complain about user-after-free scenar

Re: [1/2] vbscript: Support vb* constants for message box buttons

Hi Nikolay, On 10/03/12 13:34, Nikolay Sivov wrote: > Support vb* constants for message box buttons How about using MB_* constants from winuser.h instead of hardcoding them here? Other than that, the patch looks good to me. Jacek

Re: [PATCH 1/3] hhctrl.ocx: Fix removing a window from the help list when window creation fails.

On 10/02/12 23:02, Erich E. Hoover wrote: > If a cleanup occurs because HTML Help window creation fails then > list_remove() causes a crash, since the window was never added to the > window list. The attached patch fixes this issue, allowing safe > reloading of files (needed for part 2). This loo

Re: [PATCH] rpcrt4: wait_async_request: return error if we received an error

Hi Marcus, On 10/01/12 23:00, Marcus Meissner wrote: > Hi, > > Various coverity issues complain about user-after-free scenarios, > all involving this code path. > > I strongly think if call_ret signals error, we also need to return > an error condition to avoid the callers from proceeding as if no

Re: [PATCH] rpcrt4: wait_async_request: return error if we received an error

Hi Marcus, On 09/29/12 11:44, Marcus Meissner wrote: > Hi, > > Various coverity issues complain about user-after-free scenarios, > all involving this code path. > > I strongly think if call_ret signals error, we also need to return > an error condition to avoid the callers from proceeding as if no

Re: mshtml: Implement IHTMLFrameBase_put_name()

Hi Nikolay, On 09/30/12 20:36, Nikolay Sivov wrote: > http://bugs.winehq.org/show_bug.cgi?id=31835 The code may be simple and obvious, but I'd still like to see a test. A simple call should be enough just to make sure it's executed when I test new Gecko builds. Jacek

Re: scrrun: Correct Invoke parameter

Hi Alistair, On 09/21/12 14:12, Alistair Leslie-Hughes wrote: > Hi, > > > Changelog: > scrrun: Correct Invoke parameter > --- a/dlls/scrrun/dictionary.c +++ b/dlls/scrrun/dictionary.c @@ -153,7 +153,7 @@ static HRESULT WINAPI dictionary_Invoke(IDictionary *iface, DISPID dispIdMember, hr

Re: [PATCH 21/21] jscript: Pack jsval_t to 64-bit structure on i386

Hi Juan, On 09/17/12 22:42, Juan Lang wrote: > Hi Jacek, > > + * that NaN value representation has 52 (almost) free bytes. > > You mean bits, yes? Yes, of course. > While you're at it, > + * jsval_t structure is used to represent JavaScript dynamicaly-typed values. > > dynamically is spelled wit

Re: [PATCH 21/21] jscript: Pack jsval_t to 64-bit structure on i386

Please ignore this last patch. It has one more dependency that I didn't send yet. On 09/17/12 15:21, Jacek Caban wrote: > --- > dlls/jscript/jsutils.c |4 +- > dlls/jscript/jsval.h | 143 > +-- > 2 files changed, 114 insertions(+), 33 deletions(-) >

Re: mshtml: Added support for navigating to anchors with IDs containing '#'

On 09/10/12 12:19, Alexandre Julliard wrote: > Jacek Caban writes: > >> --- >> dlls/mshtml/navigate.c | 42 +++--- >> dlls/mshtml/nsiface.idl | 11 +++ >> 2 files changed, 50 insertions(+), 3 deletions(-) > It does

Re: [PATCH 6/9] mshtml: Use first script host's GUID as default script guid

On 09/07/12 19:15, Alexandre Julliard wrote: > Jacek Caban writes: > >> dlls/mshtml/htmlwindow.c |1 - >> dlls/mshtml/mshtml_private.h |1 - >> dlls/mshtml/script.c | 18 ++ >> dlls/mshtml/tests/vbtest.html | 15 +

Re: [PATCH 5/5] mshtml: Added VBScript as event attribute tests

Hi, Here is proper run: https://testbot.winehq.org/JobDetails.pl?Key=21409 Jacek

Re: [PATCH 1/6] mshtml: Moved getting frame by name to separated function

On 09/03/12 16:13, Alexandre Julliard wrote: > Jacek Caban writes: > >> --- >> dlls/mshtml/htmlwindow.c | 127 >> ++ >> 1 files changed, 72 insertions(+), 55 deletions(-) > gcc -m32 -c -I. -I. -I../../inclu

Re: Wine Gecko 1.8-beta1

On 09/02/12 20:52, Vincent Povirk wrote: >> On related note, I seriously consider dropping debug builds and replace >> them by unstripped release build or even just a separated package >> containing only debug symbols for the release build. > No one has complained about the debugging symbols in Win

Wine Gecko 1.8-beta1

Hi all, It's time for another Gecko update. I've uploaded to SourceForge [1] new Gecko builds. These are based on Firefox 16 beta. Other than tons of changes inherited from Firefox and usual fixes to keep it working well for us, it brings a few visible fixes: - Proper tag handling - Synchronous

  1   2   3   4   5   6   7   8   9   >