Re: New Wine stuff in FreeWear.org

2010-06-15 Thread Ismael Barros²
Hi again, As the design seems to be liked, we just made the garments available for sale. As always, you can find them at http://www.freewear.org/?org=Wine Cheers! Ismael

Re: [PATCH 2/2] dpwsockx: Implementation of Open callback

2009-09-15 Thread Ismael Barros²
On Mon, Sep 14, 2009 at 12:46 AM, Vitaliy Margolen wrote: >> It's a way to tell between abruptly ending the thread due to an error, >> and ending the thread gracefully. > That makes no sense to me. You have no other point of exit from the loop. > Using goto for no good reason is always a bad thing

Re: [PATCH 2/2] dpwsockx: Implementation of Open callback

2009-09-13 Thread Ismael Barros²
On Sun, Sep 13, 2009 at 11:46 PM, Vitaliy Margolen wrote: > Forgot this part: >> Ismael Barros wrote: >> +static DWORD WINAPI tcp_listener_thread( LPVOID lpParameter ) >> +{ >> +    for ( ;; ) >> +    { >> +        if ( clientSock == INVALID_SOCKET )

Re: [PATCH 2/2] dpwsockx: Implementation of Open callback

2009-09-13 Thread Ismael Barros²
On Sun, Sep 13, 2009 at 11:39 PM, Vitaliy Margolen wrote: > You do not have exit from the loop. > > I haven't found the place where you closing this handle. > > Same here. The code to close those threads and their listener sockets is meant to go in DPWSCB_CloseEx(), but I still haven't worked on

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-09-09 Thread Ismael Barros²
On Fri, Sep 4, 2009 at 12:12 PM, Henri Verbeet wrote: > 2009/9/4 Ismael Barros² : >> I've been looking into iphlpapi/ip.h (just learned bit fields >> exist...); would this implementation be fine? >> >> #include "pshpack1.h" >> >> typedef st

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-09-04 Thread Ismael Barros²
On Tue, Sep 1, 2009 at 12:43 PM, Henri Verbeet wrote: > 2009/9/1 Ismael Barros² : >> Is there any standard way to deal with this cases? Any example in the >> codebase? >> > For packing, look for "#include " and "#include > " in some of the headers.

Re: Wine t-shirts?

2009-09-02 Thread Ismael Barros²
our Wine catalog soon with other style of designs, stay tunned. Cheers, Ismael On Tue, Aug 4, 2009 at 11:45 PM, Ismael Barros² wrote: > Hi there, > > Sorry for the huge delay, our artist has been quite busy. We finally > got the last design iteration: > > http://www.freewear.or

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-09-01 Thread Ismael Barros²
On Tue, Sep 1, 2009 at 11:00 AM, Henri Verbeet wrote: > 2009/9/1 Ismael Barros : >> +typedef struct tagDPSP_MSG_HEADER >> +{ >> +    DWORD       size;           /* size & 0x000F, token & 0xFFF0 */ >> +    SOCKADDR_IN SockAddr; >> +} DPSP_MSG_HEAD

Re: [PATCH 1/7] dpwsockx: Stub implementation

2009-09-01 Thread Ismael Barros²
dpwsockx is not used by any application, only by us in dplayx, so it's pretty safe to assume we won't pass any invalid parameter, as all the parameters passed by applications are already checked for validity in dplayx. On Tue, Sep 1, 2009 at 11:00 AM, Henri Verbeet wrote: > 2009/9/1

Re: [PATCH 1/3] dpwsockx: Stub implementation

2009-08-29 Thread Ismael Barros²
On Sat, Aug 29, 2009 at 12:25 PM, Stefan Dösinger wrote: > Yay, Dplay work! A few suggestions though: > > From patch 1: >> +static HRESULT WINAPI DPWSCB_GetCaps( LPDPSP_GETCAPSDATA data ) >> +{ >> +    TRACE( "(%d,%p,0x%08x,%p)\n", >> +           data->idPlayer, data->lpCaps, data->dwFlags, data->l

Re: Wine t-shirts?

2009-08-04 Thread Ismael Barros²
Hi there, Sorry for the huge delay, our artist has been quite busy. We finally got the last design iteration: http://www.freewear.org/images/release_candidates/Wine_final.png The only difference between versions A and B is in the eyes. Let us know which one you like better, and any kind of comme

Re: dplayx: Enclose NS_GetOtherMagic() in #if 0 since it's only used from code enclosed in #if 0.

2009-05-13 Thread Ismael Barros²
NS_GetOtherMagic is probably safe to remove. NS_GetNsMagic was only used in some hackish code that tried to reverse engineer dplay protocol. I removed that code that used it, but don't know if it'll be needed in a future. On Wed, May 13, 2009 at 12:10 PM, Kai Blin wrote: > On Wednesday 13 May 2

Re: wine shirts

2009-03-02 Thread Ismael Barros²
On Mon, Mar 2, 2009 at 5:33 PM, Hervÿe9 Chanal wrote: > http://img522.imageshack.us/img522/8526/wines2.jpg Heh, looks cool, too bad we can't print a design with so many gradients If you want some dumb Wine slogans to inspire you, there are some in http://spreadsheets.google.com/viewform?key=

Re: wine shirts

2009-03-02 Thread Ismael Barros²
> > Other old links: > > Martin's design: > http://cross-lfs.org/~mlankhorst/t-shirt.png > > Ismael Barros put some effort into this before: > http://www.winehq.org/pipermail/wine-devel/2008-December/070894.html > but nobody could think up good text. > - Dan > > >

Re: Wine t-shirts?

2008-12-23 Thread Ismael Barros²
Looks like the poll is pretty dead, and unless somebody wants to link it somewhere, I suppose we should start getting some conclussion White T-shirt wins 17-11 over white and red, but designs A and B are drawn, so our designer will choose (and she really disliked option A :P) About the slogan, th

Re: Wine t-shirts?

2008-12-17 Thread Ismael Barros²
On Wed, Dec 17, 2008 at 4:49 PM, Andrew Fenn wrote: > Thinking about me walking down the street again I have to say I prefer > Remco's suggestion the best because it describes best what wine does. > I like the idea of a witty shirt however the lines suggested requires > that you already understand

Re: Wine t-shirts?

2008-12-17 Thread Ismael Barros²
> "Windows translation layer" > "Run Windows applications on Linux, BSD and Mac OS X." It doesn't really sound very T-shirt-y to me. I think I'd rather wear a T-shirt with a short, witty slogan than being a walking banner :) Something like "Releasing your computer of Windows since 1993" or "Closi

Re: Wine t-shirts?

2008-12-16 Thread Ismael Barros²
On Wed, Dec 17, 2008 at 12:58 AM, Andrew Fenn wrote: > Shouldn't you take off the "hq" part of the name? Indeed, I forgot to tell the arts team that. > I don't know how exactly you could do what I am about to suggest, but > is there a way to make the graphics tell a little more as to what wine >

Re: Wine t-shirts?

2008-12-16 Thread Ismael Barros²
ve created this to make voting easier: http://spreadsheets.google.com/viewform?key=pFqhThgtfGxo3OxU8pe8ZDg Cheers Ismael Barros

Re: Wine t-shirts?

2008-12-03 Thread Ismael Barros²
Hum, that would be cool, I'll ask the boss but it's probably in. Does anyone have a higher resolution version? On Wed, Dec 3, 2008 at 4:29 PM, Steven Edwards <[EMAIL PROTECTED]> wrote: > On Wed, Dec 3, 2008 at 9:50 AM, Ismael Barros² <[EMAIL PROTECTED]> wrote: >>

Re: Wine t-shirts?

2008-12-03 Thread Ismael Barros²
're limited to 4 colours), but the "hq" is probably unnecessary for a T-shirt. Anyway, if you guys want come up with a nicer design/logo, or want to order T-shirts for some Wine/FOSS event, we're open for business. Cheers Ismael Barros

Re: Fixing the conformance tests

2008-09-07 Thread Ismael Barros
On 9/6/08, James Hawkins <[EMAIL PROTECTED]> wrote: >> Tests with timeouts >> === >> - dplayx:dplayx fails with a timeout on all windows servers > > According to Ismael, he has a few fixes that cut the time needed in > half. Ismael, what's the status on this? > > http://winehq.org/

Re: Summer of code evaluations

2008-08-24 Thread Ismael Barros
On Wed, Aug 20, 2008 at 1:14 AM, Maarten Lankhorst <[EMAIL PROTECTED]> wrote: > I would like to request from the mentors to fill in the final evaluation > form and from the students to give a final write up: What went well? Did > you meet the goals you set? Did you have fun? Is there anything we ca

Re: dplayx tests hanging

2008-08-12 Thread Ismael Barros
On 8/11/08, Ismael Barros <[EMAIL PROTECTED]> wrote: > Actually the thread stuff is a very good idea, I'll take a look. I tried launching each tests in a new thread, but a lot of tests failures arise, sometimes even with segfaults or deadlocks. Looks like the original implement

Re: dplayx tests hanging

2008-08-11 Thread Ismael Barros
On 8/11/08, Kai Blin <[EMAIL PROTECTED]> wrote: > On Monday 11 August 2008 18:17:58 Ismael Barros wrote: >> That's probably the main problem, as there's no network latency (all >> the messages are sent to localhost) or cpu intensive operation. >> Actually the t

Re: dplayx tests hanging

2008-08-11 Thread Ismael Barros
On 8/11/08, Kai Blin <[EMAIL PROTECTED]> wrote: > On Sunday 10 August 2008 18:34:02 Dan Kegel wrote: > >> http://test.winehq.org/data/tests/dplayx:dplayx.html >> Since your commits on the 4th of Aug, the dplayx tests have been hanging. >> This is getting in the way of my regression testing. > > I'v

Re: dplayx tests hanging

2008-08-10 Thread Ismael Barros
On 8/10/08, Dan Kegel <[EMAIL PROTECTED]> wrote: > In my case, they really were hanging, I waited 20 minutes on Wine. That's really weird, in wine most of the tests are skipped, and they take around 5 seconds on my machine with the latest git head. Could you provide a log with WINEDEBUG=+dplay?

Re: dplayx tests hanging

2008-08-10 Thread Ismael Barros
On 8/10/08, Dan Kegel <[EMAIL PROTECTED]> wrote: > Hi Ismael, > have a look at > http://test.winehq.org/data/tests/dplayx:dplayx.html > Since your commits on the 4th of Aug, the dplayx tests have been hanging. > This is getting in the way of my regression testing. > Can you have a look? > Thanks, >

Re: [dplayx 01/12] Tests for CreateGroup

2008-08-05 Thread Ismael Barros
On 8/5/08, Paul Vriens <[EMAIL PROTECTED]> wrote: > Ismael Barros wrote: >> Tests for CreateGroup >> Fixed the implementation of CreateGroup and CreateGroupInGroup so that >> it doesn't segfault when the service provider is not initialized >> >&g

Re: [dplayx] New library dpwsockx, needed by dplayx

2008-07-13 Thread Ismael Barros
On 7/13/08, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > Michael Karcher <[EMAIL PROTECTED]> writes: > >> Hello Alexandre, >> >> this thread is about an include file specifying the interface between >> dplayx.dll and the DirectPlay service providers. As it is not in the >> Windows Platform SDK,

Re: [dplayx] New library dpwsockx, needed by dplayx

2008-07-12 Thread Ismael Barros
On 7/12/08, James Hawkins <[EMAIL PROTECTED]> wrote: > On Sat, Jul 12, 2008 at 12:25 PM, Ismael Barros <[EMAIL PROTECTED]> > wrote: >> Nop, actually I also thought the best solution would be to move that >> file to include, because in fact it's just copied

Re: [dplayx] New library dpwsockx, needed by dplayx

2008-07-12 Thread Ismael Barros
better. I will also have to implement a stub modem provider, so I would have to copy that dplaysp.h again to dlls/dpmodemx, and any change in those definitions would have to be done three times... On 7/12/08, Michael Karcher <[EMAIL PROTECTED]> wrote: > Am Samstag, den 12.07.2008, 18:4

Re: [dplayx 02/29] Tests for DirectPlayCreate

2008-07-11 Thread Ismael Barros
On 7/11/08, Michael Karcher <[EMAIL PROTECTED]> wrote: > Am Donnerstag, den 10.07.2008, 22:04 +0300 schrieb Ismael Barros: >> I've been checking how this is done in other tests, and it's >> particularly interesting how they do it in ddraw/tests/refcount.c:81: >&

Re: [dplayx 02/29] Tests for DirectPlayCreate

2008-07-10 Thread Ismael Barros
>> > And last but not >> > least: As I see it, a static inline would do the job too, and is always >> > preferrable to macros. >> The main reason of using ditry macros instead of functions was to >> preserve the __LINE__ number, otherwise the debug information provided >> is pretty much useless. >

Re: [dplayx 02/29] Tests for DirectPlayCreate

2008-07-09 Thread Ismael Barros
Thanks for the review :) On 7/9/08, Michael Karcher <[EMAIL PROTECTED]> wrote: > Hello Ismael, > > reviewing this patch shows some issues. > > > +#define _okHR(expected, result) \ >> +ok( (expected) == (result), \ >> +"expected=%d(%s) go