Re: server: Android has struct user in asm/user.h

> On 24 Sep 2013, at 17:57, André Hentschel wrote: > > is that for the warning about the missing casts? No, this actually introduces more :-) The cast warning is about the 4th param of ptrace. Huw.

Re: [PATCH 2/3] iphlpapi: Add interface enumeration for Android.

On 19 Sep 2013, at 15:07, Bruno Jesus wrote: > Hi, Huw. I'm not sure this is an issue but in the android > implementation of get_interface_indexes you are not setting > > +if (table) *table = NULL; Hi Bruno, Good catch! Resent. Thanks, Huw.

Re: fonts: Add some box-type glyphs to wingdings.

On Fri, Sep 13, 2013 at 11:07:19AM +0100, Huw Davies wrote: > --- > fonts/wingding.sfd | 86 + Please ignore this one and use 'try 2'. I had the points of one glyph selected in the outline editor which apparently gets saved to the .sfd . Huw.

Re: riched20: Use \ulnone instead of \ul0 for no underline.

On Mon, Aug 19, 2013 at 05:38:13PM -0500, Vincent Povirk wrote: > Testing on Windows (by saving rtf documents with wordpad and viewing > them with notepad) shows that it uses \ulnone instead of \ul0 to end > underline. Wine and Windows are both able to read either one. I think these are symonyms a

Re: gdi32: Printer drivers don't use the character extra spacing if lpdx is supplied.

On Tue, Mar 26, 2013 at 04:50:03PM +0100, Alexandre Julliard wrote: > Ah OK, I guess that makes it a PITA to test... Some kind of print-scan magic comes to mind ;-)

Re: gdi32: Printer drivers don't use the character extra spacing if lpdx is supplied.

On Tue, Mar 26, 2013 at 04:30:14PM +0100, Alexandre Julliard wrote: > Huw Davies writes: > > > Ideally this would be done in wineps.drv, but by that point the conversion > > to device units would cause rounding errors. > > What about GetTextExtent functions? Do they n

Re: winspool.drv: Fallback to cupsGetPPD if cupsGetPPD3 is missing or failed.

On Mon, Feb 11, 2013 at 06:12:57PM +0800, Dmitry Timoshkov wrote: > Huw Davies wrote: > > Under what conditions does cupsGetPPD succeed if cupsGetPPD3 fails? > > I don't have full understanding of what is going on, but sometimes (!) > cupsGetPPD3 returns 404, while cup

Re: winspool.drv: Fallback to cupsGetPPD if cupsGetPPD3 is missing or failed.

On Mon, Feb 11, 2013 at 02:03:26PM +0800, Dmitry Timoshkov wrote: > -if (pcupsGetPPD3) return pcupsGetPPD3( http, name, modtime, buffer, > bufsize ); > +if (pcupsGetPPD3) > +{ > +http_status_t status; > + > +TRACE( "Calling cupsGetPPD3\n" ); > +status = pcupsGet

Re: riched20: ME_StrDup() is no longer used so remove it.

On Tue, Jan 29, 2013 at 07:05:13AM +0100, Francois Gouget wrote: > --- > dlls/riched20/editor.h |1 - > dlls/riched20/string.c |5 - > 2 files changed, 6 deletions(-) I'm about to send in a patch that uses this again, so please hold off on this one. Huw.

Re: usp10: Implement GPOS MarkToLigature Attachment Positioning Subtable

On Wed, Jan 09, 2013 at 11:36:51AM -0600, Aric Stewart wrote: > +typedef struct { > +WORD LigatureAnchor[1]; > +} GPOS_ComponentRecord; > + > +typedef struct { > +WORD ComponentCount; > +GPOS_ComponentRecord ComponentRecord[1]; > +} GPOS_LigatureAttach; > + > +for (

Re: [PATCH 3/3] usp10: Add support for format 2 pair adjustments.

On Thu, Dec 20, 2012 at 11:26:36PM +0800, Dmitry Timoshkov wrote: > Huw Davies wrote: > > The size is irrelevant - it's variable sized anyway. We just care > > about the offsets of the elements. > > Anyway, in order to avoid any confusion or bugs in future with all

Re: [PATCH 3/3] usp10: Add support for format 2 pair adjustments.

On Thu, Dec 20, 2012 at 11:05:48PM +0800, Dmitry Timoshkov wrote: > Huw Davies wrote: > > > > > typedef struct { > > > > +WORD PosFormat; > > > > +WORD Coverage; > > > > +WORD ValueFormat1; > > > > +WORD Valu

Re: [PATCH 3/3] usp10: Add support for format 2 pair adjustments.

On Thu, Dec 20, 2012 at 10:12:38PM +0800, Dmitry Timoshkov wrote: > Huw Davies wrote: > > > typedef struct { > > +WORD PosFormat; > > +WORD Coverage; > > +WORD ValueFormat1; > > +WORD ValueFormat2; > > +WORD ClassDef1; > >

Re: winex11: Add a few 'fall through' comments.

On Tue, Nov 27, 2012 at 06:44:35PM +0800, Dmitry Timoshkov wrote: > case DirectColor: > X11DRV_PALETTE_PaletteFlags |= X11DRV_PALETTE_VIRTUAL; > /* fall through */ > case GrayScale: > > would be more clear IMHO. Right now it's not obvious to which case statement > 'fall throu

Re: [PATCH 2/2] oleaut32: If pointers (ppTLib or pIndex in ITypeInfo2_fnGetContainingTypeLib) are null, we simply ignore it.[resend]

On Thu, Nov 08, 2012 at 06:13:33PM +0400, Tatyana Fokina wrote: > +if(ppTLib) > +{ > *ppTLib = (ITypeLib *)&This->typelib->ITypeLib2_iface; > ICreateTypeLib_AddRef((ICreateTypeLib*)This->typelib); > +} > + > +if(pIndex) > *pIndex = This->typeinfo->typekind >> 16; Ple

Re: [PATCH 1/2] oleaut32/tests: Add test for ITypeInfo2_fnGetContainingTypeLib [try 2]

On Thu, Nov 08, 2012 at 06:13:28PM +0400, Tatyana Fokina wrote: > +hr = CreateTypeLib2(SYS_WIN32, jsdeb, (ICreateTypeLib2 **)&ctl2); > +ok_ole_success(hr, CreateTypeLib2); > + > +hr = ICreateTypeLib2_CreateTypeInfo(ctl2, jsname, TKIND_DISPATCH, &cti); > +ok_ole_success(hr, ICreateTy

Re: vbscript/tests: Skip some of the weekday tests if the first day of the week is not Sunday.

On Wed, Oct 31, 2012 at 12:34:49PM +0100, Jacek Caban wrote: > Did you see those failures on Windows? test.winehq.org shows only some > Linux failures, which suggests that the problem is in implementation, > not tests. Hi Jacek, You're right. The current tests all pass on my Windows box with the

Re: ole32: Add CoGetDefaultContext stub

On Wed, Sep 19, 2012 at 09:09:55AM +0200, Michael Stefaniuc wrote: > > +/*** > > + * CoGetContextToken [OLE32.@] > copy and paste error ^^^ > > > + */ > > +HRESULT CoGetDefaultContext(APTTYPE type, REFIID riid, LPVOID *p

Re: localspl: Only store the file part of the filenames in the registry

On 16/05/2012 17:22, Detlef Riekenberg wrote: We have only filenames in the registry. The current code works fine with the adobe postscript driver and various other driver for PDF printers. No, the current code copies the entire contents of the DRIVER_INFO struct's filename entries - this isn'

Re: [1/2] gdi32: GetGlyphOutline should fail for a bitmap font.

On Sat, Apr 28, 2012 at 05:52:13PM +0900, Dmitry Timoshkov wrote: > --- > dlls/gdi32/freetype.c |6 ++ > dlls/gdi32/tests/font.c | 17 - > 2 files changed, 18 insertions(+), 5 deletions(-) This will break the display of bitmap fonts in winex11.drv . Do you have an app

Re: [2/2] gdi32: Enumerated font size should not be too large.

On 23/04/2012 16:07, Dmitry Timoshkov wrote: Huw Davies wrote: You'll need to fix the ntmTm.ntmCellHeight and ntmTm.ntmAvgWidth values. As far as I can see that code always have been that way, and reverted patch didn't touch it either. But I see your point, and will add the tests

Re: [2/2] gdi32: Enumerated font size should not be too large.

On 23/04/2012 15:32, Dmitry Timoshkov wrote: This reverts commit f4625d1ae1109ee9a30faa8254b10779853f0ac2. --- dlls/gdi32/freetype.c |2 +- dlls/gdi32/tests/font.c |1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index

Re: gdi32: Add support for emulating bold faces of bitmap fonts.

On Mon, Apr 16, 2012 at 05:51:20PM +0900, Dmitry Timoshkov wrote: > Huw Davies wrote: > > > Don't we need to add some bytes if glyph_width % 32 == 0 ? > > Well, I didn't see in my tests a need for that. That may be because your tests are just looking at the font m

Re: gdi32: Add support for emulating bold faces of bitmap fonts.

On Mon, Apr 16, 2012 at 04:37:39PM +0900, Dmitry Timoshkov wrote: > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index 0a5d3c3..eb3f9b5 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -5669,12 +5669,27 @@ static inline BYTE get_max_level( UINT format ) >

Re: (try 2)quartz: add control.idl as a typelib resource

On Thu, Apr 05, 2012 at 07:51:13AM -0500, Aric Stewart wrote: > > revised based on comments from Jacek Caban > --- > dlls/quartz/Makefile.in|1 + > dlls/quartz/control_v2.idl | 17 + > 2 files changed, 18 insertions(+), 0 deletions(-) > create mode 100644 dlls/quartz/co

Re: [PATCH 3/4] winspool/tests: Add some tests for OpenPrinter with non-NULL defaults.

On Tue, Apr 03, 2012 at 12:50:18PM +0200, Marvin wrote: > === WINEBUILD (build) === > Can't determine base name A winspool vs winspool.drv thing perhaps? Huw.

Re: gdi32: Add support for loading scalable font resources.

On Fri, Mar 30, 2012 at 07:31:54PM +0900, Dmitry Timoshkov wrote: > Huw Davies wrote: > > > +if (size.u.LowPart < sizeof( *dos )) goto fail; > > Testing LowPart only could not work for large sizes. Of course, but we don't care if very large files fail, they won&#

Re: 80135: [PATCH 05/10] gdi32: Implement SetPixel.

On Wed, Oct 19, 2011 at 07:04:02AM -0700, Dan Kegel wrote: > Sounds like your temporary todo_wine didn't quite do the trick...? Ah, I see. I was getting a failure on 111 and not 104, presumably due to different XServers. Anyway they all pass again after the entire series is applied. Huw.

Re: 80135: [PATCH 05/10] gdi32: Implement SetPixel.

On Wed, Oct 19, 2011 at 06:46:49AM -0700, Dan Kegel wrote: > Patches 5-7 failed on WINEDEBUG=warn+heap here: > > ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p > gdi32_test.exe.so palette.c && touch palette.ok > ... > palette.c:104: Test failed: getColor=0028 > > Might be flaky

Re: patch for dlls/gdi32/dib.c: fixes crash

On Thu, Jul 28, 2011 at 04:14:56PM +0200, Wolfgang Walter wrote: > I think that > > bitmapinfo_from_user_bitmapinfo() > > is the real culprit. I think colors gets to big (> 256) and therefore the > size > for the memcpy. Hopefully http://source.winehq.org/patches/data/77076 should fix th

Re: Statur of DIB Engine

On Sun, Jul 24, 2011 at 07:10:46PM +0300, Octavian Voicu wrote: > Disclaimer: these comments are based only on what I gather from > following commits and looking at the code, so can't guarantee it's > 100% accurate; Huw or Alexandre would know better. This is a good summary of where we're at - nic

Re: ole32/ole2: Don't call IDropTarget::QueryInterface() in RegisterDragDrop(). [whitespace fixed]

On Thu, May 26, 2011 at 06:51:13AM -0500, Adam Martinson wrote: > On 05/26/2011 06:47 AM, Huw Davies wrote: > >On Wed, May 25, 2011 at 12:45:15PM -0500, Adam Martinson wrote: > >>On 05/25/2011 12:36 PM, Adam Martinson wrote: > >>>The AddRef is done in WrapDropTarget

Re: ole32/ole2: Don't call IDropTarget::QueryInterface() in RegisterDragDrop(). [whitespace fixed]

On Wed, May 25, 2011 at 12:45:15PM -0500, Adam Martinson wrote: > On 05/25/2011 12:36 PM, Adam Martinson wrote: > >The AddRef is done in WrapDropTarget(), seems like the appropriate > >place for it. Quite right on the rest though, thanks. > > Oops no, the window prop should be pDropTarget, not th

Re: ole32/ole2: Don't call IDropTarget::QueryInterface() in RegisterDragDrop(). [whitespace fixed]

> +static IDropTarget* WrapDropTarget(IDropTarget* inner) > +{ > +DropTargetWrapper* This = HeapAlloc(GetProcessHeap(), 0, sizeof(*This)); > + > +if (This) > +{ > +This->iface = (IDropTarget){ &DropTargetWrapper_VTbl }; This->iface.lpVtbl = &DropTargetWrapper_VTbl; > - hr = C

Re: gdi32/dibdrv: The dib debug channel is unused so remove it.

On Sun, Apr 10, 2011 at 06:45:51PM +0200, Francois Gouget wrote: > It might get used soon but then it's easy to add back anyway. Very soon in fact - it gets used in the PatBlt patch I just sent ;-)

Re: gdi32/tests: Start of a framework for writing dib driver tests.

On Tue, Apr 05, 2011 at 03:31:23PM +0100, Huw Davies wrote: > > Try2. Using the A_SHA functions to generate the hashes. Although somewhat neater than the first version it doesn't work on nt4/win2k as they don't export these functions. So we're better off using the original. Huw.

Re: [PATCH 2/5] shdocvw: Added IShellBrowser interface stub

On Mon, Mar 14, 2011 at 05:03:37PM +0100, Piotr Caban wrote: > +static HRESULT WINAPI ShellBrowser_QueryInterface( > +IShellBrowser* iface, > +REFIID riid, > +void **ppvObject) > +{ > +ShellBrowser *This = impl_from_IShellBrowser(iface); > +*ppvObject = NULL; > + > +

Re: oleaut32: Implement ITypeInfo_GetNames Stub/Proxy (resend)

On Tue, Feb 22, 2011 at 09:02:38PM +1100, Alistair Leslie-Hughes wrote: > >From 6aa7bfa0c06b746ee64daf56f2b02e6f38542d54 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes > Date: Fri, 18 Feb 2011 12:04:56 +1100 > Subject: [PATCH] Implement ITypeInfo_GetNames Stub/Proxy > To: wine-patches >

Re: widl: Added support for registering alternative progids.

On Fri, Dec 17, 2010 at 04:14:24PM +0100, Jacek Caban wrote: > diff --git a/tools/widl/parser.y b/tools/widl/parser.y > index c924a66..28cb1da 100644 > --- a/tools/widl/parser.y > +++ b/tools/widl/parser.y > @@ -190,7 +190,7 @@ static statement_list_t > *append_statement(statement_list_t *list, st

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword

On Wed, Sep 15, 2010 at 01:34:06PM +0200, Marcus Meissner wrote: > On Wed, Sep 15, 2010 at 12:22:57PM +0100, Huw Davies wrote: > > On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote: > > > Marcus Meissner wrote: > > > > > > > + if (!unk) { &

Re: [PATCH] ole32: check for interface NULL which happens with e.g. Abiword

On Wed, Sep 15, 2010 at 08:04:51PM +0900, Dmitry Timoshkov wrote: > Marcus Meissner wrote: > > > + if (!unk) { > > + FIXME("hr was %d, but unk is NULL?\n", hr); > > + return E_FAIL; > > + } > > IDropTarget_QueryInterface() should be fixed instead. The implementation is in abiword, s

Re: Use SUBLANG_NEUTRAL for the Gaelic resources?

On Tue, Aug 24, 2010 at 09:59:51AM +0200, Francois Gouget wrote: > > Are SUBLANG_GAELIC, SUBLANG_GAELIC_SCOTTISH and SUBLANG_GAELIC_MANX very > different languages? > > If not it would be better to use SUBLANG_NEUTRAL instead of > SUBLANG_GAELIC. For instance: I think they're different enough

Re: ole32: Implement cross-process drag and drop.

On Mon, Jul 19, 2010 at 04:42:40PM +0100, Huw Davies wrote: > Fix a typo in a comment spotted by Detlef. > --- > dlls/ole32/ole2.c | 199 > 1 files changed, 168 insertions(+), 31 deletions(-) Sorry, this is still broken, please ignore. Huw.

Re: ole32: Implement cross-process drag and drop.

On Mon, Jul 19, 2010 at 01:58:07PM +0100, Huw Davies wrote: > --- > dlls/ole32/ole2.c | 199 > 1 files changed, 168 insertions(+), 31 deletions(-) Please use the updated version which has fixed a typo in a comment (spotted by Detlef).

Re: sane.ds: Change "ns" to "ms" in resource files

On Wed, Jul 07, 2010 at 11:45:59AM +0100, Ken Sharp wrote: > On 7/7/2010 11:39 AM, Huw Davies wrote: >> On Wed, Jul 07, 2010 at 11:28:21AM +0100, Ken Sharp wrote: >>> On 7/7/2010 10:30 AM, Alexandre Julliard wrote: >>>> Ken Sharp writes: >>>> >>

Re: sane.ds: Change "ns" to "ms" in resource files

On Wed, Jul 07, 2010 at 11:28:21AM +0100, Ken Sharp wrote: > On 7/7/2010 10:30 AM, Alexandre Julliard wrote: >> Ken Sharp writes: >> >>> Apparently the English resource file should show "ms" (microseconds) >>> instead of "ns". This error has been copied too all the .rc files. >> >> "ms" doesn't m

Re: sane.ds: Add Welsh resource

On Mon, Jul 05, 2010 at 06:51:36PM +0100, Ken Sharp wrote: > +{ > + 0 "" > + 1 "px" > + 2 "b" /* What is "b" ? */ > + 3 "mm" > + 4 "dpi" /* dotiau fesul modfedd */ > + 5 "%" > + 6 "ns" /* What is "ns" ? */ > +} See the SANE_UNIT_ defines in /usr/include/sane/sane.h 'b' is bits and 'ns' should be

Re: [PATCH 2/5] include: Add IEnumShellItems interface declaration.

On 11 Jun 2010, at 12:17, David Hedberg wrote: --- dlls/actxprxy/usrmarshal.c | 21 + include/shobjidl.idl | 30 ++ 2 files changed, 51 insertions(+), 0 deletions(-) diff --git a/dlls/actxprxy/usrmarshal.c b/dlls/actxprxy/usrmarshal.c ind

Re: IDL trouble (patch: adding IEnumShellItems interface declaration.)

On 11 Jun 2010, at 02:42, David Hedberg wrote: Hello everyone, I'm having some trouble with this simple patch. Specifically, it breaks compiling of dlls/actxprxy, producing the message: * /home/david/Projects/wine/git/dlls/actxprxy/actxprxy_shobjidl_p.c: 6507: undefined reference to

Re: rpcrt4: Add tests for multi-dimensional conformant arrays.

On Fri, Feb 12, 2010 at 11:27:38AM +, Huw Davies wrote: > On Fri, Feb 12, 2010 at 11:53:30AM +0100, Paul Vriens wrote: > > On 02/11/2010 05:18 PM, Huw Davies wrote: > >> +ptr = NdrSimpleStructMarshall(&StubMsg, (unsigned char *)&memsrc, > >> +&fmt

Re: rpcrt4: Add tests for multi-dimensional conformant arrays.

On Fri, Feb 12, 2010 at 11:53:30AM +0100, Paul Vriens wrote: > On 02/11/2010 05:18 PM, Huw Davies wrote: >> +ptr = NdrSimpleStructMarshall(&StubMsg, (unsigned char *)&memsrc, >> +&fmtstr_complex_array[32] ); > > Hi Huw, > > This particular test crashe

Re: shell32: Dynamically load an ordinal only export.

On Fri, Jan 22, 2010 at 02:51:04PM +0100, Alexandre Julliard wrote: > Huw Davies writes: > > > On Fri, Jan 22, 2010 at 02:01:03PM +0100, Alexandre Julliard wrote: > >> Huw Davies writes: > >> > >> > --- > >> > dlls/shell32/tests/shlfileop.

Re: shell32: Dynamically load an ordinal only export.

On Fri, Jan 22, 2010 at 02:01:03PM +0100, Alexandre Julliard wrote: > Huw Davies writes: > > > --- > > dlls/shell32/tests/shlfileop.c | 18 +- > > 1 files changed, 9 insertions(+), 9 deletions(-) > > This shouldn't be needed, import b

Re: Patch feedback requested for OleCreatePropertyFrame()

On Sun, Jan 03, 2010 at 03:00:12PM -0800, Geoffrey Hausheer wrote: > I found a patch from 2001 written by TAKESHIMA Hidenori that > was posted to wine-patches > (http://www.winehq.org/pipermail/wine-patches/2001-October/001229.html) > but never committed. Actually it was commited (2843934af5515c7f

Re: gdiplus: Fix a memory leak in the tests.

On Tue, Dec 15, 2009 at 02:40:26PM +0300, Nikolay Sivov wrote: > On 12/15/2009 14:35, Huw Davies wrote: >> Found by Valgrind. >> --- >> dlls/gdiplus/tests/customlinecap.c |1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) > Hi, Huw. > > Th

Re: ole32: Fix invalid memory access in storage32

Nathan Gallaher wrote: In StorageImpl_construct(): For pwcsName strings shorter than DIRENTRY_NAME_BUFFER_LEN-1, an invalid read would be noted by valgrind as the memcpy wanders off the end of the string. Do the needful to calculate the required string length. By the way, in storage32.h the f

Re: oledb32: Implement CanConvert.

On Mon, Sep 21, 2009 at 03:36:21PM +0200, Marcus Meissner wrote: > On Mon, Sep 21, 2009 at 01:50:51PM +0100, Huw Davies wrote: > > +if(src_type & DBTYPE_VECTOR || dst_type & DBTYPE_VECTOR) return > > S_FALSE; > > I think this needs brackets... Why? It&#x

Re: winetest: Add the ability to retrieve the dll path for com dlls from the registry.

Paul Vriens wrote: The attached patch fixes the issue. We are using LOAD_LIBRARY_AS_DATAFILE as we don't really want to load the dll but we need some info from it. The problem is that GetModuleFileName can't cope with LOAD_LIBRARY_AS_DATAFILE loaded dlls. So will using LoadLibrary introduce

Re: [PATCH 1/5] msdaps: Use 2 byte structure packing.

On Mon, Aug 24, 2009 at 01:51:24PM +0200, Alexandre Julliard wrote: > Huw Davies writes: > > > diff --git a/dlls/msdaps/Makefile.in b/dlls/msdaps/Makefile.in > > index d6f71a0..cebf659 100644 > > --- a/dlls/msdaps/Makefile.in > > +++ b/dlls/msdaps/Makefil

Re: msctf: fully clear the Variant before setting it.

On Wed, Jul 01, 2009 at 10:29:22AM -0500, Aric Stewart wrote: > diff --git a/dlls/msctf/compartmentmgr.c b/dlls/msctf/compartmentmgr.c > index 3afcfda..e1c7187 100644 > --- a/dlls/msctf/compartmentmgr.c > +++ b/dlls/msctf/compartmentmgr.c > @@ -537,6 +537,7 @@ static HRESULT WINAPI Compartment_GetV

Re: [PATCH 4/4] gdi32: Add tests for the GetWinMetaFileBits MFCOMMENT record.

On Tue, Jun 30, 2009 at 12:40:54PM +0200, Paul Vriens wrote: > Huw Davies wrote: >> --- >> dlls/gdi32/tests/metafile.c | 80 >> +++ >> 1 files changed, 80

Re: oleaut32/tests: Add some tests for [lcid] parameters.

On Wed, Jun 17, 2009 at 03:58:33PM +0200, Paul Vriens wrote: > Huw Davies wrote: >> --- >> dlls/oleaut32/tests/tmarshal.c | 53 >> +++- >> dlls/oleaut32/tests/tmarshal.idl |6 +++ >> dlls/oleaut32/tests/tmarsh

Re: ntdll/tests: Mark return value of RtlUnicodeStringToInteger("", 16) as broken for nt4.

On Tue, May 19, 2009 at 03:39:07PM +0200, Alexandre Julliard wrote: > Paul Vriens writes: > > > I don't think this is correct. This test has always succeeded until > > March 9th. There haven't been any changes to the test in that period, > > but I remember an upgrade of winehq in that weekend. >

Re: [2/2] winex11.drv: export copied images as image/bmp

On Fri, May 01, 2009 at 01:25:33PM +0200, Alexandre Julliard wrote: > "Vincent Povirk" writes: > > > +if (dibinfo->biBitCount < 16) > > +numcolors = dibinfo->biClrUsed || 1 > You have been doing too much Perl ;-) Hi Vincent, You may find bitmap_info_size() useful here

Re: [PATCH 1/2] ole32: Register the clipboard formats at load time.

On Thu, Apr 23, 2009 at 03:40:11PM +0200, Alexandre Julliard wrote: > Huw Davies writes: > > > --- > > dlls/ole32/clipboard.c | 54 > > + > > dlls/ole32/compobj.c |2 + > > dlls/ole32/compobj_priva

Re: [PATCH 5/5] user32/tests: Fix tests on win9x.

On Tue, Apr 21, 2009 at 11:34:04AM +0200, Paul Vriens wrote: > Huw Davies wrote: >> On Tue, Apr 21, 2009 at 11:22:29AM +0200, Paul Vriens wrote: >>> Huw Davies wrote: >>>> --- >>>> dlls/user32/tests/clipboard.c |7 +-- >>&

Re: [PATCH 5/5] user32/tests: Fix tests on win9x.

On Tue, Apr 21, 2009 at 11:22:29AM +0200, Paul Vriens wrote: > Huw Davies wrote: >> --- >> dlls/user32/tests/clipboard.c |7 +-- >> 1 files changed, 5 insertions(+), 2 deletions(-) >> >> >> ---

Re: Problem with compiling ole32 crosstest

On Fri, Feb 13, 2009 at 02:01:35PM +0300, Vitaly Perov wrote: > Hi! > > Does anybody have a problem compilling the crosstest of ole32? > Or maybe it's only my fault? > > I have: > usrmarshal.cross.o: In function `func_usrmarshal': > /srv/vitperov/Projects/wine-dev/dlls/ole32/tests/usrmarshal.c:44

Re: gdi32/tests: Use the ANSI text metrics so the tests work on win9x.

On Thu, Feb 12, 2009 at 01:40:54PM +0100, Paul Vriens wrote: > Huw Davies wrote: >> --- >> dlls/gdi32/tests/font.c | 20 ++-- >> 1 files changed, 10 insertions(+), 10 deletions(-) >> >> >> -

Re: Huw Davies : opengl/tests: Skip tests if we can't find a pixel format.

On Mon, Dec 08, 2008 at 01:44:41PM +0100, Alexandre Julliard wrote: > Huw Davies <[EMAIL PROTECTED]> writes: > > > Hi Alexandre, > > > > This wasn't what I intended my patch to do. The problem is that > > Wine's ChoosePixelFormat() rets 0 on XServe

Re: Huw Davies : opengl/tests: Skip tests if we can't find a pixel format.

On Fri, Dec 05, 2008 at 11:04:07AM -0600, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: e86ff2a3128f4a0157ecfa10fee31d1416312c71 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=e86ff2a3128f4a0157ecfa10fee31d1416312c71 > > Author: Huw Dav

Re: opengl/tests: Skip tests if we can't find a pixel format.

On Fri, Dec 05, 2008 at 03:25:56PM +0100, Paul Vriens wrote: > This looks a bit strange: > > +if(iPixelFormat == 0) > +{ > +todo_wine ok(iPixelFormat > 0, > > > Is it your intention to just throw up a failed message in all cases? Hi Paul, It was my intention to thro

Re: [RESEND] Send page size to cups with lpr command on printing (bug 15942)

Massimo Del Fedele wrote: > Steven Edwards ha scritto: >> On Wed, Nov 12, 2008 at 12:51 PM, Massimo Del Fedele <[EMAIL PROTECTED]> >> wrote: >>> The best way would be, of course, replace ALL LPR code with direct cups >>> calls. It's feasible, but it requires some refactoring of all printing >>> co

Re: inetcomm: Add an implementation of IVirtualStream.

On Fri, Nov 07, 2008 at 02:20:04PM +0100, Hans Leidekker wrote: > On Friday 07 November 2008 13:48:29 Huw Davies wrote: > > > This interface is undocumented but fortunately its name was enough > > > of a hint to create a sensible implementation. Used by Outlook when > >

Re: inetcomm: Add an implementation of IVirtualStream.

Hans Leidekker wrote: > This interface is undocumented but fortunately its name was enough > of a hint to create a sensible implementation. Used by Outlook when > retrieving or sending a mail. We already have MimeOleCreateVirtualStream() which is implemented on top of CreateStreamOnHGlobal()...

Re: ole32: implement IEnumFORMATETC_Next_Proxy (1/2) try 2

> +celt, rgelt, pceltFetched); That's still not right. It gives the impression that the 'return' is part of the 'if' block. The 'return' line should be indented by four spaces not eight. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: ole32: implement IEnumFORMATETC_Next_Proxy (1/2)

celt, > + rgelt, > + pceltFetched); There's some strange indentation going on here. Could you make it all 4-space based? Thanks, Huw. -- Huw Davies [EMAIL PROTECTED]

Re: gdi32: Add EMR_GDICOMMENT to the list of records producing output.

need more exhaustive tests here. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: gdi32: Add EMR_GDICOMMENT to the list of records producing output.

tion to something like emr_updates_transform() since EMR_GDICOMMENT clearly doesn't produce any output. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: ole32: quiet a ridiculously noisy fixme (resend)

; -FIXME(":stub\n"); > +static int quietfixme = 0; > +if (quietfixme == 0) { > +FIXME(":stub\n"); > +quietfixme = 1; > +} > return E_NOTIMPL; > } > The real implementation of this would actually result in fewer lines of code! See IEnumVARIANT_Next_Proxy / Stub (in oleaut32/usrmarshal.c) for an example. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: [PATCH 3/3] ole32: Call the appropriate storage function when we run the object.

On Wed, Oct 22, 2008 at 02:03:26PM +0100, Rob Shearman wrote: > 2008/10/22 Huw Davies <[EMAIL PROTECTED]>: > > On Wed, Oct 22, 2008 at 12:46:39PM +0100, Rob Shearman wrote: > >> 2008/10/21 Huw Davies <[EMAIL PROTECTED]>: > >> > @@

Re: [PATCH 3/3] ole32: Call the appropriate storage function when we run the object.

On Wed, Oct 22, 2008 at 12:46:39PM +0100, Rob Shearman wrote: > 2008/10/21 Huw Davies <[EMAIL PROTECTED]>: > > @@ -1728,6 +1767,10 @@ static HRESULT WINAPI > > DefaultHandler_IPersistStorage_HandsOffStorage( > > if(SUCCEEDED(hr) && objec

Re: oleaut32: Add support for loading typelibs from NE files.

On Wed, Sep 03, 2008 at 12:51:36PM +0100, Rob Shearman wrote: > 2008/9/2 Huw Davies <[EMAIL PROTECTED]>: > > --- a/dlls/oleaut32/typelib.c > > +++ b/dlls/oleaut32/typelib.c > > @@ -64,6 +64,7 @@ > > #include "winnls.h" > > #include "w

Re: [Gdiplus] Implement GdipCloneImage

> bitmap, > > GpStatus WINGDIPAPI GdipCloneImage(GpImage *image, GpImage **cloneImage) > { > +hr = OleLoadPicture(stream, size, FALSE, &IID_IPicture, > +(LPVOID*)(*cloneImage)->picture); This can't be right. You need to pass the address of the interface ptr. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: wininet: default to keep-alive when the server is HTTP/1.1, not when it isn't

Vincent Povirk wrote: > This is a fix to a problem I introduced in > fd5b97bc4d12adc69085b739061c56e9107f8d1f. The expression that checked > the HTTP version was true for HTTP/1.0 servers, and I treated it as if > it were true for HTTP/1.1 servers. That means we defaulted to keep-alive > for HTTP/1

Re: DIB engine status

not planning on doing any work on it for a while, but will probably return to it at some point in the future. Huw. -- Huw Davies [EMAIL PROTECTED]

DIB engine status

send me patches! Thanks, Huw. -- Huw Davies [EMAIL PROTECTED]

Re: [Gdiplus try3 02/16] Implement GdipCreateRegion

Adam Petaccia wrote: > On Tue, 2008-07-22 at 11:11 +0100, Huw Davies wrote: >>> +} RegionElement; >> It would be better to avoid the mixed upper/lower case names, since >> this makes it look like they're win32 api structures. Something like >> typedef stru

Re: [Gdiplus try3 02/16] Implement GdipCreateRegion

FlushIntention; > typedef enum CoordinateSpace CoordinateSpace; > Are you sure RegionType is in the win32 api? I can't find this is my gdiplusenums.h. If it isn't then it should be put in gdiplus_private.h (or even just in region.c if nothing else uses it) and renamed to enum region_type. Again, I think you'd be better off submitting a couple of patches at a time. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: [Gdiplus try2 02/16] Implement GdipCreateRegion

Adam Petaccia wrote: >@@ -226,6 +277,11 @@ GpStatus WINGDIPAPI GdipSetEmpty(GpRegion*region) > > if(!(calls++)) > FIXME("not implemented\n"); >+TRACE("%p\n", region); >+ >+GdipDeleteRegion(region); >+GdipCreateRegion(®ion); >+region->node->type = RegionDataEmpty

Re: [Gdiplus 02/15] Implement GdipCreateRegion

Adam Petaccia wrote: > @@ -226,6 +277,11 @@ GpStatus WINGDIPAPI GdipSetEmpty(GpRegion*region) > > if(!(calls++)) > FIXME("not implemented\n"); > +TRACE("%p\n", region); > + > +GdipDeleteRegion(region); > +GdipCreateRegion(®ion); > +region->node->type = RegionD

Re: [Gdiplus 2/3] Add a test for a floating-point triangle

. that you noted in an earlier patch). As you've also noticed there are two ways of storing paths, if all the co-ords are short ints then they get stored that way and the 0x4000 bit of buf + 8 is set. Otherwise the co-ords are stored as floats. In addition, the 0x2000 bit of that same DWORD corresponds to the FillMode of the path. Anyway, good work! Huw. -- Huw Davies [EMAIL PROTECTED]

Re: [Gdiplus 11/15] Implement GdipCreateRegionRect

oring the data in a similar way to native gdiplus. Then you can go on to work on the bounds (which would appear to be non-trivial - good luck!). Huw. -- Huw Davies [EMAIL PROTECTED]

Re: [Gdiplus 11/15] Implement GdipCreateRegionRect

On Wed, Jul 09, 2008 at 11:58:23AM +0100, Huw Davies wrote: > This doesn't look right. See the GdipGetRegionData tests (and extend > them to add paths), these are supposed to help understanding how > regions are stored. It looks to me that a region is stored as a > sequence o

Re: [Gdiplus 11/15] Implement GdipCreateRegionRect

extend them to add paths), these are supposed to help understanding how regions are stored. It looks to me that a region is stored as a sequence of rects and paths that are combined with various CombineMode ops. I'll send a patch that adds paths to the test in a bit. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: [Gdiplus 07/15] Stub GdipFillRegion

this in the 'graphics' section of the gdiplus flat api, so I'd suggest it goes in graphics.c Huw. -- Huw Davies [EMAIL PROTECTED]

Re: gdiplus: Add a test to show that bitmap fonts aren't used for fontfamilies.

Adam Petaccia wrote: > On Tue, 2008-07-08 at 13:20 +0100, Huw Davies wrote: >> --- >> dlls/gdiplus/tests/font.c |7 +++ >> 1 files changed, 7 insertions(+), 0 deletions(-) > > On my Windows system I can't find MSSansSerif, only Microsoft Sans > Serif.

Re: user32: sizeof DDEPOKE and DDEDATA is six, which is probably not what is expected, so use offsetof instead.

James Hawkins wrote: > 2008/7/8 Huw Davies <[EMAIL PROTECTED]>: >> Fixes a todo_wine and a Valgrind warning. > > @@ -699,10 +699,7 @@ static HDDEDATA CALLBACK > server_ddeml_callback(UINT uType, UINT uFmt, HCONV hcon > > ptr = (LPSTR)DdeAccessData(hdata, &

Re: [Gdiplus 4/4] Implement GdipCloneImage

> +return Ok; > } > You can't simply copy an interface ptr like this. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: Gdiplus [1/3] Improve accuracy in calculating height

On Fri, Jun 27, 2008 at 03:27:44PM +0100, Huw Davies wrote: > On Fri, Jun 27, 2008 at 10:16:41AM -0400, Adam Petaccia wrote: > > --- a/dlls/gdiplus/font.c > > +++ b/dlls/gdiplus/font.c > > @@ -34,6 +34,7 @@ WINE_DEFAULT_DEBUG_CHANNEL (gdiplus); > > #include "gdi

  1   2   >