Re: [Bug 18786] patch

2009-06-17 Thread Guy Albertelli
Hi Juan, On Tue, 2009-06-16 at 08:51 -0700, Juan Lang wrote: > The patch is unfortunately incorrect. Hardcoding 1 as the instance > can't work in general. I don't know what the correct fix is offhand. > I also don't see how it's a partial revert, as the patch looks nothing > like the code before

[Bug 18786] patch

2009-06-15 Thread Guy Albertelli
Hello Juan, Could you look at bug 18786 and my suggested patch to get MINITAB working again. It is a partial revert of one of your patches from 6/25/08 (see comment #7). I have verified that the associated tests (dlls/inetmib1/tests/main.c) exercise that code both pre and post revert. However the

Re: (try2) [1/2] kernel32/tests: Add tests for CreateFile errors and opening volumes

2009-06-03 Thread Guy Albertelli
On Wed, 2009-06-03 at 17:44 +0200, Paul Vriens wrote: > Guy Albertelli wrote: > > Changelog: > >- Add tests to verify error codes returned for certain error cases. > >- Also add tests for opening volumes and handle the case where we do > > not have the

Re: (resend) [1/2] kernel32/tests: Add tests for CreateFile errors and opening volumes

2009-06-02 Thread Guy Albertelli
On Tue, 2009-06-02 at 13:17 +0200, Alexandre Julliard wrote: > Guy Albertelli writes: > > > +hFile = CreateFileA( filename, GENERIC_READ | GENERIC_WRITE, > > +FILE_SHARE_READ | FILE_SHARE_WRITE, > > +

Re: [2/2] kernel32: Fix GetVolumeNameForVolumeMountPointW to match Mountmgr

2009-05-12 Thread Guy Albertelli
On Sat, 2009-05-09 at 09:52 -0600, Vitaliy Margolen wrote: > Few nitpicks about your patch. > > Guy Albertelli wrote: > > > +/* is there space in the return variable ?? */ > > +if ((o1->SymbolicLinkNameLen

Re: try5 [1/4](resend) kernel32/tests: Add tests for GetVolumeInformationA and QueryDosDevice

2009-04-29 Thread Guy Albertelli
On Wed, 2009-04-29 at 18:42 +0200, Paul Vriens wrote: > Guy Albertelli wrote: > > Fixed memory leak and changed skip to win_skip in this patch. > > Add todo_wine as necessary so all tests pass. > > > > Changelog: > > - Enhance QueryDosDevice test for

Re: try4 [2/3] kernel32: Fix GetVolumeInformation[AW] to require trailing \

2009-04-15 Thread Guy Albertelli
On Wed, 2009-04-15 at 10:58 -0500, Austin English wrote: > On Tue, Apr 14, 2009 at 11:17 PM, Guy Albertelli wrote: > > MSDN and test verify the valid "root dirs" for GetVolumeInformation[AW] > > must end in trailing '\' and if not then return ERROR_INVALID_N

Re: try4 [1/3] kernel32/tests: Add tests for GetVolumeInformationA and QueryDosDevice

2009-04-15 Thread Guy Albertelli
On Wed, 2009-04-15 at 08:18 +0200, Paul Vriens wrote: > Guy Albertelli wrote: > > Fixed memory leak and changed skip to win_skip in this patch. > > > > Changelog: > > - Enhance QueryDosDevice test for attempting to return all devices. > > - Add tests for

Re: try2 [1/3] kernel32/tests: Add tests for GetVolumeInformationA and QueryDosDevice

2009-04-10 Thread Guy Albertelli
On Fri, 2009-04-10 at 08:31 +0200, Paul Vriens wrote: > Guy Albertelli wrote: > > Enhance QueryDosDevice test for attempting to return all devices. > > Add tests for GetVolumeInformationA testing the different root dir formats. > > --- > > dlls/ker

Re: [PATCH 00/10] Support for dumb picture keychain

2009-03-27 Thread Guy Albertelli
On Thu, 2009-03-26 at 10:08 +0100, Alexandre Julliard wrote: > Guy Albertelli writes: > > > 1. The initial problem was that the CreateFile above would not > > successfully translate the volume id to the associated Unix file. #3/10 > > fixed that. > > That sho

Re: [PATCH 00/10] Support for dumb picture keychain

2009-03-25 Thread Guy Albertelli
On Tue, 2009-03-24 at 11:32 +0100, Alexandre Julliard wrote: > Guy Albertelli writes: > > > 1/10 server: Implement FILE_NO_INTERMEDIATE_BUFFERING with O_DIRECT > > 2/10 kernel32/tests: First test for CreateFile on NT unique volume name > > 3/10 ntdll: Implement conver

Re: [PATCH] usp10: Use passed hdc instead of cached one for ScriptTextOut with test to check

2008-04-29 Thread Guy Albertelli
On Tue, 2008-04-29 at 11:12 +0200, Hans Leidekker wrote: > On Tuesday 29 April 2008 06:15:23 Guy Albertelli wrote: > > > Application does most of the Script... calls under one hdc then deletes it > > prior to calling the ScriptTextOut with the original hdc. > > Out of