Re: DIB Engine - Mostly fixed against test suite

2009-05-21 Thread Giuseppe Bilotta
On Wednesday 20 May 2009 00:13, Massimo Del Fedele wrote: > Well, it seems that the engine fixes some unrelated bugs too :-) > Bugs 15146 and 10408, as reported by a tester. > > BTW In a couple of weeks all (few) remaining failing tests should be fixed. > Then I'll try to optimize somehow the mix

Re: DIB Engine - first set of fixings agains wine test suite

2009-05-13 Thread Giuseppe Bilotta
On Thursday 14 May 2009 02:02, Massimo Del Fedele wrote: > I started fixing failures against test suite. > Most of bitmap ones are fixed, remaining are due > to still stubbed funcs. > > Now the problem is that it fixed also most todo_wines on bitmap suite > > As usual, on bug 421 page for wh

Re: [PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-23 Thread Giuseppe Bilotta
2009/4/23 Mikołaj Zalewski : >  Hi, >  I think it would be interesting to test what TB_GETBUTTONINFO returns as > iString for such a separator. That way we will know if the value is simply > ignored, or it's something more complicated. Forget what I said in my previous email. I was running the GET

Re: [PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-23 Thread Giuseppe Bilotta
2009/4/23 Mikołaj Zalewski : >  Hi, >  I think it would be interesting to test what TB_GETBUTTONINFO returns as > iString for such a separator. That way we will know if the value is simply > ignored, or it's something more complicated. You're definitely on to something here. Indeed, trying to get

Re: [PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-23 Thread Giuseppe Bilotta
On Thu, Apr 23, 2009 at 8:00 AM, Paul Vriens wrote: > Giuseppe Bilotta wrote: >> >> Trying to add a separator with an invalid pointer in iString to a >> toolbar works in Windows, showing that the field is ignored. > > Patches should only go to wine-patches unless you

[PATCH 2/2] comctl32/toolbar: skip iString field for separators

2009-04-22 Thread Giuseppe Bilotta
Some programs (e.g. Graphmatica 2.0f) forget to initialize the iString field for separators in toolbars. Windows copes with this smoothly, ignoring the field altogether. Do the same in Wine. --- dlls/comctl32/toolbar.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dll

[PATCH 1/2] comctl32/tests: test toolbar separator with uninitialized iString

2009-04-22 Thread Giuseppe Bilotta
Trying to add a separator with an invalid pointer in iString to a toolbar works in Windows, showing that the field is ignored. --- dlls/comctl32/tests/toolbar.c | 51 + 1 files changed, 51 insertions(+), 0 deletions(-) diff --git a/dlls/comctl32/tests/too

[PATCH] comctl32/toolbar.c: fix trace info for TOOLBAR_InternalInsertButtonsT

2009-04-22 Thread Giuseppe Bilotta
TOOLBAR_DumpTBButton should be invoked over the button currently being inserted, and not always over the first button. --- dlls/comctl32/toolbar.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/comctl32/toolbar.c b/dlls/comctl32/toolbar.c index cf54df7..851a5cc 1006