RE: Wine users with a CD-ROM drive, please test

2010-08-16 Thread Ge van Geldorp
> From: Joerg Hoehle > > There's no mention of win95/98 in the attachment so I assume these > were not included, or was that because there was no error? Right, they were not included. I ran into some problems trying to attach the .iso to those VMs and gave up. Win9x should die :-). Ge.

RFC: Fixing kernel32:locale tests on Vista and higher

2009-08-30 Thread Ge van Geldorp
There are quite a few failures in kernel32:locale on Vista+. The attached patch tries to address those. Although any comment on the patch is welcome, I'm particularly interested in feedback on the changes to test_FoldStringW() (the part that starts at "@@ -2081,43 +2136,49 @@ static void test_FoldS

RE: Crash in the mlang test

2009-06-23 Thread Ge van Geldorp
Hi Detlef, > The mlang tests where reordered and now it crashed on > on your Win98 machine with mlang.dll "4.72.3110.0". > > http://test.winehq.org/data/675e6e93b1d2b4555d05e311764510abf763d21d/98_gvg- w98/mlang:mlang.html > > Please send me the results for the test with: > set WINETEST_REPORT_SU

RE: [comctl32] Test request

2009-05-24 Thread Ge van Geldorp
Hi Nikolay, >From: Nikolay Sivov [mailto:bungleh...@gmail.com] > >Ge van Geldorp wrote: >>> From: Nikolay Sivov >>> >>> I've just prepared some simple MRU tests and I need test them on various >>> native platfoms - >>> >>&g

RE: [comctl32] Test request

2009-05-24 Thread Ge van Geldorp
> From: Nikolay Sivov > > I've just prepared some simple MRU tests and I need test them on various native platfoms - > tested only on xp sp2 so this one could be skipped. > > Could somebody do it? Your tests pass on my W2K, XP, W2K3, Vista and W2K8 machines, but I get crashes which were not there

RE: Getting my test for DrawIcon and DrawIconEx included

2009-05-07 Thread Ge van Geldorp
Hi Joel, > From: Joel Holdsworth > > Is there a reason why my patch (attached) hasn't been included yet? This > is my first patch, so maybe someone can help me get it in. You are aware that this patch introduces test failures on Windows 2000, Vista and 2008? See http://www.winehq.org/pipermail/wi

RE: Question about my user32 tests patch

2009-05-02 Thread Ge van Geldorp
Hi Joel, > From: Joel Holdsworth > > How do you deal with this problem, because presumably not every test > contributor has VMs ready to confirm the behaviour of 95, 98, ME, 2000, > XP and Vista. Do I submit the patch as-is, in the knowlege that it will > cause failures in old windows? Presumably

RE: [2/2] secur32/tests: Fix GetUserNameEx() tests (try 2)

2009-04-14 Thread Ge van Geldorp
Hi Paul, > From: Paul Vriens [mailto:paul.vriens.w...@gmail.com] > > I've added these to the tests to show that Windows crashes. This is thus > a test (although not run) for behavior. It just means that Windows > doesn't check the input parameters thoroughly and so we shouldn't > either. It wa

RE: [2/2] secur32/tests: Fix GetUserNameEx() tests (try 2)

2009-04-14 Thread Ge van Geldorp
Hi Paul, > From: Paul Vriens > > Why did you remove: > > -if (0) /* Crashes on Windows */ > -rc = pGetUserNameExW(NameSamCompatible, NULL, NULL); > - > > The point of these additions was to show/document that Windows crashes > when called like this. Because Alexandre told me for an

RE: [2/2] secur32/tests: Fix GetUserNameEx() tests

2009-04-11 Thread Ge van Geldorp
> From: Austin English [mailto:austinengl...@gmail.com] > > Shouldn't these be win_skip's? Another day that wasn't wasted because I learnt something new :-). Thanks, resubmitted. Ge.

RE: [2/3] secur32/tests: Add simple tests for GetUserNameExA/W() [try 2]

2009-04-11 Thread Ge van Geldorp
Hi Paul, > From: Paul Vriens [mailto:paul.vriens.w...@gmail.com] > Ge van Geldorp wrote: > > Try 2: Add buffer overflow tests > > > > Changelog: > > secur32/tests: Add simple tests for GetUserNameExA/W() > > > > --

RE: [2/3] secur32/tests: Add simple tests for GetUserNameExA/W() [try 2]

2009-04-09 Thread Ge van Geldorp
Hi Paul, > From: Paul Vriens [mailto:paul.vriens.w...@gmail.com] > > Ge van Geldorp wrote: > > Try 2: Add buffer overflow tests > > > > Changelog: > > secur32/tests: Add simple tests for GetUserNameExA/W() > > > >

Re: 'Interactive' tests on Windows 2003

2009-04-04 Thread Ge van Geldorp
From: "James Hawkins" > On Fri, Jun 13, 2008 at 8:40 AM, Francois Gouget wrote: > > > > Someone asked to check which tests require interaction when running in > > my Windows 2003 VM. However I cannot find the corresponding email (it > > might have been on irc), so I'm sending this data to the lis

Re: mshtml/tests: Fix tests on Windows

2009-04-01 Thread Ge van Geldorp
> From: Reece Dunn > 2009/4/1 Ge van Geldorp : > > Modify load_state only in ReadyState_Changed callback. > > > > Changelog: > > ?Fix tests on Windows > > > > --- > > ?dlls/mshtml/tests/htmldoc.c | ? 28 +++- > > ?1 fil

urlmon ftp protocol failures on Windows

2009-03-29 Thread Ge van Geldorp
Hi Jacek, I've been investigating the failures in the urlmon ftp protocol tests that show up on quite a few WinXP and higher machines. It seems to me that there is an inherent race condition in the test. The main thread waits in line 1822 until IInternetProtocolSink_Switch has been called. It will

Re: wintrust(3/3): Fix a couple tests on a variety of systems

2009-02-13 Thread Ge van Geldorp
> From: Alexandre Julliard > > Paul Vriens writes: > > > I sent out an email earlier to ask if we should include more > > information in the header of the report. We could use that > > information, if this change will be accepted by AJ, to > > limit the reporting only to boxes were we have a

RE: wintrust(2/3): Remove a couple tests that fail on a variety of systems (try 2)

2009-02-12 Thread Ge van Geldorp
> From: Paul Vriens [mailto:paul.vriens.w...@gmail.com] > > Paul Vriens wrote: > > Juan Lang wrote: > >> This removes the unused variables in the last version. > >> --Juan > >> > >> > >> > - > >> --- > >> > >> > > I think that t

user32:menu test

2009-02-09 Thread Ge van Geldorp
> From: Florian Köberle [mailto:flor...@fkoeberle.de] > > I ran the test 30 times using the same way you did without > any failure.I used a vm with 1 CPU assigned too. Installed > is a Windows XP with SP2. > > If I start the test twice so that two tests are running > parallel then I get test f

RE: First complete test run passing on a Windows platform

2009-01-30 Thread Ge van Geldorp
> From: Ge van Geldorp [mailto:g...@gse.nl] On Behalf Of 'Florian Köberle' Sorry, I messed up the headers. The previous message containing: > BTW, this causes failures also with my own fix applied (althoug only a > single failure instead of a bunch), so my own fix wasn

RE: First complete test run passing on a Windows platform

2009-01-30 Thread Ge van Geldorp
Florian, > From: Florian Köberle [mailto:flor...@fkoeberle.de] > How many cores do your processor have? > I have a dual core which might make the difference. I ran inside a VM that had 1 CPU assigned, so single core. > How exactly do you execute the tests? > I executed "../../../tools/runtest -

RE: First complete test run passing on a Windows platform

2009-01-30 Thread Ge van Geldorp
Hi Florian, > From: Florian Köberle [mailto:flor...@fkoeberle.de] > I think the main problem is that the thread might run > parallel with some other test code. > > That is why I would suggest to wait for the thread to finish > at the end of the test. > > I made a patch and attached it to this

RE: First complete test run passing on a Windows platform

2009-01-30 Thread Ge van Geldorp
> From: Reece Dunn [mailto:mscl...@googlemail.com] > > Do you know why you need to do a SetForegroundWindow there to > make the tests succeed? > Why is the input being sent to a different window? > Why does it vary from platform-to-platform and machine-to-machine? It's a timing issue. It doesn't

RE: First complete test run passing on a Windows platform

2009-01-30 Thread Ge van Geldorp
> From: Reece Dunn > > The Wine tests are now passing on a Windows XP machine > (http://test.winehq.org/data/4b27dfec939d131c9d7e09f97f14dfc7dabe8843/#group _XP). Actually, that was not the first time. On 20 Jan an XP machine passed: http://test.winehq.org/data/e9d8c9f572998054b1f9c386ea81a3570

RE: Ge van Geldorp : ole32/tests: Some Windows versions need the class to be registered.

2009-01-29 Thread Ge van Geldorp
> From: Rob Shearman [mailto:robertshear...@gmail.com] > > -error = RegCreateKeyEx(HKEY_CLASSES_ROOT, buffer, 0, NULL, 0, > > KEY_SET_VALUE, NULL, &hkey, > > +error = RegCreateKeyEx(HKEY_CURRENT_USER, buffer, 0, NULL, 0, > > KEY_SET_VALUE, NULL, &hkey, > > This appears to have cau

Re: d3d8/tests: Make tests pass on W2K8

2009-01-26 Thread Ge van Geldorp
Hi Henri, > From: Henri Verbeet > 2009/1/26 Ge van Geldorp : > > Changelog: > > d3d8/tests: Make tests pass on W2K8 > > > > >-ok(hr == D3D_OK || hr == D3DERR_INVALIDCALL, "IDirect3D8_CreateDevice failed with %#08x\n", hr); > >+

RE: msi/tests: Make tests pass for Windows Installer 3.0 [2/3]

2009-01-19 Thread Ge van Geldorp
> From: Austin English [mailto:austinengl...@gmail.com] > > Just do as we do in other tests: > ok(GetLastError == Error1 /* Win9X */ || > Error2 /* Win2K */ || > Error3 /* WinXP */... Not possible like that in this case since the error ch

Re: urlmon/tests: Fix protocol tests when proxy is configured

2009-01-19 Thread Ge van Geldorp
Hi Jacek, > From: Jacek Caban > Subject: Re: urlmon/tests: Fix protocol tests when proxy is configured > > Ge van Geldorp wrote: > > There is a large amount of proxy configurations possible on > > Windows (WPAD, proxy.pac, fixed proxy values), which might behave >

RE: msi/tests: Make tests pass for Windows Installer 3.0 [2/3]

2009-01-19 Thread Ge van Geldorp
Hi James, > From: James Hawkins [mailto:trui...@gmail.com] > > On Sun, Jan 18, 2009 at 3:38 PM, Ge van Geldorp wrote: > > I see different estimated size values for Windows Installer 2.x and > > 3.0 compared to 3.1 and later. > > > > Please don't remove

RE: winetest: make the wrapper immune to Ctrl-C

2009-01-17 Thread Ge van Geldorp
> From: Dylan Smith [mailto:dylan.ah.sm...@gmail.com] > > On Fri, Jan 16, 2009 at 6:21 PM, Ge van Geldorp wrote: > > > > The riched20:editor test seems to be sending Ctrl-C > > keystrokes to the wrong window on Windows. When running > > "winetest -q"

RE: rpcrt4/tests: NdrVaryingArrayUnmarshall() is broken on Windows

2009-01-12 Thread Ge van Geldorp
> From: Paul Vriens [mailto:paul.vriens.w...@gmail.com] > > It looks like we've had exceptions on anything but XP and > W2K3 for a long time. > The exceptions (as reported on test.winehq.org) for XP and > W2K3 started happening after the move to use winetest.exe > from test.winehq.org. I'm n

RE: rpcrt4/tests: NdrVaryingArrayUnmarshall() is broken on Windows

2009-01-12 Thread Ge van Geldorp
> From: Rob Shearman [mailto:robertshear...@gmail.com] > > 2009/1/12 Alexandre Julliard : > > "Ge van Geldorp" writes: > > > > > > Changelog: > > > NdrVaryingArrayUnmarshall() is broken on Windows > > > > If it's broke

WIDL and Windows rpcrt4

2009-01-07 Thread Ge van Geldorp
Hi Rob, Is WIDL supposed to generate code that's compatible with Windows RPCRT4.DLL? Because it appears this is currently not the case. When you look at http://test.winehq.org you'll see that the rpcrt4:server test fails on pretty much any Windows version. I investigated a bit more, the failures

Re: Race in thread shutdown in imm32?

2008-11-15 Thread Ge van Geldorp
> From: "Rob Shearman" <[EMAIL PROTECTED]> > > I believe that Windows terminates all threads on process > exit It does, see http://blogs.msdn.com/oldnewthing/archive/2007/05/03/2383346.aspx

RE: Some feedfack for string {\style} on msi

2008-06-08 Thread Ge van Geldorp
> I am trying to fix the bug 13408 related with ActiveSync, but > i need some information of how and when appear the string > {\style} on msi. > I need some specification or url for begin. Try http://msdn.microsoft.com/en-us/library/aa367524(VS.85).aspx (or search for "Adding Controls and Text")

RE: shell32: Support getting the shell folder path for users other than the current user and the default user [resend]

2008-01-24 Thread Ge van Geldorp
> From: Alexandre Julliard [mailto:[EMAIL PROTECTED] > > "Ge van Geldorp" <[EMAIL PROTECTED]> writes: > > > +if (! CopySid(SidSize, Sid, UserInfo->User.Sid)) > > +{ > > +HeapFree(GetProcessHeap(), 0, Sid); > > +

RE: DIB Engine & GSoC

2007-03-02 Thread Ge van Geldorp
> If I understand it correctly, there was an idea floating > around that Ge van Geldorp had which was to auto generate the > needed DIB engine code for certain color depths and functions > so you would not have to implement the whole thing at once. > if I remember correctly he

RE: compiling wine for amd64 on ubuntu dapper 6.06

2006-10-02 Thread Ge van Geldorp
nGL setup: > configure: WARNING: No OpenGL library found on this system. I found the easiest way around this problem is to run configure using --without-opengl. I doubt OpenGL is very useful at the moment for 64-bit Wine anyway. Ge van Geldorp.

RE: Patchwork (was Re: Governance revisited)

2006-09-28 Thread Ge van Geldorp
> From: Jakob Eriksson [mailto:[EMAIL PROTECTED] > > I have been watching this thread with keen interest. > > Alexandre does not HAVE to respond to that patch, he can > silently ignore it just like he can now. > > The only difference with Patchwork would be that after a > certain time with no

RE: Patchwork (was Re: Governance revisited)

2006-09-28 Thread Ge van Geldorp
unicated back to the author. Focusing solely on review doesn't solve the problem of patches getting lost either. Ge van Geldorp.

Re: Patchwork (was Re: Governance revisited)

2006-09-28 Thread Ge van Geldorp
objective is to improve Wine by maximizing the number of patches of acceptable quality. In my opinion, this can be done by: 1) assuring no patches get lost 2) assuring an author gets informed about why his patch is not acceptable in its current form so he can improve it. Ge van Geldorp.

RE: Patchwork (was Re: Governance revisited)

2006-09-27 Thread Ge van Geldorp
has to look at a patch twice before sending a reply. Not to mention the time it costs the author. Shouldn't we be looking at the productivity of everyone involved in Wine development and not just at Alexandres productivity (although I acknowledge his special position)? I'm a bit surpri

Re: Patchwork (was Re: Governance revisited)

2006-09-27 Thread Ge van Geldorp
e list of pending patches, repeat. > and how it would be different from what we are doing now. It would make sure the author always receives some kind of feedback (either from the bot, other developers or yourself) and would make sure patches don't get lost (patches are automatically entered into the system and only leave the system when the author withdraws them or when you make a final decision). Ge van Geldorp.

Re: Governance revisited (Wineconf report)

2006-09-25 Thread Ge van Geldorp
> From: Kai Blin > > Now, getting back to the patch submission process, you're talking about a > patch management system. How would that look like, in your opinion. We were > discussing a couple of ideas, but in the end figured that most of those would > slow down the submission speed of patches

Re: Governance revisited

2006-09-25 Thread Ge van Geldorp
27;m not going to beg for an explanation. If the Wine community can't be bothered to provide feedback I can't be bothered to resubmit. After all, I've already scratched my itch, the bug is already fixed in my tree, it's the communities loss, not mine. Ge van Geldorp

Re: Governance revisited (Wineconf report)

2006-09-24 Thread Ge van Geldorp
on't disappear into the big void) because Alexandre refuses to use it if it won't work in Emacs I'm starting to wonder if people realise that the developers don't work for Alexandre. He's a great Benovelent Dictator on technical issues, but in my opinion only a Dictator on patch process management. Ge van Geldorp.

RE: Win64 patch 3/6 (resend)

2006-07-25 Thread Ge van Geldorp
I'm not sure what you want changed in request_send_message to make it fit in 64 bytes? Ge van Geldorp.

RE: Win64 patch 3/6 (resend)

2006-07-25 Thread Ge van Geldorp
> From: Dmitry Timoshkov [mailto:[EMAIL PROTECTED] > > What exactly size is required then to avoid an assert? This is the assert: assert( sizeof(union generic_request) == sizeof(struct request_max_size) ); So the way the assert is written now "struct request_max_size" should have a size exactl

RE: Win64 patch 3/6 (resend)

2006-07-24 Thread Ge van Geldorp
> From: Dmitry Timoshkov [mailto:[EMAIL PROTECTED] > > "Ge van Geldorp" <[EMAIL PROTECTED]> wrote: > > > --- a/include/wine/server_protocol.h > > +++ b/include/wine/server_protocol.h > > @@ -33,6 +33,9 @@ struct reply_header > > struct req

RE: winnt32.exe on AMD64

2006-07-18 Thread Ge van Geldorp
> From: Boaz Harrosh > > Why not compile the all of Wine as PE with a GCC > cross-compiler (MinGW), But for the 3 low level DLL's. In > effect a ReactOS system and Makefiles (On a Linux kernel). > Sure we will maybe want an alternate system for > Builtin/Native, maybe different system folder

RE: winnt32.exe on AMD64

2006-07-17 Thread Ge van Geldorp
> From: Troy Rollo [mailto:[EMAIL PROTECTED] > > These are complications rather than impenetrable barriers. > Wine->Wine (and Winelib App->Wine) calls would not need to go > through the thunks. Many of the issues involved have already > been dealt with for 16<->32 thunking and cross-process CO

RE: winnt32.exe on AMD64

2006-07-17 Thread Ge van Geldorp
ables. Some more info on the Wine64 wiki page http://wiki.winehq.org/Wine64 Ge van Geldorp.

RE: Win64 patch 3/9 (user32)

2006-07-12 Thread Ge van Geldorp
> From: Alexandre Julliard [mailto:[EMAIL PROTECTED] > > Ge van Geldorp <[EMAIL PROTECTED]> writes: > > > Changelog: > > Ge van Geldorp <[EMAIL PROTECTED]> > > - Move handle indicator to upper 32 bits for Win64 > > Why do you need this

RE: include/msvcrt: Make sure size_t is properly defined for 64-bit.

2006-07-10 Thread Ge van Geldorp
dd -D_WIN64 to EXTRACFLAGS in dlls/Makedll.rules and programs/Makeprogs.rules. This would mimic the behaviour of MSVC better (it has _WIN64 predefined). Ge van Geldorp.

RE: include/msvcrt: Make sure size_t is properly defined for 64-bit.

2006-07-07 Thread Ge van Geldorp
> From: Ge van Geldorp [mailto:[EMAIL PROTECTED] > > Yes, this works fine, both with and without the change to > include/msvcrt/string.h. Sorry, I only tested dlls/msvcrt. When doing a full rebuild I get errors, will investigate and let you know. Ge.

RE: include/msvcrt: Make sure size_t is properly defined for 64-bit.

2006-07-07 Thread Ge van Geldorp
h > @@ -37,8 +37,6 @@ > #ifndef __WINE_MSVCRT_H > #define __WINE_MSVCRT_H > > #include > -#include > -#include > > #include "windef.h" > #include "winbase.h" Yes, this works fine, both with and without the change to include/msvcrt/string.h. Best regards, Ge van Geldorp.

Re: include/msvcrt: Make sure size_t is properly defined for 64-bit.

2006-07-06 Thread Ge van Geldorp
> diff --git a/include/msvcrt/string.h b/include/msvcrt/string.h > index a821aa2..cc0b25e 100644 > --- a/include/msvcrt/string.h > +++ b/include/msvcrt/string.h > @@ -18,8 +18,18 @@ typedef unsigned short wchar_t; > #endif > #endif > > +#ifndef _MSC_VER > +# ifndef __int64 > +# define __int64

RE: Win64 patch 1/5 (configure)

2006-07-05 Thread Ge van Geldorp
nvestigate something else please let me know. Ge van Geldorp.

RE: Win64 patch 1/5 (configure)

2006-07-03 Thread Ge van Geldorp
> From: Alexandre Julliard [mailto:[EMAIL PROTECTED] > > > Changelog: > > Ge van Geldorp <[EMAIL PROTECTED]> > > - Allow relocation on x86_64 > > Is that really needed for Win64? And if so, shouldn't it use > a more appropriate address? The sta

RE: Win64 patch 3/5 (winedbg)

2006-07-01 Thread Ge van Geldorp
> From: Eric Pouech [mailto:[EMAIL PROTECTED] > > this one is questionnable. Now that we have stackwalk64 > implemented (I'm not saying it works flawlessly on 64bit > machines), it may be more interesting here to use the 64 bit > version of the call back That's actually a separate issue. The

RE: Win64 patch 1/13

2006-06-20 Thread Ge van Geldorp
> From: Mike McCormack [mailto:[EMAIL PROTECTED] > > > Except that dlls/ntdll/tests/generated.c was hand-modified. > > That would explain the rather large diff that I saw when I > regenerated these tests :/ Sorry, I mixed up two files :( I have no evidence that dlls/ntdll/tests/generated.c was

RE: Win64 status

2006-06-19 Thread Ge van Geldorp
as it's > done, in addition to posting it here. Note that the only way > for me to test it would be to inspect the assembly output, as > I'm not running 64 bit environment here (even though I'm on a > 64 bit AMD processor). So it'd need testing from 64 bit > people here at least. I'm volunteering. I could also give you ssh access to a 64 bit environment. Ge van Geldorp.

CVS server

2006-06-19 Thread Ge van Geldorp
> From: Mike McCormack [mailto:[EMAIL PROTECTED] > > I think you're a bit behind the times: > > http://cvs.winehq.org/cvsweb/wine/dlls/mapi32/mapi32_main.c.diff?r1=1.13&r2= 1.14 > http://cvs.winehq.org/cvsweb/wine/dlls/user/user32.spec.diff?r1=1.114&r2=1.1 15 Indeed... Being on the European side

RE: Win64 patch 1/13

2006-06-19 Thread Ge van Geldorp
> From: Mike McCormack [mailto:[EMAIL PROTECTED] > > Ge van Geldorp wrote: > > > +SPEC_SRC32 = $(BASEMODULE).spec > > +SPEC_SRC64 ?= $(SPEC_SRC32) > > Not sure we want seperate spec files. In any case, ?= > doesn't look portable. I don't want t

Win64 status

2006-06-19 Thread Ge van Geldorp
With the Win64 patches I just submitted to wine-patches, I'm able to successfully build Win64-enabled Wine and execute the following 64-bit winelib (winelib64? wine64lib?) application: #include "windows.h" int WINAPI WinMain(HINSTANCE hinst, HINSTANCE hprev, LPSTR cmdline, int cmdshow) { DWORD

RE: Unixfs as ShellFSFolder?

2006-01-17 Thread Ge van Geldorp
> From: Michael Jung > > What do people think about getting rid of shfldr_fs.c in the > long run, in order to remove the redundancy? Does ReactOS use > wine's shell32.dll? I guess it would be a problem for them? Yes, we do and yes, it would be a problem... We don't import the shfldr_unixfs.c fi

RE: Repackaging Mozilla ActiveX control to include MSVCP60.DLL?

2006-01-15 Thread Ge van Geldorp
> From: Boaz Harrosh > > Hi! I was Just wondering. Is there at all a MinGW build > system for the "Mozilla ActiveX control"? I guess not so the > Question is: > Any body knows what are the Main hurdles for that? Is that mainly COM > TLB(s) related? or there are other problems? I've built Firefo

RE: Repackaging Mozilla ActiveX control to include MSVCP60.DLL?

2006-01-15 Thread Ge van Geldorp
> From: Dan Kegel > > The Mozilla ActiveX control download feature is cool and all, but > until we repackage the sucker to include MSVCP60.DLL to fix > http://bugs.winehq.org/show_bug.cgi?id=4064 > it's going to leave a lot of users scratching their heads as to why it > keeps asking where its fi

RE: STATUS_* definitions

2005-11-27 Thread Ge van Geldorp
> From: Vitaliy Margolen > > Saturday, November 26, 2005, 10:34:22 AM, Ge van Geldorp wrote: > > As proposed here: > > http://www.winehq.org/pipermail/wine-devel/2005-November/042583.html > > I didn't receive any replies, which I'll take as a "no o

NTSTATUS values in ntstatus.h and winnt.h

2005-11-20 Thread Ge van Geldorp
The PSDK defines some NTSTATUS values in both ntstatus.h and in winnt.h, guarded by "#ifndef WIN32_NO_STATUS". Unfortunately, the definitions in the PSDK are not equivalent. In ntstatus.h: #define STATUS_xxx ((NTSTATUS) 0x) In winnt.h: #define STATUS_xxx ((DWORD) 0x) The Wine he

RE: wine / Linux kernel, TWAIN and STI: explained

2005-10-21 Thread Ge van Geldorp
ked another component, widl, at Wine-20050628). Of course, our changes are available to Wine, I'd be happy to work with one of you guys to get the Wine/ReactOS versions back in sync. BTW, I'm the guy who usually merges the Wine changes into the ReactOS tree after a Wine release. Ge van Geldorp.

RE: IDE disk geometry

2005-09-20 Thread Ge van Geldorp
istry, I don't think that's very likely (and it would be driver-dependent). That doesn't mean that Wine can't store the info where it pleases (e.g. in the registry). Ge van Geldorp.

ShellExecuteExW

2005-09-08 Thread Ge van Geldorp
is messed up. Fixing this allowed one of the todo tests to succeeed. Since looking at/tracing through the ShellExecuteEx code makes me scream in agony every time, I would appreciate a review of the patch below. Ge van Geldorp. Index: dlls/shell32/cpanelfolder.c

RE: wine/dlls/shell32 shresdef.h shres.rc shfldr_u ...

2005-09-07 Thread Ge van Geldorp
Michael, > I'm aware of this problem (though I didn't know about the > exact numbers). > There was a short discussion on wine-devel about it: > > http://www.winehq.org/pipermail/wine-devel/2005-August/039452.html I actually read the discussion but didn't make the connection when looking at th

RE: BUG[1481] : unimplemented function msvcrt.dll._mbsbtype

2005-08-30 Thread Ge van Geldorp
> From: Jesse Allen > > Quick question. Does React OS or DJGPP include a portable > implementation of printf in msvcrt? I tried looking using > your source browser but I could not tell where it is actually located. It's in lib/crt/stdio (http://svn.reactos.com/viewcvs/trunk/reactos/lib/crt/st

RE: BUG[1481] : unimplemented function msvcrt.dll._mbsbtype

2005-08-29 Thread Ge van Geldorp
> From: Vijay Kiran Kamuju > > can we use the reactos implementation of the _mbsbtype? > http://reactos.geldorp.nl/dc/d8d/mbbtype_8c-source.html > > Any ReactOS guys, please respond regarding the licensing of the above > code? Most of the code in our C Runtime originates from the DJGPP compiler

RE: calling *W functions in wt (Was: dlls/shell32/shfldr_desktop.c)

2005-08-15 Thread Ge van Geldorp
and Unicode implementations both ways (which is kind of boring to write) on NT and skip the Unicode tests on Win9x. Difficult stuff. I guess it's not an option to drop Win9x compatibility in Wine . Ge van Geldorp.

RE: dlls/shell32/pidl.c

2005-08-15 Thread Ge van Geldorp
> From: Michael Jung > > SHBindToParent does not allocate a > new PIDL for pidlLast, but returns a pointer to right > location in pidl. This means you should not free it. > There's still the problem that the shell folder isn't > released in failure cases. > > Sorry, I didn't realize this. I

SHGetPathFromIDList problem

2005-08-12 Thread Ge van Geldorp
e, but the shell COM interfaces easily confuse me, so perhaps someone with a better understanding of this stuff should look it over before I submit it to wine-patches. Ge van Geldorp. Index: dlls/shell32/pidl.c === RCS file: /home

RE: LoadImage & 32bpp bitmaps

2005-07-08 Thread Ge van Geldorp
is interest in this from the Wine side, I'd be happy to provide assistance. Ge van Geldorp.

RE: tools/widl

2005-05-12 Thread Ge van Geldorp
I'm wondering what happened to the reworked widl patch at http://www.winehq.org/hypermail/wine-patches/2005/04/0371.html? It hasn't been applied yet, does that mean there's no interest on the Wine side and I can drop it from my TODO list? Best regards, Ge van Geldorp.

RE: tools/widl

2005-04-25 Thread Ge van Geldorp
ignificantly increase the chance of introducing bugs and b) take too much of my time. Maybe we can try to find a solution at WineConf? Ge van Geldorp.

RE: dlls/shell32/shelllink.c

2005-03-16 Thread Ge van Geldorp
> From: Mike McCormack [mailto:[EMAIL PROTECTED] > > Ge van Geldorp wrote: > > I have some shortcuts (created in Windows 2000) which only have 24 > > bytes of LOCATION_INFO, i.e. they are missing the dwFinalPathOfs > > member. Also lots of shortcuts seem to have an

wpp

2005-02-20 Thread Ge van Geldorp
clude_next in Wine anyway (not every compiler supports it) I'm not going to bother creating and testing a Wine patch for it. If I misjudged and there is interest in this from the Wine side just let me know. Ge van Geldorp. Index: libs/wpp/ppl.l

RE: Microsoft genuine downloads looking for wine

2005-02-16 Thread Ge van Geldorp
> From: Ivan Leo Puoti > > Interestingly if you run the validation program on wine, > and the version of windows you're emulating is prior to > 2000 or is windows server 20003, you get a message saying > a validation code couldn't be found, because of technical > difficulties or because you're runn

RE: Summary of MSRPC / DCE/RPC interoperability / Applicability of FreeDCE for Wine (DCOM)

2005-01-25 Thread Ge van Geldorp
mailing lists? If so, I can begin to understand why they banned you, it gets _really_ annoying. Ge van Geldorp.

RE: [LOSTWAGES] Add janitorial task to avoid using strncpy

2005-01-13 Thread Ge van Geldorp
character is an '\0'? That sane implementation already exists as lstrcpynA/lstrcpynW in kernel32. Ge van Geldorp.

RE: advpack: add two missing stubs

2005-01-11 Thread Ge van Geldorp
> From: Dmitry Timoshkov > > "Steven Edwards" <[EMAIL PROTECTED]> wrote: > > Its nice to note where the code came from. We always try to > > do it in ReactOS so please credit Jim for his advpack function. > > It's sad to say that, but unfortunately that's not the case > on the ReactOS side some

RE: Stubs in PE build

2004-12-13 Thread Ge van Geldorp
stubs from shlwapi.dll but then doesn't call them in our usage scenarios. I'm just a little bit surprised that stubs are ok for elf builds but not for PE builds. It's not a big issue, I'm going to keep the code in ReactOS CVS anyway . Ge van Geldorp.

RE: Stubs in PE build

2004-12-13 Thread Ge van Geldorp
l instead > of killing the app). You can view the lack of stubs support > on PE as an encouragement to help us remove them from the > spec files ;-) Seems impossible for functions with unknown calling conventions and number of parameters. Ge van Geldorp.

RE: Treeview +/-

2004-12-02 Thread Ge van Geldorp
> From: Jon Griffiths > > >Maybe the height/width at which to switch to the Rectangle drawing > >algorithm needs a bit of tuning? > > Ge, Can you confirm this fixes the size for you? It works for > me if I change my system font to a larger one... Yes, this wo

Stubs in PE build

2004-11-24 Thread Ge van Geldorp
Stubs declared in .spec files were not generated or exported for PE (MinGW) builds. The patch below fixes that. It adds a new mode to winebuild, --pedll, which generates the stubs. Since it's a global change I'm sending it here for review first. Ge van Geldorp. Index: Mak

Ekush

2004-11-10 Thread Ge van Geldorp
> From: Ge van Geldorp > > Ekush (http://www.ekush.com) published some binaries. > Surprise, surprise, it looks like ReactOS very much (Check > e.g. the radio buttons on the "Accept License" screen during > 2nd stage setup). > Some string searching in their bina

RE: Treeview +/-

2004-10-21 Thread Ge van Geldorp
would be an improvement for large icon sizes, but I don't think it's good for small icon sizes. See attached screenshot of regedit. Maybe the height/width at which to switch to the Rectangle drawing algorithm needs a bit of tuning? Ge van Geldorp. <>

RE: dlls/setupapi/parser.c

2004-10-07 Thread Ge van Geldorp
> From: Alexandre Julliard > > Ge van Geldorp <[EMAIL PROTECTED]> writes: > > > Changelog: > > Ge van Geldorp <[EMAIL PROTECTED]> > > - GetFullPathName returns length without nul byte > > If it does that's a bug, it's supposed to c

RE: wctype

2004-10-04 Thread Ge van Geldorp
> From: Dmitry Timoshkov > > "Ge van Geldorp" <[EMAIL PROTECTED]> wrote: > > > I compared the results of CT_CTYPE1 GetStringTypeW() > > between Windows 2000 and Wine and found a lot of differences > > That's a known incompatibility. Another one i

wctype

2004-10-04 Thread Ge van Geldorp
I compared the results of CT_CTYPE1 GetStringTypeW() between Windows 2000 and Wine and found a lot of differences (about 12000 of them). Nothing really spectacular, e.g. codepoint 0x00b5 (MICRO SIGN) is classified C1_PUNCT in Win2k and (C1_ALPHA | C1_LOWER) in Wine. I noticed that the Wine table is

Moving some 16-bit code

2004-09-22 Thread Ge van Geldorp
dlls/shell32/control.c contains some 16-bit code (function RunDLL_CallEntry16), which I would like to separate out. I wonder if the attached patch is the correct way to do that? On Win2k export 122 is just a stub. Maybe it would be ok to turn our export 122 into an empty function too? Ge van

RE: RICHEDIT: use buffers rather than linked lists for input and out buffers

2004-08-27 Thread Ge van Geldorp
ways seems to read the input in 4096 byte chunks. Maybe you could enlarge InputBuffer from 0x400 to 0x1000? Ge van Geldorp.

RE: usb support in ROS

2004-08-12 Thread Ge van Geldorp
> From: Tom > > Steven is USB by chance working in ROS? > http://cvs.reactos.com/cgi-bin/cvsweb.cgi/reactos/w32api/include/ddk/ No, not yet. Some work is being done on USB but it will take a while before support is finished. Ge van Geldorp.

Pending patches

2004-07-07 Thread Ge van Geldorp
Last week I submitted the following patches: http://www.winehq.org/hypermail/wine-patches/2004/06/0227.html (dlls/commdlg "old style" file dialogs - take 2) and http://www.winehq.org/hypermail/wine-patches/2004/06/0276.html (dlls/shell32 RestartDialog and RestartDialogEx) Is there any particula

  1   2   >