Re: [1/3] apphelp: Add definitions

2013-08-16 Thread GOUJON Alexandre
On 08/16/2013 12:50 PM, Mislav Blazevic wrote: Pardon my ignorance... What does it mean to bottom post? I am new to mailing lists. GIYF : http://en.wikipedia.org/wiki/Posting_style#Bottom-posting

Re: [website] Added templates/zh-cn/cvs.template translation

2013-08-16 Thread GOUJON Alexandre
On 08/16/2013 11:59 AM, Frédéric Delanoy wrote: On Fri, Aug 16, 2013 at 8:13 AM, xulixin wrote: From 860262aed3d58f42012e6dd5264eb29bd29deffb Mon Sep 17 00:00:00 2001 From: xulixin Date: Fri, 16 Aug 2013 13:56:36 +0800 Subject: add templates/zh-cn/cvs.template --- templates/zh-cn/cvs.templat

Re: po: Tweak the French 'broadcast' and 'unicast' translations.

2013-07-12 Thread GOUJON Alexandre
On 07/12/2013 07:30 PM, Frédéric Delanoy wrote: On Fri, Jul 12, 2013 at 4:33 PM, Francois Gouget wrote: --- Surprisingly enough (for me) the existing translations match the term used in Microsoft's Terminology file: "broadcast address" -> "adresse de diffusion" "broadcast" -> "

Re: Re : Full software of Wine version 1.4

2013-05-11 Thread GOUJON Alexandre
On 05/10/2013 01:52 AM, Nick Kucan wrote: Each time the system crashes (fails to load and screen says "input signal out of range" and does not load Ubuntu 11.04). Yeah, I experienced the same thing with my old computer which had a VIA chipset. When you boot up your computer, the X server tries

Re: Crash confuses me

2013-03-08 Thread GOUJON Alexandre
On 03/07/2013 08:53 PM, Graham wrote: Another thing to notice is that this was tested using wine1.4.1 However it DOES work with wine1.5.10 [...] If it works with the latest version, it means there was a bug and we fixed it. Each commit is as small as possible to ease the identification of the

Re: IOCTL_DVD_READ_STRUCTURE (DvdPhysicalDescriptor) test failure

2013-03-04 Thread GOUJON Alexandre
Hi Detlef, On 03/03/2013 10:23 PM, Detlef Riekenberg wrote: Hi Alexandre. I have a test failure on my win7 Machine, while a valid cd was in the dvd drive. volume.c:785

Re: Wine release 1.5.24

2013-02-17 Thread GOUJON Alexandre
On 02/15/2013 09:38 PM, Gennady Telegin wrote: Hi, I want to unsubscribe from this list, how to do it? Best, Gennady Telegin It's wine-announce so go to http://www.winehq.org/mailman/listinfo/wine-announce and read instructions at the bottom of the page

Re: FindFirstVolume crash

2012-12-14 Thread GOUJON Alexandre
On 12/12/2012 11:00 PM, Michael Ost wrote: Hi list, Can someone help me get through the wineserver code for passing data through a buffer in response to an ioctl? Our (slightly out of date 1.3.24 version of) Wine is getting INVALID_HANDLE_VALUE returned for FindFirstVolume. The problem is th

Re: The EFF is asking for our help explaining why APIs should not be copyrightable

2012-11-09 Thread GOUJON Alexandre
On 11/09/2012 06:29 PM, Scott Ritchie wrote: https://www.eff.org/deeplinks/2012/11/no-copyrights-apis-help-us-make-case There are court cases pending that are very, very relevant to what we do here. It would help the EFF very much if a few engineers could send them a short email statement e

Re: [PATCH 1/1] include/basetsd.h: fix bad casting

2012-10-14 Thread GOUJON Alexandre
On 10/14/2012 01:40 AM, Max TenEyck Woodbury wrote: Dan: AJ and DT can both speak for themselves, and have just done so. It is now AJs decision. There are criteria beyond the two you mentioned, but it is rare to see them come into play. Few people know enough to even recognize such problems.

Re: kernel32: Return correct drive type for empty drives

2012-08-31 Thread GOUJON Alexandre
On 08/29/2012 09:35 PM, Alexandre Julliard wrote: Alexandre Goujon writes: Should fix bug #17037 I followed your advice and now, I only ask the mountmgr when needed. --- dlls/kernel32/volume.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) This is failing here when the d

Re: Question about some Linux integration

2012-08-25 Thread GOUJON Alexandre
On 08/25/2012 12:28 PM, Oleg Yarigin wrote: And an off-top question: where is wine_server_call realisation defined? I can't help you about the other points but as every project, answers you are looking for lies in the source code. See http://source.winehq.org/ident?i=wine_server_call for insta

Re: mountmgr.sys: For loop-mounted devices, use the backing file

2012-08-21 Thread GOUJON Alexandre
On 08/21/2012 11:49 AM, Alexandre Julliard wrote: Alexandre Goujon writes: As part of their copy protection, some games use some ioctl's to check some physical attributes. Unfortunately, when using the loop device, some ioctl fail (like IOCTL_SCSI_GET_ADDRESS). A simple fix is to use /path/t

[RFC] kernel32: Try to get the drive type from the mountmgr first

2012-07-28 Thread GOUJON Alexandre
On 07/22/2012 03:36 PM, Alexandre Goujon wrote: Should fix bug #17037 --- dlls/kernel32/tests/volume.c |2 ++ dlls/kernel32/volume.c |3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/kernel32/tests/volume.c b/dlls/kernel32/tests/volume.c index 8152ae1..1

Re: Query MediaType of SD-Cards using IOCTL_GET_DISK_DRIVE_GEOMETRY

2012-07-23 Thread GOUJON Alexandre
On 07/21/2012 12:34 PM, Eduard Hasenleithner wrote: All the code in dlls/kernel32/volume.c seems to be build around evaluating the symlinks present in .wine/dosdevices. Is there already a design document which describes how the interaction with mountmgr should look like in future? Will the dosd

Re: kernel32: Reimplement GetLogicalDrives using the mountmgr

2012-07-23 Thread GOUJON Alexandre
On 07/23/2012 09:15 PM, Alexandre Julliard wrote: GOUJON Alexandre writes: On 07/23/2012 03:03 PM, Alexandre Julliard wrote: That's very inefficient. There are better way of enumerating drives, check for instance QueryDosDevice. I'm not sure QueryDosDevice is more efficient : +

Re: kernel32: Reimplement GetLogicalDrives using the mountmgr

2012-07-23 Thread GOUJON Alexandre
On 07/23/2012 03:03 PM, Alexandre Julliard wrote: That's very inefficient. There are better way of enumerating drives, check for instance QueryDosDevice. I'm not sure QueryDosDevice is more efficient : + with NULL device name, it returns every MS-DOS device which is not what we want + if we ca

Re: Build failure of "[PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test (try 4)" ?

2012-07-16 Thread GOUJON Alexandre
On 07/16/2012 06:12 PM, Alexandre Julliard wrote: There's nothing mystic about it, but when you are changing the Mac code, testing the build on a Mac is recommended ;-) gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-ali

Re: Query MediaType of SD-Cards using IOCTL_GET_DISK_DRIVE_GEOMETRY

2012-07-16 Thread GOUJON Alexandre
On 07/16/2012 09:44 AM, Eduard Hasenleithner wrote: [...] Maybe I should have mentioned it, but I'm using Ubuntu 12.04 and the SD card is mounted automatically as soon as I put it into the slot. My current hypothesis why the symlink in dosdevices is missing is that the partition is added using

Re: Query MediaType of SD-Cards using IOCTL_GET_DISK_DRIVE_GEOMETRY

2012-07-15 Thread GOUJON Alexandre
On 07/14/2012 09:14 PM, Eduard Hasenleithner wrote: [...] This means that the drive letter assigned for the sd card will not be returned in GetLogicalDrives(). When the symlink to the mountpoint is added manually, following output is produced: Does http://source.winehq.org/patches/data/88280 so

GetDriveType and empty CD/DVD-ROM drives

2012-07-14 Thread GOUJON Alexandre
Hi, I'm currently working on bug #17037. The root cause is that GetDriveType("D:\") (if D is mapped to /dev/cdrom) returns DRIVE_NO_ROOT_DIR while on Windows it returns DRIVE_CDROM when there is no disc in the D drive. GetDriveType tries to open D:\ which is converted into \\??\\D:\\ then ~/

Re: Suppressing My Computer in File Open dialog box?

2012-07-14 Thread GOUJON Alexandre
On 07/14/2012 01:28 AM, Dan Kegel wrote: I'm creating a page of tips at http://wiki.winehq.org/DisplayingUnixFilenames for vendors shipping Windows apps on Linux with Wine who want their apps to use Windows paths throughout internally, but display Linux paths in the GUI This is something I've be

Build failure of "[PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test (try 4)" ?

2012-07-13 Thread GOUJON Alexandre
Hi, My patch (http://source.winehq.org/patches/data/88072) is marked as "Build failure". I tried with the latest (today) HEAD and I successfully applied it. Compilation also works for me at least on my x86 and x86_64 computers. Moreover, the Wine Test Bot tested it without any issue, see https

Re: [PATCH 5/5] kernel32/tests: Add a IOCTL_DVD_READ_STRUCTURE (DvdManufacturerDescriptor) test

2012-06-17 Thread GOUJON Alexandre
On 06/17/2012 01:19 PM, Nikolay Sivov wrote: On 6/17/2012 13:11, Alexandre Goujon wrote: case DvdManufacturerDescriptor: +nt_desc.manf->Header.Length = 0x0802; +nt_desc.manf->Header.Reserved[0] = 0; +nt_desc.manf->Header.Reserved[1] = 0; Does this

Re: [PATCH 2/5] include/ddk: Add DVD_DESCRIPTOR_HEADER descriptor structure (try 2)

2012-06-17 Thread GOUJON Alexandre
On 06/17/2012 01:16 PM, Nikolay Sivov wrote: This looks wrong, correct name for it __midl, and this also needs a check for __WIDL__ probably. This is exactly what's present in the header file but if you want, I can resubmit with #if !(defined __midl || defined __WIDL__)

Re: func or pFunc in tests ?

2012-05-27 Thread GOUJON Alexandre
On 05/27/2012 05:08 PM, Juan Lang wrote: Basically, if the function is available on all versions of Windows that the test bot runs on, use func. If it's not available on some versions, and you need to test whether it's available to avoid a non-running test, use pFunc instead. Regarding the his

func or pFunc in tests ?

2012-05-27 Thread GOUJON Alexandre
Hi, I'm planning to add a test in the wine test suite and I noticed a difference. Some tests call directly the function by its name (i.e. GetWindowsDirectory, CreateFileA, CloseHandle...) while others declare a pointer to the function (prefixing its name by 'p' and followed by a capital let

Fwd: Re: Logging issue ?

2012-05-18 Thread GOUJON Alexandre
Also replying to wine-devel Original Message Subject:Re: Logging issue ? Date: Fri, 18 May 2012 16:52:34 +0200 From: GOUJON Alexandre To: Nikolay Sivov On 05/18/2012 05:31 PM, Nikolay Sivov wrote: On 5/18/2012 17:23, GOUJON Alexandre wrote: Any thought

Logging issue ?

2012-05-18 Thread GOUJON Alexandre
Hi, To understand why a game does not work with the disc while it does with the ISO (created from the same disc), I made a log with +tid,+relay,+volume in both cases and noticed : - some lines (call or ret) are not printed / missing - some lines are half-printed and joined with the following

Re: Fwd: Ubuntu 12.04 (version#2, drop previous mail)

2012-04-30 Thread GOUJON Alexandre
On 04/29/2012 10:44 PM, Eric Pouech wrote: Warning at compilation -- when compiling, some warnings still have to be worked upon /home/eric/work/wine/dlls/winex11.drv/keyboard.c:1109:5: warning: 'XKeycodeToKeysym' is deprecated (declared at /usr/include/X11/Xlib.h:1695) [-Wde

Re: Fwd: Ubuntu 12.04 (version#2, drop previous mail)

2012-04-30 Thread GOUJON Alexandre
On 04/29/2012 10:44 PM, Eric Pouech wrote: for the devels having upgraded their boxes to ubuntu 12.04, here's a couple of stuff I had to do, especially to get 32bit wine compile That's funny because I just tried yesterday and filed [1] to see what developers think. They are aware of the issue b

Re: Tools under the <>tools/winapi directory

2012-04-03 Thread GOUJON Alexandre
On 04/03/2012 07:34 PM, Roger Cruz wrote: How are the tools under the winapi directory used? I've tried running them but they all complain about the same error. ~/sandbox/wine/sources/wine-1.3.36/dlls/kernel32$ ~/sandbox/wine/sources/wine-1.3.36/tools/winapi/winapi_extract winapi_extract: You m

About release 1.3.35

2011-12-16 Thread GOUJON Alexandre
Am I the only one who noticed that the "Release 1.3.35" was authored by Frédéric Delanoy ? Who's the author (really) doesn't matter but having a commit from a gmail.com e-mail address instead of a winehq.org one (just) surprised me. Anyway, let's pull this latest wine version, compile and test i

Re: [PATCH] kernel32: implement GetLogicalProcessorInformation

2011-11-26 Thread GOUJON Alexandre
On 11/25/2011 08:35 PM, Claudio Fontana wrote: That's great! When it's done it will be one less out of tree patch to maintain, always a win. Ciao, C You're free to keep your patches on your own/private tree but if you're discussing here, I guess you wanted your stuff being committed in the ma

Re: MS XInput*.dll implementation

2011-11-01 Thread GOUJON Alexandre
On 11/01/2011 03:11 PM, Alexey Loukianov wrote: a) [...] What I've got available to do the tests are three Windows-based PCs You should have a look at https://testbot.winehq.org/ which let you submit a patch on several (VMware'd) Windows machines. But I doubt there is any input devices in these

Re: WineHQ database compromise

2011-10-12 Thread GOUJON Alexandre
On 10/11/2011 09:13 PM, Jeremy White wrote: I am sad to say that there was a compromise of the WineHQ database system. "Nothing Is Invulnerable" So, now or later, your system will be compromised. The only thing you have to do is to be prepared to face an incident and of course secure your syste

WINMM_OpenDevice Activate failed

2011-10-06 Thread GOUJON Alexandre
Hi Andrew, I saw you modified the Audio tab of winecfg to let the user choose a device. You're really doing a great job considering the mess behind it (audio architecture & drivers). I tested the latest wine and noticed that when you click the "Test Sound" button, there is no error but if you

Re: [patch] Fake display interface

2011-09-06 Thread GOUJON Alexandre
On 09/06/2011 02:25 PM, Jari Vetoniemi wrote: I have them both disabled, however then some applications won't work because they don't get any resolution information. I only use FakeDisp. IMO, there is a need and your patch is a solution (among other). Is there a relevant developer able to answe

Re: [patch] Fake display interface

2011-09-05 Thread GOUJON Alexandre
On 09/02/2011 10:57 PM, Jari Vetoniemi wrote: Yeah, I'm aware of virtual desktop and used to create scripts to launch applications using wine explorer \desktop=WIDTHxHEIGHT or whatever the parameters were, it works well. But means that you have to create always new shell script, and it also can p

Re: ws2_32: Avoid an unhandled read exception on WSAIoctl (resend)

2011-09-02 Thread GOUJON Alexandre
On 09/02/2011 10:32 AM, Michael Stefaniuc wrote: Bruno Jesus wrote: On Thu, Sep 1, 2011 at 18:40, Bruno Jesus<00cp...@gmail.com> wrote: I don't get the same results here, can anyone help me to understand why it failed? 10014 = WSAEFAULT and I could not find this return value anywhere near, may

Re: [PATCH 4/5] mountmgr.sys: Also unlink a:: drive when removing a dos device

2011-08-31 Thread GOUJON Alexandre
On 08/31/2011 01:16 PM, Alexandre Julliard wrote: Alexandre Goujon writes: @@ -818,6 +818,7 @@ NTSTATUS remove_dos_device( int letter, const char *udi ) if ((path = get_dosdevices_path(&p ))) { p[0] = 'a' + drive->drive; +unlink( path ); That's no

Re: [PATCH 1/5] kernel32: Add UDF support

2011-08-31 Thread GOUJON Alexandre
On 08/31/2011 01:21 PM, Alexandre Julliard wrote: Alexandre Goujon writes: Based on Steven Wallace work. Should fix the wine side of bug #26273 It fails here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so volume.c&& touch volume.ok volume.c:105: Test

Re: [PATCH 3/5] kernel32: Improve GetVolumeInformation filesystem flags

2011-08-31 Thread GOUJON Alexandre
On 08/31/2011 01:15 PM, Alexandre Julliard wrote: Alexandre Goujon writes: if (fsname) lstrcpynW( fsname, ntfsW, fsname_len ); if (filename_len) *filename_len = 255; -if (flags) *flags = FILE_CASE_PRESERVED_NAMES; +if (flags) *flags = FILE_NAMED_STREAMS | FI

Re: kernel32: Improve GetVolumeInformation filesystem flags I set flags value according to my tests which may differ from a windows version to another.

2011-08-29 Thread GOUJON Alexandre
On 08/29/2011 02:49 PM, Frédéric Delanoy wrote: On Mon, Aug 29, 2011 at 14:41, GOUJON Alexandre wrote: When I wrote the description of the patch using git commit, I wrote "kernel32: Improve GetVolumeInformation filesystem flags" as the title and the remaining part on a new line (to

Re: kernel32: Improve GetVolumeInformation filesystem flags I set flags value according to my tests which may differ from a windows version to another.

2011-08-29 Thread GOUJON Alexandre
On 08/29/2011 04:46 AM, Dan Kegel wrote: Fails to build here, since it depends on the patch "include/winnet.h: Add more GetVolumeInformation system flags", but you didn't mark them as being part of a series. See "Subject Line" in http://wiki.winehq.org/SubmittingPatches volume.c: In function ‘Ge

Re: kernel32: Add UDF support Based on Steven Wallace work. Should fix the wine side of bug #26273

2011-08-29 Thread GOUJON Alexandre
On 08/29/2011 04:33 AM, Dan Kegel wrote: Fails tests here? ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so volume.c&& touch volume.ok fixme:volume:DefineDosDeviceW (0x,L"a:",L"Z:\\home\\dank\\wineslave.dir\\sandbox\\slave\\runtests\\build\\dlls\\ker

Re: [2/3] msi/tests: Skip a test if the process is limited.

2011-08-24 Thread GOUJON Alexandre
On 08/24/2011 10:47 AM, Hans Leidekker wrote: No, win_skip is for behavior observed on Windows that Wine should not emulate, which is not the case here. Is there any page on the wiki explaining the meaning of broken(), skip(), win_skip() ? Because your definition of win_skip is my definition of

Re: gdi32: Add a buch of CreateScalableFontResource() tests. Resend.

2011-08-24 Thread GOUJON Alexandre
On 08/24/2011 07:16 AM, Dmitry Timoshkov wrote: That doesn't explain why the test case (!) sent one month ago has not been accepted and has stalled in the pending state while many other patches have been committed before and after the two weeks vacation time. I'd guess that's because my mailing a

Re: gdi32: Add a buch of CreateScalableFontResource() tests. Resend.

2011-08-23 Thread GOUJON Alexandre
On 08/24/2011 03:42 AM, Dmitry Timoshkov wrote: It's pretty disappointing to see no any reaction except the (answered) question above in a month. Do you know AJ has been on vacation for two weeks ? That you're not the only developer ? That AJ has tons of patch to read and comment ? You should

Re: [PATCH] GNU/kFreeBSD detection

2011-08-22 Thread GOUJON Alexandre
On 08/22/2011 07:11 PM, Robert Millan wrote: 2011/8/22 Alexandre Julliard: If it doesn't need a different behavior there's no need for a new platform, just use PLATFORM_FREEBSD. It may need different behaviour in the future. Anyhow, if you still prefer to share the same macro here's the new pa

Re: Bug #27975 and one small change

2011-08-09 Thread GOUJON Alexandre
On 08/09/2011 01:49 PM, Frédéric Delanoy wrote: http://wiki.winehq.org/SubmittingPatches already links to http://wiki.winehq.org/GitWine (see http://wiki.winehq.org/SubmittingPatches#head-c088a6649bf6b17d21c57a87be967bc309b2f57c) I was just referring to the .git/config file which may need som

Re: Bug #27975 and one small change

2011-08-09 Thread GOUJON Alexandre
On 08/09/2011 08:51 AM, Frédéric Delanoy wrote: 2011/8/8 Adam Stachowicz: From f91549a682b52b77853b53a475011c7869f861b2 Mon Sep 17 00:00:00 2001 From: Saibamen Date: Mon, 8 Aug 2011 15:43:48 +0200 Subject: Resize control to allow wider string of polish translator and bug 27975 Please see http:

kernel32: GetVolumeInformation and FS flags

2011-08-04 Thread GOUJON Alexandre
As I'm updating GetVolumeInformation to add UDF support, I noticed file system flags differ from one Windows version to another. For instance, on TestBot and NTFS I get [1] : - 000700FF for XP and W2K3 - 002700FF for Vista and W2K8 - 03E700FF for 7 Should I - not test flags, don't bother ? (hide

Re: Wine and endianness

2011-08-01 Thread GOUJON Alexandre
On 08/01/2011 09:09 AM, David Laight wrote: If you have 'unsigned char bloc[]' and want to read a 32 bit LE value you can do: value = bloc[20 + 0]; value |= bloc[20 + 1]<< 8; value |= bloc[20 + 2]<< 16; value |= bloc[20 + 3]<< 24; *offs = value; And that is correct on

Wine and endianness

2011-07-31 Thread GOUJON Alexandre
On 07/31/2011 08:12 PM, Stefan Dösinger wrote: With the bitfields I'm not sure about stuff like endianess. My gut feeling would be to use bitmasks and shifts to separate a DWORD instead, but bitfields certainly look nicer. Beyond that endianess is a somewhat academic consideration with an API th

Re: [PATCH] comctl32: Fixed strncpy (Coverity)

2011-06-28 Thread GOUJON Alexandre
... What is wrong with: buff[0] = 'x'; buff[1] = 0; David and why not buff = { 'x', '\0' };

Re: d3dx9/tests: Fix comparison that expects NAN, since NAN != NAN.

2011-06-28 Thread GOUJON Alexandre
On 06/28/2011 10:59 AM, Tijl Coosemans wrote: On Tuesday 28 June 2011 00:40:09 Alexandre Julliard wrote: Dylan Smith writes: @@ -4834,7 +4834,7 @@ static void test_create_skin_info(void) for (i = 0; i< num_influences; i++) { ok(exp_vertices[i] == vertices[i],

Re: Add sub-message to a commit

2011-06-15 Thread GOUJON Alexandre
On 06/15/2011 04:17 PM, Andrew Eikum wrote: On 06/15/2011 09:09 AM, GOUJON Alexandre wrote: I would like to add a 'sub'-message to a commit like this one http://source.winehq.org/git/wine.git/commitdiff/dbd878639424071e1d4c6cfc9bcc75906a4b2b8a I know that I can specify this t

Add sub-message to a commit

2011-06-15 Thread GOUJON Alexandre
Hi, I would like to add a 'sub'-message to a commit like this one http://source.winehq.org/git/wine.git/commitdiff/dbd878639424071e1d4c6cfc9bcc75906a4b2b8a I know that I can specify this text at the beginning of a patch I want to send to wine-patches (befor the '---'). But here, I'm interested

Re: Regression in ioctl

2011-05-17 Thread GOUJON Alexandre
On 05/17/2011 12:43 PM, Susan Cragin wrote: I compile every git. So last compile was the day before this one. However, I don't remember if I tried to run NatSpeak, so the error might be as much as two days old? If something worked before and don't work anymore, it's a regression. Have a look

Re: USB Device Support - Nokia PC Suite

2011-02-19 Thread GOUJON Alexandre
On 02/18/2011 05:08 PM, Mike Yates wrote: After rebooting, I did get a full list of "fixme" lines:- mike@myvmubuntu:~$ wine .wine/drive_c/Program\ Files/Nokia/Nokia\ PC\ Suite\ 7/PCSuite.exe [snip] Mike, this is a developer's mailing list. With questions about how to use Wine please refer to

Re: Tiny imap message appender written in perl

2011-02-13 Thread GOUJON Alexandre
On 02/13/2011 12:10 PM, Krzysztof Nikiel wrote: It's a kind of side effect of my Wine patching. Sending those patches traditional way was an epic fail. Mail client wrapped lines, git-imap-send provided by Debian don't support SSL. I have modified my tiny imap downloader to append new messages to

Re: Resend: Who does c2man?

2011-02-11 Thread GOUJON Alexandre
On 02/11/2011 05:19 PM, Max TenEyck Woodbury wrote: I have just been going over tools/c2man and have a fair number of questions about it. You can ask them here. This is why wine-devel exists. There is also IRC (http://wiki.winehq.org/IRC) But keep in mind that everyone is very busy. So ask some

Re: avifil32: Skip tests when we couldn't create or open the AVI file

2011-02-10 Thread GOUJON Alexandre
On 02/11/2011 12:10 AM, Julius Schwartzenberg wrote: Is there a specific situation in which the file creation fails? I expected the temporary directory would always be writable when I created it like that. Maybe that is not a good assumption when writing tests though? I wrote the patch because

Re: avifil32: Skip tests when we couldn't create or open the AVI file

2011-02-10 Thread GOUJON Alexandre
On 01/30/2011 07:29 PM, Alexandre Goujon wrote: --- dlls/avifil32/tests/api.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/dlls/avifil32/tests/api.c b/dlls/avifil32/tests/api.c index 14ad4b4..c1ba878 100644 --- a/dlls/avifil32/tests/api.c +++ b/dlls/avif

Re: Killing WineAPI project on SourceForge.

2011-02-05 Thread GOUJON Alexandre
On 02/05/2011 06:36 AM, Max TenEyck Woodbury wrote: No feedback and apparently no interest in the WineAPI project on SourceForge. The subject has been debated before you launched the WineAPI project on SF. Some questions may help to understand why does nobody is interested : + Why a WineAPI shou

Re: Pulling Patch

2011-02-05 Thread GOUJON Alexandre
On 02/04/2011 07:13 PM, James McKenzie wrote: Since my Mac is dying I have decided to return to the Windows world. It's your choice so I can't comment it but I bet you know what I think. Please remember what you wrote to me (May, 2010) : Don't give up on it, just take a break away from it, plea

Re: Policy regarding 3rd party "windows" distributions and winetest

2011-01-30 Thread GOUJON Alexandre
On 01/30/2011 07:27 PM, James McKenzie wrote: I think Dan Kegel does not want them in the Winetest list. I'll defer to AJ as to what HE wants. Sure ! The boss's always right. And it should be great to find a way to identify these "fake" windows. On 01/30/2011 07:29 PM, F Capela wrote: Couple

Re: Policy regarding 3rd party "windows" distributions and winetest

2011-01-30 Thread GOUJON Alexandre
On 01/30/2011 04:47 PM, James McKenzie wrote: On 1/27/11 7:04 PM, Dan Kegel wrote: I suspect that we should discourage people from submitting winetest results from 3rd party repackagings of Microsoft Windows, e.g. http://thepiratebay.org/torrent/4254053/MicroXP_v0.82_-_eXPerience Agreed? +1.

Re: Alexandre Julliard : winedump: Try to load the PDB string table from file number 4 too.

2011-01-13 Thread GOUJON Alexandre
On 01/13/2011 09:11 PM, Eric Pouech wrote: Alexandre visiblement tu as un exemplaire de pdb sous la main différent de ceux que j'ai vu peux-tu me le passer (sauf si contrat spécifique CW bien sûr) j'ai toujours trouvé curieux les index constants pour certains streams dans les PDB, donc si j'en

Re: [PATCH 1/4] wineaddon.cpl: Added initial Wine Add-ons Manager stub.

2010-12-06 Thread GOUJON Alexandre
On 12/06/2010 09:15 PM, André Hentschel wrote: So that will simply create a linux executable with an ".exe" extention. You should consider being more friendly, especially when you dont know what you are talking about Hey ! I said I didn't want to be rude and that's still true RTFM is a kind of

Re: [PATCH 1/4] wineaddon.cpl: Added initial Wine Add-ons Manager stub.

2010-12-06 Thread GOUJON Alexandre
On 12/06/2010 08:21 PM, Jacek Caban wrote: That's exactly the problem of creating Windows self-extracting archives on Linux. How do you do that? (I don't want to be rude but ...) RTFM quoting `man 7z` from Ubuntu 10.04 : EXAMPLE 2 7z a -sfx archive.exe dir1 add all files

Re: Function strstr and MinGW

2010-11-05 Thread GOUJON Alexandre
On 11/05/2010 09:11 PM, Ozan Türkyılmaz wrote: \0 ending? I think you're right. I forgot '\0' at the end of escaped_space. That's so stupid ! Well, sorry for the noise and thanks for your help. It remember me a sentence a teacher told me: "When there are errors, we know a program doesn't

Function strstr and MinGW

2010-11-05 Thread GOUJON Alexandre
Hi everyone, I'm still trying to improve wine cmd but I'm stuck with my patch making tests failing. After some investigations, I've found that my function which replace all @space@ by real spaces does not always work. So I've written a test_case (attached code). It runs perfectly on Ubuntu (

Re: [RFC] cmd: Add a space at the end of the first echo'ed batch line [try5]

2010-11-01 Thread GOUJON Alexandre
On 11/01/2010 10:47 PM, Jacek Caban wrote: Why do you need this? AFAICS the change to compare_line should be enough. In wine/programs/cmd/tests there are 2 files : + test_builtins.cmd + test_builtins.cmd.exp The first one is a kind of .bat on windows. The wine cmd read line after line and execu

Re: [RFC] cmd: Add a space at the end of the first echo'ed batch line [try5]

2010-11-01 Thread GOUJON Alexandre
On 11/01/2010 03:12 PM, Vitaliy Margolen wrote: +static const char escaped_space[] = "@space@"; +DWORD len_space = strlen(escaped_space); The better way to calculate size of a static string, which is a compile time calculation. strlen() call is a runtime. The better way is ... ? In comp

[RFC] cmd: Add a space at the end of the first echo'ed batch line [try5]

2010-11-01 Thread GOUJON Alexandre
Hi everyone, I'm trying to fix the wine cmd behavior but as this 5th try differs greatly with the previous one, I'd like to have some feedback before submitting it. If you have any question, just let me know. Thanks is advance. diff --git a/programs/cmd/tests/batch.c b/programs/cmd/tests/batc

Re: IDE for Wine Development?

2010-10-10 Thread GOUJON Alexandre
On 10/09/2010 11:50 PM, Evil Jay wrote: My question is: Which IDE/editors do you "real" devs prefer for your work on Wine? It depends on you. I mean, some devs like auto-completion and will use an IDE (Eclipse, Code::Blocks, Dec-C++, NetBeans ... GIYF !) whereas others will prefer good text e

Re: cmd: Add a space at the end of the first echo'ed batch line

2010-10-03 Thread GOUJON Alexandre
On 10/03/2010 03:37 PM, Jacek Caban wrote: @todo_space@ is meant to do tests in todo_wine block. You should change @todo_space@ to spec in .exp file instead. If we're convinced that the whole keyword is not useful anymore, the whole handling code should be removed (although I think we'd better

Re: mshtml.inf: Add default GeckoCabDir

2010-10-01 Thread GOUJON Alexandre
That's intended. It's for overwriting defaults (although now that we install Gecko during wineprefix creation is doesn't make much sense anyways). You can't do that. The default is what's found by 'step (2)' from your description, not any hardcoded path. The version from Gecko package is meant

Re: mshtml.inf: Add default GeckoCabDir

2010-10-01 Thread GOUJON Alexandre
On 10/01/2010 12:17 PM, Austin English wrote: On Fri, Oct 1, 2010 at 4:29 AM, Alexandre Goujon wrote: diff --git a/dlls/mshtml/mshtml.inf b/dlls/mshtml/mshtml.inf index d7d2428..dea1712 100644 --- a/dlls/mshtml/mshtml.inf +++ b/dlls/mshtml/mshtml.inf @@ -273,6 +273,7 @@ HKLM,"Software\Micro

Re: Debugging 64-bit Wine Apps with winedbg

2010-09-23 Thread GOUJON Alexandre
Hi, I'm not a winedbg expert but I think your mis-using it. As it's your software, you can compile it from source and add debug info. I know Visual Studio can create .pdb files but I don't know if winedbg can use it. Personally, I'm using gcc mingw with -g and that perfectly works. The easies

Re: WineAPI wiki progress (resent)

2010-09-15 Thread GOUJON Alexandre
On 09/15/2010 03:32 PM, Max TenEyck Woodbury wrote: The wiki at https://sourceforge.net/apps/mediawiki/wineapi/index.php now has pages for the directories in the Wine Repository with classifications of the directory content. Well, to be frank, I don't like the structure. Doxygen is able to prod

Re: fusion:asmname Improve parse_display_name

2010-09-10 Thread GOUJON Alexandre
On 09/09/2010 06:18 PM, Alexandre Julliard wrote: It's unlikely that you would get a space here... Damn ! You're (always) right. I just sent a [try2] Thanks

Re: msxml3: IXMLDOMText_get_text return trimmed text when XML_TEXT_NODE

2010-09-05 Thread GOUJON Alexandre
On 09/05/2010 11:52 AM, David Laight wrote: Not to mention the bloatage of using 'inline' for something that size I modified my patch accordingly but as I can't check the preserveWhiteSpace property, I have to wait. Anyway, thanks for all your advices !

Re: msxml3: IXMLDOMText_get_text return trimmed text when XML_TEXT_NODE

2010-09-04 Thread GOUJON Alexandre
On 09/03/2010 06:52 AM, Nikolay Sivov wrote: Also this probably depends on ::preserveWhiteSpace() property. You are talking about the 'preserving' property from the internal domdoc structure, aren't you ? I tried accessing it from the xmlnode with xmlnode_get_ownerDocument but then I can't do

Re: msvcrt:string Fix codepage table 1361 (Korean Johab) [try3]

2010-09-03 Thread GOUJON Alexandre
On 09/03/2010 12:30 PM, Alexandre Julliard wrote: GetCPInfo, that's where the kernel32 info is. I must admit I don't understand anymore. GetCPInfo failed with codepage 1361 on my XP (whereas _setmbcp(1361) succeeded ) However, on WXPPROJASP3 (32 bit) [1], GetCPInfo succeeds and LeadByte[] co

Re: msvcrt:string Fix codepage table 1361 (Korean Johab) [try3]

2010-09-03 Thread GOUJON Alexandre
On 09/03/2010 11:18 AM, Alexandre Julliard wrote: A quick test on Windows shows that this isn't correct as far as the kernel32 info is concerned Huh ? What test did you do ? I compiled the attached source with mingw on my virtual XP. (unfortunately, G**gle prevent me from attaching the produce

Re: msxml3: IXMLDOMText_get_text return trimmed text when XML_TEXT_NODE

2010-09-02 Thread GOUJON Alexandre
On 09/02/2010 12:10 PM, Alexandre Julliard wrote: That's ugly and inefficient, especially since the common case is to not modify it. Well, in fact I don't modify the content. I just trim the output of bstr_from_xmlChar( xmlNodeGetContent( (xmlNodePtr)This->node ) ) And I made a separate fu

Re: msvcrt:string Fix codepage table 1361 (Korean Johab)

2010-09-01 Thread GOUJON Alexandre
On 09/01/2010 04:54 AM, Vitaliy Margolen wrote: On 08/31/2010 04:58 AM, GOUJON Alexandre wrote: Is the attached patch well formed ? +if( $codepage == 1361 ) my $lb_ranges = ( 0x81, 0xd3, 0xd8, 0xde, 0xe0, 0xf9, 0x00, 0x00 ); +else my $lb_ranges = get_lb_ranges(); + No, it's

Re: msvcrt:string Fix codepage table 1361 (Korean Johab)

2010-08-31 Thread GOUJON Alexandre
Is the attached patch well formed ? Can someone give it a try ? I don't want to run it, I fear it'll download all tables : my 3G Internet connection is limited to 20 kB/s now (I downloaded more than 5 GB but no one cares) diff --git a/libs/wine/cpmap.pl b/libs/wine/cpmap.pl index 79f5fd5..d112f0

Re: msvcrt:string Fix codepage table 1361 (Korean Johab)

2010-08-31 Thread GOUJON Alexandre
On 08/31/2010 12:23 PM, Dmitry Timoshkov wrote: Wine's aim is to run Windows applications, not to implement everything Windows has. I disagree about that but it doesn't matter after all. Spending time fixing differencies nobody cares about is a time loss You're probably right but what about if

Re: msvcrt:string Fix codepage table 1361 (Korean Johab)

2010-08-31 Thread GOUJON Alexandre
On 08/31/2010 11:20 AM, Dmitry Timoshkov wrote: Windows uses an older Unicode specification, that's pretty normal that unicode.org and Windows data differ in some places. There is no need to change the mapping unless there is an application that depends on it Thanks for your answer. You've done

Re: msvcrt:string Fix codepage table 1361 (Korean Johab)

2010-08-31 Thread GOUJON Alexandre
On 08/28/2010 02:12 PM, Alexandre Goujon wrote: I know that libs/wine/c_1361.c is generated ("DO NOT EDIT!!"). However (union cptable)cptable_1361.dbcs->lead_bytes needs to be modified according tests [...] diff --git a/libs/wine/c_1361.c b/libs/wine/c_1361.c index b424cb1..50d2c47 100644 ---

Re: ddraw [patch 1/2]: SetCooperativeLevels with Normal+Fullscreen+Exclusive mode is authorized

2010-08-30 Thread GOUJON Alexandre
On 08/30/2010 12:34 AM, Octavian Voicu wrote: Try running: git config --global color.ui auto This will activate colorful output for all git commands (in particular for `git diff' too). Then, when you run `git diff' from a terminal you will see whitespace errors (eg. trailing whitespace) highli

Re: msvcrt:locale Properly fix setlocale and clean up tests

2010-08-30 Thread GOUJON Alexandre
On 08/30/2010 11:21 AM, Alexandre Julliard wrote: Now you are overdoing it. I said to remove broken() for minor spelling differences, not for everything. For instance confusing 936 and 950 codepages for Chinese is broken, it's not just a spelling difference Sorry, I'm trying to do my best but N

Re: msvcrt:string Avoid size_t in ok()

2010-08-29 Thread GOUJON Alexandre
On 08/29/2010 02:36 AM, James McKenzie wrote: Alexandre: Can we avoid a typo by substituting: "Did not returned \n" with "Did not return \n" for each instance in the file? Thank you. James McKenzie Sorry for the typo, I guess I wrote it too fast. And no problem, I'll send a try2.

Re: msvcrt:locale Properly fix setlocale()

2010-08-27 Thread GOUJON Alexandre
On 08/27/2010 03:22 PM, Alexandre Julliard wrote: I don't think it makes sense to declare minor spelling differences as broken, or to change the kernel resources for this I did not write these broken. I just removed the todo_wine and fix the nls. I think they have been added to match what wine

Re: Any idea how to solve that ?

2010-08-27 Thread GOUJON Alexandre
On 08/27/2010 09:53 AM, GOUJON Alexandre wrote: Hi, No one have replied for my ["Spanish - Modern Sort_Spain.1252" locale on wine] mail. So I'm asking again if someone has an idea. If solved, msvcrt:locale test on wine will pass without any error. The situation is the follow

Any idea how to solve that ?

2010-08-27 Thread GOUJON Alexandre
Hi, No one have replied for my ["Spanish - Modern Sort_Spain.1252" locale on wine] mail. So I'm asking again if someone has an idea. If solved, msvcrt:locale test on wine will pass without any error. The situation is the following : setlocale(LC_ALL, "esn"); > ok(!strcmp(ret, "Spanish_Spain.12

  1   2   >