On Sat, Feb 11, 2012 at 2:27 PM, Maarten Lankhorst
wrote:
> Are you sure? I don't see any example calls being wrapped to ITextHost
> for example..
>
Yup, I worked on it myself. All those ITextHost_*(...), which you can
easily grep for in editor.c, are using macros in editor.h:
--- snip ---
#
On Sat, Feb 11, 2012 at 9:50 AM, Maarten Lankhorst
wrote:
> I have my doubts about these for example:
> - Richedit windowless mode - There's no way this can be a student project
> until someone does the thiscall that works both ways, this has been the
> biggest stumbling block to implementing it.
On Sat, Jul 9, 2011 at 10:16 AM, Misha Koshelev wrote:
> Does the attached patch work on MS Visual Studio 2010? This passes all tests.
Ya, it should work. I was only building test applications using the
cl from the platform SDK in wine; I haven't been using it for make
crosstest.
> Your version
On Tue, Jul 5, 2011 at 8:27 AM, Marvin wrote:
> === WXPPROSP3 (32 bit math) ===
> math.c:2275: Test failed: Got , expected 7fff or 7fff for index 18.
0.0f/0.0f = -nan (0xffc0)
-(0.0f/0.0f) = nan (0x7fc0)
msvc complains about dividing by zero. I found the following works
around the er
The latest ConvertPointRepsToAdjacency patches look good.
On Sat, Jul 2, 2011 at 1:01 PM, Michael Mc Donnell wrote:
> Thank you for the good review.
Glad you appreciate them. Here is another.
> +static HRESULT init_edge_face_map(struct edge_face_map *edge_face_map, CONST
> DWORD *index_buffer, CONST DWORD *point_reps, CONST DWORD num_faces)
> +{
...
On Thu, Jun 30, 2011 at 3:50 PM, Michael Mc Donnell
wrote:
> I've implemented the look-up scheme that you described.
> +if (!point_reps) /* Indentity point reps */
> +{
> +memset(adjacency, -1, 3 * num_faces * sizeof(*adjacency));
> +return D3D_OK;
> +}
I think you ar
On Wed, Jun 29, 2011 at 11:16 AM, Misha Koshelev wrote:
> Submitted by original author as requested by Alexandre. Necessary for
> further patches by Dylan Smith to fix bug 25769.
>
Attached are the further patches he is referring to, which are based on his
patch ser
On Fri, Jun 24, 2011 at 11:04 AM, Dylan Smith wrote:
> So how about the revised patch that uses memset to set all the bits to 1.
Oops, forgot to diff against origin. Attached patch against origin.
diff --git a/dlls/d3dx9_36/tests/mesh.c b/dlls/d3dx9_36/tests/mesh.c
index a07cc9d..8a87da3 100
On Fri, Jun 24, 2011 at 10:19 AM, Stefan Dösinger
wrote:
> On Friday 24 June 2011 16:01:21 Dylan Smith wrote:
>> On Fri, Jun 24, 2011 at 9:31 AM, Michael Stefaniuc
> wrote:
>> > this commit breaks compilation on my old RHEL5 box:
>> > dlls/d3dx9_36/tests/mesh.c:48
future reference.
commit a247dd5dbf40c859fb9a77352cc8f6c556c69cc8
Author: Dylan Smith
Date: Fri Jun 24 09:53:57 2011 -0400
d3dx9/tests: Avoid using FP_NAN for portability.
diff --git a/dlls/d3dx9_36/tests/mesh.c b/dlls/d3dx9_36/tests/mesh.c
index a07cc9d..54ef66b 100644
--- a/dlls/d3dx9_36/tests/mesh.c
On Thu, Jun 23, 2011 at 8:18 AM, Michael Mc Donnell
wrote:
> I've change the test a bit. I split up the complex example (mesh6)
> into two simpler examples. I also got inspired by your ASCII
> illustrations and have added my own in the comments. The examples have
> also been updated so that they a
On Wed, Jun 22, 2011 at 4:08 PM, Stefan Dösinger wrote:
> I'll have to do some more background reading on the kind of mesh data
> structures used here before I can give qualified comments on your patches, so
> for now I'll yield to Dylan :-)
I looked over the latest patches, and the code looks
On Wed, Jun 22, 2011 at 4:08 PM, Stefan Dösinger wrote:
> I'll have to do some more background reading on the kind of mesh data
> structures used here before I can give qualified comments on your patches, so
> for now I'll yield to Dylan :-)
I couldn't actually find information on point represe
On Wed, Jun 22, 2011 at 10:12 AM, Michael Mc Donnell
wrote:
> Thanks your comments. I've attached an updated version.
> +if (indices) HeapFree(GetProcessHeap(), 0, indices);
> +}
> +if (new_indices) HeapFree(GetProcessHeap(), 0, new_indices);
HeapFree checks for NULL for you, so
On Tue, Jun 21, 2011 at 6:32 AM, Michael Mc Donnell
wrote:
> Here is my test and implementation of ConvertAdjacencyToPointReps.
> + hr = iface->lpVtbl->LockIndexBuffer(iface, D3DLOCK_READONLY,
> (void**)&indices);
> + if (FAILED(hr)) goto cleanup;
> + memcpy(new_indices, indices, This-
On Thu, Jun 16, 2011 at 4:49 AM, Michael Mc Donnell
wrote:
>
> Yeah it turned out to be a lot harder than I had expected to get all
> the details correct. I have also added a check for non-zero stream
> values that Dylan Smith wanted me to add.
>
Thanks. Looks good to me too now.
On Fri, Jun 10, 2011 at 2:08 AM, Dylan Smith wrote:
> D3DXCreateMesh fails when the declaration contains a non-zero Stream
> value. I would expect UpdateSemantics to be as strict as D3DXCreateMesh,
> otherwise a test could validate the different behaviour.
Seems like you missed this
> +static void test_update_semantics(void)
> +{
> ...
> + int offset = 12;
sizeof(D3DXVECTOR3) might be clearer.
Your patches have dos line endings (i.e. "\r\n") which causes git apply to
fail, although the patch command only gives a warning.
@@ -208,6 +221,12 @@ static DWORD WINAPI
> ID3DXMeshImpl_GetNumBytesPerVertex(ID3DXMesh *iface)
> TRACE("iface (%p)\n", This);
> +if (!This->vertex_declaration
I can't seem to reproduce this patch apply failure. Is there a way to
check if the wine testbot is building against origin (currently commit
5bf7622fc3ad043cb17accfefcaf5b6371f80a8e)? Because the apply failure
is completely consistent with applying my patchset against yesterdays
last commit (441f
7c6f3aad688 Mon Sep 17 00:00:00 2001
From: Dylan Smith
Date: Tue, 12 Apr 2011 17:35:20 -0400
Subject: [2/5] d3dx9: Generate effect instances from materials for mesh
loading. (try 3)
Reply-To: wine-devel
To: wine-patches
---
dlls/d3dx9_36/d3dx9_36_private.h |2 +
dlls/d3dx9_36/mes
On Sun, May 22, 2011 at 3:10 AM, Stefan Dösinger wrote:
> On Sunday 22 May 2011 06:57:30 Dylan Smith wrote:
>> 4 bytes of padding are at the end of DDSURFACEDESC when compiling for
>> x64, because it contains a pointer field followed by an odd number
>> of DWORD fields.
>
On Thu, May 19, 2011 at 6:16 AM, Joris Huizer wrote:
>
> Hello,
>
> I found a possibly memory leak in the patch.
> In this function:
>
>> +static HRESULT parse_mesh(IDirectXFileData *filedata, struct mesh_data
>> *mesh_data, DWORD provide_flags)
>
> These may leak the allocated blocks:
>>
>> +
>>
On Sun, May 8, 2011 at 3:18 PM, Matteo Bruni wrote:
> 2011/5/6 Dylan Smith :
> > +struct vertex_attrib_duplication {
> > +DWORD attrib;
> > +DWORD vertex_index;
> > +struct vertex_attrib_duplication *ptr;
> > +};
> ...
> > +struc
On Sun, May 8, 2011 at 3:17 PM, Matteo Bruni wrote:
> 2011/5/6 Dylan Smith :
>
> ...
> > +new_vertex_buffer_size = This->numvertices;
> ...
> > +new_vertex_buffer_size *= vertex_size;
> > +hr = IDirect3DDevice9_CreateVertexBuffer(This-
On Thu, May 5, 2011 at 11:39 AM, Marcus Meissner wrote:
> Hi Dylan, folks,
>
> Coverity sees following constructs in dlls/riched20/tests/editor.c
> introduced by your commit aa3b75f6b74fa87641b1f2b5912fbb82feb4c2da
>
> +SendMessage(hwndRichEdit, WM_CHAR, 22,
> +(MapVirtualKey(
On Thu, Apr 28, 2011 at 3:59 PM, Austin English wrote:
>
> Looks like some C99 comments slipped in.
>
> It is an X file, not a c file, so the c compiler never touches it directly.
C style comments are also not supported in X files, just // or # style
comments.
On Tue, Apr 26, 2011 at 4:15 PM, Michael Mc Donnell wrote:
>
> > Completely unimplemented:
> > - ConvertPointRepsToAdjacency
> > - ConvertAdjacencyToPointReps
> > - UpdateSemantics
>
> Ok so I can still work on ConvertPointRepsToAdjacency and
> ConvertAdjacencyToPointReps?
>
> Yes. I had no plans
On Sun, Mar 20, 2011 at 1:09 PM, Michael Mc Donnell
wrote:
> I would like implement some of the missing mesh functions in Wine's
> D3DX9 for Google Summer of Code 2011. I would like to implement the
> following functions:
> - CloneMesh
> - CloneMeshFVF
> - ConvertPointRepsToAdjacency
> - Conve
On Tue, Apr 19, 2011 at 8:32 AM, Alexandre Julliard wrote:
>
> Dylan Smith writes:
>
> > +#ifndef __WINE_RMXFTMPL_H
> > +#define __WINE_RMXFTMPL_H
> > +
> > +/* sizeof(D3DRM_XTEMPLATES) */
> > +#define D3DRM_XTEMPLATE_BYTES 3278
> > +
> &g
On Thu, Apr 7, 2011 at 1:00 PM, Dylan Smith wrote:
>
> The rest of the richedit code needs to call the ITextHost interface
> using the thiscall calling convention, so on i386 it calls a thunk in
> itextHostStdcallVtbl which are defined using the stdcall calling
> convention, and
On Thu, Apr 7, 2011 at 12:17 PM, Michael Stefaniuc wrote:
>
> Dylan Smith wrote:
> > On Thu, Apr 7, 2011 at 5:30 AM, Michael Stefaniuc wrote:
> >
> >> The COM methods are already __stdcall.
> >> ---
> >> dlls/riched20/txthost.c | 128
> >>
On Thu, Apr 7, 2011 at 5:30 AM, Michael Stefaniuc wrote:
> The COM methods are already __stdcall.
> ---
> dlls/riched20/txthost.c | 128
> ++
> 1 files changed, 39 insertions(+), 89 deletions(-)
>
> COM methods are supposed to use the stdcall calling c
On Wed, Mar 16, 2011 at 3:57 AM, Francois Gouget wrote:
> Any reason why we were not freeing glyphmetrics_float?
>
No reason, just a mistake on my part.
On Fri, Mar 11, 2011 at 9:44 AM, Alexandre Julliard wrote:
>
> That stuff needs to be generated from source, you can't just copy the
> native header contents.
>
Is the following acceptable?
1. Implement IDirectXFileSaveObject::SaveTemplates
2. Create programs/dxfconv as a wine program that uses
On Wed, Mar 9, 2011 at 8:02 AM, Alexandre Julliard wrote:
>
> Is there a reason for not using qsort?
>
> No.
I didn't realize the function existed in the c standard library.
2010/9/7 Mariusz Pluciński
> In my opinion it would be good to make it available in similar way, as
> functions like debugstr_guid, which are defined in include/wine/debug.h
>
> Messages' names are declared as an array MessageTypeNames in spy.c . Maybe
> it would be enough to copy it into the hea
2010/8/4 André Hentschel
> Hi,
> what is the best/easiest/fastest way to hack Wine so it does not start
> winedbg and i can debug it with gdb?
> my problem is that my WineARM works so far that it tries to run winedbg and
> uses its own handlers. but i want that not to happen
> of course it crashe
On Mon, Jul 26, 2010 at 3:48 PM, Dylan Smith wrote:
> On Mon, Jul 26, 2010 at 3:26 PM, James Mckenzie <
> jjmckenzi...@earthlink.net> wrote:
>
>>
>> Just a question, I don't see 1/6 in this sequence. Was it submitted
>> earlier?
>>
>> I sent
On Mon, Jul 26, 2010 at 3:26 PM, James Mckenzie
wrote:
>
> Just a question, I don't see 1/6 in this sequence. Was it submitted
> earlier?
>
> I sent it, but somehow it must have gotten lost along its digital path. It
shows up in my gmail sent mail folder.
On Tue, Jul 20, 2010 at 8:34 PM, Marvin wrote:
> === W7PRO (32 bit win) ===
> win.c:823: Test failed: wrong dwWindowStatus: != 0001 active 006E01AE
> fg 00030050 in hook HCBT_SETFOCUS
> win.c:823: Test failed: wrong dwWindowStatus: != 0001 active 007001AE
> fg 00030050 in hook HCBT_SETF
On Sat, Jul 17, 2010 at 11:32 PM, Dmitry Timoshkov
wrote:
>
> Testing other values besides 0 would be helpful, in particular values like
> sizeof(class) - 1 and sizeof(class) + 1. Did you inspect all the places
> in Wine which call RegisterClassEx()? Also, GetClassInfoEx() in Wine is an
> obvious
In richedit.h CHARFORMAT2[AW] is padded differently on the Windows
PSDK depending on whether it is included for a c or c++ source file.
Should the include file be fixed, or does bug for bug compatibility
mean that a correct CHARFORMAT2 structure should be declared in a
private include file?
I tri
---
programs/wordpad/Zh.rc | 24
1 files changed, 0 insertions(+), 24 deletions(-)
diff --git a/programs/wordpad/Zh.rc b/programs/wordpad/Zh.rc
index 135f00c..bae40a7 100644
--- a/programs/wordpad/Zh.rc
+++ b/programs/wordpad/Zh.rc
@@ -111,30 +111,6 @@ BEGIN
END
On Sun, Jun 20, 2010 at 6:00 PM, James McKenzie
wrote:
> While looking for implementation guidance at google.com, came across the
> value for WB_ISDELIMITER which was not in richedit.h. This patch adds this
> value which will be necessary for full implementation of this function.
>
> WB_LEFT, WB_
>-/* FIXME: Allow other units and convert between them */
> if(!lstrcmpA(endptr, units_cmA))
>+{
>+if (punit != NULL) *punit = UNIT_CM;
>+endptr += 2;
>+}
>+else if (!lstrcmpA(endptr, units_inA))
>+{
>+if (punit != NULL) *punit = UNIT_INCH;
>+
On Sun, Feb 28, 2010 at 3:16 PM, Andrew Eikum
wrote:
> I'd be very surprised if git is modifying your patches without telling you.
> It's probably Gmail trying to be clever. Telling git-imap-send to send as
> an attachment (--attach) might fix the issue. Or, if you're already doing
> that, mayb
On Sun, Feb 28, 2010 at 1:09 PM, James McKenzie
wrote:
>
> git apply complains about whitespace errors:
> 0001-richedit-Documented-paragraph-border-widths-are-in-p.patch:10:
> trailing whitespace.
> int ME_GetParaBorderWidth(ME_Context *c, int flags);
> 0001-richedit-Documented-paragraph-border-wi
On Wed, Feb 24, 2010 at 9:04 AM, James Mckenzie
wrote:
> >Either one or two pages may be shown in print preview when zoomed out.
> >This value is stored in the registry in native wordpad, and preserved
> >while opening and closing the print preview. Zooming in will only show
> one
> >page, but th
On Sun, Feb 21, 2010 at 9:33 AM, James McKenzie
wrote:
> This is how I calculated the value to be the same as that returned by
> EM_FORMATRANGE when run in Windows(whatever). If you have a better
> method, that would be great.
>
I have a better method, it is returning textlength + 1 in this case
You accidentally sent the email for try 2 of this patch to wine-devel
instead of wine-patches.
In function ME_FormatContent in file paint.c you calculate the value
>+ numCharPrintable = c.nAvailWidth / (1440/c.dpiTarget.cy);
then use it later to set iEndOffset, the return value, when the
remainde
On Thu, Sep 24, 2009 at 2:25 PM, James Mckenzie
wrote:
> >From: Dylan Smith
> >Sent: Sep 24, 2009 6:02 AM
> >To: wine-patches
> >Subject: richedit: Silence fixme for WM_STYLECHANGING & WM_STYLECHANGED.
> >
> >I have tried changing the different styles,
On Wed, Sep 2, 2009 at 12:15 PM, wrote:
> Hi,
>
> although wine in MacOSX works generally good enough (see test.winehq.org about
> release 1.1.28), I recently visited the print menu in notepad and wordpad to
> see whether printing would work (in order to complete the FAQ).
>
> All that happened is
On Wed, Sep 2, 2009 at 1:34 PM, Sergey Khodych wrote:
>
>> 1. editor->hWnd may be NULL for windowless richedit controls, but you
>> code doesn't seem to take that into consideration.
>> 2. The style flags that you get from GetWindowLongW should probably
>> come from the cached values in editor->sty
> 3. Is there any need for storing the hwndParent in editor. Couldn't
> the value be obtained by using GetWindowLongW using GWL_HWNDPARENT
> after making sure that editor->hWnd is non-NULL (i.e. windowed mode).
>
Scratch that point, I see that it is tested for using SetParent in the
tests after cr
On Tue, Sep 1, 2009 at 4:18 AM, Sergey Khodych wrote:
> @@ -2145,6 +2145,31 @@ ME_KeyDown(ME_TextEditor *editor, WORD nKey)
> ME_SendRequestResize(editor, FALSE);
> return TRUE;
> case VK_RETURN:
> + if (editor->bDialogMode)
> + {
> + DWORD dwStyle;
> +
> +
On Fri, Aug 28, 2009 at 5:57 PM, John Klehm wrote:
>
> On Fri, Aug 28, 2009 at 3:13 PM, Dylan Smith wrote:
> > (used sed to get the EXEEXT from the wine-tools/Make.rules file)
> >
> > When compiling Wine on windows, the non-script tools will have an .exe
> > ext
On Thu, Aug 27, 2009 at 10:02 AM, Alexandre Julliard wrote:
> Any decent shell should be able to run apps without .exe suffix on
> Windows.
There is no problem with running something with an exe suffix, it is
the Makefile rules that are causing the trouble.
For instance, when building a program,
On Wed, Aug 26, 2009 at 5:26 PM, Steven Edwards wrote:
> I've never had a problem building most of Wine with cygwin or
> msys+mingw before. Is this new behaviour?
What do you mean by most of Wine? I am trying to easily build all of
Wine from Windows.
I was able to build the whole wine tree on w
On Fri, Feb 27, 2009 at 8:32 PM, Dan Kegel wrote:
> Hmm. So making riched20 prefer native would break apps
> that use msftedit, if native riched20 but no native msftedit is present?
>
Yes. Although I haven't heard of this being an issue with people using
winetricks.
>
> Does this mean that ou
On Fri, Feb 27, 2009 at 3:14 PM, Dan Kegel wrote:
> Say, have we considered making riched20 prefer native?
> That makes the app work, too.
>
A couple of things to note, in case they are relevant:
1. msftedit currently uses the native version by default
2. builtin msftedit will not work with nati
On Mon, Feb 16, 2009 at 3:19 PM, James McKenzie
wrote:
> Would this be needed for EM_FORMATRANGE support or can this safely be
> removed. Don't want to delete and then add back code.
>
This wouldn't be needed for EM_FORMATRANGE. If it were to duplicate the
text to cache the formatting it could
On Sat, Feb 7, 2009 at 9:33 AM, Andrew Talbot
wrote:
>
> @@ -65,17 +65,6 @@ ME_String *ME_MakeStringR(WCHAR cRepeat, int nMaxChars)
> return s;
> }
>
> -ME_String *ME_MakeStringB(int nMaxChars)
> -{ /* Create a buffer (uninitialized string) of size nMaxChars */
> - ME_String *s = ALLOC_OBJ(ME_
On Fri, Jan 16, 2009 at 6:21 PM, Ge van Geldorp wrote:
>
> The riched20:editor test seems to be sending Ctrl-C keystrokes to the
> wrong window on Windows. When running "winetest -q" They end up in the
> winetest console window, causing it to terminate. Judging from the lack of
> test results, I'm
On Sun, Jan 11, 2009 at 6:32 AM, Detlef Riekenberg wrote:
> Hi Dylan.
> After testing your first Patch, i tried this one:
> patching file dlls/riched20/tests/editor.c
> Hunk #1 succeeded at 5826 (offset 23 lines).
> Hunk #2 succeeded at 5856 (offset 23 lines).
> Hunk #3 succeeded at 6281 (off
On Sat, Jan 3, 2009 at 12:37 AM, Dmitry Timoshkov wrote:
> "Dylan Smith" wrote:
>
> - SendMessageA(GetParent(hWnd), WM_COMMAND,
>> (nCode<<16)|GetWindowLongW(hWnd, GWLP_ID), (LPARAM)hWnd);
>> + SendMessageA(GetParent(hWnd), WM_COMMAND, (nCode<<16
The problems with having the macros in the public headers are that they
won't work on x86 machines, and are not included in the public headers.
Therefore someone developing for another platform will have their code break
when using the native public headers or when porting the code to an x86
where
On Sat, Nov 8, 2008 at 10:40 AM, Peter Oberndorfer <[EMAIL PROTECTED]>wrote:
> This page [1] seems to suggest memory returned from HeapAlloc
> is marked as not executable.
> Other tests (ntdll exception) are using VirtualAlloc()
> for dynamically created code.
>
> patch 1
> > +/* The following x86
On Mon, Oct 6, 2008 at 2:17 AM, Dmitry Timoshkov <[EMAIL PROTECTED]>wrote:
> You need to fix SCROLL_GetScrollBarRect for the SB_CTL case instead.
>
SCROLL_GetScrollBarRect is used is used in multiple places where client
coordinates are expected, and it isn't just the SB_CTL case that needs to be
On Sat, Oct 4, 2008 at 1:21 AM, Dylan Smith <[EMAIL PROTECTED]>wrote:
> Implemented the code to check for this condition in the function that
> handles WM_SETCURSOR. For each scrollbar I checked for visibility and
> checked the MessagePos to see if the mouse was over the scrollbar
On Wed, Oct 1, 2008 at 6:13 AM, Rob Shearman <[EMAIL PROTECTED]>wrote:
> 2008/9/30 Dylan Smith <[EMAIL PROTECTED]>:
> > -exec $WINETEST_WRAPPER "$topobjdir/wine" "$program" "$infile" "$@"
> > +exec $WINETEST_WRAPPER "
On Thu, Sep 11, 2008 at 4:30 PM, Juan Lang <[EMAIL PROTECTED]> wrote:
> Hi Dylan, commit 11c80396995065701205f2facb3dba10a6f8170f[1]
> introduced a buffer overrun in riched20's editor.c.
>
Thanks for pointing out the problem.
I sent a patch to wine-patches that fixes the problem.
http://www.win
It seems like I somehow missed the fact that patch was already accepted
on the first try, however I still ended up rebasing the patch against the
origin.
I'll resend it anyways, since the commit message needs to be changed.
On Thu, Sep 11, 2008 at 10:34 AM, Dylan Smith <[EMAIL PROTECTE
at 10:54 PM, Dylan Smith <[EMAIL PROTECTED]>wrote:
> Previously the control words in skipped groups were being processed by
> the read hook on the RTF parser. By moving this code into the class
> callbacks for the parser, the skipped groups actually remain skipped.
>
> An exa
On Tue, Aug 19, 2008 at 7:14 PM, Maarten Lankhorst
<[EMAIL PROTECTED]> wrote:
> I would like to request from the mentors to fill in the final evaluation
> form and from the students to give a final write up: What went well? Did
> you meet the goals you set? Did you have fun? Is there anything we ca
On Mon, Jul 7, 2008 at 5:39 PM, Maarten Lankhorst <[EMAIL PROTECTED]>
wrote:
> Hi students,
>
> As you might know it's time for midterm evaluations. Unfortunately for
> some students I haven't seen the progress they made, and I highly
> encourage all students to send their patches early and often,
On Thu, Jul 3, 2008 at 2:01 PM, Juan Lang <[EMAIL PROTECTED]> wrote:
> Hi Dylan,
>
> - if (!editor->bEmulateVersion10 || (editor->nEventMask & ENM_UPDATE))
> + if (!editor->dwEmulatedVersion || (editor->nEventMask & ENM_UPDATE))
>
> This change is incorrect, as dwEmulatedVersion is never set to
On Wed, Jul 2, 2008 at 1:31 PM, Alex Villacís Lasso
<[EMAIL PROTECTED]> wrote:
>
> Alex Villacís Lasso escribió:
> > This is supposed to be a fix for bug #12311 . This bug involves a
> > recursive message loop where the application forces visibility of
> > scrollbars for the richedit control, whi
On Wed, Jul 2, 2008 at 12:52 AM, Dylan Smith <[EMAIL PROTECTED]> wrote:
>
> On Tue, Jul 1, 2008 at 1:24 PM, James Hawkins <[EMAIL PROTECTED]> wrote:
> > This commit is causing ~350 failures on all platforms. Please send in
> > a fix or a revert patch.
>
> O
On Tue, Jul 1, 2008 at 1:24 PM, James Hawkins <[EMAIL PROTECTED]> wrote:
> This commit is causing ~350 failures on all platforms. Please send in
> a fix or a revert patch.
Oh, crap. You are right, I must have only tested this on Windows with
further patches applied that fix this problem. There
On Fri, Jun 27, 2008 at 12:43 PM, Dylan Smith <[EMAIL PROTECTED]> wrote:
> Rather than using one URL for all the messages, you could also cycle through
> URL after testing them initially. It would have the same performance of
> using the same valid URL, but keeps the variety in the
Ignore this patch, I still need to work on it.
I ran the test again under valgrind the key events were not getting sent
at first in test_EM_AUTOURLDETECT, and then started working after
some point. I'll resubmit it when it is done properly.
On Sat, Jun 28, 2008 at 11:36 AM, Dylan Smith &l
On Sun, Jun 29, 2008 at 4:20 AM, Phil Krylov <[EMAIL PROTECTED]> wrote:
> Of course this looks most sane. But I'm asking if you're going to make
> use of the dwEmulatedVersion other than "< 0x200"? That is, under what
> circumstances we should emulate version 2 or 3 when we have support
> for versi
The error was a memory access of a freed object. In ME_AddUndoItem I
checked the top of the undo stack to end a coalescing undo transaction,
assuming that this should be either a valid undo item, or NULL, instead
it was already freed.
The undo item being added was actually being added to the redo
er to
programs using them, but this seem too inflexible to me.
4. We could also have a single implementation with preprocessor conditions,
and then compile the code twice with different defines.
On Fri, Jun 27, 2008 at 3:30 PM, Phil Krylov <[EMAIL PROTECTED]> wrote:
> Hi,
>
> 2008/6/27
paragraphs/table rows).
On Thu, Jun 26, 2008 at 10:35 PM, James McKenzie <[EMAIL PROTECTED]>
wrote:
> Alex Villacís Lasso wrote:
>
>> Dylan Smith escribió:
>>
>>
>>> EM_STOPGROUPTYPING simply ends the undo coalescing transaction. The
>>> remarks for
On Fri, Jun 27, 2008 at 12:22 PM, Alex Villacís Lasso <
[EMAIL PROTECTED]> wrote:
> Dan Kegel escribió:
> > Under Valgrind, on my nice fast e7200 system,
> > the entire suite of tests takes about three hours to run.
> >
> > The slowest ten percent of the tests take over a third of the runtime.
>
Thanks for catching that. I didn't mean to leave that in, and should have
searched my patch for those comments.
I'll fix fix it and resubmit the patch.
On Wed, Jun 25, 2008 at 5:24 AM, Michael Stefaniuc <[EMAIL PROTECTED]>
wrote:
> Hello Dylan,
>
> Dylan Smith wr
o make the dependancies clearer next
time.
On Mon, Jun 23, 2008 at 5:10 PM, Dylan Smith <[EMAIL PROTECTED]>
wrote:
> To test the bug, open up Wine's wordpad (try with native and builtin
> riched20), then enter a line of text that ends with enough trailing
> spaces to go past t
IL PROTECTED]>
wrote:
> Dylan Smith wrote:
> > + if (!inStream.editstream->dwError && parser.stackTop > 0)
> > +inStream.editstream->dwError = -2147024858;
>
> This should be HRESULT_FROM_WIN32(ERROR_HANDLE_EOF).
>
> --
> Rob Shearman
various lengths, and with
different thumb sizes. However, I don't know how to make the scrollbar
wider.
On Wed, Jun 18, 2008 at 2:43 AM, Rob Shearman <[EMAIL PROTECTED]>
wrote:
> Dylan Smith wrote:
> > + /* Distance beside or past the ends the scrollbar for the mo
Hello everyone,
My name is Dylan Smith, and I will be working on implementing tables in rich
edit controls as a Google Summer of Code project. Any remaining time I have
will also be focused on rich edit controls for this summer.
Forgive me for taking so long to introduce myself on the
93 matches
Mail list logo
