Re: question about standalone tests

2005-05-24 Thread Dimitrie Paun
From: "Kees Cook" <[EMAIL PROTECTED]> > Is there some new way to build standalone tests, or should I send a > patch for re-including the #ifndef STANDALONE stuff for the tests? Please don't add the ugly #idfes back. What you need is an out-of-source (dummy) implementation of the Wine test framew

Re: Corrected the determination of capturing inside EDIT_WM_MouseMove function.

2005-05-20 Thread Dimitrie Paun
> Hence, the modification was made so that the text selection by mouse movement will only occur when edit control itself sets the capture. OK, I'm sold, but can you please resubmit the patch with an appropriate comment explaining the problem? -- Dimi Paun <[EMAIL PROTECT

Re: Move GDI handles to the large heap

2005-05-19 Thread Dimitrie Paun
From: "Alexandre Julliard" <[EMAIL PROTECTED]> > > In particular, what do we do with > > windows/syscolor.c:SYSCOLOR_MakeObjectSystem() > > Now you know why this hasn't been done yet ;-) What about a private __wine_make_system_object()? It's not like we'll use our USER on windows, no? -- D

Re: Wiki tips

2005-05-19 Thread Dimitrie Paun
These are good tips. Maybe we should collect them on the Wiki :) Couple more: -- if you want to put your email on your page, but are afraid of spam, use the MailTo macro like so: [[MailTo(dimi AT SPAMFREE lattica DOT com)]] This will still show the address properly in the browser,

Re: Corrected the determination of capturing inside EDIT_WM_MouseMove function.

2005-05-19 Thread Dimitrie Paun
> With only GetCapture() != es->hwndSelf statemet, the string selection will occur > even if the capturing is done by external processes. So what you are saying is that an external process captures the mouse, and somehow GetCapture() returns the handle of this edit. Why would tha

Re: Added the feature to change row height in owner draw controls.

2005-05-19 Thread Dimitrie Paun
> I will send the modified patch with 4 space indents. Thanks! > But because some of the original source codes do not have 4 space indents, > patches there are matched with the original code's indents. I know, I hope to get time to hack some more on listview, review the c

Re: Translate the WineFAQ to French

2005-05-18 Thread Dimitrie Paun
From: "Francois Gouget" <[EMAIL PROTECTED]> > [...] here's a patch to translate the > Wine FAQ to French using the new po4a/ directory. OK, I've applied the patch to make your life easier, but it needs a lot of work: A. It doesn't work for me (details below) B. The po-rules need to be moved to

Re: [Fwd: Relationship between Wine and the proprietary versions.]

2005-05-17 Thread Dimitrie Paun
From: "Brian Vincent" <[EMAIL PROTECTED]> > I think we need to get the scripts first. > Do you already have them? They are in the tools/ module in the WineHQ CVS: http://cvs.winehq.org/cvsweb/tools/ Namely 'make_winehq' and 'wine_release'. -- Dimi Paun <[EMAIL PROTECTED]> Lattica, Inc.

Re: Added the callback item processing for LISTVIEW_EndEditLabelT function.

2005-05-17 Thread Dimitrie Paun
> Added the callback item processing for LISTVIEW_EndEditLabelT function. I think this would be a bit more explicit and correct (is_textW() returns false if pszText == NULL) if the test is the other way around: +if (lpItem && lpItem->hdr.pszText == LPSTR_TEXTCALLBACKW) +

Re: [Fwd: Relationship between Wine and the proprietary versions.]

2005-05-17 Thread Dimitrie Paun
From: "Brian Vincent" <[EMAIL PROTECTED]> > Submitted to wine-patches. The account I mailed it from isn't > subscribed, so it may take a while to get moderated on. Many thanks! > I also added an entry for how to update the FAQ since it's recently > changed. That leads me to ask - has WineHQ be

Re: Corrected the determination of capturing inside EDIT_WM_MouseMove function.

2005-05-17 Thread Dimitrie Paun
> Corrected the determination of capturing inside EDIT_WM_MouseMove function. > - if (GetCapture() != es->hwndSelf) > + if (GetCapture() != es->hwndSelf || !es->bCaptureState) Can we have GetCapture() == es->hwndSelf && !es->bCaptureState If so, isn't this an invalid

Re: Added the feature to change row height in owner draw controls.

2005-05-17 Thread Dimitrie Paun
> Added the feature to change row height in owner draw controls. The indentation looks a bit funky on this one -- can you please use 4-space indentation? -- Dimi.

Re: edit: no not use LOCAL_*() functions

2005-05-16 Thread Dimitrie Paun
From: "Alexandre Julliard" <[EMAIL PROTECTED]> > It seems dangerous to set DS for the whole window procedure, it will > be calling a lot of other functions that may end up depending on > DS. It's especially dangerous here since the window instance won't be > a valid DS for 32-bit windows. I think y

Re: Implement RegNotifyChangeKeyValue on top of NtNotifyChangeKey

2005-05-16 Thread Dimitrie Paun
> This patch removes the last server call from advapi32 and we should keep > it free from server calls to reduce the effects of the changing of a > server interface. Nice. BTW, what DLLs make server calls? Any other that shoudn't but still do? -- Dimi.

Re: Video capturing under Wine, some overview

2005-05-13 Thread Dimitrie Paun
> What are the thoughts about this? Having a winev4l seems like it would be the way to go. There's a lot of good info in this message, maybe you can create a page on the Wiki to capture all this stuff. -- Dimi.

Re: [WINEDOCS] Add French translation for Wine's FAQ

2005-05-13 Thread Dimitrie Paun
> The best way to do that would be to do a vendor import. The way to do > that would be as follows: True. There's no point to first add the Fr translation and then po4a if the FR requires it. We need to decide if we are going to use it or not. I have no experience with it, any other opinions out

Re: winefile temporary allocations

2005-05-13 Thread Dimitrie Paun
> > Doesn't HeapAlloc work on any 'Win32' platform? > > I want to avoid calling heap allocation functions. > Using alloca() is slightly lighter. Please don't do that. It uglifies the code, and makes it less reliable. alloca() is lighter but it's on the stack, and I really doubt that yoy can measu