Re: DirectSound, new patch available for testing

2005-11-07 Thread Davin McCall
Juergen, Sorry for the slow reply. Thanks for responding. Because a couple of people (including yourself) had bad results with this patch, I've put it on hold for the moment, except for the alsa-driver part which has now gone into wine CVS. That alone gives a good improvement on my own system (

Re: DirectSound, new patch available for testing

2005-11-07 Thread Davin McCall
On Mon, 7 Nov 2005 09:52:35 +0100 Molle Bestefich <[EMAIL PROTECTED]> wrote: > Great explanation, thanks!!! > Greatly appreciated by me and I'm sure a lot others. Good :-) > I'm missing a point from your explanation here: > Why do you even need the hardware play position? > It seems that the ALS

Re: DirectSound, new patch available for testing

2005-11-06 Thread Davin McCall
On Mon, 07 Nov 2005 18:25:49 + Randall Walls <[EMAIL PROTECTED]> wrote: > This has since been changed with your patch to: > > hw_ptr = This->mmap_ppos; > > Just curious if you could shed a bit of light on this. As I said, the > original patch did not fix my specific problem, but I would cur

Re: DirectSound, new patch available for testing

2005-11-03 Thread Davin McCall
reduce underrun problems). Davin On Thu, 3 Nov 2005 18:42:50 +1100 Davin McCall <[EMAIL PROTECTED]> wrote: > Thanks for that - > > There was at least one problem with the patch. I've attached a fix for that > (apply over the top of the previous one). > > I don

Re: DirectSound, new patch available for testing

2005-11-03 Thread Davin McCall
Davin On Thu, 3 Nov 2005 18:42:50 +1100 Davin McCall <[EMAIL PROTECTED]> wrote: > Thanks for that - > > There was at least one problem with the patch. I've attached a fix for that > (apply over the top of the previous one). > > I don't get buffer unde

Re: DirectSound, new patch available for testing

2005-11-02 Thread Davin McCall
Thanks for that - There was at least one problem with the patch. I've attached a fix for that (apply over the top of the previous one). I don't get buffer underruns in my own testing, but I do get an annoying clicking noise every so often (seems to be when streaming buffers wrap from the end b

Re: DirectSound, new patch available for testing

2005-11-02 Thread Davin McCall
On Wed, 2 Nov 2005 14:02:55 + (GMT) Robbert Xerox <[EMAIL PROTECTED]> wrote: > Hi Davin,Two questions about this: > the patch fails here at hunk 5 with current cvs. Works for me... I just made sure I had the latest files from CVS, but there have been no updates to these files since wine-0.9,

DirectSound, new patch available for testing

2005-11-02 Thread Davin McCall
To all those who tested my previous patch, thanks. I have a new patch which may help to resolve some of the (few) issues which cropped up. The "length not a multiple of block size" issue has been partially addressed. Also, buffer underruns should be far less frequent than the previous patch if

Re: DirectSound problems - dlls/dsound/mixer.c

2005-11-01 Thread Davin McCall
By all means. Davin On Mon, 31 Oct 2005 22:06:20 -0800 Dan Kegel <[EMAIL PROTECTED]> wrote: > I'm seeing a lot of stuttering in the sound for Kid Pix 4; see > http://bugs.winehq.org/show_bug.cgi?id=3553 > for a log with last night's cvs. > Should I try your patch?

Re: DirectSound problems - dlls/dsound/mixer.c

2005-10-31 Thread Davin McCall
On Tue, 01 Nov 2005 02:29:25 + Randall Walls <[EMAIL PROTECTED]> wrote: > Scratch that after spending about an hour playing Battlezone 2 > tonight (with patch applied) I noticed that certain sounds (mainly > sounds longer than a few seconds) would exhibit a strange problem with > the la

Re: Patch: DSound: PhaseCancel subtracts secondary from primary

2005-10-31 Thread Davin McCall
n sent in after mine had been accepted, so I guess I got worried - but you're right, it's too soon (though it is in fact Tuesday in my time zone :-)) Davin On Mon, 31 Oct 2005 18:07:08 -0700 Jesse Allen <[EMAIL PROTECTED]> wrote: > On 10/31/05, Davin McCall <[EMAIL PROT

Patch: DSound: PhaseCancel subtracts secondary from primary

2005-10-31 Thread Davin McCall
cel inverts the original waveform; with this patch it doesn't. Please consider accepting. Thanks, - Davin Changelog: DSound: PhaseCancel subtracts secondary buffer from primary buffer, not the other way around. Davin McCall[EMAIL PROTECTED] --- wine-0.9-orig/dlls/dsound/mixer.c Mon

Re: DirectSound problems - dlls/dsound/mixer.c

2005-10-30 Thread Davin McCall
factor of blocksize' problem that Randall Walls mentioned (I see the same message sometimes when I exit StarCraft). Will post another test patch here when I've made better progress. Davin On Mon, 31 Oct 2005 00:23:17 +1100 Davin McCall <[EMAIL PROTECTED]> wrote: > Good ne

Re: DirectSound problems - dlls/dsound/mixer.c

2005-10-30 Thread Davin McCall
rors when I patch mixer.c and audio.c. I'm patching against > the 0.9 release, not against cvs, but I don't think that would matter, I > don't think that the content of the files has changed since the release. > > I'll run through the patch and see if I can spot

Re: DirectSound problems - dlls/dsound/mixer.c

2005-10-30 Thread Davin McCall
Here is the patch. Davin On Sun, 30 Oct 2005 15:31:15 +0100 Stefan Dösinger <[EMAIL PROTECTED]> wrote: > Am Sonntag, 30. Oktober 2005 14:23 schrieb Davin McCall: > > Good news - I have got it working. It required work in both the mixer and > > the Wine ALSA sound driver.

Re: DirectSound problems - dlls/dsound/mixer.c

2005-10-30 Thread Davin McCall
Trying again as an inline attachment. Davin On Sun, 30 Oct 2005 15:31:15 +0100 Stefan Dösinger <[EMAIL PROTECTED]> wrote: > Am Sonntag, 30. Oktober 2005 14:23 schrieb Davin McCall: > > Good news - I have got it working. It required work in both the mixer and > > the Wine

Re: DirectSound problems - dlls/dsound/mixer.c

2005-10-30 Thread Davin McCall
esn't break anything else - StarCraft is one of the few Windows apps I actually have :-) Davin On Fri, 28 Oct 2005 18:24:36 +1000 Davin McCall <[EMAIL PROTECTED]> wrote: > Hi, > > I'm trying to sort out sound problems with StarCraft and have made some > progress

Re: DirectSound problems - dlls/dsound/mixer.c

2005-10-28 Thread Davin McCall
Yes, if sounds are being clipped at the end it does seem like the answer to my first question is "yes this is wrong". Thanks. I'll keep looking at it. Davin On Fri, 28 Oct 2005 16:34:05 +0200 Molle Bestefich <[EMAIL PROTECTED]> wrote: > Can't offer any help, except to say that I've noticed too

DirectSound problems - dlls/dsound/mixer.c

2005-10-28 Thread Davin McCall
Hi, I'm trying to sort out sound problems with StarCraft and have made some progress by hacking around with the "dlls/dsound/mixer.c" file. I'm new to Wine hacking however, and there's some things in the code which I don't understand (and others which seem blatantly wrong). Hopefully someone c