On Mon, May 30, 2011 at 12:45, David Hedberg wrote:
> ---
Sorry, the commit message should of course say bcrypt, not crypt32.
Hi Jay,
On Fri, Mar 25, 2011 at 21:51, Jay Yang wrote:
>> The code for creating new explorer windows should probably reside in
>> explorerframe.dll, somewhat analogous to how this works for the
>> Internet Explorer and shdocvw.dll.
>
> So would implementing explorerframe.dll be a good summer pro
Hi Jay,
On Thu, Mar 24, 2011 at 05:16, Jay Yang wrote:
> Hello,
>
> Since my first proposal got no response at all, I thought I'd offer
> another possible project I'm interested in. I looked a little into the
> "Implement the Explorer" project idea listed on the Summer of Code page on
> the wi
>> On Mon, Mar 21, 2011 at 14:55, Nikolay Sivov wrote:
>
> I think it is, it makes it clear that dialogue instance is about save or
> open, not both.
>
Ok, I'll change that.
> By the way, IFileSaveDialog is based on IFileDialog, and you add
> IFileDialog2 too. It's a bit messy,
> does target cla
On Mon, Mar 21, 2011 at 14:55, Nikolay Sivov wrote:
>> +typedef struct FileDialogImpl {
>> + IFileDialog2 IFileDialog2_iface;
>> + IFileOpenDialog IFileOpenDialog_iface;
>> + IFileSaveDialog IFileSaveDialog_iface;
>> + LONG ref;
>> +} FileDialogImpl;
>
> Maybe it's better to use a uni
Hi Jacek,
On Wed, Dec 22, 2010 at 13:07, Jacek Caban wrote:
>> + if(security_problem) {
>> + hres = IUnknown_QueryService((IUnknown*)This->base.protocol_sink,
>
> You shouldn't need the cast here.
>
I get warnings if I leave the casts out though, and I can't see any
obvious problem wi
On Mon, Nov 8, 2010 at 01:22, Vitaliy Margolen wrote:
>>
>> - ok(hr == S_OK, "got (0x%08x)\n", hr);
>> + ok(hr == S_OK || hr == E_FAIL /* Win7 */, "got (0x%08x)\n", hr);
>
> This can't be correct. It either works or it fails. Can't be both at the
> same time. You should look into why it's fa
On Thu, Aug 26, 2010 at 19:32, Octavian Voicu wrote:
> On Thu, Aug 26, 2010 at 8:11 PM, Juan Lang wrote:
>> Hi David, I know this was committed already, but something caught my
>> eye that I didn't understand:
>>
>> + if(This->navpane.show ^ show_navpane)
>>
>> Is this a cute way to write if(T
On Thu, Aug 26, 2010 at 13:03, Nikolay Sivov wrote:
> On 8/26/2010 14:53, David Hedberg wrote:
>>
>> + *ppvObject = NULL;
>> + if(IsEqualIID(riid,&IID_INameSpaceTreeControlEvents))
>> + {
>> + *ppvObject = iface;
>> + }
>&g
On Thu, Aug 26, 2010 at 13:15, Nikolay Sivov wrote:
> On 8/26/2010 14:53, David Hedberg wrote:
>>
>> ---
>> dlls/shell32/ebrowser.c | 98 +++
>> dlls/shell32/tests/ebrowser.c | 174
>> -
&g
.
From 1a8d009fd59ca7b3e9229ed7819a0be1aac4f678 Mon Sep 17 00:00:00 2001
From: David Hedberg
Date: Mon, 2 Aug 2010 13:50:23 +0200
Subject: [PATCH] shell32: Replace some checks with calls to _ILIsEmpty().
---
dlls/shell32/brsfolder.c |4 ++--
dlls/shell32/pidl.c |4 ++--
dlls/sh
Hi,
On Mon, Aug 2, 2010 at 7:04 AM, Nikolay Sivov wrote:
> On 8/2/2010 02:36, David Hedberg wrote:
>>
>> +static HRESULT ShellItem_get_shellfolder(ShellItem *This, IBindCtx *pbc,
>> IShellFolder **ppsf)
>> +{
>> + IShellFolder *desktop;
>
On Thu, Jul 29, 2010 at 9:19 PM, David Hedberg wrote:
> ---
> dlls/explorerframe/explorerframe_main.h | 3 +
> dlls/explorerframe/nstc.c | 211
> ++-
> dlls/explorerframe/tests/nstc.c | 49 +++-
> 3 files changed, 26
On Thu, Jul 29, 2010 at 9:16 PM, Nikolay Sivov wrote:
> I don't see a reason for this. If you want to zero two remaining fields do
> it explicitly. Also this helper doesn't need WINAPI it seems.
>
Ok, please ignore this one then, I'll try again.
On Tue, Jul 20, 2010 at 10:51 AM, Marvin wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> http://tes
On Sat, Jul 17, 2010 at 5:26 PM, Marvin wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> http://test
On Sun, Jul 18, 2010 at 3:10 PM, Marvin wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> http://test
On Sat, Jul 17, 2010 at 5:51 PM, Nikolay Sivov wrote:
> On 7/17/2010 19:45, David Hedberg wrote:
>>
>> On Sat, Jul 17, 2010 at 5:30 PM, Nikolay Sivov
>> wrote:
>>>
>>> On 7/17/2010 19:08, David Hedberg wrote:
>>>>
>>>> sta
On Sat, Jul 17, 2010 at 5:30 PM, Nikolay Sivov wrote:
> On 7/17/2010 19:08, David Hedberg wrote:
>>
>> static HRESULT WINAPI IFView_SetCurrentViewMode(IFolderView *iface, UINT
>> mode)
>> {
>> - IShellViewImpl *This = impl_from_IFolderView(iface);
>
On Sat, Jul 10, 2010 at 2:54 AM, Misha Koshelev wrote:
> Dear All:
>
> I am still learning git and it seems that my solution does not quite
> work.
>
> Specifically, my idea was to use:
> git rebase -i upstream/master
>
> Mark the commit _after_ which I'd like to insert a commit with edit.
>
> The
Hello everyone,
I'm having some trouble with this simple patch. Specifically, it breaks
compiling of dlls/actxprxy, producing the message:
*
../../tools/winegcc/winegcc -m32 -B../../tools/winebuild --sysroot=../..
-fasynchronous-unwind-tables -shared ./actxprxy.spec usrmarshal.o
actxprxy
On Mon, May 24, 2010 at 2:40 PM, Marvin wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> http://test
On Mon, May 24, 2010 at 2:42 PM, Nikolay Sivov wrote:
> On 5/24/2010 16:25, David Hedberg wrote:
>
> Hi, David.
>>
>> +}
>> +
>> +static ULONG WINAPI IExplorerBrowser_fnRelease(IExplorerBrowser *iface)
>> +{
>> + ExplorerBrowserImpl *This = (Explor
e of the
GSoC ideas on the wiki). I might be wrong though, and I guess that it
either way strictly speaking is an implementation detail that doesn't
really matter to wine.
Any thoughts, comments or questions on the above are very welcome. :-)
I'm also idling in #winehackers with the nick sk atteola.
Thanks,
David Hedberg
On Wed, Mar 3, 2010 at 12:53 PM, Alexandre Julliard wrote:
> David Hedberg writes:
>
>> Brings the return value in line with msdn and test results.
>>
>> This time without the skips. Return values other than 0 are somewhat
>> unlikely, but strictly speaking only one
Hi again,
On Wed, Feb 24, 2010 at 8:27 AM, Maarten Lankhorst
wrote:
> Hi David,
>
> David Hedberg wrote:
>>
>> On Wed, Feb 24, 2010 at 7:12 AM, Maarten Lankhorst
>> wrote:
>>
>>>
>>> Hi David,
>>>
>>
>> Hi Maarten,
&
Hi everyone!
Maybe it's a bit early, but I thought I would announce my interest in
participating as a student in this years GSoC. I'm currently busy
studying for my degree in Computer Engineering here in Sweden, and I
have realized that it would be really nice if I were able to spend a
few months
Hello,
This function is supposed to convert a jis-encoded (Japanese)
character to sjis encoding. I think I botched my last attempt up in
more than one way so I've now reworked it slightly and thought I'd try
again, but perhaps I should first ask if there is anything else
obviously wrong with it.
so, I'll wrap it up together with the tests.
Thanks for the guidance,
David
On 9/7/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote:
> Am Donnerstag, 6. September 2007 16:02:59 schrieb David Hedberg:
> > This patch adds tests to check the devices enumerated by
> > IDirect3
n 9/2/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote:
> Am Sonntag, 2. September 2007 14:15 schrieb David Hedberg:
> > While this works as a "fix", it's obviously not a good one. In my
> > (somewhat limited and at the moment not doublechecked) understanding,
> >
Hi,
I've been tracking down the reason for bug 7993 (
http://bugs.winehq.org/show_bug.cgi?id=7993 , "Delta Force Land
Warrior 1.31 -> Can't find 3D Video Card" ), and I think I've found
it.
It appears as if the EnumDevices callback in Delta Force for some
reason discards all devices with a GUID o
added a test case. Even with this, delta force still seems to
work fine.
Does this look ok?
David
On 9/2/07, Stefan Dösinger <[EMAIL PROTECTED]> wrote:
> Am Sonntag, 2. September 2007 14:16 schrieb David Hedberg:
> > (Resending mail after subscribing to list)
> >
> >
(Resending mail after subscribing to list)
Hi,
I've been tracking down the reason for bug 7993 (
http://bugs.winehq.org/show_bug.cgi?id=7993 , "Delta Force Land
Warrior 1.31 -> Can't find 3D Video Card" ), and I think I've found
it.
It appears as if the EnumDevices callback in Delta Force for so
33 matches
Mail list logo
