Re: [janitor] tools -Wwrite-strings cleanup

2004-10-15 Thread Daniel Marmier
On Thursday 14 October 2004 02.55, Alexandre Julliard wrote: > Daniel Marmier <[EMAIL PROTECTED]> writes: > > > This is one situation I would like to discuss a bit more. > > Some code uses a mix of static and dynamic structures containing strings. > > The static i

Re: named pipes problem?

2003-10-19 Thread Daniel Marmier
On Sat, 2003-10-18 at 19:38, Alexandre Julliard wrote: > Mike Hearn <[EMAIL PROTECTED]> writes: > > > Alexandre - this is your area. Any ideas? > > Your glibc is using TLS. Support for that is not ready yet. Depending > on your system you need to either set LD_ASSUME_KERNEL=2.4 or install > anoth

Re: [janitor] dlls/winmm/wine* -Wwrite-strings cleanup

2003-10-12 Thread Daniel Marmier
t; We have to keep the memory used by device[] or wwo->device even when we > exit the function, because we'll access it later. Local variables’ > memory are supposed to be freed after the function exits. Sorry for breaking it. I noticed the string never gets modified, so I fixed it by casting in a recent patch. Best Regards, Daniel Marmier

Re: [janitor] dlls/winmm/wine* -Wwrite-strings cleanup

2003-10-12 Thread Daniel Marmier
> I think it should be > > > static char device[] = "hw"; Yes, I submitted one such change in winealsa/audio.c (wine-20031007-dm8.diff). But it was a non-static one, so it does not explain the garbage you get. Best Regards, Daniel Marmier

Re: [janitor] programs/wcmd -Wwrite-strings cleanup

2003-10-09 Thread Daniel Marmier
Comments, ideas, suggestions? Best Regards, Daniel Marmier