RE: exploring/possibly porting winelib app to support 64bit.

2013-04-01 Thread Daniel Lehman
> probably Wine's 64-bit support, since that's a little-used feature). > This is a little off-topic from the original thread, but I think 64-bit Wine works pretty well. Our ArcGIS Server on Linux is exclusively 64-bit and is in use by some large organizations

RE: ntdll: Fixed some heap allocation stalls

2012-11-02 Thread Daniel Lehman
>> Which game were you testing? i dunno about the game, but i saw similar stalls in our software a huge batch process that consumed about 1 GB on Windows would both run slower and eat up about 2 GB on Wine before crashing i made a similar change to Steaphan's that not only improved performance,

RE: msvcp: free facet and _Locimp in Locimp dtor

2012-10-17 Thread Daniel Lehman
> You can't add return value to locale__Locimp_dtor since it have to be > compatible with what native returns. I'm not sure how it's supposed to > work, I guess locale__Locimp_dtor should be only called when refcount > already is 0. I'll do some testing tomorrow. How about something like the attac

RE: msvcp: free facet and _Locimp in Locimp dtor

2012-10-17 Thread Daniel Lehman
> Memory allocated for locale__Locimp object should be freed in locale > class (locale_dtor function). You can't delete it here. > Yeah, wasn't entirely sure about the location, but I want to call delete as soon as the refcount is 0 and can only reliably do that there. locale_dtor can't count

RE: gdi32: use HandleToULong inline function to convert handle to index instead of casting

2012-10-11 Thread Daniel Lehman
> It can't, the code explicitly casts handle to unsigned before the > shift. It's cast to a 64-bit unsigned, so the upper 32 bits are kept for the shift One of the pointers passed in was: 0xff26a8 after the shift, it became: 0xff26a8 => 0x3fc9aa When assigned to the 32

RE: msvcp90: handle npos as a len in basic_string<>::replace

2012-07-16 Thread Daniel Lehman
> -Original Message- > From: daniel.r.ke...@gmail.com [mailto:daniel.r.ke...@gmail.com] On > Behalf Of Dan Kegel > Sent: Monday, July 16, 2012 12:27 PM > To: Daniel Lehman > Cc: wine-devel@winehq.org > Subject: re: msvcp90: handle npos as a len in basic_string<>:

RE: Examples of AJ silently improving patches?

2012-06-20 Thread Daniel Lehman
Another example: http://www.winehq.org/pipermail/wine-patches/2012-January/110398.html http://source.winehq.org/git/wine.git/commit/b1f04e23bf361e06d239e03693c904a597b9a32d I had added a redundant null check in both A and W paths. he simplified it by making just the W path handle the null

gdi32/dibdrv: don't add_join if points are coincident in wide_line_segments (try 2)

2012-04-13 Thread Daniel Lehman
after the for loop I modified will always return valid faces From a369ea27438f0b83ebb738cc79649102b2a47bce Mon Sep 17 00:00:00 2001 From: Daniel Lehman Date: Wed, 25 Jan 2012 13:47:31 -0800 Subject: gdi32/dibdrv: don't add_join if points are coincident in wide_line_segments if 2 points coincid

RE: msvcp90: start rfind from given position

2012-01-13 Thread Daniel Lehman
> > === WVISTAADM (32 bit string) === > Failure running script in VM: The specified guest user must be logged > in interactively to perform this operation Do I need to resend in this case? I already ran it on TestBot before submitting the patch and they all passed Thanks daniel

RE: msvcrt: make WEOF returned from swscanf signed

2012-01-04 Thread Daniel Lehman
> === WNT4WSSP6 (32 bit scanf) === > scanf.c:257: Test failed: sscanf returns 0 instead of Apparently, msvcrt.dll returns 0 but msvcr90.dll returns -1 for the same arguments. I'll fix and resubmit later (and I'll fix the 'sscanf' to 'swscanf')