Re: comctl32/imagelist: use proper color format for merged image lists (try 2)

2013-03-05 Thread Daniel Jelinski
) use the greater of the color depths from source imagelists. Any idea what might be happening there? Regards, Daniel 2013/3/5 Alexandre Julliard : > Daniel Jelinski writes: > >> +static void test_merge_colors(void) >> +{ >> +HIMAGELIST himl[5], hmerge; >> +

Re: comctl32/listview: fix mouse message sequences

2013-02-25 Thread Daniel Jelinski
2013/2/25 Nikolay Sivov : > On 2/24/2013 17:52, Daniel Jelinski wrote: >> >> 2013/2/24 Nikolay Sivov : >>> >>> This doesn't look very clean. I mean invoking *up handler from a *down >>> one. >>> Is this something that could be resolv

Re: comctl32/listview: fix mouse message sequences

2013-02-24 Thread Daniel Jelinski
2013/2/24 Nikolay Sivov : > This doesn't look very clean. I mean invoking *up handler from a *down one. > Is this something that could be resolved with message loop like rbutton > dragging was fixed? TrackMouse contains the message loop. It returns FALSE when it receives LBUTTONUP (or any other bu

Re: comctl32/listview: fix selection in ownerdata listview

2013-02-20 Thread Daniel Jelinski
Hello Nikolay, I didn't have time to write and test a proper fix yet, and I'm not sure when I will. I thought this hack may be better than what we have now. If you want to fix this, please do. If not, I'll get back to it later. Regards, Daniel 2013/2/21, Nikolay Sivov : > What's a problem in fixi

Re: [1/5] comctl32/tests: more tests for icon spacing calculation

2013-01-25 Thread Daniel Jelinski
Hello, Thanks for reviewing. What's the preferred way of checking whether the code is compiled for 32 or 64bit? Regards, Daniel 2013/1/24 Alexandre Julliard : > Daniel Jelinski writes: > >> +#ifdef _WIN64 >> +/* NOTE: -1 is not treated the same as (DWORD)-1 by 64bit

Re: [3/5] comctl32/listview: always use large icon size when calculating icon spacing

2013-01-19 Thread Daniel Jelinski
Looks like the testbot is still having problems... 2013/1/20 Marvin : > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can b

Re: gdi32/tests: GetTextExtentPoint should give repeatable results

2013-01-15 Thread Daniel Jelinski
2013/1/15 Alexandre Julliard : > Daniel Jelinski writes: > >> These are tests for bug 32529. Since commit >> ebaf5ea17623268fb1c0f68b1cf9a5984bd4e46e >> (Don't load bitmap glyphs when using subpixel rendering in GetGlyphOutline) >> GetTextExtentPoint returns

Re: comctl32/listview: fix icon spacing calculation [try 2]

2013-01-14 Thread Daniel Jelinski
2013/1/14 Nikolay Sivov : > It's a way it's used in ListView_SetIconSpacing() (which could be broken in > its own way of course). > I think it's ok to ignore this 64 bit case for now, especially while we > don't get daily test runs. Are you saying that I should drop this? -return LISTVIEW_SetI

Re: comctl32/listview: fix icon spacing calculation [try 2]

2013-01-14 Thread Daniel Jelinski
2013/1/14 Nikolay Sivov : > This message actually is supposed to be used with MAKELONG(), so it's not > truncated in such way. Probably (MSDN doesn't say a word about the preferred macro for this function, unless you count user comments), however if any app actually calls MAKELPARAM, at least it w

Re: comctl32/listview: fix icon spacing calculation [try 2]

2013-01-14 Thread Daniel Jelinski
2013/1/14 Nikolay Sivov : > So on 64bit you want to distinguish two cases: > - ~0 value of lParam - you use it to reset to default values; > - all other values including 0x that will result in the same call > with both args being -1. Unless I got something wrong, all other values including

testbot

2013-01-14 Thread Daniel Jelinski
Hello, the testbot does not revert patches submitted through testbot.winehq.org after testing. As a result it is almost impossible to test another patch affecting the same area in code as a previous one. Could anyone please fix it? Or at least add git reset to cron... Regards, Daniel

Re: comctl32/listview: fix icon spacing calculation [try 2]

2013-01-14 Thread Daniel Jelinski
2013/1/14 Nikolay Sivov : > On 1/15/2013 00:53, Daniel Jelinski wrote: > >> +if(lParam == -1) >> + return LISTVIEW_SetIconSpacing(infoPtr, -1, -1); >> +return LISTVIEW_SetIconSpacing(infoPtr, LOWORD(lParam), >> HIWORD(lParam)); > > Why do you ne

Re: comctl32/listview: fix calculating item height

2013-01-05 Thread Daniel Jelinski
Interesting: https://testbot.winehq.org/JobDetails.pl?Key=23746&log_206=1#k206 Looks like testbot tried to do the entire test suite, even though I changed only one test file. 2013/1/5 Marvin : > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and al

Re: [9/9] server: Add support for named pipe message mode.

2012-12-27 Thread Daniel Jelinski
Hello, FWIW, Adam Martinson's named pipe series looks good to me. I tested it with MS SQL Server, which uses message mode pipes, and did not run into any problems. In current git I can't connect to server using named pipes, because as soon as SetNamedPipeHandleState returns false, client applicatio

Re: Ubuntu 12.10 - anyone?

2012-10-18 Thread Daniel Jelinski
Thanks for all of your answers. Playing with wine in 11.10 is becoming near impossible because of the infamous xcb bug. I'd rather not mess with files outside /home, so I guess I'll be checking how well x86+PAE works. -- Daniel

Ubuntu 12.10 - anyone?

2012-10-17 Thread Daniel Jelinski
Hello, Is it possible to compile 32bit wine in 64bit ubuntu 12.10? I heard there were problems in 12.04 - were they resolved? Regards, Daniel

Re: [3/4] comctl32: fix notifications and return value when collapsing already collapsed node (rebased)

2012-10-15 Thread Daniel Jelinski
Hello, Nikolay. Thanks for reminder. Attached it now. 2012/10/15 Nikolay Sivov : > Hi, Daniel. > > You forgot a patch. >

Re: comctl32/listview: update dwStyle before checking for scrollbar

2012-09-23 Thread Daniel Jelinski
2012/9/22 Daniel Jelinski : > 2012/9/22 Nikolay Sivov : >> And apparently we have code in WM_STYLECHANGED handler to deal with scroll >> bars: >> >> --- >> if (((lpss->styleOld & WS_HSCROLL) != 0)&& >> ((lpss->styleNew &

Re: comctl32/listview: update dwStyle before checking for scrollbar

2012-09-22 Thread Daniel Jelinski
2012/9/22 Nikolay Sivov : > I see. Now a question is how scroll bars are enabled/disabled in a case > you're trying to fix, > and a message test should be added for listview after that. What I'm seeing > - ControlSpy > running on XP shows style change messages after I toggle scrollbar bits, but > w

Re: comctl32/listview: update dwStyle before checking for scrollbar

2012-09-22 Thread Daniel Jelinski
I wouldn't mind if someone proved me wrong here). Regards, Daniel PS. I guess I should have used GetWindowLong instead on GetWindowLongPtr. Not sure if I should bother with resending now. 2012/9/22 Nikolay Sivov : > On 9/21/2012 23:07, Daniel Jelinski wrote: > >> dwStyle is update

Re: user32: search more aggressively for a window under a tooltip

2012-08-13 Thread Daniel Jelinski
2012/7/23 Alexandre Julliard : > Daniel Jelinski writes: > >> 2012/7/23, Alexandre Julliard : >>> You can't assume that the other Wine window is directly underneath the >>> transparent one, there may be some other X windows in between that >>> sh

Re: vcomp.dll, vcomp90.dll missing on testbot?

2012-08-07 Thread Daniel Jelinski
Hello, FWIW, comctl32 version 6 is accessible only with manifest, and there are tests that reference it. Here's an example: http://source.winehq.org/source/dlls/comctl32/tests/treeview.c#L1966 -- Daniel

What happened to testbot?

2012-07-27 Thread Daniel Jelinski
It seems that WINEBUILD has taken a break two days ago, no tasks involving building have been completed since then. Regards, Daniel

Re: user32: search more aggressively for a window under a tooltip

2012-07-23 Thread Daniel Jelinski
2012/7/23, Alexandre Julliard : > You can't assume that the other Wine window is directly underneath the > transparent one, there may be some other X windows in between that > should receive the click instead. I just determined that in such cases Windows (at least 2008) silently eats the event - n

Re: user32: search more aggressively for a window under a tooltip

2012-07-23 Thread Daniel Jelinski
e message to another window on the same thread, and the applications in question need only that. If we can make these applications work, why don't we? Daniel 2012/7/23, Alexandre Julliard : > Daniel Jelinski writes: > >> Hello, >> Check out the description of HTTRANSPARENT

Re: user32: search more aggressively for a window under a tooltip

2012-07-21 Thread Daniel Jelinski
patch and ok without it, or a massive test involving several overlapping windows belonging to different threads? Daniel [1] http://msdn.microsoft.com/en-us/library/windows/desktop/ms645618%28v=vs.85%29.aspx 2012/7/21 Dmitry Timoshkov : > Daniel Jelinski wrote: > >> Fixes bug 9512

[1/2] comctl32: Fix message sequence when right-clicking a treeview

2012-07-02 Thread Daniel Jelinski
Resend from last month From e9d9c543589ea2120ac39962d9820699b220a576 Mon Sep 17 00:00:00 2001 From: Daniel Jelinski Date: Thu, 19 Apr 2012 22:02:25 +0200 Subject: comctl32: Fix message sequence when right-clicking a treeview The message sequence obtained from testing native comctl32 was: - first

ODBC on 64bit system

2012-06-27 Thread Daniel Jelinski
Hello all, Is it possible to run a 32bit application using 64bit ODBC drivers? I already checked that standard 32bit wine compilation does not work - but will it work with WoW64? I am trying to get an application to connect to SQL Server via tdsodbc, but unfortunately tdsodbc:i386 in ubuntu 11.10 i

Re: Is it safe yet for developers to upgrade to Ubuntu 12.04?

2012-06-25 Thread Daniel Jelinski
I don't know about compiling, but there are several other reasons to keep waiting, listed here: http://forum.winehq.org/viewtopic.php?t=15802 Regards, Daniel 2012/6/25, Erich E. Hoover : > I know that for a while there were some packaging problems that meant that > upgrading to 12.04 made compili

Re: atl80: prefer native, if present

2012-06-18 Thread Daniel Jelinski
2012/6/18, Alexandre Julliard : > Daniel Jelinski writes: > >> From 7243b3594c9c0b13770ede1ab32d4dd1329b1dd4 Mon Sep 17 00:00:00 2001 >> From: Daniel Jelinski >> Date: Sun, 17 Jun 2012 17:37:15 +0200 >> Subject: atl80: prefer native, if present >>

Re: comctl: allow label edit only if treeview style allows editing

2012-06-06 Thread Daniel Jelinski
2012/6/4 Dan Kegel : > I had the same problem, and wrote a little script to skip the bad tests. > It was written for buildbot, but can be run standalone. > Try downloading > http://winezeug.googlecode.com/svn/trunk/buildbot/dotests.sh > and > http://winezeug.googlecode.com/svn/trunk/buildbot/dotest

Re: comctl: allow label edit only if treeview style allows editing

2012-06-04 Thread Daniel Jelinski
2012/6/4 Alexandre Julliard : > Daniel Jelinski writes: > >> From 21d26b76560f0c15a3d302883efa2d41d940a093 Mon Sep 17 00:00:00 2001 >> From: Daniel Jelinski >> Date: Sat, 2 Jun 2012 07:23:32 +0200 >> Subject: comctl: allow label edit only if treeview style allo

stub for SetThreadStackGuarantee

2012-05-29 Thread Daniel Jelinski
Hello, SQL Server Management Studio 2005 needs SetThreadStackGuarantee to either be absent or return TRUE - otherwise it refuses to run at all. Is there a reason for this stub to return FALSE? Regards, Daniel

Re: Testing regedit

2012-05-23 Thread Daniel Jelinski
2012/5/24 Austin English : > On Wed, May 23, 2012 at 12:24 PM, Daniel Jelinski > wrote: >> Hello, >> I just noticed that wine's regedit has a few interesting bugs that >> appear when running with native comctl32. Can I/should I file them in >> the bugzilla? >

Testing regedit

2012-05-23 Thread Daniel Jelinski
Hello, I just noticed that wine's regedit has a few interesting bugs that appear when running with native comctl32. Can I/should I file them in the bugzilla? Regards, Daniel

Re: comctl32: Fix message sequence when right-clicking a treeview

2012-05-15 Thread Daniel Jelinski
Are there any tests I could use as a base? 2012/5/15 Nikolay Sivov : > On 5/15/2012 21:30, Daniel Jelinski wrote: >> >> Patch dropped out of the pending list, resending. > > Please add a test for this fix. >

Re: [1/2] comctl32/tests: Added tests for mouse events handling (try 3)

2012-04-15 Thread Daniel Jelinski
Hello, I see that my patch hasn't been accepted yet. Well if some explanation could help it through, here goes: Bug 19222 makes using MS SQL Server management studio a pain. The application displays database structure in a tree view, and most actions are executed from a context menu displayed by ri

Re: Regression testing

2012-04-12 Thread Daniel Jelinski
2012/4/12 Scott Ritchie : > On 4/12/12 1:23 AM, Daniel JeliƄski wrote: >> >> Hello all, >> I am trying to get Microsoft SQL Server Management Studio to work >> flawlessly under Wine. For the most part I create and triage related bug >> reports, but recently I also started tinkering with code, speci

Re: Regression testing

2012-04-12 Thread Daniel Jelinski
Marcus, Alexey, thank you for your ideas. I just did several builds to see how to make things work. Here's what I got: make clean && make - does not work (the problem persists) make distclean && ./configure && make - same as above git clean -xdf && ./configure && make - this one finally worked. I'm

Re: [1/2] comctl32/tests: Added tests for mouse events handling (try 3)

2012-04-08 Thread Daniel Jelinski
2012/4/8 Dmitry Timoshkov : > Daniel Jelinski wrote: > >> Skipping tests on WinNT - older versions of comctl send a different >> set of events. > > Then you need to figure out what is different, and make the tests pass > there as well (there is 'optional