Re: ptrace single-stepping change breaks Wine

2005-01-01 Thread Daniel Jacobowitz
On Fri, Dec 31, 2004 at 09:19:48AM -0800, Linus Torvalds wrote: > > > On Fri, 31 Dec 2004, Daniel Jacobowitz wrote: > > > > Lots, I like it. The syscall trap will always be delivered before the > > single-step trap, right, because signal delivery won't run

Re: ptrace single-stepping change breaks Wine

2004-12-31 Thread Daniel Jacobowitz
e signal delivery won't run until we return to userspace? -- Daniel Jacobowitz

Re: ptrace single-stepping change breaks Wine

2004-12-31 Thread Daniel Jacobowitz
t; > Now, that should be easily handled by just separating out the cases of > system call tracing and debug trap handling, and using the old silly code > for system calls. I'd prefer a cleaner approach, but that seems to be the > sane thing to do for now. Strace doesn'

Re: ptrace single-stepping change breaks Wine

2004-12-31 Thread Daniel Jacobowitz
On Thu, Dec 30, 2004 at 03:17:01PM -0800, Linus Torvalds wrote: > > > On Thu, 30 Dec 2004, Daniel Jacobowitz wrote: > > > > does not look right to me. Before, we'd get an 0x80|SIGTRAP result > > from wait. Now, you've moved the 0x80 to live only inside t

Re: ptrace single-stepping change breaks Wine

2004-12-31 Thread Daniel Jacobowitz
us the fakey SIGTRAP */ > + send_sig_info(SIGTRAP, &info, current); > } does not look right to me. Before, we'd get an 0x80|SIGTRAP result from wait. Now, you've moved the 0x80 to live only inside the siginfo. This is accessible to the debugger via ptrace, but only very recently (late 2.5.x). So this will probably break users of PT_TRACESYSGOOD. -- Daniel Jacobowitz

Re: ptrace single-stepping change breaks Wine

2004-11-20 Thread Daniel Jacobowitz
aybe it should be a separate ptrace operation. Platforms which don't implement PTRACE_SINGLESTEP would probably appreciate this. A "single step" which stops you after setting up the signal trampoline and adjusting the PC, before executing any instructions in the handler. -- Daniel Jacobowitz