On Thu, Aug 21, 2008 at 05:54:07AM +0900, Scott Lindeneau wrote:
> Guh. Ill figure it out eventually I guess. Which tabs are you talking
> about in particular? All of them?
Yes, just stick with spaces, and it seems the convention is four spaces
per indentation level.
On Thu, Aug 21, 2008 at 04:25:07AM +0900, Scott Lindeneau wrote:
> Sorry about not knowing how to cross compile before. Here is the
> patch(gmail doesn't let me attach exe's... I will look into this).
> Please try this. Tell me if I am doing something wrong (again).
Thanks for working on this. Be
On Sun, Aug 10, 2008 at 06:30:17PM -0600, Erich Hoover wrote:
> Honestly, I believe that this problem illustrates the need for these kind of
> bugs - if I had found a bug for WinHttp in bugzilla assigned to Zac then I
> could easily contact him. I do not have time to monitor wine-devel in order
>
On Sun, Aug 10, 2008 at 06:57:12PM +0100, Rob Shearman wrote:
> These should go into usrmarshal.c. However, Dan Hipschman as already
> done some work in this area so you might want to search for his
> patches on generating proxy/stub code for oleidl.idl and objidl.idl so
> that you
On Thu, Aug 07, 2008 at 02:33:35PM -0700, Juan Lang wrote:
> > I guess I should elaborate on that. You can request any of the four
> > parts of the security descriptor and pass NULL for the SD itself and
> > Windows will return them without anyway to free the memory.
>
> I can see what MSDN says
On Thu, Aug 07, 2008 at 02:28:10PM -0700, Dan Hipschman wrote:
> On Thu, Aug 07, 2008 at 02:25:00PM -0700, Juan Lang wrote:
> > +if (ppSecurityDescriptor)
> > +*ppSecurityDescriptor = sd;
> > +
> >
> > you leak sd in the (implicit) else block here.
On Thu, Aug 07, 2008 at 02:25:00PM -0700, Juan Lang wrote:
> +if (ppSecurityDescriptor)
> +*ppSecurityDescriptor = sd;
> +
>
> you leak sd in the (implicit) else block here.
So does Windows.
On Wed, Aug 06, 2008 at 02:21:44PM +0900, Dmitry Timoshkov wrote:
> "Dan Hipschman" <[EMAIL PROTECTED]> wrote:
>
> >+#include
> ...
> >DWORD WINAPI GetSecurityInfo(
> >HANDLE hObject, SE_OBJECT_TYPE ObjectType,
> >@@
On Tue, Jul 29, 2008 at 04:45:31PM -0700, Roy Shea wrote:
> +static HRESULT WINAPI MSTASK_ITask_GetTriggerString(
> +ITask* iface,
> +WORD iTrigger,
> +LPWSTR *ppwszTrigger)
> +{
> +FIXME("(%p, %d, %p): stub\n", iface, iTrigger, ppwszTrigger);
> +FIXME("Not implement
Hey Roy,
On Tue, Jul 29, 2008 at 04:44:45PM -0700, Roy Shea wrote:
> +static BOOL setup_task_scheduler()
> +{
> +HRESULT hres;
> +
> +hres = CoCreateInstance(&CLSID_CTaskScheduler, NULL,
> CLSCTX_INPROC_SERVER,
> +&IID_ITaskScheduler, (void **) &test_task_scheduler);
> +r
Thanks for these especially good comments, Rob!
On Sat, Jul 19, 2008 at 07:08:17PM +0100, Rob Shearman wrote:
> 2008/7/19 Dan Hipschman <[EMAIL PROTECTED]>:
> >
> > This patch implements the timer thread, running callbacks, cleaning up
> > timers, and all that goo
On Fri, Jul 18, 2008 at 09:27:49PM +0200, Detlef Riekenberg wrote:
> Some functions are not present on win98:
> CreateTimerQueue
> CreateTimerQueueTimer
> DeleteTimerQueueEx
>
>
> Changelog:
> kernel32/tests: Run the tests again on Win9x (TimerQueue)
>
>
>
> ???Dan, when you are finished with
On Thu, Jul 17, 2008 at 05:38:29PM -0700, Zac Brown wrote:
>
> +if (dwFlags & WINHTTP_FLAG_ESCAPE_PERCENT ||
> +dwFlags & WINHTTP_FLAG_NULL_CODEPAGE ||
> +dwFlags & WINHTTP_FLAG_ESCAPE_DISABLE ||
> +dwFlags & WINHTTP_FLAG_ESCAPE_DISABLE_QUERY)
if (dwFlags & (WINHTTP
On Thu, Jul 03, 2008 at 05:32:32PM +1000, Austin Lund wrote:
> I have run these with the native dll in wine and it works fine, but
> would like someone to test them on windows platforms.
I couldn't get these to compile within a few minutes due to not being
familiar with what headers were needed, b
On Thu, Jun 26, 2008 at 02:06:18PM -0400, [EMAIL PROTECTED] wrote:
> ok sorry for cutting and pasting the whole routine.. did not see to do just
> the diff ...
> (give the old guy a break.. I am an architect now not a programmer )
>
Your diff is getting corrupted. See all the ???:
http://www.w
On Mon, Jun 23, 2008 at 10:29:11PM +0100, Rob Shearman wrote:
> diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c
> index 1f8695a..84115fd 100644
> --- a/tools/widl/typegen.c
> +++ b/tools/widl/typegen.c
> @@ -809,7 +809,9 @@ size_t type_memsize(const type_t *t, unsigned int *align)
> {
>
On Mon, Jun 16, 2008 at 08:20:24PM +0100, Rob Shearman wrote:
> http://www.winehq.org/pipermail/wine-patches/2008-June/055831.html
Ha, oops, sorry.
On Mon, Apr 28, 2008 at 08:37:26PM +0100, Robert Shearman wrote:
>
> This should aid in testing more-obscure parts of the parser that aren't
> necessarily valid when using RPC (and hence don't make sense being put
> in dlls/rpcrt4/tests/server.idl).
Obviously this is a good idea. I tried doing
On Sat, Apr 26, 2008 at 09:51:58AM +0100, Robert Shearman wrote:
> +u_suffix (l|L)
> +l_suffix (u|U)
I'm guessing you meant for these to be the other way around.
On Thu, Apr 10, 2008 at 11:22:41AM -0700, Dan Kegel wrote:
> It's an April 15th event sponsored by Microsoft, but
> it sure sounds like something we should be holding on our own terms :-)
>
>
http://www.microsoft.com/events/EventDetails.aspx?CMTYSvcSource=MSCOMMedia...
(snip)
That's a long URL (
On Wed, Apr 09, 2008 at 12:10:55PM -0500, Austin English wrote:
> /* @makedep: test.avi */
> TEST_AVI_RES AVI_RES_TYPE test.avi
> -/* @makedep: sound_test.avi */
> +/* @makedep: test_sound.avi */
> TEST_SOUND_AVI_RES AVI_RES_TYPE test_sound.avi
Oops, sorry, and thanks for fixing it.
On Thu, Apr 03, 2008 at 06:14:03PM -0700, Dan Kegel wrote:
> I think you can't depend on files existing in the source
> directory; you have to create them yourself
> (e.g. from a hex array in your source).
> Otherwise the unified winetest app that we
> use for semiautomated remote windows testing
>
On Wed, Apr 02, 2008 at 11:46:27AM -0700, Dan Hipschman wrote:
> On Wed, Apr 02, 2008 at 12:56:21PM +0100, Robert Shearman wrote:
> > @@ -186,13 +186,19 @@ static const struct keyword keywords[] = {
> > {"FALSE", tFALSE},
> > {"
On Wed, Apr 02, 2008 at 12:56:21PM +0100, Robert Shearman wrote:
> @@ -186,13 +186,19 @@ static const struct keyword keywords[] = {
> {"FALSE", tFALSE},
> {"TRUE",tTRUE},
> {"__cdecl", tCDECL},
> + {"__fastcall"
Yup, ignore.
On Thu, Mar 13, 2008 at 04:00:32PM -0700, Dan Hipschman wrote:
>
> NOTE: I thought I sent this with the other five patches, but I don't see
> it. Sorry if it ends up being a resend.
>
> This feature of MoveFileEx is technically needed by
> IBackgroundCopyJ
On Thu, Jan 31, 2008 at 09:52:17PM +0100, Roderick Colenbrander wrote:
>
> In case of your dll I guess it should be hardcoded. Shipping extra
> files puts an extra burden on packagers and it likely isn't what
> windows is doing.
The .INF is compiled into the DLL as a resource. Packagers shipping
On Wed, Jan 23, 2008 at 09:45:26PM +1100, Alistair Leslie-Hughes wrote:
>
> The think ths issue is that widl isnt making the .tlb file when run. Also
> when I run the widl command from
> a prompt, no .tlb file is created.
msxml2.idl doesn't contain any library definitions. widl won't generate
On Thu, Nov 29, 2007 at 02:57:50PM +0100, Alexandre Julliard wrote:
> Dan Hipschman <[EMAIL PROTECTED]> writes:
>
> > In this revision, I leave setting permissions on page faults to the
> > unhandled exception filter and simply ignore page faults on execution
> >
On Wed, Nov 21, 2007 at 06:53:27PM -0600, James Hawkins wrote:
> On Nov 21, 2007 6:08 PM, Zac Brown <[EMAIL PROTECTED]> wrote:
> > Hi,
> >
> > Fixes valgrind error:
> > http://kegel.com/wine/valgrind/20071121/vg-ntdll_env.txt
> >
> > Changelog:
> > * Initialize buffers used in test using me
On Sun, Nov 04, 2007 at 01:04:02PM +0100, Detlef Riekenberg wrote:
>
> Why is the code only used, when "WANT_NEAR_INDICATION" is defined?
> Should we remove the code or enable it always?
>
> @@ -591,18 +592,17 @@ static void generic_msg(const char *s, c
> fprintf(stderr, "%s:%d:%d: %s: ", pp
On Sun, Oct 28, 2007 at 07:07:15PM -0700, Dan Kegel wrote:
> To get uninitialized warnings, you have to also specify
> optimization (-O2). Without -O, gcc doesn't
> do the analysis that can detect uninitialized variables.
Compiling with "-O2 -W -Wall" using either gcc 4.0 or 3.4 I don't get
any w
On Mon, Oct 29, 2007 at 01:26:45AM +0100, Gerald Pfeifer wrote:
> I think the question is whether a compiler can reasonably be expected
> to deduce that the source is fine. If that deduction involves solving
> the halting problem (or similar) hacking the source to avoid the warning
> actually does
On Sun, Oct 28, 2007 at 01:51:34PM +0100, Gerald Pfeifer wrote:
> In tools/widl/typegen.c we have the following snippet
>
> static void write_user_tfs(FILE *file, type_t *type, unsigned int *tafsoff)
> {
> unsigned int start, absoff, flags;
> unsigned int align = 0, ualign = 0;
> c
Some of what you're saying has validity, but all your criticisms are on
very minor points, and I was surprised to see them. I think they're
offset by the fact that James is a long-time developer who has a lot of
work to do. I'm sure the Wine community appreciates every person who
wants to help t
On Thu, Oct 18, 2007 at 04:02:40PM +0100, Robert Shearman wrote:
> Dan Hipschman wrote:
> >@@ -1859,6 +1859,7 @@ static int get_struct_type(var_list_t *fields)
> > case RPC_FC_OP:
> > case RPC_FC_CARRAY:
> > case RPC_FC_CVARRAY:
> >+case RPC_FC_B
On Thu, Oct 18, 2007 at 11:12:23AM +0200, Michael Stefaniuc wrote:
> Dan Hipschman wrote:
> > This is just a minor cleanup patch. Even if we're definitely sure a
> > string doesn't contain any % signs, it's still better not to use it as a
> > printf format
On Tue, Sep 18, 2007 at 11:15:26PM +0100, Robert Shearman wrote:
> >Sorry, I missed your last three patches somehow. My patch not only uses
> >RPC_FC_POINTER instead of RPC_FC_LONG here, but it also implements the
> >pointer description section for complex structures.
>
> Right, but I was really
On Tue, Sep 18, 2007 at 09:23:37AM +0100, Robert Shearman wrote:
> Dan Hipschman wrote:
> >var_t *field,
> > }
> > else if (is_ptr(type))
> > {
> >-print_file(file, 2, "0x8,\t/* FC_LONG */\n");
> >+unsi
On Mon, Aug 06, 2007 at 04:24:39PM +0200, Herv? Poussineau wrote:
> Hi Dan,
>
> I'm using Wine IDL compiler to compile some .idl files, and I found a
> regression in WIDL between 0.9.38 and 0.9.39.
> As you are the one who mostly changed WIDL between these releases, I'm
> sending you this email ;)
On Thu, Jun 14, 2007 at 06:28:41PM -0700, Dan Hipschman wrote:
> + if (strcmp(winetest_platform, "wine") != 0)/* crashes wine */
> + {
> +eu.t = ENCU_I;
> +eu.tagged_union.i = 7;
> +ok(square_encu(&eu) == 49.0, "RPC square_
On Thu, Jun 14, 2007 at 06:28:41PM -0700, Dan Hipschman wrote:
>
> This adds a test for encapsulated unions, but it crashes wine. The exact
Hmm, now that I reread this, I think I said this wrong. The test does
crash wine, but I wrote my patch so that it doesn't run on wine. So,
On Tue, Jun 12, 2007 at 10:29:24AM +0100, Robert Shearman wrote:
> error("structure size for %s exceeds %d bytes by %d bytes\n",
>name, USHRT_MAX, total_size - USHRT_MAX);
>
> +current_structure = type;
> has_pointers = write_embedded_types(file, NULL, type, name
On Tue, Jun 05, 2007 at 09:35:59PM +0100, Robert Shearman wrote:
> >This and your next patch are in the same area as the one I just sent in
> >yesterday. Actually, my patch completely removes this function. Can
> >you try doing whatever you're working on with my last patch applied and
> >see if t
On Tue, Jun 05, 2007 at 07:50:42PM +0100, Robert Shearman wrote:
>
> Previously, an array of pointers wouldn't be detected by this function.
> ---
> tools/widl/header.h |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/widl/header.h b/tools/widl/header.h
> index
On Thu, May 31, 2007 at 02:23:59PM -0500, Tom Spear wrote:
> I recall a few years back (2003?) There was a discussion about
> removing extra whitespace at the end of lines, and someone came up
> with a bash/sed script to look thru the entire wine tree, strip
> trailing whitespace, and then somehow
On Thu, May 10, 2007 at 10:39:31AM -0700, Duane Clark wrote:
> Dan Hipschman wrote:
> >Well, I sent this quite a while ago and it hasn't shown up on the list yet.
> >It's probably too big, so here's a link to the patch instead of inlining
> >it.
> >
>
On Thu, May 10, 2007 at 10:47:26AM +0100, Robert Shearman wrote:
> Dan Hipschman wrote:
> >This patch just simplifies the make_safearray function. It didn't need
> >to be that complicated. I tested the generated headers and typelibs
> >with this patch applied (well, I d
On Tue, May 08, 2007 at 11:19:16AM -0500, Tom Spear wrote:
> static const DWORD MAXSUBKEYNAMELEN = 255;
> WCHAR subKeyName[MAXSUBKEYNAMELEN + 1];
I'm not sure what version of C wine is strictly trying to conform to,
but it's usually best to go with the lowest common denominator. This is
not C89.
On Sun, Apr 22, 2007 at 05:13:23PM +0100, Robert Shearman wrote:
> Dan Hipschman wrote:
> >On Fri, Apr 20, 2007 at 11:41:16AM +0200, Alexandre Julliard wrote:
> >
> >>That's very ugly; you shouldn't need any of that stuff, especially not
> >>a separate
On Fri, Apr 20, 2007 at 11:41:16AM +0200, Alexandre Julliard wrote:
> Dan Hipschman <[EMAIL PROTECTED]> writes:
>
> > This extends the testing framework to allow for tests that need IDL
> > files and RPC clients. It's the same as the last attempt, but I've
On Thu, Apr 12, 2007 at 11:47:05AM +0100, Robert Shearman wrote:
> Dan Hipschman wrote:
> >@@ -94,7 +95,8 @@ struct connection_ops {
> > RpcConnection *(*alloc)(void);
> > RPC_STATUS (*open_connection_client)(RpcConnection *conn);
> > RPC_STATUS (*hando
On Mon, Oct 09, 2006 at 03:45:16PM -0700, Dan Kegel wrote:
> Dan H., could you have a quick look at Michal's patch?
Well, the patch I sent in didn't crash on my machine, but crashed on
Alexandre's (and maybe others' who didn't try to run it). It's pretty
hard to fix something that works when you
On Tue, Aug 29, 2006 at 08:45:17PM -0400, Vijay Kiran Kamuju wrote:
> But when i see the generated header file. I see that there is the
> expansion of interfaces defined in the foo.idl if we include it in
> foobar.idl
> eg: foobar.idl
> #include "foo.idl"
>
> For further reference see the msxml.id
On Tue, Aug 29, 2006 at 05:53:20PM -0400, Vijay Kiran Kamuju wrote:
> I am cleaning up msxml*.idl files.
> It seems that msxml.idl and msxml2.idl are incompatible.
> msxml.idl includes xmldso.idl and xmldom.idl (eg: include "xmldso.idl")
> where as msxml2.idl explicitly declares the interface defin
On Tue, Aug 29, 2006 at 01:54:23PM +0100, Robert Shearman wrote:
> I see from a couple of patches back that you intend to move the
> representation of pointers out of the var_t type. How do you intend to
> represent "char **" for example?
> type: FC_RP, ref: { type: FC_RP, ref: { type: FC_CHAR }
On Tue, Aug 29, 2006 at 01:46:52PM +0100, Robert Shearman wrote:
> >@@ -207,6 +207,7 @@ struct _type_t {
> > func_t *funcs; /* interfaces and modules */
> > var_t *fields; /* interfaces, structures and
> > enumerations */
> > ifref_t *ifaces;/*
On Tue, Aug 29, 2006 at 01:45:41PM +0100, Robert Shearman wrote:
> > if (n) fprintf(h, "%s", n);
> >+ else if (t->kind == TKIND_ALIAS) fprintf(h, "%s", t->name);
>
> I'm not really sure we should be depending on a typelib thing for a
> fundamental concept such as this. In fact, I think the kind
On Fri, Aug 25, 2006 at 11:08:03AM +0100, Andrew Talbot wrote:
> What confused me - especially with my ignorance of yacc - is that I couldn't
> find a corresponding xmalloc() that assigns the char * variables that the
> above free() frees. make_var() gains storage for a var_t type, but the
> free()
On Wed, Aug 16, 2006 at 12:27:48PM +0100, Robert Shearman wrote:
> It might be better to reuse the code in typegen.c rather than
> maintaining two different pieces of code that essentially do the same job.
I was just trying to be consistent with what was already in proxy.c. The
next thing I was
On Thu, Aug 03, 2006 at 03:44:49PM +0200, Jacek Caban wrote:
> be used to implement an object. And HTMLDocument is IMO the best name. Also
>
> $ grep -w HTMLDocument dlls/mshtml/*.[ch] |wc -l
> 304
> $ grep -w WebBrowser dlls/shdocvw/*.[ch] |wc -l
> 210
> $ grep -w InternetExplorer dlls/shdocvw/*.
Hi all,
I'd like to submit a patch which makes widl output forward declarations
to the header file for coclass definitions. Currently this is done only
if the coclass has its own forward declaration. For example,
[ uuid(...) ] coclass Foo;
[ uuid(...) ] coclass Bar { ... };
Foo will get dec
On Mon, Jul 24, 2006 at 11:49:35AM -0700, Dan Hipschman wrote:
>
> This field is superfluous:
>
> [widl]$ find -name "*.[chly]" | xargs fgrep -n ignore
> ./parser.y:1049: t->ignore = parse_only;
> ./parser.y:1126: f->ignore = parse_only;
> ./widltyp
On Wed, Jul 19, 2006 at 02:09:45PM -0700, Dan Hipschman wrote:
>
> This sets up a regression testing framework for WIDL (it could be used
> in other places, too). You'll need the next patch to actually do "make
> test" in tools/widl/tests, but this patch contains th
On Mon, Jul 10, 2006 at 10:12:55PM +0100, Huw Davies wrote:
> There are GetTextExtentPoint entry points in both winex11.drv and
> wineps.drv. Both of these will need to be updated to
> GetTextExtentExPoint.
Thanks for pointing that out.
> > -for(idx = 0; idx < count; idx++) {
> > -ge
Hello,
I've been asked to introduce myself. You can figure out a lot from my email.
My name is Dan, I'm an undergrad at UCLA and I like Linux. I've never worked
for Microsoft or even visited a Microsoft office (I drove by one once). I'll
be working on slow loading times of Richedit documents f
On Sun, Jul 02, 2006 at 04:35:11PM -0700, Dan Kegel wrote:
> FWIW, Dan H also explored a change to make a riched "run" struct be
> refcounted; that gave a 4x speedup. Then he switched to using
> git bisect to find the cause of the regression, and shelved the
> refcounting patch.
That wasn't the r
66 matches
Mail list logo
