Re: kernel32/tests: do not compare handle with zero directly (Smatch)

2010-01-20 Thread Dan Carpenter
On Tue, Jan 19, 2010 at 03:01:20PM +0300, Dan Carpenter wrote: > On 1/19/10, Dan Carpenter wrote: > > > There is a wine_checker.sh script in smatch_scripts so you can quickly test > > individual files. I just pushed a change to make wine_checker.sh find the > > smatch b

Re: kernel32/tests: do not compare handle with zero directly (Smatch)

2010-01-19 Thread Dan Carpenter
On 1/19/10, Dan Carpenter wrote: > There is a wine_checker.sh script in smatch_scripts so you can quickly test > individual files. I just pushed a change to make wine_checker.sh find the > smatch binary so you may want to pull the most recent changes. > > /path/to/smatch_scripts/

Re: kernel32/tests: do not compare handle with zero directly (Smatch)

2010-01-19 Thread Dan Carpenter
mpared against zero. Like this: if (x) file = CreateFile(); else file = some_func(); if (file) // <- complain I know smatch has been abandonware for a long time, but I hope to do better now. regards, dan carpenter