Re: Bug 28791: ensure that dashes value is not 0 for PS_USERSTYLE linestyles

2011-10-19 Thread Damian Dixon
Just removing the zeros will shift the pattern to the left potentially producing an effect that is not expected. I will take a look at what happens on Windows to see what needs to be replicated. On 19 October 2011 20:05, Alexandre Julliard wrote: > damian dixon writes: > > > diff

Solved: Problems with drawing text in 1.3.29

2011-10-07 Thread Damian Dixon
to be. I will raise a bug for this one... as a difference in behaviour. On 7 October 2011 08:50, Damian Dixon wrote: > Thanks for the suggestions. > > I've narrowed one of the issues down to WineEngGetGlyphOutline > in dlls/gdi32/freetype.c. > > The pitch is 6640 and the

Re: Problems with drawing text in 1.3.29

2011-10-07 Thread Damian Dixon
11 at 04:53:18PM +0100, Damian Dixon wrote: > > Hi, > > > > I was attempting to use Wine 1.3.29 (in OpenSUSE 11.4 x86) and because of > > issues pulled the source from git last night and still have problems. > > > > I am having performance issues with DrawText

Problems with drawing text in 1.3.29

2011-10-05 Thread Damian Dixon
Hi, I was attempting to use Wine 1.3.29 (in OpenSUSE 11.4 x86) and because of issues pulled the source from git last night and still have problems. I am having performance issues with DrawText (5 odd seconds to draw a simple string) and the occasional X Error and crash. The X Error is consistent

Windows Installer change in behaviour Wine 1.3.5.

2010-10-29 Thread Damian Dixon
Hi, I have installed my application under Wine 1.3.5 however with this version of Wine the registry is not updated by the installer. The registry entry ends up with the value '[INSTALL_DIR]'. Which is odd as it has worked before with older versions of Wine. I've not had the time to investigate b

Crash bug in Wine 1.3.5 in advapi32/service.c

2010-10-29 Thread Damian Dixon
Hi, In file dlls/advapi32/service.c, line 1135 a memory copy occurs, however the lpservicestatus is not checked to see if the value is NULL. This causes a crash in an application that has worked before under wine. My naive change is: if (ret && lpservicestatus) memcpy(lpservicestatus, &SvcS

Re: implement PS_USERSTYLE handling - obviously not correct ;)

2009-04-06 Thread Damian Dixon
Hi Hans, I have run the patch against my application and the line-styles draw as far as I can tell are the same as on Windows when a single line segment where the pixel width of one is used. However when a polyline is drawn the dash style does not get drawn correctly. There seems to be an issue w

Advice on where to place new private methods and access to private methods across modules.

2009-03-30 Thread Damian Dixon
Hi, I am working on creating a patch for X11DRV_AlphaBlend to allow Bitmap's with no DIBSECTION to work. The code to do this is fairly generic so I created a new method: DIB_CreateDIBSectionFromBitmap. I initially placed this in winex11.drv/dib.c, however the method required access to private me

X11DRV_AlphaBlend: FIXME not a DIB section

2009-03-27 Thread Damian Dixon
Hi, I'm trying to get an application running as best as possible under Wine and have found that X11DRV_AlphaBlend does not handle Bitmaps which are not a DIB Section. I have also found that a number of people have submitted some fixes to X11DRV_AlphaBlend: 1. http://www.nabble.com/(re-resend)-x1