Re: [PATCH] kernel32: implement GetLogicalProcessorInformation

2011-11-26 Thread Claudio Fontana
On Fri, Nov 25, 2011 at 8:01 PM, Charles Davis wrote: > > On Nov 25, 2011, at 8:17 AM, Claudio Fontana wrote: > >> On Fri, Nov 25, 2011 at 4:07 PM, Claudio Fontana >> wrote: >>> I have resent the patch as a "try 2" (there was a try 1.5 to fix test &g

Re: [PATCH] kernel32: implement GetLogicalProcessorInformation

2011-11-26 Thread Claudio Fontana
On Fri, Nov 25, 2011 at 4:07 PM, Claudio Fontana wrote: > I have resent the patch as a "try 2" (there was a try 1.5 to fix test > issues under windows older than XP SP3). > > The patch contains changes based on your feedback. Which is completely broken, since the U() macr

Re: [PATCH] kernel32: implement GetLogicalProcessorInformation

2011-11-26 Thread Claudio Fontana
I have resent the patch as a "try 2" (there was a try 1.5 to fix test issues under windows older than XP SP3). The patch contains changes based on your feedback. Some things I stand by, and won't change. If you feel differently, you should argue for their validity a little bit more than "don't us

Re: [PATCH] kernel32: implement GetLogicalProcessorInformation

2011-11-24 Thread Claudio Fontana
work on all items you mentioned, so if you want to cannibalize it and do things differently, you are more than welcome to take what you need from my patch. Some comments on your comments below :) On Fri, Nov 25, 2011 at 12:13 AM, Charles Davis wrote: > Hi, > > On Nov 24, 2011, at 4:21 AM

configure looking for prelink

2011-05-11 Thread Claudio Fontana
package is built from source and installed in the default prefix (/usr/local). Thanks, Claudio Fontana

Re: profile.c (kernel32): API broken

2009-08-22 Thread Claudio Fontana
I tried to work on the patch again, but it does not apply anymore. I am slowly going through what happened in profile.c, to find out which changes should be kept, and which go in a wrong direction. I stumbled already @the first entry: commit 9a10234ef2b5212ba44b82a797c478f190b4dad1 Author: Paul V

Re: profile.c (kernel32): API broken

2009-08-08 Thread Claudio Fontana
Paul Vriens wrote: Claudio Fontana wrote: On Thu, Aug 6, 2009 at 11:47 AM, Paul Vriens wrote: Claudio Fontana wrote: On Thu, Aug 6, 2009 at 9:38 AM, Paul Vriens wrote: Claudio Fontana wrote: Just a reminder to everyone involved with profile.c: I have watched the git log of the somewhat

Re: profile.c (kernel32): API broken

2009-08-08 Thread Claudio Fontana
On Thu, Aug 6, 2009 at 11:47 AM, Paul Vriens wrote: > Claudio Fontana wrote: >> >> On Thu, Aug 6, 2009 at 9:38 AM, Paul Vriens >> wrote: >>> >>> Claudio Fontana wrote: >>>> >>>> Just a reminder to everyone involved with profile.c: >

Re: profile.c (kernel32): API broken

2009-08-06 Thread Claudio Fontana
On Thu, Aug 6, 2009 at 9:38 AM, Paul Vriens wrote: > Claudio Fontana wrote: >> >> Just a reminder to everyone involved with profile.c: >> >> I have watched the git log of the somewhat recent changes to >> kernel32/profile.c. >> >> The profile API does n

profile.c (kernel32): API broken

2009-08-05 Thread Claudio Fontana
interested, you can contact me for further details, or look at the testcases in my last patch (search for profile.c / Claudio Fontana). A good fix in profile.c is difficult because of the unfortunate use of the empty string as sentinel in the implementation. Probably rewriting the module would be a

kernel32 (profile.c): allow profile section and key names of zero length patch

2007-02-18 Thread Claudio Fontana
Hello all, I was wondering if there's anything wrong with my patch to kernel32/profile.c and its tests: http://www.winehq.org/pipermail/wine-patches/2007-February/035468.html It fixes a problem that causes applications built with Multimedia Fusion to fail under wine, since the "INI object" of M

kernel32: allow profile section and key names of zero length

2007-01-29 Thread Claudio Fontana
Hello, following up on the profile changes started on this thread: http://www.winehq.org/pipermail/wine-devel/2006-December/053009.html I tried a patch in git format made against latest. First attempt at using git, that is. dlls/kernel32/profile.c: allow section and key names of zero length dll

function_grep.pl - idutils

2006-12-28 Thread Claudio Fontana
Hello, I noticed that you are using function_grep.pl to search for a certain function. Have you considered GNU idutils? They can do that and more (and faster): http://www.gnu.org/software/idutils It is as simple as $ cd $WINE_SRC_PATH $ mkid (generate ID database, takes about 4 seconds on my ma

Re: kernel32 (profile.c): current section and key implementation

2006-12-25 Thread Claudio Fontana
Hello Robert, On 12/24/06, Robert Shearman <[EMAIL PROTECTED]> wrote: Hi Claudio, The patch looks good, apart from the specific version check for win95. Do you think you could add some tests to our test framework (dlls/kernel32/tests) to test for this issue that you've found. Then the tests cou

dlls/kernel32/tests: test failure in locale.c

2006-12-25 Thread Claudio Fontana
Hello, while tweaking other things in kernel32, I noticed that latest version fails a test in locale.c: $ cd dlls/kernel32/tests $ make test ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so locale.c && touch locale.ok locale.c:1990: Test failed: Enumerated gr

kernel32 (profile.c): current section and key implementation

2006-12-24 Thread Claudio Fontana
implementation is incorrect, and a patch fixing it by not requiring name[0] to be != '\0' is likely to be accepted? (btw, I've noticed you switched to git, so I will be using that instead now). Thanks, Claudio Fontana