Re: Patch for bug 34388

2013-09-06 Thread Charles Davis
On Sep 6, 2013, at 5:01 PM, Juan Lang wrote: > On Fri, Sep 6, 2013 at 3:54 PM, Charles Davis wrote: > Maybe then the real fix is to make Wine accept either a constructor SET or > the custom tag (ASN_CONTEXT | ASN_CONSTRUCTOR) it currently accepts, for > either attribute set. I sh

Re: Patch for bug 34388

2013-09-06 Thread Charles Davis
7;t expect to find another one. But I suspect that in the other case (just with the "UnknownItem"), it's because Crypto was expecting to find something in the set, but didn't. (I did, after all, fill the set with zeroes.) Maybe then the real fix is to make Wine accept eith

Patch for bug 34388

2013-09-05 Thread Charles Davis
Hi Juan, I need some advice. Attached is a patch to fix bug 34388, where an app that tries to verify its code signature fails because Wine, while parsing the certificates embedded within the signature, encounters an item in the CMS signer info (tag 0x31, i.e. ASN_UNIVERSAL | ASN_CONSTRUCTOR |

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Charles Davis
On Sep 3, 2013, at 1:30 PM, Bruno Jesus wrote: > On Tue, Sep 3, 2013 at 4:26 PM, Charles Davis wrote: >>> You mean removing protocol.c and adding all content to socket.c? If >>> yes I would appreciate if you could do that because I don't have the >>> git skil

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Charles Davis
On Sep 3, 2013, at 12:37 PM, Bruno Jesus wrote: > On Tue, Sep 3, 2013 at 3:34 PM, Alexandre Julliard > wrote: >> Bruno Jesus <00cp...@gmail.com> writes: >> >>> On Tue, Sep 3, 2013 at 3:16 PM, Bruno Jesus <00cp...@gmail.com> wrote: On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard

Re: Help to create a server request

2013-08-29 Thread Charles Davis
On Aug 29, 2013, at 6:43 PM, Bruno Jesus wrote: > Hi all, I need some help to continue my current wine work. > > In order to implement SO_PROTOCOL_INFO for getsockopt I need to > retrieve some information from the socket like its family and > protocol. > > I have searched for a few days and end

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-29 Thread Charles Davis
On Aug 29, 2013, at 2:35 PM, André Hentschel wrote: > Am 29.08.2013 19:52, schrieb André Hentschel: >> Hi, >> thank you both for the comments, i'll see what i can do. > > How about that? Much better, but... > > diff --git a/programs/winedbg/info.c b/programs/winedbg/info.c > index c0b86ba..0667

Re: patch:kernel32

2013-08-29 Thread Charles Davis
On Aug 29, 2013, at 8:15 AM, matyapiro31 wrote: > > <0001-kernel32-change-for-loop-to-optimize.patch><0002-kernel32-change-for-loop-to-optimize.patch> One patch per email, please. Also, the subject should be more descriptive. The first one doesn't look much better than the second one (which was

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-27 Thread Charles Davis
On Aug 27, 2013, at 3:08 PM, André Hentschel wrote: > Hi, > at [1] i noticed that dylibs are printed as PEs. > This intents to fix that, but i have no Mac, could someone please review/test? > > [1] > http://test.winehq.org/data/8ef3a142263e6db11f1514f77b3de84c8b08d7a0/mac_fg-snow-macdrv/advapi3

Re: [PATCH] winemac.drv: Support the public UTF-16 type for Unicode text.

2013-08-21 Thread Charles Davis
On Aug 21, 2013, at 10:34 PM, Ken Thomases wrote: > On Aug 21, 2013, at 9:42 PM, Charles Davis wrote: >> +static HANDLE import_utf16_to_unicodetext(CFDataRef data) >> +{ >> +const WCHAR *src; >> +unsigned long data_len; >> +unsigned long

Re: [PATCH] winemac.drv: Use the public UTF-16 type for Unicode text.

2013-08-21 Thread Charles Davis
On Aug 21, 2013, at 10:11 AM, Ken Thomases wrote: > On Aug 21, 2013, at 10:12 AM, Ken Thomases wrote: > >> On Aug 20, 2013, at 10:49 PM, Charles Davis wrote: >> >>> In the Windows world, "Unicode" almost universally means "UTF-16". So, >>

Re: Compiler warnings on Debian kfreebsd-i386

2013-08-09 Thread Charles Davis
On Aug 9, 2013, at 11:01 AM, Ken Sharp wrote: > On 08/08/13 21:28, Charles Davis wrote: >> >> On Aug 8, 2013, at 8:20 AM, Ken Sharp wrote: >> >>> Some interesting, some not: >>> >>> /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1898:24: warning: ‘

Re: Compiler warnings on Debian kfreebsd-i386

2013-08-08 Thread Charles Davis
On Aug 8, 2013, at 8:20 AM, Ken Sharp wrote: > Some interesting, some not: > > /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1898:24: warning: ‘get_pid_map’ > defined but not used [-Wunused-function] > /home/ken/wine-git/dlls/iphlpapi/ipstats.c:1953:21: warning: > ‘find_owning_pid’ defined but no

Clang warns on "wrong" header guard in "config.h"

2013-08-01 Thread Charles Davis
Hi, I've been building Wine with Clang, and it (apparently, unlike GCC) produces warnings like this: ../../include/config.h:4:9: warning: 'WINE_CROSSTEST' is used as a header guard here, followed by #define of a different macro [-Wheader-guard] #ifndef WINE_CROSSTEST ^~

Re: How to configure C++ implements in wine?

2013-07-15 Thread Charles Davis
On Jul 15, 2013, at 1:00 AM, 中川祥 wrote: > I'm working at User Access Logging API for Windows8. > It need C++ style coding. > How can I solve it? Those aren't C++ classes. Those are MOF classes. They're used with WMI. I'm sure you've seen how we implement WMI (cf. dlls/wbemprox). They do not nee

Re: api-ms-win-core-localregistry-l1-1-0: add stub dll

2013-06-04 Thread Charles Davis
On Jun 4, 2013, at 12:15 PM, Austin English wrote: > diff --git > a/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec > > b/dlls/api-ms-win-core-localregistry-l1-1-0/api-ms-win-core-localregistry-l1-1-0.spec > new file mode 100644 > index 000..cc15d4e > ---

Re: [PATCH 2/5] dinput: Support SendForceFeedbackCommand for OSX joysticks

2013-05-21 Thread Charles Davis
On May 21, 2013, at 1:34 PM, Andrew Eikum wrote: > --- > dlls/dinput/joystick_osx.c | 34 -- > 1 file changed, 32 insertions(+), 2 deletions(-) > > diff --git a/dlls/dinput/joystick_osx.c b/dlls/dinput/joystick_osx.c > index 94398e7..8fb675d 100644 > --- a/dlls/din

Re: windowscodecs: Add support for IMILBitmapSource interface.

2013-05-20 Thread Charles Davis
On May 19, 2013, at 9:14 PM, Dmitry Timoshkov wrote: > diff --git a/dlls/windowscodecs/bitmap.c b/dlls/windowscodecs/bitmap.c > index f8904df..646f3a7 100644 > --- a/dlls/windowscodecs/bitmap.c > +++ b/dlls/windowscodecs/bitmap.c > @@ -446,6 +471,226 @@ static const IWICBitmapVtbl BitmapImpl_Vtbl

Re: request.h: size of unnamed array is negative

2013-04-13 Thread Charles Davis
On Apr 13, 2013, at 9:43 PM, Hugh McMaster wrote: > On Apr 13, 2013, at 7:39 AM, Hugh McMaster wrote: > >> I've been adding a new handler to Wine's server. Unfortunately, I've run >> into a problem with C_ASSERT that I can't seem to resolve. >> >> In server/request.h, I've added the following

Re: request.h: size of unnamed array is negative

2013-04-13 Thread Charles Davis
27;d need more info like the actual struct get_desktop_workarea_request > > Hallo André, I missed your response to the list. > > This is what I have done. Wine compiles perfectly if I uncomment the > C_ASSERT lines. I note that Charles Davis said in another response that > requ

Re: request.h: size of unnamed array is negative

2013-04-13 Thread Charles Davis
On Apr 13, 2013, at 7:39 AM, Hugh McMaster wrote: > I've been adding a new handler to Wine's server. Unfortunately, I've run > into a problem with C_ASSERT that I can't seem to resolve. > > In server/request.h, I've added the following code: STOP! You should modify server/protocol.def instead.

Re: Dosbox integration

2013-04-08 Thread Charles Davis
On Apr 8, 2013, at 1:27 PM, Fabian Ebner wrote: > Hello, > I'm Fabian Ebner and work with wine as a hobby. > > I found that GetShortNameA converts the example path > C:\123456789\dn\DN.COM > to > C:\1234~Q4C\dn\DN.COM > which causes problems with dosbox integration. > Dosbox would need the path

Re: Build and override a simple winelib DLL

2013-04-05 Thread Charles Davis
On Apr 5, 2013, at 10:34 AM, Maxime Sednaoui wrote: > Hi, > > First, I already asked for the same thing at the forum where I've been told > to post here for my question > Link here : http://forum.winehq.org/viewtopic.php?f=8&t=18675 > > I have a Windows executable that load a really simple DLL

Re: Mac driver status: ready for contributions

2013-03-18 Thread Charles Davis
I have one more of my own to add: * Fix crash whenever an app makes a GLU call. I suspect this is because Mesa's GLU calls Mesa's libGL--which crashes horribly because there's no Mesa/GLX context current. I see two ways to fix that. One is to make GLU dispatch go through the driver. The other

Re: [PATCH 4/5] winemac: Implement rudimentary support for system tray icons as Mac status items.

2013-03-18 Thread Charles Davis
On Mar 18, 2013, at 2:23 PM, Ken Thomases wrote: > On Mar 18, 2013, at 2:15 PM, Ken Thomases wrote: > >> On Mar 18, 2013, at 3:03 PM, C.W. Betts wrote: >> >>> On Mar 17, 2013, at 9:40 PM, Ken Thomases wrote: >>> Doesn't support right-clicks, mouse moves, or notification balloons. >>> Not

Re: [1/3] Make mac driver the default on OS X

2013-03-07 Thread Charles Davis
On Mar 7, 2013, at 1:23 PM, Ken Thomases wrote: > On Mar 7, 2013, at 12:03 PM, Charles Davis wrote: > >> On Mar 6, 2013, at 7:56 AM, Ken Thomases wrote: >> >>> On Mar 6, 2013, at 8:24 AM, >>> wrote: >>> >>>> Bug report: >>>

Re: [1/3] Make mac driver the default on OS X

2013-03-07 Thread Charles Davis
On Mar 6, 2013, at 7:56 AM, Ken Thomases wrote: > On Mar 6, 2013, at 8:24 AM, > wrote: > >> Bug report: >> Toying around with built-in notepad, clock, winhlp32, I noticed that >> notepad and winhlp32 are not resizable, whereas the system >> preferences "control" is. By comparison, with the x

Re: [PATCH] winebuild: Use $CCAS to assemble if found

2013-02-07 Thread Charles Davis
On Feb 3, 2013, at 9:36 PM, Alexandre Rostovtsev wrote: > On Sun, 2013-02-03 at 20:27 -0700, Charles Davis wrote: >> If the user doesn't set CCAS--which she doesn't the majority of the >> time--configure will pick up the first of {clang, gas, as} in the PATH. Are &g

Re: Compiling Wine on Mac OS X 10.8.2?

2013-02-04 Thread Charles Davis
d not run 'make -j3' in /Users/jeremiah/wine/build/wine-git - exiting Yep, this is related to my patch alright. I'm willing to bet you're still running Xcode 4.5, too. Try upgrading to 4.6. Chip > > > On Sun, Feb 3, 2013 at 11:02 PM, Bill Broach > wrote: > Whi

Re: [PATCH] winebuild: Use $CCAS to assemble if found

2013-02-03 Thread Charles Davis
Hi, On Feb 3, 2013, at 7:33 PM, Alexandre Rostovtsev wrote: > Commit c14bdaf1 made winebuild use Clang to assemble if found. > > However, just because a user has some version of Clang installed, it > does not mean that she wants to use Clang to assemble Wine. For example, > a user who has both C

Re: Compiling Wine on Mac OS X 10.8.2?

2013-02-03 Thread Charles Davis
On Feb 3, 2013, at 10:50 AM, Saulius Krasuckas wrote: > * On Sun, 3 Feb 2013, Jeremiah Flerchinger wrote: > >> Is anyone compiling Wine from the git repository for OS X version >> 10.8.2? > > Not me... > >> At first I thought I broke my toolchain and could no longer compile Wine >> at all, b

Re: Clang warnings on OS X ML

2013-01-31 Thread Charles Davis
On Jan 30, 2013, at 6:44 PM, C.W. Betts wrote: > When compiling Wine using Clang, there are a bunch of warnings that pop up, > such as: > ld: warning: could not create compact unwind for .L__wine_spec_call16_p_pw: > dwarf uses DW_CFA_same_value > ld: warning: could not create compact unwind for

Re: User driver function conventions

2013-01-19 Thread Charles Davis
On Jan 19, 2013, at 1:09 PM, C.W. Betts wrote: > I'm wondering what the user driver functions GetScreenSaveActive and > SetScreenSaveActive are supposed to do. I have an implementation against > CodeWeaver's changes to Wine and I just want to make sure that I'm making the > functions properly.

Re: Ken Thomases : libwine: Use rpath-based install name and library references for libwine on Mac.

2013-01-11 Thread Charles Davis
On Jan 11, 2013, at 12:46 PM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: f377591e98c490ca00e6479627832e41b2ad01b9 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=f377591e98c490ca00e6479627832e41b2ad01b9 > > Author: Ken Thomases > Date: Fri Jan 11 03:25:

Re: [PATCH 3/6] loader: On Mac, embed Info.plist in (__TEXT, __info_plist) section.

2013-01-07 Thread Charles Davis
On Jan 7, 2013, at 9:15 AM, Ken Thomases wrote: > On Jan 7, 2013, at 1:23 AM, Per Johansson wrote: > >> On Mon, Jan 7, 2013 at 4:48 AM, Charles Davis wrote: >>> >>> With this, you won't be able to launch Wine from the Finder or with open(1) >>> pr

Re: [PATCH 3/6] loader: On Mac, embed Info.plist in (__TEXT, __info_plist) section.

2013-01-06 Thread Charles Davis
On Jan 6, 2013, at 6:54 PM, Ken Thomases wrote: > diff --git a/loader/wine_info.plist.in b/loader/wine_info.plist.in > new file mode 100644 > index 000..c332649 > --- /dev/null > +++ b/loader/wine_info.plist.in > @@ -0,0 +1,28 @@ > + > + "http://www.apple.com/DTDs/PropertyList-1.0.dtd";> > + >

Re: [PATCH] winebuild: Use Clang to assemble if its integrated assembler is being used.

2013-01-02 Thread Charles Davis
On Jan 2, 2013, at 11:23 AM, Per Johansson wrote: > On Wed, Jan 2, 2013 at 5:05 PM, André Hentschel wrote: >> >> Not sure if you can do it like that, as i understand it winebuild should >> always be able to crosscompile something, these ifdefs would destroy that >> feature. Only on Mac OS :).

Re: winebuild: Add configure option to use llvm-mc as assembler.

2013-01-02 Thread Charles Davis
On Jan 2, 2013, at 5:35 AM, Per Johansson wrote: > On Wed, Jan 2, 2013 at 3:12 AM, Charles Davis wrote: > >> What kind of undefined symbol errors? Other than the ones I got because >> as(1) from cctools can't grok CFI pseudo-ops (and probably never will >> becau

Re: winebuild: Add configure option to use llvm-mc as assembler.

2013-01-01 Thread Charles Davis
On Jan 1, 2013, at 4:36 PM, Per Johansson wrote: > On Tue, Jan 1, 2013 at 7:11 PM, Per Johansson wrote: >> On Tue, Jan 1, 2013 at 6:00 PM, Charles Davis wrote: >>> >>> The right thing IMO is to test if we're compiling with Clang. If we are, >>>

Re: winebuild: Add configure option to use llvm-mc as assembler.

2013-01-01 Thread Charles Davis
On Jan 1, 2013, at 9:35 AM, Per Johansson wrote: > Needed to build with clang on OS X, the normal as program can't parse clang > output. > It's a configure option since llvm-mc takes different options than the normal > assembler, and on OS X is most often installed by a different name > (llvm-mc-

Re: [PATCH] ntdll: Fix existing conftests for nanosecond precision time fields.

2012-11-29 Thread Charles Davis
On Nov 29, 2012, at 2:22 PM, Charles Davis wrote: > > On Nov 29, 2012, at 11:47 AM, Alexandre Julliard wrote: > >> Charles Davis writes: >> >>> From: Charles Davis >>> >>> Autoconf checks for a field of a struct by using it in an if() >

Re: [PATCH] ntdll: Fix existing conftests for nanosecond precision time fields.

2012-11-29 Thread Charles Davis
On Nov 29, 2012, at 11:47 AM, Alexandre Julliard wrote: > Charles Davis writes: > >> From: Charles Davis >> >> Autoconf checks for a field of a struct by using it in an if() >> expression. Of course, you can't do this for an aggregate field, so you &g

Re: How to tell Mac from Linux wine within a Wine app? (steam hardware survey)

2012-11-10 Thread Charles Davis
On Nov 10, 2012, at 12:03 PM, Scott Ritchie wrote: > Is there an easy way for the steam hardware survey to tell whether it's > running under Mac or Linux Wine? > > I remember discussing this issue with an engineer from Valve after asking > they make the % of Wine users public again. You can ca

Re: [spam-high] Re: [PATCH 3/7] advapi: Implement GetNamedSecurityInfoW on top of GetSecurityInfo (try 3).

2012-11-05 Thread Charles Davis
nly supports one user per prefix right now, so objects that exist in the file-system are the only ones where we have to worry about other users. (Besides, Wine probably doesn't even support multiple window station and desktop objects anyway...) Sorry for the noise. Chip > > Erich

Re: [PATCH 3/7] advapi: Implement GetNamedSecurityInfoW on top of GetSecurityInfo (try 3).

2012-11-04 Thread Charles Davis
On Nov 4, 2012, at 1:30 AM, Erich E. Hoover wrote: > This patch implements GetNamedSecurityInfoW on top of the more > fundamental GetSecurityInfo function, permitting the return of more > accurate ownership information for files. PlayReady uses this > information to determine if its files have t

Re: [PATCH] regedit: err() on printing

2012-10-12 Thread Charles Davis
On Oct 12, 2012, at 6:12 AM, Dmitry Timoshkov wrote: > Marcus Meissner wrote: > >> +ERR("printing is not yet implemented.\n"); > > Printing a FIXME seems more appropriate. Also, aren't programs supposed to use the prefixed calls (e.g. WINE_FIXME() instead of FIXME())? Chip

Re: [PATCH 1/4] jscript: Use custom string container instead of BSTR.

2012-10-11 Thread Charles Davis
On Oct 11, 2012, at 4:16 AM, Jacek Caban wrote: > This patch alone makes SunSpider 0.9 17x faster. Seems to me that something is really wrong with our BSTR implementation if replacing it with a home-grown implementation speeds this up by a factor of 17. Chip

Re: CIA going down: KGB wants your commits!

2012-09-27 Thread Charles Davis
On Sep 27, 2012, at 5:10 PM, Austin English wrote: > -- > -Austin > > -- Forwarded message -- > From: Martín Ferrari > Date: Thu, Sep 27, 2012 at 3:52 PM > Subject: CIA going down: KGB wants your commits! > To: debian-proj...@lists.debian.org, Debian Developers > > > > Hi th

Re: [PATCH 3/3] hhctrl.ocx: Resize the window when HH_SET_WIN_TYPE is called (try 3, resend 2).

2012-09-02 Thread Charles Davis
On Sep 2, 2012, at 11:23 AM, Erich E. Hoover wrote: > This patch adds the final feature to make the embedded help work > properly, allowing Elster to resize the HTML Help window whenever the > application window is resized. Without this feature the HTML Help > window would always remain at the s

Re: How to convert msvcp names to legible names?

2012-08-18 Thread Charles Davis
On Aug 18, 2012, at 6:04 PM, Bruno Jesus wrote: > Which is the roseta stone used to read all msvcp function names like > "msvcp80.dll.??0?$basic_stringstream@GU?$char_traits@G@std@@V?$allocator@G@2@@std@@QAE@H@Z, > aborting" as the real function name in source code? The __unDName() function in ms

Re: Vincent Povirk : windowscodecs: Add wrapper functions for IWICPalette methods.

2012-05-10 Thread Charles Davis
On May 10, 2012, at 1:17 PM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 2fc7cdc93f6dc8ed67498b74193423c44e5bb770 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=2fc7cdc93f6dc8ed67498b74193423c44e5bb770 > > Author: Vincent Povirk > Date: Tue May 8 10:49

Re: [5/5] msvcm80: Add __setusermatherr_m stub.

2012-05-04 Thread Charles Davis
On May 4, 2012, at 10:10 AM, Vincent Povirk wrote: > diff --git a/dlls/msvcm80/msvcm80_main.c b/dlls/msvcm80/msvcm80_main.c > index cd38f5b..eb09898 100644 > --- a/dlls/msvcm80/msvcm80_main.c > +++ b/dlls/msvcm80/msvcm80_main.c > @@ -50,3 +50,10 @@ void __cdecl > CrtImplementationDetails_Register

Re: [2/5] msvcm80: Add stub dll.

2012-05-04 Thread Charles Davis
On May 4, 2012, at 11:36 AM, Stefan Dösinger wrote: > Am Freitag, 4. Mai 2012, 11:07:50 schrieb Vincent Povirk: >> + * Copyright 2010 Vincent Povirk for CodeWeavers > Your clock seems a bit slow. > I imagine that he started working on this a while ago. Maybe he does have a plan for finishing th

Re: [2/5] msvcm80: Add stub dll.

2012-05-04 Thread Charles Davis
On May 4, 2012, at 10:07 AM, Vincent Povirk wrote: > > <0002-msvcm80-Add-stub-dll.txt> msvcmrt? The Managed C++ Runtime DLL? I imagine you won't get far on that without a C++/CLI compiler that understands the Microsoft Visual C++ ABI--unless you're willing to write all the marshaling glue code

SoC 2012 Ideas

2012-03-28 Thread Charles Davis
Hi, Since I graduate this year, this may be the last time I participate--or at least, attempt to participate, since last year didn't quite work out for me :(--in Summer of Code. (I realize I was supposed to email you last week, but what's done is done.) So, without further ado, here's what I'm

Re: [PATCH] mscoree: Print the correct values in a TRACE.

2012-03-23 Thread Charles Davis
On Mar 23, 2012, at 3:09 PM, Nicolas Le Cam wrote: > Le 23 mars 2012 21:41, Lauri Kenttä a écrit : >> --- >> dlls/mscoree/mscoree_main.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/dlls/mscoree/mscoree_main.c b/dlls/mscoree/mscoree_main.c >> index 1aa120f..0e

Re: Are we the reason Apple isn't helping us?

2012-03-11 Thread Charles Davis
Sorry about the really long email, but I didn't want to flood your inboxes with 5 separate responses. On Mar 11, 2012, at 12:15 AM, Jerome Leclanche wrote: > On Sun, Mar 11, 2012 at 4:33 AM, Charles Davis > wrote: >> Hi, >> >> An Apple developer recently contacted

Are we the reason Apple isn't helping us?

2012-03-10 Thread Charles Davis
Hi, An Apple developer recently contacted me directly about the Wine64 radar (number 9269783). What's interesting about his response, however, is that he put in an aside to berate us for our etiquette. I am convinced that at least this developer sees us as rude, hateful creatures now, and he ci

Re: [PATCH] winepulse: Add pulse driver, v8

2012-02-28 Thread Charles Davis
On Feb 28, 2012, at 10:58 PM, Chris Robinson wrote: > On Tuesday, February 28, 2012 5:32:13 PM Maarten Lankhorst wrote: >> + * This is basically the same as the pa_threaded_mainloop implementation, >> + * but that cannot be used because it uses pthread_create directly >> + * >> + * pa_threaded_ma

Re: Alexandre Julliard : gdi32: Avoid overflows for invalid coordinates in line clipping.

2012-02-22 Thread Charles Davis
On Feb 22, 2012, at 1:27 PM, Alexandre Julliard wrote: > --- a/dlls/gdi32/dibdrv/objects.c > +++ b/dlls/gdi32/dibdrv/objects.c > @@ -372,7 +372,8 @@ static inline DWORD calc_outcode(const POINT *pt, const > RECT *clip) > int clip_line(const POINT *start, const POINT *end, const RECT *clip, >

Re: Windows-on-Arm won't support win32

2012-02-13 Thread Charles Davis
On Feb 13, 2012, at 7:09 PM, Dan Kegel wrote: > On Mon, Feb 13, 2012 at 4:36 PM, Charles Davis > wrote: >> >> ...our implementation can be written purely in C the same way all our COM >> DLLs are. > > Or, come to think of it, we could write in Mono. True

Re: Windows-on-Arm won't support win32

2012-02-13 Thread Charles Davis
rently ready to all but abandon Win32, Wine will be more important than ever as a way to run legacy apps that aren't based on WinRT. > Eventually, if and when llvm gets Visual C++ ABI support, > maybe wine could start allowing C++ source code. > > (FWIW, I see Charles Davis was working o

Re: [PATCH 3/7] ntdll: fix endianness of three fields in DVD_LAYER_DESCRIPTOR (resend)

2012-02-10 Thread Charles Davis
On Feb 10, 2012, at 4:24 PM, Dan Kegel wrote: > On Fri, Feb 10, 2012 at 2:00 PM, Charles Davis > wrote: >>> -p->StartingDataSector = l->start_sector; >>> -p->EndDataSector = l->end_sector; >>> -p->EndLayerZ

Re: [PATCH 3/7] ntdll: fix endianness of three fields in DVD_LAYER_DESCRIPTOR (resend)

2012-02-10 Thread Charles Davis
On Feb 10, 2012, at 1:30 PM, Dan Kegel wrote: > --- > dlls/ntdll/cdrom.c | 12 +--- > 1 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c > index 802782b..6b64203c 100644 > --- a/dlls/ntdll/cdrom.c > +++ b/dlls/ntdll/cdrom.c > @@ -14

Re: [PATCH 4/7] kernel32/tests: initial tests for cdrom.c (try 2)

2012-02-10 Thread Charles Davis
On Feb 10, 2012, at 1:30 PM, Dan Kegel wrote: > +START_TEST(cdrom) > +{ [...] > +/* GENERIC_WRITE because without it, passthrough doesn't work on win7 */ But with it, you can't open the device at all on Mac. As I explained on bug 29669, the device file only has 0440 access. Chip

Re: Wine automated testing update

2012-02-03 Thread Charles Davis
On Feb 3, 2012, at 10:13 AM, Jeremy White wrote: > On 02/03/2012 10:47 AM, Dan Kegel wrote: >> Jeremy wrote: >>> the VMWare folks are not willing to provide a permanent license for VMWare >>> to us. >>> >>> So, we've shifted gears, and are exploring whether something like qemu + >>> kvm would b

Re: [PATCH] kernel32: implement GetLogicalProcessorInformation

2011-11-25 Thread Charles Davis
On Nov 25, 2011, at 8:17 AM, Claudio Fontana wrote: > On Fri, Nov 25, 2011 at 4:07 PM, Claudio Fontana > wrote: >> I have resent the patch as a "try 2" (there was a try 1.5 to fix test >> issues under windows older than XP SP3). >> >> The patch contains changes based on your feedback. > > Whic

Re: [PATCH] kernel32: implement GetLogicalProcessorInformation

2011-11-24 Thread Charles Davis
Hi, On Nov 24, 2011, at 4:21 AM, Claudio Fontana wrote: > First implementation of GetLogicalProcessorInformation. > Limitations: all logical processors are added to the same NUMA set, > and all cores are added to the same package. > Only the linux-specific helper function is implemented, so for n

Re: [PATCH] server: Use syscall(2) instead of inline assembly on Mac OS, too.

2011-10-09 Thread Charles Davis
On Oct 9, 2011, at 1:42 PM, David Laight wrote: > On Sat, Oct 08, 2011 at 07:48:40PM +0200, Alexandre Julliard wrote: >> Charles Davis writes: >> >>> @@ -268,9 +256,9 @@ int send_thread_signal( struct thread *thread, int sig ) >>> if (!mach_port_ex

Re: [PATCH] server: Use syscall(2) instead of inline assembly on Mac OS; too.

2011-10-07 Thread Charles Davis
On Oct 7, 2011, at 1:50 PM, Dan Kegel wrote: > Probably a spurious failure Yeah... especially considering that: - That change only affects Mac OS X, and I haven't added my buildslave yet ;). (That file shouldn't even get built on non-Darwin.) - Wine won't even build 64-bit on Mac OS yet (and mi

Re: kernel32: Implement GetVolumePathName.

2011-10-04 Thread Charles Davis
On Oct 4, 2011, at 11:56 AM, Erich Hoover wrote: > On Tue, Oct 4, 2011 at 11:36 AM, Charles Davis > wrote: >> On Oct 4, 2011, at 9:32 AM, Erich Hoover wrote: >>> This patch implements GetVolumePathName by using the full folder >>> path and working backward un

Re: kernel32: Implement GetVolumePathName.

2011-10-04 Thread Charles Davis
On Oct 4, 2011, at 9:32 AM, Erich Hoover wrote: > This patch implements GetVolumePathName by using the full folder > path and working backward until stat() returns a different device. Surely there's a better way. Can't you do a statfs(2)/statvfs(2) (for example) to find out the FS root? (I know

Re: Tests failing on OSX

2011-09-21 Thread Charles Davis
On Sep 21, 2011, at 3:35 PM, Stefan Dösinger wrote: > On Wednesday 21 September 2011 02:29:31 Charles Davis wrote: >>> No Xvidmode support, so Get/SetDeviceGammaRamp fail. There's a win_skip >>> for that already. Should we change it to skip(), or ignore it until w

Re: Tests failing on OSX

2011-09-20 Thread Charles Davis
On Sep 20, 2011, at 3:11 PM, Stefan Dösinger wrote: >> gdi32/dc >> user32/monitor > No Xvidmode support, so Get/SetDeviceGammaRamp fail. There's a win_skip for > that already. Should we change it to skip(), or ignore it until we have a > quartz driver? > User32/monitor also fails because it can'

Re: Glitch-free iTunes?

2011-07-05 Thread Charles Davis
On 7/5/11 2:23 AM, Damjan Jovanovic wrote: > On Tue, Jul 5, 2011 at 10:13 AM, Stefan Dösinger > wrote: >> Do we need full-fledged support for USB drivers for iTunes? I've been told in >> the past that all we need to do is properly report the new USB drive to >> iTunes >> when an iPod is attached

Re: [1/3] kernel32/heap: Emulate Win9x if appropriate in GlobalMemoryStatusEx(). (resend)

2011-06-02 Thread Charles Davis
On 6/2/11 2:46 PM, Adam Martinson wrote: > On 06/02/2011 03:10 PM, Dmitry Timoshkov wrote: >> Adam Martinson wrote: >> >>> +osver.dwOSVersionInfoSize = sizeof(osver); >>> +GetVersionExW(&osver); >>> + >> ... >>> +if (osver.dwMajorVersion>= 5) >> Once again, that's wrong way of detectin

Re: NTDLL doesn't compile under Clang

2011-05-29 Thread Charles Davis
On 5/29/11 12:41 PM, C.W. Betts wrote: > When compiling the NTDLL component of Wine, I get the following error: > ../../../wine-git/./dlls/ntdll/large_int.c:267:13: error: unknown use of > instruction mnemonic without a size suffix > __asm__("div %4,%%eax" > ^ > :1:2: note: in

Re: no line numbers in backtraces on Mac OS X?

2011-05-23 Thread Charles Davis
On 5/23/11 1:53 PM, Stefan Dösinger wrote: > On Monday 23 May 2011 17:48:55 Charles Davis wrote: >> Right now on Mac, you have to configure with -gstabs+. DbgHelp doesn't >> support DWARF on Mac OS yet. (It doesn't know how to find the .dSYM >> bundle or the origina

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 7 resend)

2011-05-23 Thread Charles Davis
On 5/23/11 12:15 PM, Alexandre Julliard wrote: > Charles Davis writes: > >> Rebased against Marcus Meissner's DECLSPEC_HIDDEN patches. (I hate you, >> Marcus...) >> Try 7: Fix getting the device name for IDE devices. >> Try 6: Fix some problems noticed by

Re: no line numbers in backtraces on Mac OS X?

2011-05-23 Thread Charles Davis
On 5/23/11 9:44 AM, joerg-cyril.hoe...@t-systems.com wrote: > Hi, > > Is it normal that there are no source line numbers in backtraces on Mac OS? > Despite many patches to winedbg etc., the backtraces I get are > no better that those from 1.1.24 times. > 18 0x41f5b2a1 _OpenDriverA+0x51() in winm

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 6)

2011-05-10 Thread Charles Davis
On 5/10/11 11:11 AM, Alexandre Julliard wrote: > Charles Davis writes: > >> Try 6: Fix some problems noticed by Vitaliy Margolen. >> Try 5: Get the value of "DeviceName" from mountmgr instead of making one up. >> Try 4: Fix unused variable warning. >> Try

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 5)

2011-05-09 Thread Charles Davis
On 5/9/11 8:36 AM, Vitaliy Margolen wrote: > On 05/09/2011 07:42 AM, Charles Davis wrote: >> Try 5: Get the value of "DeviceName" from mountmgr instead of making >> one up. >> Try 4: Fix unused variable warning. >> Try 3: Add support for IDE drives. >&

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32. (try 2)

2011-04-25 Thread Charles Davis
On 4/25/11 5:01 AM, Alexandre Julliard wrote: > Charles Davis writes: > >> Try 2: don't depend on the existence of scsi-generic entries in the HAL tree. > > It's still not listing my /dev/hda CD drive. Hmm... which IDE driver is your kernel using, the "legac

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32.

2011-04-21 Thread Charles Davis
On 4/21/11 4:21 AM, Alexandre Julliard wrote: > Charles Davis writes: > >> On 4/20/11 9:43 AM, Alexandre Julliard wrote: >>> It doesn't seem to work here, I don't get any devices. >> Funny. It works fine on both my 32-bit and 64-bit VMs. Clearly my setup >

Re: [PATCH 1/2] mountmgr: Populate HKLM\HARDWARE\DEVICEMAP\Scsi here instead of in kernel32.

2011-04-20 Thread Charles Davis
On 4/20/11 9:43 AM, Alexandre Julliard wrote: > Charles Davis writes: > >> --- >> dlls/kernel32/Makefile.in|1 - >> dlls/kernel32/oldconfig.c| 404 >> -- >> dlls/kernel32/process.c |3 - >

Re: Windres and wine

2011-04-15 Thread Charles Davis
On 4/15/11 10:38 PM, Gerold Jens Wucherpfennig wrote: > Hi, > > I have created GUI dialog with ResEdit. > That rc-file shall be used in wine. > The problem is that wine doesn't have > a Windres.exe. Is it possible to make > a c-file from the rc-file? No. But you don't need windres. Wine has its ow

Introducing "Deobjectivizer"

2011-04-10 Thread Charles Davis
Hi, I've been working on a secret Clang-based project for a while, and now I'm ready to share it with the world. Introducing the "Deobjectivizer". This is a program that scans framework bundle headers for Objective-C constructs, and generates procedural C wrappers around them, so you can call th

Re: Must multimedia players check the message queue and invoke DispatchMessage?

2011-04-09 Thread Charles Davis
On 4/9/11 12:43 PM, Ove Kaaven wrote: > The function calling GetMessage isn't supposed to do anything beyond > calling DispatchMessage. What about TranslateMessage()? Chip

Re: Google Summer of Code project

2011-04-07 Thread Charles Davis
On 4/7/11 4:28 PM, Michał Ziętek wrote: > Do you consider putting this project into Google Summer of Code? You can propose whatever you want for GSoC (as long as it's relevant to Wine, or whatever organization you're proposing to). That page is just a list of ideas to get you started. In fact, I p

Re: riched20: Remove the unneeded DEFINE_STDCALL_WRAPPER.

2011-04-07 Thread Charles Davis
On 4/7/11 3:28 PM, Michael Stefaniuc wrote: > On 04/07/2011 07:04 PM, Dylan Smith wrote: >> On Thu, Apr 7, 2011 at 1:00 PM, Dylan Smith >> wrote: >>> >>> The rest of the richedit code needs to call the ITextHost interface >>> using the thiscall calling convention, so on i386 it calls a thunk in >>

Re: Summer of Code 2011 ideas

2011-04-03 Thread Charles Davis
On 3/27/11 5:53 PM, Charles Davis wrote: > 1. Quartz Driver. I know you guys rejected this last year, but it looks > like AJ's been doing some work refactoring the driver interface (at > least, the GDI driver interface) lately. I also have some patches to > isolate the rest of

Re: Project: x86 to ARM binary translator

2011-04-01 Thread Charles Davis
On 4/1/11 6:19 PM, Yale Zhang wrote: > Fellow developers, > > I'm thinking of starting a VM project to allow running x86 Windows apps > on ARM Android. This will obviously involve binary translation. I've > read about QEMU's tiny code generator and think for a usable experience, > the intermedia

Re: [PATCH] kernel32: Populate HKLM\HARDWARE\DEVICEMAP\Scsi on Mac OS.

2011-03-31 Thread Charles Davis
On 3/30/11 2:53 AM, Alexandre Julliard wrote: > Charles Davis writes: >> How do you propose to do that? The way this is done on Linux, it's >> probably fine to just build up/tear down an entry for each device that >> HAL/udev detects, but DiskArbitration only handles dis

Re: [PATCH] kernel32: Populate HKLM\HARDWARE\DEVICEMAP\Scsi on Mac OS.

2011-03-29 Thread Charles Davis
On 3/29/11 4:34 AM, Alexandre Julliard wrote: > Charles Davis writes: > >> From: Charles Davis >> >> --- >> dlls/kernel32/Makefile.in |2 +- >> dlls/kernel32/oldconfig.c | 157 >> +++- >> 2 files chan

Summer of Code 2011 ideas

2011-03-27 Thread Charles Davis
Hi, I intend to participate in the Google Summer of Code (again), so I'd like to bounce some ideas off of you guys again. (I don't know why; I'll probably end up doing an extension of last year's project that I did for LLVM. But just in case...) I know that students are supposed to start submittin

Re: Failing kernel32:change and ntdll:change tests on Mac OS

2011-03-21 Thread Charles Davis
Sorry I waited so long to get back to you. On 3/10/11 3:27 PM, Ken Thomases wrote: > On Mar 10, 2011, at 4:20 PM, Ken Thomases wrote: > >> I doubt Alexandre would accept reworking wineserver around CFRunLoop, I know. Then again, I've often wondered if doing this might be beneficial. I seem to rem

Re: [PATCH] winegcc - do not create .exe.so

2011-03-20 Thread Charles Davis
On 3/20/11 10:28 PM, Ben Klein wrote: > On 21 March 2011 15:10, Charles Davis wrote: >> On 3/20/11 9:31 PM, Ben Klein wrote: >>> On 21 March 2011 12:26, Charles Davis wrote: >>>> Also, as near as I can tell, this will only work on x86 Linux. It won't >

Re: [PATCH] winegcc - do not create .exe.so

2011-03-20 Thread Charles Davis
On 3/20/11 9:31 PM, Ben Klein wrote: > On 21 March 2011 12:26, Charles Davis wrote: >> Also, as near as I can tell, this will only work on x86 Linux. It won't >> work anywhere else (e.g. Mac OS X, FreeBSD, Solaris, etc.). This is >> because the 'start' code i

Re: [PATCH] winegcc - do not create .exe.so

2011-03-20 Thread Charles Davis
On 3/20/11 6:54 PM, Chris Robinson wrote: > On Sunday, March 20, 2011 4:37:07 PM Vitaliy Margolen wrote: >> On 03/20/2011 05:14 AM, Pali Rohár wrote: >>> Can anybody review my patch? >> >> Not sure what you trying to do exactly. Wine already has wrapper that makes >> all wine binaries executable af

Failing kernel32:change and ntdll:change tests on Mac OS

2011-03-10 Thread Charles Davis
Hi, I just got done looking over the latest batch of test results I sent, and one thing really sticks out and bothers me. The Change Notification tests all fail miserably on my machine (a 2009 Mac Pro with Mac OS X 10.6), because that feature hasn't been implemented on Mac yet. I could implement

  1   2   3   >