2013/8/2 Alexandre Julliard :
> Caibin Chen writes:
>
>> diff --git a/dlls/riched20/tomimpl.h b/dlls/riched20/tomimpl.h
>> new file mode 100644
>> index 000..886c3a8
>> --- /dev/null
>> +++ b/dlls/riched20/tomimpl.h
>> @@ -0,0 +1,59 @@
>> +/*
There are at least 3 more interfaces to be implemented, should I put
them in richole.c as well?
2013/7/31 Alexandre Julliard :
> Caibin Chen writes:
>
>> Hi Alexandre,
>>
>> I think it make sense to have a separate file for ITextDocument. It
>> will be used in txtsr
ch 2
and 3 into txtdoc.[ch]
2013/7/31 Alexandre Julliard :
> Caibin Chen writes:
>
>> Thanks Jacek for reviewing. This time I send all the changes I have in
>> 4 patches to make it clear that ReTxtDoc is reused between txtsrv.c
>> and richole.c
>> - Suppresse
Hi Jacek,
Thanks for your review. I really appreciate it :)
2013/7/29 Jacek Caban :
> You sent the patch during code freeze, when it couldn't be committed, so
> it probably didn't get enough attention. Now is the right time to resubmit.
Does that means I should resend the patch to the mail list?
2013/7/18 Caibin Chen :
> Anybody reviewing this patch? It's almost all stubs, so although it's
> long, it shouldn't be hard to review
>
> 2013/7/15 Caibin Chen :
>> (Retry with real name in mail. The name in the patch is already my real name)
>>
>> This p
Can you explain what benefits can we get from merging these two tests?
To me it only make them hard to read.
2013/7/18 Nikolay Sivov :
> On 7/19/2013 00:15, Caibin Chen wrote:
>>
>> What files do you mean to merge? txtsrv.c and richole.c or
>> test/richole.c and test/ri
What files do you mean to merge? txtsrv.c and richole.c or
test/richole.c and test/richole.c?
2013/7/18 Nikolay Sivov :
> On 7/19/2013 00:04, Caibin Chen wrote:
>>
>> The ITextRange objects are returned by ITextDocument_Range() method.
>> Both IRichEditOle and ITextService s
http://www.winehq.org/pipermail/wine-patches/2013-July/125258.html
2013/7/18 Nikolay Sivov :
> On 7/18/2013 23:36, Caibin Chen wrote:
>>
>> ITextRange will be used in both richole.c and txtsrv.c. I'm planning
>> to add more tests in it. I think it makes more sense to have one
ITextRange will be used in both richole.c and txtsrv.c. I'm planning
to add more tests in it. I think it makes more sense to have one test
file for each interface, which improves the readability of tests.
2013/7/18 Nikolay Sivov :
> On 7/18/2013 20:28, Caibin Chen wrote:
>>
>>
Anybody reviewing this patch? It's almost all stubs, so although it's
long, it shouldn't be hard to review
2013/7/15 Caibin Chen :
> (Retry with real name in mail. The name in the patch is already my real name)
>
> This patch implements a standalone stub of ITextDocument.
10 matches
Mail list logo
