Re: I'm not sure why it was rejected

2013-10-02 Thread Bruno Jesus
On Wed, Oct 2, 2013 at 12:17 PM, Akira Nakagawa wrote: > I cannnot make sure my patch 99266 was rejected. I can't really tell why it was rejected but I can tell there are mixed space/tabs in the SetLastError lines. I guess if you SetLastError to not implemented you cannot return S_OK too Try co

Re: [3/3] ws2_32: Always return the source address from WSAAccept.

2013-10-01 Thread Bruno Jesus
On Tue, Oct 1, 2013 at 6:37 AM, Hans Leidekker wrote: > --- > dlls/ws2_32/socket.c | 9 + > dlls/ws2_32/tests/sock.c | 6 +++--- > 2 files changed, 4 insertions(+), 11 deletions(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index c34de4b..6855298 100644 > --- a/dll

Re: [1/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 3)

2013-09-30 Thread Bruno Jesus
On Fri, Sep 27, 2013 at 8:16 AM, Akihiro Sagawa wrote: > > Fixes bug 18440, 20847. > > Try 3: >- Rebase to recent source. >- Separate ABC metrics change. >- Use conditional operator. > --- > dlls/gdi32/freetype.c |4 ++-- > dlls/gdi32/tests/font.c | 24

Re: [3/3] ws2_32: Implement WSASendMsg() (try 2)

2013-09-30 Thread Bruno Jesus
On Mon, Sep 30, 2013 at 6:32 AM, Alexandre Julliard wrote: > > Bruno Jesus <00cp...@gmail.com> writes: > > > @@ -2427,6 +2427,46 @@ static void WINAPI WS2_GetAcceptExSockaddrs(PVOID > > buf

Re: add ualapi directory (try 12)

2013-09-28 Thread Bruno Jesus
I still don't understand why the copyright is different for the .c and .h file. In one file you add your first name only and in the other your full name. Regards, Bruno On Sat, Sep 28, 2013 at 4:14 AM, Akira Nakagawa wrote: > > > > > > -- universe* god::bigbang (void); //and then it all bega

Re: [2/2] ws2_32: Implement WSASendMsg()

2013-09-27 Thread Bruno Jesus
On Sat, Sep 28, 2013 at 1:50 AM, Bruno Jesus <00cp...@gmail.com> wrote: > Fixes bug 34005. There is a problem with this patch, I'm working on an updated version. Sorry, Bruno

Re: [PATCH 2/3] iphlpapi: Add interface enumeration for Android.

2013-09-19 Thread Bruno Jesus
On Thu, Sep 19, 2013 at 10:06 AM, Huw Davies wrote: > --- > configure.ac | 3 +- > dlls/iphlpapi/ifenum.c | 199 > - > 2 files changed, 200 insertions(+), 2 deletions(-) Hi, Huw. I'm not sure this is an issue but in the android impleme

Re: [PATCH] oleaut32: Implement VarDecRound

2013-09-17 Thread Bruno Jesus
On Tue, Sep 17, 2013 at 3:01 PM, Andrew Eikum wrote: > This fixes a crash in PowerPoint when a shape is made > semi-transparent. May also fix bug http://bugs.winehq.org/show_bug.cgi?id=34463 and http://bugs.winehq.org/show_bug.cgi?id=30485

Re: [1/4] ws2_32: Use the struct information when the parameters are zero in WSASocket

2013-09-17 Thread Bruno Jesus
On Tue, Sep 17, 2013 at 7:00 AM, Alexandre Julliard wrote: > Bruno Jesus <00cp...@gmail.com> writes: > >> @@ -5884,20 +5884,20 @@ SOCKET WINAPI WSASocketW(int af, int type, int >> protocol, >>return ret; >> } >> >> -/*

Re: [PATCH 3/6] ws2_32: Fix parameters checking in WSADuplicateSocket

2013-09-09 Thread Bruno Jesus
On Mon, Sep 9, 2013 at 6:39 AM, Alexandre Julliard wrote: > Bruno Jesus <00cp...@gmail.com> writes: > >> +fd = get_sock_fd( s, FILE_READ_DATA, NULL ); >> +if (fd == -1) >> +{ >> +SetLastError(WSAENOTSOCK); >> +return SOCKET_E

Re: [PATCH 1/6] ws2_32: Mark WinNT result as broken

2013-09-08 Thread Bruno Jesus
On Sun, Sep 8, 2013 at 1:58 AM, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > https://newt

Re: [PATCH 2/3] ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 3)

2013-09-06 Thread Bruno Jesus
On Fri, Sep 6, 2013 at 7:16 AM, Alexandre Julliard wrote: > Bruno Jesus <00cp...@gmail.com> writes: > >> +static int ws_protocol_info(SOCKET s, int unicode, WSAPROTOCOL_INFOW >> *buffer) >> +{ >> +int size; >> +union _info

Re: ws2_32: Cope with invalid protocols in WSAEnumProtocols

2013-09-05 Thread Bruno Jesus
On Thu, Sep 5, 2013 at 9:44 AM, Dmitry Timoshkov wrote: > Bruno Jesus <00cp...@gmail.com> wrote: > >> +INT validprotocols[] = { WS_IPPROTO_TCP, >> + WS_IPPROTO_UDP, >> + NSPROTO_IPX, >> +

Re: iphlpapi: Add AllocateAndGetTcpExTableFromStack()

2013-09-04 Thread Bruno Jesus
On Wed, Sep 4, 2013 at 8:02 AM, Ralf Habacker wrote: > > - added test case (update) > > Signed-off-by: Ralf Habacker > --- > dlls/iphlpapi/iphlpapi.spec|1 + > dlls/iphlpapi/ipstats.c| 33 + > dlls/iphlpapi/tests/iphlpapi.c | 32 +++

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Bruno Jesus
On Tue, Sep 3, 2013 at 4:26 PM, Charles Davis wrote: >> You mean removing protocol.c and adding all content to socket.c? If >> yes I would appreciate if you could do that because I don't have the >> git skills and wouldn't now how to sort the functions inside socket.c. > It's not that hard. Just c

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Bruno Jesus
On Tue, Sep 3, 2013 at 4:57 PM, Charles Davis wrote: > > On Sep 3, 2013, at 1:30 PM, Bruno Jesus wrote: > >> On Tue, Sep 3, 2013 at 4:26 PM, Charles Davis wrote: >>>> You mean removing protocol.c and adding all content to socket.c? If >>>> yes I would ap

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Bruno Jesus
On Tue, Sep 3, 2013 at 3:34 PM, Alexandre Julliard wrote: > Bruno Jesus <00cp...@gmail.com> writes: > >> On Tue, Sep 3, 2013 at 3:16 PM, Bruno Jesus <00cp...@gmail.com> wrote: >>> On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard >>> wrote: &

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Bruno Jesus
On Tue, Sep 3, 2013 at 3:16 PM, Bruno Jesus <00cp...@gmail.com> wrote: > On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard > wrote: >> Bruno Jesus <00cp...@gmail.com> writes: >> >>> try 2: >>> Narrow the loop for the specified protocol >>

Re: ws2_32: Implement get socket option SO_PROTOCOL_INFO (try 2)

2013-09-03 Thread Bruno Jesus
On Tue, Sep 3, 2013 at 3:04 PM, Alexandre Julliard wrote: > Bruno Jesus <00cp...@gmail.com> writes: > >> try 2: >> Narrow the loop for the specified protocol >> Add a new test for invalid sockets > > Considering what WSAEnumProtocols does, the loop doesn'

Re: iphlpapi: Add AllocateAndGetTcpExTableFromStack().

2013-08-31 Thread Bruno Jesus
On Sat, Aug 31, 2013 at 9:16 AM, Ralf Habacker wrote: > new > - add doc for family parameter > - add doc for additional return code > - sorting in c file fixed > > Signed-off-by: Ralf Habacker I guess the patch was marked as pending because you didn't add any tests. You are also missing the (try

Re: Help to create a server request

2013-08-30 Thread Bruno Jesus
On Thu, Aug 29, 2013 at 10:38 PM, Charles Davis wrote: > To add a new request to the server, you first add a definition to > server/protocol.def . This file is processed by the make_requests tool, which > generates a bunch of other files from it. The syntax of the server protocol > definition f

Help to create a server request

2013-08-29 Thread Bruno Jesus
Hi all, I need some help to continue my current wine work. In order to implement SO_PROTOCOL_INFO for getsockopt I need to retrieve some information from the socket like its family and protocol. I have searched for a few days and ended up with a solution I dislike so I had a better idea (at least

Re: patch:kernel32

2013-08-29 Thread Bruno Jesus
On Thu, Aug 29, 2013 at 11:15 AM, matyapiro31 wrote: The patch could have a better subject =) > +unix_len=sizeof(unix_vars)/sizeof(unix_vars[0]; Missing the closing ) ? Will this compile? > -for ( i = 0; i < sizeof (special) / sizeof (WCHAR); i++ ) > +for ( i = 0; i < 17; i++ ) I gu

Re: [PATCH 1/3] ws2_32: Implement SIO_ADDRESS_LIST_CHANGE with NotifyAddrChange (try 2).

2013-08-26 Thread Bruno Jesus
On Mon, Aug 5, 2013 at 1:24 AM, Erich E. Hoover wrote: > The attached patch is the next step in the series of fixes for > Silverlight/PlayReady under Wine. This particular patch does not > impact Netflix, but it does impact a number of other PlayReady > streaming services (and a variety of non-str

Re: wine-bugs change?

2013-08-13 Thread Bruno Jesus
On Tue, Aug 13, 2013 at 12:14 PM, Thomas Spear wrote: > Hi all, > > I've been subscribed to the lists for several years now, archiving all of > the conversations in case a situation ever arises where a backup copy is > needed. I've had a filter setup in gmail for wine-bugs that has worked > perfec

Re: [PATCH 1/4] d3dx9: Track ID3DXEffect::Begin/End().

2013-08-01 Thread Bruno Jesus
On Thu, Aug 1, 2013 at 9:14 AM, Rico Schüller wrote: > --- > dlls/d3dx9_36/effect.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > +if (!This->started) > +return D3D_OK; > + > +This->started = FALSE; > + > +return D3D_OK; Sorry to bother but why no

Re: reg.exe: Add query function

2013-08-01 Thread Bruno Jesus
On Thu, Aug 1, 2013 at 10:39 AM, Hugh McMaster wrote: > This patch significantly builds on the query function stub in > programs/reg.exe. The patch includes recursion for subkeys. The patch was sent to wine-devel. > Some examples of usage: > > wine reg.exe query "HKCU" > wine reg.exe query "HKC

Re: ws2_32/tests: Test the precedence of parameters while creating a socket in WSASocket()

2013-07-31 Thread Bruno Jesus
On Wed, Jul 31, 2013 at 10:21 AM, Thomas Faber wrote: > On 2013-07-31 02:48, Bruno Jesus wrote: >> +ok(!getsockopt(sock, SOL_SOCKET, SO_TYPE, (char *) &socktype, &size), >> "getsockopt failed with %d\n", >> + WSAGetLastError()); > > It'

Re: kernel32/tests: Improve GetVolumePathNameA tests

2013-07-30 Thread Bruno Jesus
Please ignore this patch, I understand that as is it will not be commited. On Tue, Jul 30, 2013 at 3:30 AM, Bruno Jesus <00cp...@gmail.com> wrote: > Erich Hoover contacted me about a patch he sent months ago related to > GetVolumePathNameA. He developed a better test infrastructure u

Call for Windows tests

2013-07-30 Thread Bruno Jesus
Hi, I'm looking for help to test WSAEnumProtocols, I need to collect more information about the values returned from different versions of windows, especially 7 and 8. If you can help please download the file below, unzip, run the .bat and send me back the result.txt file (sources included). http:

Wine 1.6 list of deferred patches

2013-07-22 Thread Bruno Jesus
This is the list of (hopefully) all deferred patches for wine 1.6, all authors are in bcc. I hope it's useful for developers. 97187 DeferredDmitry Timoshkov[3/3] kernel32: GetShortPathName for a non-existent short file name should fail. 97131 DeferredRosen Diankov

Re: wbemprox: Implement Win32_OperatingSystem.LocalDateTime. (try 2)

2013-07-11 Thread Bruno Jesus
On Thu, Jul 11, 2013 at 11:19 AM, Sylvain Petreolle wrote: > --- > dlls/wbemprox/builtin.c | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c > index 9e2369a..5b7674e 100644 > --- a/dlls/wbemprox/builtin.c > +

Re: [website] Added Portuguese translation for call for translators

2013-06-20 Thread Bruno Jesus
On Wed, Jun 19, 2013 at 5:22 PM, Frédéric Delanoy wrote: > Just wondering: does it make sense to translate a call for translators? > > I mean, if a volunteer can't understand the English from the call, > (s)he wouldn't be able to translate correctly anyway. I don't see any problem in translating

Re: Alexandre Julliard : winefile: Avoid abbreviations in column names.

2013-06-18 Thread Bruno Jesus
On Tue, Jun 18, 2013 at 4:42 PM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: f07ff7f9819b32437624a320fe3029dd795b7a61 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=f07ff7f9819b32437624a320fe3029dd795b7a61 > > Author: Alexandre Julliard > Date: Tue Jun 18

Re: po: Update Spanish translation

2013-06-17 Thread Bruno Jesus
On Mon, Jun 17, 2013 at 6:05 PM, André Hentschel wrote: > I recently started to learn spanish, so i did this easy fixes with best > knowledge, though without guaranty > --- > po/es.po | 60 ++-- > 1 file changed, 18 insertions(+), 42 deleti

Re: ole32: Do not fail if partial blocks are read

2013-06-17 Thread Bruno Jesus
On Mon, Jun 17, 2013 at 1:28 PM, Aric Stewart wrote: > > fixes bug 25346 Actually this patch fixes bug 33821. Bug 25346 is older than the regression and was only affected by it. > --- > dlls/ole32/storage32.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > Best wishes, Bruno

Re: [PATCH] [cmd, try2] move filename . deletes file

2013-06-13 Thread Bruno Jesus
On Thu, Jun 13, 2013 at 12:23 PM, Alexandre Julliard wrote: > > Jason Edmeades writes: > > > move is not tollerent of the source and destination being the same > > and happily removes the destination (after prompting) ready to > > move the file, only to appear shocked that the file is no longer >

Re: wined3d: Add Mobility Radeon HD 4200

2013-06-06 Thread Bruno Jesus
On Sun, Jun 2, 2013 at 9:29 AM, Rico Schüller wrote: > On 30.05.2013 23:51, Kyle Luna wrote: >> >> +{HW_VENDOR_AMD,CARD_AMD_RADEON_HD4200M,"ATI Mobility >> Radeon HD 4200", DRIVER_AMD_R600, 256 }, > > > I think there are versions available which have only 128MB of

Re: bugzilla: Change no bugs found message

2013-06-04 Thread Bruno Jesus
On Tue, Jun 4, 2013 at 12:38 PM, Christian Costa wrote: > > Hi, > > Minor but shouldn't it be "bug" instead "bugs"? At least in portuguese zero is plural. In english according to [1] : Treatments differ in expressions of zero quantity: English often uses the plural in such expressions as no inju

Re: Why 0.1.0.0 as local socket address instead of 127.0.0.1?

2013-01-27 Thread Bruno Jesus
On Fri, Jan 25, 2013 at 4:11 PM, Francois Gouget wrote: > > The ws2_32:sock fails on some of my machines with the following error: > > sock.c:4794: Test failed: Local socket address is different 0.1.0.0 != > 127.0.0.1 > > Does anyone know why we GetAcceptExSockaddrs() would return 0.1.0.0 > inste

Re: wined3d: Recognize Nvidia GTX660 cards.

2012-12-16 Thread Bruno Jesus
On Fri, Dec 14, 2012 at 2:01 PM, Caron Jensen wrote: > CARD_NVIDIA_GEFORCE_GT630M = 0x0de9, > CARD_NVIDIA_GEFORCE_GT640M = 0x0fd2, > CARD_NVIDIA_GEFORCE_GT650M = 0x0fd1, > +CARD_NVIDIA_GEFORCE_GTX660 = 0X1183, > CARD_NVIDIA_GEFORCE_GTX670 = 0x1189,

Re: Explicit fall-through in switch statements?

2012-11-25 Thread Bruno Jesus
On Sun, Nov 25, 2012 at 9:20 PM, Frédéric Delanoy wrote: > For every wine version, static checkers (like coverity) detect cases > where a switch case automatically falls-through to the next case. > > Shouldn't be there a rule that such cases are always marked with a > "fall-through comment"? > Wit

Re: ws2_32: Fix TRACE format in WS_getsockname (try 2)

2012-10-01 Thread Bruno Jesus
On Mon, Oct 1, 2012 at 12:37 AM, Dmitry Timoshkov wrote: > Bruno Jesus <00cp...@gmail.com> wrote: > >> -TRACE("socket: %04lx, ptr %p, len %8x\n", s, name, *namelen); >> +TRACE("socket: %04lx, ptr %p, len %08x\n", s, name, namelen?*namelen:0);

Re: Question from new developer

2012-09-23 Thread Bruno Jesus
On Fri, Sep 21, 2012 at 8:41 PM, Chris Teague wrote: > I submitted bug 31753 for an application that I use, and started > making an attempt to fix it. I started with the last few messages > from the log: > > fixme:win:LockWindowUpdate (0x501c4), partial stub! > fixme:win:LockWindowUpdate ((nil)),

How to convert msvcp names to legible names?

2012-08-18 Thread Bruno Jesus
Which is the roseta stone used to read all msvcp function names like "msvcp80.dll.??0?$basic_stringstream@GU?$char_traits@G@std@@V?$allocator@G@2@@std@@QAE@H@Z, aborting" as the real function name in source code? Thanks in advance, Bruno

Re: MSVCP60.dll

2012-06-22 Thread Bruno Jesus
On Fri, Jun 22, 2012 at 5:27 PM, John Emmas wrote: > On 22 Jun 2012, at 20:17, Bruno Jesus wrote: >>> ... >>> BACKTRACE FOLLOWS:- >>> Unhandled exception: unimplemented function >>> msvcp60.dll.??0Init@ios_base@std@@QAE@XZ called in 32-bit code (0x7

Re: MSVCP60.dll

2012-06-22 Thread Bruno Jesus
On Fri, Jun 22, 2012 at 3:38 PM, John Emmas wrote: > If anyone thinks of any useful information I'll add it to the bug report. > ... > BACKTRACE FOLLOWS:- > Unhandled exception: unimplemented function > msvcp60.dll.??0Init@ios_base@std@@QAE@XZ called in 32-bit code (0x7b83aed2). This problem is

RFC: comdlg32: Fix null lpstrFile uses in FILEDLG95_OnOpen

2012-06-14 Thread Bruno Jesus
Hi, I have written a patch to fix bug 17229 and would like to request help to complete the test part. The test creates a common dialog and select a filename (file does not need to exist), it was copied from other tests in the same file (comdlg32/tests/filedlg.c). It's not possible to have a defaul

Re: msvcrt: Fix the name of the Portuguese locale alias.

2012-06-13 Thread Bruno Jesus
On Wed, Jun 13, 2012 at 2:47 PM, Francois Gouget wrote: > ... >  dlls/msvcrt/locale.c       |    2 +- >  dlls/msvcrt/tests/locale.c |    2 +- >  2 files changed, 2 insertions(+), 2 deletions(-) > ... > -    "portugese", "ptb", > +    "portuguese", "ptb", Just a side note. Although I'm not sure I

Re: [2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.

2012-05-22 Thread Bruno Jesus
On Mon, Apr 30, 2012 at 6:52 AM, Dmitry Timoshkov wrote: > --- >  dlls/gdi32/freetype.c   |   35 +++- >  dlls/gdi32/tests/font.c |   83 > ++- >  2 files changed, 116 insertions(+), 2 deletions(-) I don't know if this patch was directly

Re: kernel32/tests: Add tests for K32GetModuleFileNameEx

2012-05-01 Thread Bruno Jesus
On Tue, May 1, 2012 at 02:34, Bruno Jesus <00cp...@gmail.com> wrote: > Add some tests required for http://bugs.winehq.org/show_bug.cgi?id=30543 Please, ignore this patch. It was based on old git. Apologies, Bruno

Re: user32/tests: Update DlgDirList tests

2012-04-27 Thread Bruno Jesus
On Sat, Apr 14, 2012 at 21:57, Bruno Jesus <00cp...@gmail.com> wrote: > Based on original patch from Christian Lupien from bug 8226. > > Tests required to later fix http://bugs.winehq.org/show_bug.cgi?id=8226 Is there anything else I could provide in helping to get this patch

Re: ws2_32: Fix hostent memory allocation

2012-04-16 Thread Bruno Jesus
On Mon, Apr 16, 2012 at 10:17, Alexandre Julliard wrote: > ... > That's not a good helper function, with all the optional parameters and > various behaviors. Also if you need a big documentation block like this > for a 5-line function it's a sign that something is wrong. Sorry, I didn't know it w

Re: [1/2] comctl32/tests: Added tests for mouse events handling (try 3)

2012-04-15 Thread Bruno Jesus
On Sun, Apr 15, 2012 at 07:38, Daniel Jelinski wrote: > Hello, > ... > Bug 19222 makes using MS SQL Server management studio a pain. The > application displays database structure in a tree view, and most > actions are executed from a context menu displayed by right-clicking > on a relevant positio

Re: ws2_32/tests: Update hostent struct tests

2012-04-11 Thread Bruno Jesus
On Wed, Apr 11, 2012 at 15:05, Austin English wrote: > On Tue, Apr 10, 2012 at 21:13, Bruno Jesus <00cp...@gmail.com> wrote: > You should use win_skip so that the tests will only be skipped on > windows (we'd want the failure to be exposed on wine). You mean I should use win

Re: ws2_32/tests: Add hostent struct tests for gethostbyname

2012-04-08 Thread Bruno Jesus
On Sun, Apr 8, 2012 at 13:38, Erich E. Hoover wrote: > On Sat, Apr 7, 2012 at 4:54 PM, Marvin wrote: >> ... >> === WXPPROSP3 (32 bit sock) === >> sock.c:509: Test failed: oob_server (1ac): unexpectedly at the OOB mark: 0 >> sock.c:519: Test failed: oob_server (1ac): unexpectedly at the OOB mark:

Re: ws2_32/tests: Add hostent struct tests for gethostbyname

2012-04-08 Thread Bruno Jesus
On Sat, Apr 7, 2012 at 19:54, Marvin wrote: > Hi, > ... > http://testbot.winehq.org/JobDetails.pl?Key=17727 > ... > Your paranoid android. > > > === WXPPROSP3 (32 bit sock) === > sock.c:509: Test failed: oob_server (1ac): unexpectedly at the OOB mark: 0 > sock.c:519: Test failed: oob_server (1ac):

Re: [website] Add Portuguese translation for release 1.5.1

2012-04-02 Thread Bruno Jesus
2012/4/2 Lucas Fialho Zawacki : >> +  Suporte a fontes redimensionáveis em recursos. A more correct translation for: - Support for scalable font resources. Would be: - Suporte para recursos de fontes escaláveis​​. Instead of: - Suporte a fontes redimensionáveis em recursos. Maybe "redimensionáv

Save backtrace feature

2012-01-27 Thread Bruno Jesus
I'm not sure what this console error means but it's always related to exceptions and crashes: err:seh:setup_exception_record stack overflow 848 bytes in thread 0009 eip 7bc79df6 esp 00230fe0 stack 0x23-0x231000-0x33 When an error like this happens during a crash the new error window with

Re: user32: Avoid crashing if we can't alloc text buffer

2011-12-03 Thread Bruno Jesus
On Sat, Dec 3, 2011 at 05:55, Nikolay Sivov wrote: > On 12/3/2011 04:35, Bruno Jesus wrote: > >> If LocalLock fails the buffer is not allocated and get_text_length, which >> is used in several different places, will make wine crash. > > LocalLock doesn't allocate any

Re: added moethod stub for HttpPrepareUrl in dlls/httpapi/httpapi_main.c

2011-11-20 Thread Bruno Jesus
You have to use your full name (as advised before). See http://wiki.winehq.org/SubmittingPatches for more information. Also, gmail is breaking your patch, attach the patch file instead of pasting it to the email body. Best wishes, Bruno On Sat, Nov 19, 2011 at 09:24, ArasH wrote: > --- >  dlls/

Re: winscard/tests: Add the tests file (try 3)

2011-11-07 Thread Bruno Jesus
On Mon, Oct 31, 2011 at 23:27, Bruno Jesus <00cp...@gmail.com> wrote: > try 3 - avoid magic constants by using winscard.h defines > try 2 - split the patches and fix win2000 error > > This is the starting point for the winscard implementation. I'll add > dozens of tes

Re: [PATCH 1/2] include: Add a few defines to winscard.h (try 2)

2011-10-28 Thread Bruno Jesus
2011/10/28 André Hentschel : > Am 28.10.2011 19:42, schrieb Bruno Jesus: > ... > btw: if there is no dependencies than you don't need numbered patchsets Agreed. Sorry again. Best wishes, Bruno

Re: [PATCH 1/2] include: Add a few defines to winscard.h (try 2)

2011-10-28 Thread Bruno Jesus
On Fri, Oct 28, 2011 at 15:01, Alexandre Julliard wrote: > Bruno Jesus <00cp...@gmail.com> writes: > >> +/* Max ATR size defined by ISO-7816 */ >> +#define MAX_ATR_SIZE 33 > > I don't see that one in my PSDK, where does it come from? My bad, apologies. I copied

Re: winscard/tests: Add the tests file

2011-10-26 Thread Bruno Jesus
On Wed, Oct 26, 2011 at 11:38, Marvin wrote: > === W2KPROSP4 (32 bit winscard) === > winscard.c:53: Test failed: SCardIsValidContext expected > SCARD_E_INVALID_HANDLE, received 0006 > winscard.c:64: Test failed: SCardReleaseContext expected > SCARD_E_INVALID_HANDLE, received 0006 > It l

Re: Anyone wants to ban spammer on forum

2011-10-20 Thread Bruno Jesus
On Thu, Oct 20, 2011 at 11:48, Jeremy Newman wrote: > I will take suggestions on other questions that regular users can answer > easily, but would stump (for a bit anyway) a bot, or bot author. Why not the good and old random math questions inside an image? For example 2 + 4 = ...

Re: vbscript: Added lexer support for '_'

2011-10-17 Thread Bruno Jesus
Hi, Jacek. On Mon, Oct 17, 2011 at 10:30, Jacek Caban wrote: > Hi Bruno, > > On 10/14/11 20:07, Bruno Jesus wrote: > ... > I've tested it and that doesn't seem to be true. You're right, in a vbs file the limit does not exist, it looks like to be a Visual Basic

Re: vbscript: Added lexer support for '_'

2011-10-14 Thread Bruno Jesus
On Fri, Oct 14, 2011 at 13:44, Jacek Caban wrote: > --- >  dlls/vbscript/lex.c          |   10 ++ >  dlls/vbscript/tests/lang.vbs |    7 +++ >  dlls/vbscript/tests/run.c    |    2 ++ >  3 files changed, 19 insertions(+), 0 deletions(-) > Hi, Jacek, I'm far away from my linux box and I

Re: For review please: wineps.drv: Implement PS_USERSTYLE on printers

2011-10-13 Thread Bruno Jesus
Hi, Daniel. On Thu, Oct 13, 2011 at 06:14, Daniel wrote: > Hello guys.  I would like to get a little review on this patch, a follow > up to the patches that fix this problem on the screen.  Specifically, > I'm most concerned about making sure my dynamically allocated memory is > freed under all c

Re: jscript: Mark some fall-throughs in switch statements

2011-10-08 Thread Bruno Jesus
On Sat, Oct 8, 2011 at 14:58, Alexandre Julliard wrote: > Andrew Talbot writes: > >> @@ -4037,6 +4037,7 @@ static HRESULT RegExpConstr_leftContext(script_ctx_t >> *ctx, vdisp_t *jsthis, WORD >> >>          V_VT(retv) = VT_BSTR; >>          V_BSTR(retv) = ret; >> +        /* fall through */ >>  

Re: [1/4] winscard: implementation

2011-10-06 Thread Bruno Jesus
2011/10/3 André Hentschel : > Am 03.10.2011 09:31, schrieb Vincent Hardy: >> First submitted on wine-devel and modified following comments from Marcus >> Meissner (MAX_ATR_SIZE / bytecount). >> > > OK, some notes: > "winscard: implementation" is a very bad name for a patch, especially for 4. > Spl

Re: unable to compile wine from latest git

2011-10-03 Thread Bruno Jesus
On Mon, Oct 3, 2011 at 09:03, Vijay Kiran Kamuju wrote: > Hi, > > I just downloaded the git and tried compile it. > > I just issued `make` command after doing `./configure` > ... > Since the build of wine has changed a bit, i am unable to understand > how to fix this issue. Try make distclean &&

Re: winscard

2011-09-30 Thread Bruno Jesus
On Fri, Sep 30, 2011 at 06:42, Vincent Hardy wrote: > Hi all, > > Here are four patches that are a partial but functional implementation of > winscard. Congratulations =) > I installed "Belgian Electronic Identity Card MiddleWare" > (http://eid-mw.googlecode.com/files/BeidMW35-6995.msi) > > I te

CreateDC and DRIVER_GetDriverName

2011-09-28 Thread Bruno Jesus
Hi, I'm seeking advice as I really don't understand anything about wine display drawing (gdi, x11, ...). Every game created with an old win3.11 tool called Klik & Play do not work in wine because a driver called DIB is passed as parameter to CreateDC. Till today I've only seen a driver called DISP

Re: dpnet: return a TCP/IP provider in IDirectPlay8PeerImpl_EnumServiceProviders (try 3, resend)

2011-09-23 Thread Bruno Jesus
On Fri, Sep 23, 2011 at 07:50, Louis Lenders wrote: > Note: the 2 failing tests on test-bot that this patch will produce, are not > real failures as winnt and win2000 will not run the test because of missing > dpnet > > try 3: rewrote patch in a more straightforward  way > > this makes previousl

Ole16 to Ole32 mapping

2011-09-19 Thread Bruno Jesus
Hi, I would like some advice about Ole function redirection. The winsock16 dll maps some operations to ws2_32 dll, I thought I could do the same with Ole16disp to Oleaut32. For example the function SAFEARRAYALLOCDESCRIPTOR in Ole16disp have a similar counterpart named SafeArrayAllocDescriptor in Ol

Proof of concept - The crashbot

2011-09-16 Thread Bruno Jesus
Hi, I would like your opinion about a project I may start based on BuildBot (if the Dan/license allows). It's named crashbot because it's intended to automate testing of applications that crash in wine. The main goal is reduce the amount of time wasted on retesting bugzilla applications that autho

user32: Avoid drawing the caret out of the window

2011-09-09 Thread Bruno Jesus
Bruno -- universe* god::bigbang (void); //and then it all began... From 7ebdbf2166b4be1821ae069f377ac7dab039c904 Mon Sep 17 00:00:00 2001 From: Bruno Jesus <00cp...@gmail.com> Date: Thu, 8 Sep 2011 22:11:52 -0300 Subject: user32: Avoid drawing the caret out of the window Tests prove that

RFC - The ProductName registry entry

2011-09-04 Thread Bruno Jesus
Louis Lenders sent the following url patch to fix bug #28065, it was rejected because it fixes the product name so even if you set other version inside winecfg the registry entry will still say "Windows XP". http://www.winehq.org/pipermail/wine-patches/2011-August/105414.html I have made a small c

Re: ws2_32: Avoid an unhandled read exception on WSAIoctl (resend)

2011-09-01 Thread Bruno Jesus
On Thu, Sep 1, 2011 at 18:40, Bruno Jesus <00cp...@gmail.com> wrote: > > I don't get the same results here, can anyone help me to understand > why it failed? > 10014 = WSAEFAULT and I could not find this return value anywhere > near, maybe due to threading? > > Th

Re: ws2_32: Avoid an unhandled read exception on WSAIoctl (resend)

2011-09-01 Thread Bruno Jesus
On Thu, Sep 1, 2011 at 16:27, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot

RFC - ws2_32/socket.c: SIO_KEEPALIVE_VALS vs TCP_KEEPIDLE/TCP_KEEPINTVL

2011-08-30 Thread Bruno Jesus
This discussion is related to the test failing in bug 21271: http://bugs.winehq.org/show_bug.cgi?id=21271 The SIO_KEEPALIVE_VALS message on windows takes parameters as miliseconds, on some other systems there are the equivalent TCP_KEEPIDLE/TCP_KEEPINTVL which takes the parameters as seconds. To s

Re: Best way to get Program Files/Common Files?

2011-08-09 Thread Bruno Jesus
On Tue, Aug 9, 2011 at 18:17, Lucas Zawacki wrote: > I need to get the user configured path to Program Files/Common Files > to save the dinput action mapping settings. > > What are the my options for doing this? Maybe you can use environment variables: APPDATA CommonProgramFiles They are found o

Re: Winhelp crash in assertion(0) if .hlp file is not found

2011-07-31 Thread Bruno Jesus
I see, thank you. You protected the local calls instead of protecting the called function, I guess it's better this way. Best wishes, Bruno On Sun, Jul 31, 2011 at 03:55, Eric Pouech wrote: > I've just sent a patch that should fix it. > A+ > > -- > Eric Pouech > "The problem with designing somet

Re: Winhelp crash in assertion(0) if .hlp file is not found

2011-07-22 Thread Bruno Jesus
On Fri, Jul 22, 2011 at 06:26, Eric Pouech wrote: > your proposal isn't fixing the problem, it just hides it I was waiting for someone to reply saying that because I see it happening dozens of times in the list, but I guess it's better to start sending a patch them never sending any. At first I

Wininet set_cookie must handle not only = but also =

2011-07-21 Thread Bruno Jesus
Hello, while running uTorrent 3 I see the following fixme several times: fixme:wininet:set_cookie Unknown additional option L"expires = Sat,23-Jul-2011 02:20:13 GMT" After searching the source code I realized the expires parameter is already implemented but wine finds the entry names only if ther

Winhelp crash in assertion(0) if .hlp file is not found

2011-07-21 Thread Bruno Jesus
he assert(0) please send me. Looks like the assert is there since wine 1.0 according to http://source.winehq.org/source/programs/winhlp32/winhelp.c?v=wine-1.0 Best wishes, Bruno -- universe* god::bigbang (void); //and then it all began... From 824d59111b704e3db4cb7ff89bc6bf9781ea53be Mon Sep 17

Re: shlwapi: implement StrChrNW

2009-09-24 Thread Bruno Jesus
On Thu, Sep 24, 2009 at 00:32, Dmitry Timoshkov wrote: > "Aric Stewart" wrote: > >> +LPWSTR WINAPI StrChrNW(LPCWSTR lpszStr, WCHAR ch, UINT cchMax) >> +{ >> +  TRACE("(%s(%i),%i)\n", debugstr_wn(lpszStr,cchMax), cchMax, ch); >> + >> +  if (lpszStr) >> +  { >> +    ch = toupperW(ch); >> +    while

Re: urlmon: Add test for IsValidURL [try 2]

2009-09-04 Thread Bruno Jesus
On Tue, Sep 1, 2009 at 14:20, Vladimir Pankratov wrote: > Hello all. > > What do you think about this? What's wrong in this patch? Any comments? > > Vladimir Pankratov wrote: Hi, I think it needs some more tests as stated in RFC 1738, all valid: telnet://user:passw...@host:98 http://host:777/path