Re: Flickering bug for World of Warcraft

2006-11-04 Thread Bertrand Coconnier
Roderick Colenbrander wrote : Could you check if the attached patch works? It does more or less what I explained in the last email. If it works I'll clean it up as right now it is a bit hacky. I hope to find some apps to test it on. Regards, Roderick Your patch fixes everything : WoW does no

Re: Flickering bug for World of Warcraft

2006-11-04 Thread Bertrand Coconnier
Roderick Colenbrander wrote : Roderick Colenbrander wrote : Or perhaps a testcase isn't needed at all. I think the use of CreateCompatibleDC in wglGetPbufferDCARB is incorrect. According to MSDN this function creates a memory device context. Perhaps something like this works: HDC hdc = Create

Re: Flickering bug for World of Warcraft

2006-11-04 Thread Bertrand Coconnier
Roderick Colenbrander wrote : Or perhaps a testcase isn't needed at all. I think the use of CreateCompatibleDC in wglGetPbufferDCARB is incorrect. According to MSDN this function creates a memory device context. Perhaps something like this works: HDC hdc = CreateDC(...); int format_orig = GetP

Re: Flickering bug for World of Warcraft

2006-11-04 Thread Bertrand Coconnier
Roderick Colenbrander wrote : Hi, After investigating a bit in the Wine code, it seems that the flickering bug of WoW in OpenGL mode is due to wglGetPbufferDCARB that returns a DC which type is OBJ_MEMDC while it should return a DC which type is OBJ_DC. And since in the current git tree, the

Re: Flickering bug for World of Warcraft

2006-11-04 Thread Bertrand Coconnier
Jesse Allen wrote : On 11/3/06, Bertrand Coconnier <[EMAIL PROTECTED]> wrote: Hi, After investigating a bit in the Wine code, it seems that the flickering bug of WoW in OpenGL mode is due to wglGetPbufferDCARB that returns a DC which type is OBJ_MEMDC while it should return a DC which t

Flickering bug for World of Warcraft

2006-11-03 Thread Bertrand Coconnier
Hi, After investigating a bit in the Wine code, it seems that the flickering bug of WoW in OpenGL mode is due to wglGetPbufferDCARB that returns a DC which type is OBJ_MEMDC while it should return a DC which type is OBJ_DC. And since in the current git tree, the DC type of a Pbuffer is OBJ_ME

Re: Patch for opengl32.dll.so

2006-11-02 Thread Bertrand Coconnier
Roderick Colenbrander wrote : Hi, I think that the patch which I just sent titled 'X11DRV: opengl init fix' should fix the issues. The patch makes sure that opengl is initialized when x11drv wgl functions are called. Regards, Roderick Your patch works OK for me. It fixes the crash when lauc

Re: Patch for opengl32.dll.so

2006-11-02 Thread Bertrand Coconnier
Roderick Colenbrander wrote : Compared to 0.9.23 I changed the way wglGetIntegerv is loaded before it was directly loaded using GetProcAddress from winex11.drv now it is still loaded from winex11.drv but then using wglGetProcAddress from gdi32. At wine startup (I'm not sure at which stage but