Code quality (was Re: comctl32: Fix invalid syntax)

2008-02-07 Thread Bang Jun-young
On 2/7/08, Michael Stefaniuc <[EMAIL PROTECTED]> wrote: > Bang Jun-young wrote: > > On 2/7/08, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > >> "Bang Jun-young" <[EMAIL PROTECTED]> writes: > >> > >>> 18 hours passed, and it look

Re: comctl32: Fix invalid syntax.

2008-02-07 Thread Bang Jun-young
On 2/7/08, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > "Bang Jun-young" <[EMAIL PROTECTED]> writes: > > > 18 hours passed, and it looks like Alexandre decided to ignore this...why? > > > > This fix is required for Wine to be built with VC2005/200

Re: comctl32: Fix invalid syntax.

2008-02-06 Thread Bang Jun-young
18 hours passed, and it looks like Alexandre decided to ignore this...why? This fix is required for Wine to be built with VC2005/2008 (although Alexandre doesn't seem to care about it). On 2/6/08, Bang Jun-young <[EMAIL PROTECTED]> wrote: > Any reason why this hasn't been committed? >

Re: cabinet: Include wine/port.h for strcasecmp().

2008-02-01 Thread Bang Jun-young
On 2/1/08, Francois Gouget <[EMAIL PROTECTED]> wrote: > The rules are as follows: > > * For case insensitive comparisons of 'windows strings', a Windows >function must be used (stricmp() or similar). In this case, KERNEL32 lstrcmpiA() would be more appropriate. In general, using stricmp() in

Re: Review comparing Wine and Vista for running games

2008-01-31 Thread Bang Jun-young
To prove Wine is better than Vista: 1. Find a number of games that don't work with Vista but work fine with Wine. 2. Write a blog. 3. Everybody knows that Vista sucks. Now a Vista user gets upset with the results, so he will: 1. Find a ton of games and apps that don't work with Wine but work fin

Re: Valgrind results for Oct 9: still lots of hangs

2007-11-11 Thread Bang Jun-young
Just out of curiousity, is there a special reason for you to use "Oct" as the abbreviation for November? On 11/10/07, Dan Kegel <[EMAIL PROTECTED]> wrote: > Results for today's git (plus my dde patch) are online at > http://kegel.com/wine/valgrind/20071109/ > > ole32/tests/marshall.c has always b

void dispatch_rpc() returns a value

2006-05-27 Thread Bang Jun-Young
Hi, I wonder how this has been possible so far: static void __RPC_STUB dispatch_rpc(RPC_MESSAGE *msg) { struct dispatch_params *params; APARTMENT *apt; IPID ipid; HRESULT hr; RpcBindingInqObject(msg->Handle, &ipid); TRACE("ipid = %s, iMethod = %d\n", debugstr_guid(&ipid), msg