Re: wine bug 27600

2011-07-01 Thread Austin Lund
On 1 July 2011 06:10, wrote: > > > gcc -c -I. -I. -I../../include -I../../include  -D__WINESRC__ > -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing > -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes > -Wtype-limits -Wwrite-strings -Wpointer-arith  -g -O2  -o adsiid.o > adsiid.c >

Re: [PATCH 1/4] dlls/ntdll: Add handle count to NtQuerySystemInformation

2011-06-20 Thread Austin Lund
null pointers or null handles). Later patches, which I have already sent, try to fill in more of these fields. From 8e9631f10f5da50792fd4bc825c6f4b0f8ecac5c Mon Sep 17 00:00:00 2001 From: Austin Lund Date: Sun, 12 Jun 2011 19:41:18 +1000 Subject: [PATCH] dlls/ntdll: Add handle count to NtQuerySystemInf

Re: [PATCH 2/4] server: Add function to count only valid handles in a process

2011-06-20 Thread Austin Lund
On 20 June 2011 15:12, Vitaliy Margolen wrote: > On 06/19/2011 08:15 PM, Austin Lund wrote: >> >> [PATCH 2/4] server: Add function to count only valid handles in a process > > This makes no sense. All handles are valid inside wineserver. When looking at bug 9484 and try

Re: [PATCH 1/4] dlls/ntdll: Add handle count to NtQuerySystemInformation

2011-06-20 Thread Austin Lund
On 20 June 2011 15:08, Vitaliy Margolen wrote: > On 06/19/2011 08:15 PM, Austin Lund wrote: >> >> +                    ret = wine_server_call( req ); >> +                    shi->Count += reply->handles; >> +                    len = sizeof(SYSTEM_HANDLE_EN

Re: riched20: Remove the unneeded DEFINE_STDCALL_WRAPPER.

2011-04-07 Thread Austin Lund
On 8 April 2011 08:09, Charles Davis wrote: > > I don't know if this will help but... > > Both Clang and (recent) GCC have direct support for > __attribute__((thiscall)) (and I would know about Clang, I added it to > the LLVM side). We could potentially take advantage of this and not have > to dec

Re: [PATCH] user32/tests: Fixed SetParent test on 64bit Vista

2011-04-03 Thread Austin Lund
On 1 April 2011 14:03, Dmitry Timoshkov wrote: > Austin Lund wrote: > >> --- a/dlls/user32/tests/msg.c >> +++ b/dlls/user32/tests/msg.c >> @@ -12681,6 +12681,7 @@ static const struct message WmSetParentSeq_2[] = { >>      { WM_WINDOWPOSCHANGING, sent|wparam,

Re: 64-bit Notepad2 crashes

2010-12-28 Thread Austin Lund
On 29 December 2010 04:47, Susan Cragin wrote: > Stack dump: > 0x0022b470:   > 0x0022b480:   > 0x0022b490:   > 0x0022b4a0:   > 0x0

Re: TestBot IPv6 enabled

2010-11-16 Thread Austin Lund
On 14 November 2010 07:40, Greg Geldorp wrote: > Hi, > > All TestBot VMs (with the exception of the Win9x ones) now have IPv6 > connectivity. I was surprised that there was even a IPv6 stack available for > NT4, it was produced by Microsoft Research. > The VMs are (and always have been) behind a

Re: shell32/tests: Fix IShellFolderView test failure under Windows 7.

2010-11-08 Thread Austin Lund
On 8 November 2010 17:32, Reece Dunn wrote: > On 8 November 2010 04:45, Austin Lund wrote: >> On 8 November 2010 11:49, James McKenzie wrote: >>> Thus a second test case needs to be >>> developed that is only for Windows7 and the remaining test skipped for >>>

Re: shell32/tests: Fix IShellFolderView test failure under Windows 7.

2010-11-07 Thread Austin Lund
On 8 November 2010 11:49, James McKenzie wrote: > Thus a second test case needs to be > developed that is only for Windows7 and the remaining test skipped for > Windows7.   Something like what we do for Unicode tests for Windows9x/ME. Isn't the rule that the tests should only check windows versio

Re: [PATCH 2/4] comctl32/tests: Change toolbar size test data to load dynamically.

2010-11-05 Thread Austin Lund
On 5 November 2010 22:35, Alexandre Julliard wrote: > Austin Lund writes: > >> +static void init_tbsize_results(void) { >> +    tbsize_results = (tbsize_result_t *)HeapAlloc(GetProcessHeap(), >> HEAP_ZERO_MEMORY, 24*sizeof(tbsize_result_t)); >> +    tbsize_results[

RFC: Fixing comctl32 toolbar tests for different system font heights

2010-11-04 Thread Austin Lund
ixing these (in a three part patch set). Is this approach even close to being the right way to do this? From 6940f0c65a39b9a9e87c96857dc82c27bae726fa Mon Sep 17 00:00:00 2001 From: Austin Lund Date: Thu, 4 Nov 2010 15:07:18 +1000 Subject: [PATCH 1/4] comctl32/tests: Change toolbar size test data to

RFC: Fixing imagelist control tests for 16bpp

2010-10-12 Thread Austin Lund
From: Austin Lund Date: Wed, 13 Oct 2010 15:34:01 +1000 Subject: [PATCH] comctl32/tests: ImageList control is broken differently for different device color depths. Reply-To: wine-devel --- dlls/comctl32/tests/imagelist.c | 44 +- 1 files changed, 38

Re: [PATCH] riched20/tests: Cleaned up ITextServices::TxGetNaturalSize test and fixed test failures. (try 2)

2010-10-11 Thread Austin Lund
On 11 October 2010 13:46, Austin Lund wrote: > > +    todo_wine ok(result == S_OK || broken(result == E_FAIL), /* WINXP Arabic > Language */ > +        "TxGetNaturalSize gave unexpected return value (result = %x)\n", > result); I know it's slightly unorthodox to r

Test failures on Windows XP Japanese due to fonts selection differences

2010-10-06 Thread Austin Lund
There are a number of test failures due to hardcoded sizes in test which fail for particular platforms, e.g. http://test.winehq.org/data/6e89a61446088dbe029913896dfae467bb8d37a1/xp_wtb-wxpprojasp3/comctl32:toolbar.html It seems the reason for this is that it is impossible to select the system fon

Re: [PATCH 2/2] comctl32/tests: Default listview width appears to be 1 inch.

2010-09-22 Thread Austin Lund
On 22 September 2010 16:53, Marvin wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.w

Re: [PATCH] comctl32/tests: DateTimePicker and MonthCalendar controls only support Gregorian calendar.

2010-08-18 Thread Austin Lund
On 19 August 2010 16:34, Nikolay Sivov wrote: > On Thu, Aug 19, 2010 at 9:50 AM, Austin Lund wrote: >> http://www.microsoft.com/middleeast/msdn/ArabicCalendar.aspx > > Hi, Austin. > > This information is outdated probably. There's a message to set a > calend

Re: [PATCH] advapi32: Add magic codes to HCRYPTKEY and HCRYPTHASH.

2010-08-18 Thread Austin Lund
On 18 August 2010 20:44, GOUJON Alexandre wrote: > On 08/18/2010 12:22 PM, Hans Leidekker wrote: >> >> They are often built from four character ascii strings to help find out >> where the structures come from. I don't know why this one was chosen >> but I guess you could use something like 0xA39E7

Re: [PATCH] advapi32: Add magic codes to HCRYPTKEY and HCRYPTHASH.

2010-08-18 Thread Austin Lund
On 18 August 2010 18:34, Hans Leidekker wrote: > On Wed, 2010-08-18 at 10:14 +1000, Austin Lund wrote: > >>  #define MAGIC_CRYPTPROV 0xA39E741F >> +#define MAGIC_CRYPTKEY 0xA39E741F >> +#define MAGIC_CRYPTHASH 0xA39E741F > > The app might pass a crypto handle of

Re: [PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance.

2010-08-11 Thread Austin Lund
On 12 August 2010 15:48, Vitaliy Margolen wrote: > You can't test that. All you can test is that you got the IDirectMusicPort > back or not. What exactly inside is irrelevant. > > And if IDirectMusicPerformance8_PChannelInfo succeeds and you getting not > null pDirectMusicPort back but it points t

Re: [PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance. (try 2)

2010-08-11 Thread Austin Lund
On 12 August 2010 14:32, Vitaliy Margolen wrote: > > What are those magic numbers? Please use constants. If they are missing, add > them to appropriate header file first. They are the numbers passed to the InitAudio method from bug 22598. I've seen quite a few places where "magic" numbers are use

Re: [PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance.

2010-08-11 Thread Austin Lund
On 12 August 2010 14:23, Vitaliy Margolen wrote: > On 08/11/2010 09:14 PM, Austin Lund wrote: >> >> On 11 August 2010 20:12, David Adam  wrote: >> I wasn't sure of the best way to do this.  But basically I want to >> check that the Vtbl had been set.  I cannot cas

Re: [PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance. (try 2)

2010-08-11 Thread Austin Lund
On 12 August 2010 13:16, James McKenzie wrote: > Austin Lund wrote: > > Why the try2?  It is always nice to put why you are doing this in the git > commit notes. I was responding to review. I'm sorry if I've done something confusing.

Re: [PATCH 1/2] dmime/tests: Added tests for IDirectMusicPerformance.

2010-08-11 Thread Austin Lund
On 11 August 2010 20:12, David Adam wrote: > Hello, thanks for the comments. I've resent. > +    todo_wine ok(*(ULONG *)pDirectMusicPort != 0, "IDirectMusicPort not > set\n"); > > Why is this cast useful? I wasn't sure of the best way to do this. But basically I want to check that the Vtbl ha

Re: winex11.drv: Fix uninitialised values. (valgrind) (try 2)

2010-08-10 Thread Austin Lund
On 10 August 2010 18:05, Michael Stefaniuc wrote: > Hello Austin, > > Austin Lund wrote: >> >> > both functions are heavily used and you don't want to waste time > HEAP_ZERO_MEMORY just to pl

Re: [PATCH] riched20: Process WM_GETMINMAXINFO which arrives before WM_NCCREATE.

2010-07-06 Thread Austin Lund
>>> I'm reading this comment carefully for a suggestion as to how to "fix" >>> things, but it seems totally obfuscated. >> >> Editor should be unconditionally initialized if it's NULL, and WM_NCDESTROY >> should be made an explicit case in the 'switch' statement. > > Of course with appropriate test

Re: [PATCH] riched20: Process WM_GETMINMAXINFO which arrives before WM_NCCREATE.

2010-07-06 Thread Austin Lund
On 6 July 2010 17:39, Dmitry Timoshkov wrote: > Austin Lund wrote: > >> --- a/dlls/riched20/editor.c >> +++ b/dlls/riched20/editor.c >> @@ -4406,7 +4406,7 @@ static LRESULT RichEditWndProc_common(HWND hWnd, UINT >> msg, WPARAM wParam, >>        texthost

Re: shell32/tests: Remove atime tests in ITEMIDLIST_format test.

2009-11-23 Thread Austin Lund
2009/11/23 Paul Vriens : > > I'm curious how important a test on a FAT filesystem is. I'm not overly concerned, but the way it is at the moment, my test system will always fail with this test. > What happens when these tests are run on Wine with a FAT filesystem btw? I don't have such a system t

Re: shell32/tests: Remove atime tests in ITEMIDLIST_format test.

2009-11-20 Thread Austin Lund
2009/11/21 Austin Lund : > 2009/11/21 Paul Vriens : > >> if (abs(date2 - date1) == 1) >>   skip("We dont't check access times on a FAT filesystem\n"); > > >> "The date is always within 1 day (plus or minus)." > > It isn't quite th

Re: shell32/tests: Remove atime tests in ITEMIDLIST_format test.

2009-11-20 Thread Austin Lund
2009/11/21 Paul Vriens : > if (abs(date2 - date1) == 1) >   skip("We dont't check access times on a FAT filesystem\n"); > "The date is always within 1 day (plus or minus)." It isn't quite that easy as the date field is a bitpacked struct holding the year, month and day. So you have to account

Re: shell32/tests: Remove atime tests in ITEMIDLIST_format test.

2009-11-19 Thread Austin Lund
2009/11/19 Paul Vriens : > On 11/19/2009 01:23 PM, Austin Lund wrote: >> >> -                ok (pFileStructA->uFileDate == pFileStructW->uDate2&& >> -                    pFileStructA->uFileTime == pFileStructW->uTime2, >> -                    &q

Re: advapi32/tests: Skip tests for ACL file info if ACL info not stored (try 2)

2009-11-18 Thread Austin Lund
2009/11/18 Alexandre Julliard : > > Testing file system flags is not a good idea, that won't work on > Wine. It's better to test the results of the actual call. > The reason this test fails for me is because I have a FAT32 volume and there is no ACL info stored, so the tests: ok(dacl != NULL,

Re: [Wine] Tmax Window(a propietary OS) using Wine?

2009-07-07 Thread Austin Lund
2009/7/8 Austin English : > On Tue, Jul 7, 2009 at 9:43 PM, Ben Klein wrote: >> 2009/7/8 Austin English : >>> -- Forwarded message -- >>> From: nengad24 >>> -- snip -- >>> Yesterday a korean company has released a new OS which is compatible >>> with MS Windows Apps. >>> -- snip --

Re: user32/tests: Added test for infinite WM_PAINT loop (resend)

2009-07-07 Thread Austin Lund
2009/7/5 Austin Lund : > The last time I sent this, the patch was broken.  I've tested it on > WinXPsp2 and wine-1.1.25.  This patch relates to bug 10522. > Can I please have some feedback on this patch? The test is for what I found as the source of the problem, not for the loop its

msvcrt:file test failures under wine and winetest

2009-02-16 Thread Austin Lund
I've been playing around with the odd failure that occurs on some platforms for the msvcrt:file tests. http://test.winehq.org/data/6a1537c4b5037be5253c33021fda3a02430533f7/#group_Wine I am able to recreate it on my computer running ubuntu 8.10. (tag: apl-u810-dell630) I was trying to nail down

Re: RFC: More tests for riched20 ITextServices

2008-07-13 Thread Austin Lund
2008/7/4 Dan Hipschman <[EMAIL PROTECTED]>: > On Thu, Jul 03, 2008 at 05:32:32PM +1000, Austin Lund wrote: >> I have run these with the native dll in wine and it works fine, but >> would like someone to test them on windows platforms. > > I couldn't get these to com

Re: riched20: Added windowless text services tests (resent)

2008-07-11 Thread Austin Lund
I haven't heard anything about this patch. I know it is large, but the function headers and wrappers are necessary. Is there anything in particular wrong with it? Is there anything that could make it more obviously correct? 2008/7/7 Austin Lund <[EMAIL PROTECTED]>: > Changes f

Re: Crashes in winetest under wine

2008-07-09 Thread Austin Lund
2008/7/10 Alexandre Julliard <[EMAIL PROTECTED]>: > "Austin Lund" <[EMAIL PROTECTED]> writes: > >> 2008/7/7 Austin Lund <[EMAIL PROTECTED]>: >>> 2008/7/3 Austin Lund <[EMAIL PROTECTED]>: >>>> I get a crash all the time in winetest

Re: Crashes in winetest under wine

2008-07-07 Thread Austin Lund
2008/7/8 Austin Lund <[EMAIL PROTECTED]>: > 2008/7/7 Austin Lund <[EMAIL PROTECTED]>: >> 2008/7/3 Austin Lund <[EMAIL PROTECTED]>: >>> I get a crash all the time in winetest since 1.0. Seems there is not >>> a problem with any of the tests themselves (

Re: Crashes in winetest under wine

2008-07-07 Thread Austin Lund
2008/7/7 Austin Lund <[EMAIL PROTECTED]>: > 2008/7/3 Austin Lund <[EMAIL PROTECTED]>: >> I get a crash all the time in winetest since 1.0. Seems there is not >> a problem with any of the tests themselves (i.e. running make test). >> >> The la

rpcrt4: Compile error

2008-07-07 Thread Austin Lund
Does anyone else get the following compile error at commit 2734fb44e0f4065179044b9eb93f87a7630f292d: make[2]: Entering directory `/home/lund/src/wine/wine-git/dlls/rpcrt4' make[2]: *** No rule to make target `../../include/wine/rpcss_shared.h', needed by `ndr_contexthandle.o'. Stop. make[2]: Leavi

Re: Crashes in winetest under wine

2008-07-06 Thread Austin Lund
2008/7/3 Austin Lund <[EMAIL PROTECTED]>: > I get a crash all the time in winetest since 1.0. Seems there is not > a problem with any of the tests themselves (i.e. running make test). > > The last few lines of output from winetest is: > > fixme:xrandr:X11DRV_XRandR_SetC

Re: RFC: More tests for riched20 ITextServices

2008-07-04 Thread Austin Lund
2008/7/4 Maarten Lankhorst <[EMAIL PROTECTED]>: > Hi Austin, > > The second 'return E_NOINTERFACE' will never be reached. > > Cheers, > Maarten. > GCC throws a warning if you remove it. Perhaps this is better: static HRESULT WINAPI ITextHostImpl_QueryInterface(ITextHost *iface,

Crashes in winetest under wine

2008-07-02 Thread Austin Lund
I get a crash all the time in winetest since 1.0. Seems there is not a problem with any of the tests themselves (i.e. running make test). The last few lines of output from winetest is: fixme:xrandr:X11DRV_XRandR_SetCurrentMode Cannot change screen BPP from 32 to 8 fixme:xrandr:X11DRV_XRandR_SetC

Re: RFC: Adding tests for windowless richedit services

2008-06-29 Thread Austin Lund
This also passes the tests under the native riched20.dll version 5.30.23.1221. 2008/6/29 Austin Lund <[EMAIL PROTECTED]>: > I've sent versions of this to wine-patches in the past. > > In this version, I've stripped out most of the tests except those for > the initial c

RFC: Adding tests for windowless richedit services

2008-06-28 Thread Austin Lund
7 00:00:00 2001 From: Austin Lund <[EMAIL PROTECTED]> Date: Fri, 27 Jun 2008 22:40:51 +1000 Subject: [PATCH] richedit: Added conformance tests for txtsrv.c --- dlls/riched20/tests/Makefile.in |5 +- dlls/riched20/tests/txtsrv.c| 538 +++ 2 fi

Re: secur32: Allow loading external schannel.dll.

2008-06-24 Thread Austin Lund
I cannot get this to work with googletalk.exe. I get the following messages: trace:secur32:SECUR32_initializeProviders trace:secur32:_tryLoadProvider loaded L"schannel.dll", InitSecurityInterfaceA is 0x7ec2fae0, InitSecurityInterfaceW is 0x7ec2fb00 trace:secur32:_tryLoadProvider L"schannel.dll" h