BiDi, Unicode 6.3 and Wine.

2013-10-04 Thread Aric Stewart
Hello, So Unicode 6.3 was just recently released. One of the things it features is an updated BIDI (Bidirectional) algorithm. This is revision 29 to the algorithm. (http://www.unicode.org/reports/tr9/tr9-29.html#Modifications) Looking at the code I moved from gdi32 to usp10, it looks like the

Re: imm32: ImmGetCandidateWindow should not return unset data

2013-10-01 Thread Aric Stewart
Ok, fixed and resent -aric On 10/1/13 2:13 PM, Alexandre Julliard wrote: > Aric Stewart writes: > >> @@ -663,6 +663,8 @@ HIMC WINAPI ImmCreateContext(void) >> gl->dwSize = sizeof(GUIDELINE); >> ImmUnlockIMCC(new_context->IMC.hGuideLine); &g

Re: (try 5) [2/4] imm32: do not let ImmDestroyContext destroy any default contexts

2013-09-25 Thread Aric Stewart
On 9/25/13 7:09 AM, Nikolay Sivov wrote: > On 9/25/2013 16:03, Aric Stewart wrote: >> defaultContext = ImmCreateContext(); >> +if (defaultContext) >> +((InputContextData*)defaultContext)->threadDefault = TRUE; > I think a nicer way is to

Re: (try 5)[1/4] imm32: Move thread data from TLSEntry to an internal list

2013-09-25 Thread Aric Stewart
On 9/25/13 7:11 AM, Nikolay Sivov wrote: > On 9/25/2013 16:03, Aric Stewart wrote: >> +if (!thread_data->defaultContext) >> +{ >> +HIMC defaultContext; >> +LeaveCriticalSection(&threaddata_cs); >> +defaultContext = Imm

Re: [try3] gdi32: abc values remain the same despite any changes in layout direction or Viewport

2013-09-11 Thread Aric Stewart
Alexandre, Do you want me to rewrite this patch with your new width_to_LP helper function or are you going to do that rewrite yourself? (assuming it is acceptable in other ways) thanks! -aric

Re: questions to your commit "wineps.drv: Allow for vertical text printing!"

2013-08-26 Thread Aric Stewart
Hello Wolfgang, Thanks for the review. On 8/24/13 2:16 PM, Wolfgang Walter wrote: > Hello Aric, > > I read commit 745e7c93c9042f62460f181daaa1f05645560b41 (wineps.drv: Allow for > vertical text printing.) and I have some questions: > > > 1) You added the parameter vertical to PSDRV_WriteSetFon

Re: talking about web-based translation again -- transifex

2013-06-21 Thread Aric Stewart
Hi, Thank you for the information here. I went back to look over transifex to try to understand why i had it on my list of services that would not work. The issue with the community is that WINE's policies require that all contributors are identified by their full name. No aliases or handles.

Re: Web based translation tool

2013-06-17 Thread Aric Stewart
what I can find out. -aric On 6/17/13 4:30 PM, André Hentschel wrote: > On 04.04.2012 16:05, Michal Čihař wrote: >> Hi >> >> Dne Thu, 15 Mar 2012 10:12:14 -0500 >> Aric Stewart napsal(a): >> >>> I do not know if Weblate will work or not. >>> >

Wine's Tahoma...

2013-06-12 Thread Aric Stewart
Hi, So working on Arabic font issues I have started really looking at wine's Tahoma font. Windows Tahoma covers glyphs in quite a few ranges, Latin, Cyrillic, Hebrew, Arabic, Thai to name a few. Wine's Tahoma has bit a fraction of this coverage. Looking to improve our Arabic support, I foun

Re: macdrv: rework the way we handle cursor position and composition text

2013-05-29 Thread Aric Stewart
ok, resent. -aric On 5/29/13 12:38 PM, Ken Thomases wrote: > On May 29, 2013, at 10:37 AM, Aric Stewart wrote: > >> --- >> dlls/winemac.drv/cocoa_window.m | 9 + >> dlls/winemac.drv/event.c| 3 -- >> dlls/w

vertical.ttf

2013-05-16 Thread Aric Stewart
Hello Kusanagi-san, I am trying to do more testing with tategaki and i am finding that your original tests are incorrect because of the vertical.ttf font you have build. Windows appears to be very very picky about when it will to a vert or vrt2 replacement. I have run the test with MS UI Gothic

gdi32: GetGlyphIndices doesn't substitute glyph incorrect

2013-05-10 Thread Aric Stewart
Hi there, I know I am a year late to the party here but I am digging deep into tategaki for a few Japanese programs that are having serious rendering issues and I believe that this patch is incorrect. I am attaching the test patch that proves it to me. Kusanagi-san, we should try to make sure

Re: user32: Implement IMR_QUERYCHARPOSITION handling in the edit control

2013-05-07 Thread Aric Stewart
On 5/7/13 8:15 AM, Dmitry Timoshkov wrote: > Aric Stewart wrote: > >> dlls/user32/edit.c | 21 + >> include/imm.h | 9 + >> 2 files changed, 30 insertions(+) > > Using usual 4 spaces indentation would slightly improve the reada

Re: [PATCH] dlls/gdi32/fretype.c: Avoid division by zero.

2013-05-05 Thread Aric Stewart
I am very interested in this whole situation because I have run into a similar font issue. Many Mac fonts have an AveCharWidth of a negative value. These fonts do not work well in Wine because of this. Doing some investigation I have found that the given fonts will not install on windows 7. Wi

Re: user32: ImmProcessKey is only called on WM_KEYDOWN and if the message is being removed

2013-03-28 Thread Aric Stewart
On 3/28/13 8:10 AM, Dmitry Timoshkov wrote: > Aric Stewart wrote: > >>>> Worked out with testing on Japanese windows XP. Resolves issues with >>>> keystrokes and accelerators in menus when the IME is active. >>> >>> You should really star

Re: user32: ImmProcessKey is only called on WM_KEYDOWN and if the message is being removed

2013-03-28 Thread Aric Stewart
On 3/27/13 9:25 PM, Dmitry Timoshkov wrote: > Aric Stewart wrote: > >> Worked out with testing on Japanese windows XP. Resolves issues with >> keystrokes and accelerators in menus when the IME is active. > > You should really start adding the tests and base your p

Re: usp10: Support GPOS extension lookup subtables

2013-03-18 Thread Aric Stewart
Hi Phil, Thank you for being patient I am back from vacation and reviewing your patch. The logic looks great and just fine. Do you happen to have a font that uses lookup type 9 that I can run my usp test suite on to make sure it functions as expected? thanks! -aric On 3/8/13 10:47 AM, Phil Kr

Re: Aric Stewart : usp10: Update diacritical script handling for non OpenType Itemization.

2013-03-14 Thread Aric Stewart
source.winehq.org/git/wine.git/?a=commit;h=ef4b7c5948e43d4ceeed98ba4ddbf6c59d36 >> >> Author: Aric Stewart >> Date: Tue Feb 5 08:57:44 2013 -0600 >> >> usp10: Update diacritical script handling for non OpenType Itemization. > > (snip) > >> +for (

Re: usp10: add ShapeCharGlyphProp_Latin to properly handle invalid and zero width character properties for Latin

2013-01-22 Thread Aric Stewart
Ah, yes we are presently using the wrong glyph for control characters, which causes this test to fail. I will work on fixes. -aric On 1/22/13 1:41 PM, Alexandre Julliard wrote: > Aric Stewart writes: > >> --- >> dlls/usp10/shape.c | 33 +++-

Re: usp10: Implement GPOS MarkToLigature Attachment Positioning Subtable

2013-01-09 Thread Aric Stewart
Ah, yes, you corrected that in another area also. I will rewrite. -aric On 13/01/09 12:02, Huw Davies wrote: > On Wed, Jan 09, 2013 at 11:36:51AM -0600, Aric Stewart wrote: >> +typedef struct { >> +WORD LigatureAnchor[1]; >> +} GPOS_ComponentRecord; >> + >&g

Re: imm32: use SendMessage not PostMessage for the Default IME winproc

2012-11-20 Thread Aric Stewart
On 12/11/06 9:38, Henri Verbeet wrote: > On 6 November 2012 15:41, Aric Stewart wrote: >> >> This allows the calling program to properly get the return codes from the >> messages when they need them. >> Also prevent all of the calls for IME messages in that windproc fr

Re: wineqtdecoder: properly clean up splitter and loader threads on QTSplitter destruction

2012-11-20 Thread Aric Stewart
On 12/11/20 5:29, Alexandre Julliard wrote: > Aric Stewart writes: > >> @@ -495,9 +518,14 @@ static DWORD WINAPI QTSplitter_loading_thread(LPVOID >> data) >> to try to minimize that. >>*/ >> >> -

Re: (resend) programs/winemenubuilder: scale 64x64 classic icons to 48x48 for Icns format

2012-10-17 Thread Aric Stewart
On 10/17/12 3:11 AM, Per Johansson wrote: > On Wed, Oct 17, 2012 at 6:08 AM, Vincent Povirk wrote: >> I agree that scaling to 32x32 would probably work out better. >> Personally, I probably would've chosen 128x128, since that would >> involve no loss of information or distortion (but maybe we don'

Re: (resend) programs/winemenubuilder: scale 64x64 classic icons to 48x48 for Icns format

2012-10-16 Thread Aric Stewart
On 10/16/12 7:40 PM, Ken Thomases wrote: > On Oct 16, 2012, at 2:15 PM, Aric Stewart wrote: > >> @@ -1052,6 +1079,7 @@ static inline int size_to_slot(int size) >> case 16: return 0; >> case 32: return 1; >> case 48: return 2;

Re: programs/winemenubuilder: scale 64x64 classic icons to 48x48 for Mac OS/X

2012-10-16 Thread Aric Stewart
I can but i feel like it would be more esoteric. Something like if numIndices is greater than 1... Would that be more preferable? -aric On 10/16/12 1:39 PM, Alexandre Julliard wrote: > Aric Stewart writes: > >> @@ -403,6 +404,13 @@ static HRESULT convert_to_native_icon(IStr

Re: ImmIsUIMessageA/W

2012-10-03 Thread Aric Stewart
r the help! -aric On 10/2/12 5:34 PM, André Hentschel wrote: > Am 02.10.2012 21:23, schrieb Aric Stewart: >> I have a proposed patch that I have tested with World of Tanks and it does >> not cause http://bugs.winehq.org/show_bug.cgi?id=27554 to reappear for me on >> either mac or

Re: imm32: have IMM class return TRUE for WM_QUERYENDSESSION

2012-10-03 Thread Aric Stewart
Looking over my documentation it is explicit about many messages that cannot be passed to DefWndProc, but it looks like we can us it. I will revise the patch and send that. -aric On 10/3/12 4:31 AM, Alexandre Julliard wrote: > Aric Stewart writes: > >> resolves bug 31832 >

Re: ImmIsUIMessageA/W

2012-10-02 Thread Aric Stewart
, Henri Verbeet wrote: On 25 September 2012 21:12, André Hentschel wrote: I don't remember the app, be free to patch it in again, at best with tests. Wasn't that for World of Tanks? commit e0b590c50292c367e1c8bffb6f7b2775539e82a1 Author: Aric Stewart Date: Tue Oct 2 14:20:35

Re: (try 3) imm32: there is only 1 default Hwnd per thread

2012-09-26 Thread Aric Stewart
8d12fc61d5321350ad63b173bdfb50feef1f4b56 and cc945706a4933cda0d204ba07a13e93fccb66d18 -aric On 9/26/12 10:26 AM, Alexandre Julliard wrote: > Aric Stewart writes: > >> Do you want to delay on this fix until I figure our what should be >> happening with IMMGWL_IMC. Or I can have a second patch addressing

Re: (try 3) imm32: there is only 1 default Hwnd per thread

2012-09-26 Thread Aric Stewart
On 9/26/12 10:18 AM, Alexandre Julliard wrote: > Aric Stewart writes: > >> -if (data->imeWnd == NULL) >> +if (defWnd == NULL) >> { >> /* create the ime window */ >> -data->imeWnd = CreateWindowExW( WS_EX_TOOLWI

Re: (resend) imm32: there is only 1 default Hwnd per thread

2012-09-26 Thread Aric Stewart
On 9/26/12 7:27 AM, Alexandre Julliard wrote: > Aric Stewart writes: > >> This corrects issues with applications that create and manage multiple IMCs >> try 2: >> avoid premature destruction of the window >> --- >> dlls/imm32/imm.c | 22

Re: imm32: there is only 1 default Hwnd per thread

2012-09-25 Thread Aric Stewart
On 9/25/12 1:38 PM, Alexandre Julliard wrote: > Aric Stewart writes: > >> @@ -2323,12 +2323,18 @@ BOOL WINAPI ImmSetOpenStatus(HIMC hIMC, BOOL fOpen) >> >> if (data->imeWnd == NULL) >> { >> -/* create the ime window */ >

Re: ImmIsUIMessageA/W

2012-09-25 Thread Aric Stewart
Hi Andre, On 9/24/12 3:00 PM, André Hentschel wrote: > Am 21.09.2012 18:46, schrieb Aric Stewart: >> Hi Andre, >> >> I have a quick question for you. I am looking into why IME unaware >> applications are no longer showing their composition window and found it was

ImmIsUIMessageA/W

2012-09-21 Thread Aric Stewart
Hi Andre, I have a quick question for you. I am looking into why IME unaware applications are no longer showing their composition window and found it was because of: commit 7673d67c1e1cfdcdf7560beea9162c3699329aa5 Author: André Hentschel Date: Sat Jun 25 16:13:41 2011 +0200 imm32: Test a

Re: GSoC mentor summit 2012

2012-08-03 Thread Aric Stewart
ok, then how about you two just go. That seems easy. -aric On 8/2/12 6:02 AM, Owen Rudge wrote: On 02/08/2012 11:48, Stefan Dösinger wrote: Am Montag, 30. Juli 2012, 08:16:38 schrieb Aric Stewart: I could be interested. I have never been and am a first time mentor. October is still a bit far

Re: GSoC mentor summit 2012

2012-07-30 Thread Aric Stewart
I could be interested. I have never been and am a first time mentor. October is still a bit far off for me to be able to plan. So if someone else can completely commit that is cool. But I will try to get info about my availability that weekend asap. -aric On 7/26/12 10:07 AM, Owen Rudge wrote

Re: wineqtdecoder: Recreate audio extraction session when we run out of frames.

2012-05-22 Thread Aric Stewart
Ah, I will update the comment. -aric On 12/05/22 11:05, Alexandre Julliard wrote: Aric Stewart writes: This is instead of waiting until a movie is fully loaded before being able to start playing. This eliminates the up to several second pause when starting some, mostly avi, movies

Re: quartz: COM cleanup for Parser_OutputPin

2012-05-18 Thread Aric Stewart
Ahh, my understanding of COM cleanup grows... -aric On 5/18/12 10:27 AM, Michael Stefaniuc wrote: Hello Aric, On 05/18/2012 04:27 PM, Aric Stewart wrote: diff --git a/dlls/quartz/avisplit.c b/dlls/quartz/avisplit.c index 5027e90..bac1b24 100644 --- a/dlls/quartz/avisplit.c +++ b/dlls/quartz

Re: quartz: update ICOM_THIS_MULTI to follow the new COM standard

2012-03-30 Thread Aric Stewart
ok thanks, Glad I got this feedback before I started submitting my com cleanup patches that used it. -aric On 3/30/12 11:26 AM, Jacek Caban wrote: On 03/30/12 18:09, Aric Stewart wrote: Meaning that I should not shift TO using that macro instead shift AWAY from using it? I have been doing

Re: quartz: update ICOM_THIS_MULTI to follow the new COM standard

2012-03-30 Thread Aric Stewart
Meaning that I should not shift TO using that macro instead shift AWAY from using it? I have been doing some cleanup and been shifting to using it more. -aric On 3/30/12 11:08 AM, Jacek Caban wrote: On 03/30/12 17:55, Aric Stewart wrote: diff --git a/dlls/quartz/quartz_private.h b/dlls

Re: [PATCH] mciqtz: Actually assign result to the output structure

2012-03-27 Thread Aric Stewart
procedures like that will allow me to really focus in on what is going wrong. thanks! -aric On 12/03/23 13:18, joerg-cyril.hoe...@t-systems.com wrote: Hi, Aric Stewart wrote: If you know about specifically quartz issues I am happy to start looking at them. I find the following very

Re: Need suggestion to choose a GSoC idea

2012-03-27 Thread Aric Stewart
Hi, On 3/26/12 10:29 PM, Qian Hong wrote: - Improve Wine CJK font support The main idea is fix Bug 16325 [11], Aric and others have done a lot of work on it, and I'm glad to participating too. I think the main blocker for Wine CJK font support is Font Association now, is it suitable for a GSoC

Re: GSoC proposal

2012-03-26 Thread Aric Stewart
Hi, Not to argue if it will be useful or not, as I do not know. I think this will be technically very hard. You will have to be able to get the keystrokes for a native linux applications feed them into WINE, have wine do the IME processing and then get the resulting characters and feed them b

Re: GSoC proposal

2012-03-25 Thread Aric Stewart
Hi, As a developer who has done a lot of work in the IME/XIM areas of wine I thought I would chime in. The IME/XIM stuff sounds interesting but I am really not sure how useful it is going to be. I will have to review what the GSoC outline is like but it feels like something that would not

Re: [PATCH] mciqtz: Actually assign result to the output structure

2012-03-23 Thread Aric Stewart
Hi Jörg, Thanks for the e-mail. I will admit that I am completely ignorant about mci and mciqtz. However I am becoming more and more skilled at quartz. Right now I am mostly knowledgeable about the filters and filter chain. I will start looking at our filter graph stuff soon, but there is

Re: [2/4](resend)strmbase: implement BaseControlWindow

2012-03-16 Thread Aric Stewart
On 3/16/12 12:36 AM, Nikolay Sivov wrote: On 3/16/2012 04:00, Aric Stewart wrote: +HRESULT WINAPI BaseControlWindowImpl_GetTypeInfo(IVideoWindow *iface, UINT iTInfo, LCID lcid, ITypeInfo**ppTInfo) +{ + BaseControlWindow* This = (BaseControlWindow*)iface; + It doesn't look like a norma

Re: Web based translation tool

2012-03-15 Thread Aric Stewart
Hi Yaron, Thanks for continuing to push this forward. I have been a bit swamped recently. The thing is that there are several projects who are all JUST on the edge of being able to do what we need but none that are there yet. I got an e-mail from a pootle developer saying that they are doing

Windows 8 anyone?

2012-03-02 Thread Aric Stewart
So for some conversation that is not release related... Anyone installed the windows 8 consumer preview yet? It refuses to install in my virtual box or (old) vmware fusion machines. I think it really wants real hardware. If someone does has a copy running, maybe i can send a uniscribe script

Re: Web based translation tool

2012-02-28 Thread Aric Stewart
Hi, I have had quite a long discussion with the TranslateWiki people. They are great and while what we need would require a bit of PHP development they expressed that they would be happy to do the work. The main sticking block is that our requirement for Real Names and e-mail for all contri

TranslateWiki

2012-02-22 Thread Aric Stewart
Hi, I just had a very good conversation with the mediawiki people about TranslateWiki. (http://translatewiki.net/wiki/Main_Page) There are some snags right now but they are really interested in doing work to accommodate us. We will see where that goes but so far it is looking like the most p

Re: Translators wanted!

2012-02-22 Thread Aric Stewart
On 2/22/12 8:08 AM, Yaron Shahrabani wrote: Hey Aric, can you please explain? In both Pootle and Transifex you can have a language maintainer. In Pootle you can set permissions for each and every user as the maintainer while in Transifex you can only allow or disallow people who want to assist (

Re: Translators wanted!

2012-02-22 Thread Aric Stewart
We would love to do this and it is being explored. The core issue is the ability to directly connect each translation to the translator. None of the platforms we have looked at have this functionality. If i have more time I can try to explore the pootle code as I have at least passing famil

Re: gdi32: pOS2->xAvgCharWidth can be negative however tmAvgCharWidth needs a positive value

2012-02-21 Thread Aric Stewart
On 2/21/12 10:17 AM, Dmitry Timoshkov wrote: Aric Stewart wrote: >>> what Mac does in that case? >> The mac handles the fonts without issue >>>Why do you think that your fix is correct? >>..windows tmAveCharWidth should never be negative, and yet th

Re: gdi32: pOS2->xAvgCharWidth can be negative however tmAvgCharWidth needs a positive value

2012-02-21 Thread Aric Stewart
On 2/21/12 10:03 AM, Dmitry Timoshkov wrote: Aric Stewart wrote: So, what Mac does in that case? Why do you think that your fix is correct? The mac handles the fonts without issue. The issue appears to be that the windows tmAveCharWidth should never be negative, and yet this logic causes

Re: gdi32: pOS2->xAvgCharWidth can be negative however tmAvgCharWidth needs a positive value

2012-02-21 Thread Aric Stewart
On 2/21/12 9:39 AM, Dmitry Timoshkov wrote: Aric Stewart wrote: Windows response appears to not allow the user to install the fonts at all. It reports any of the fonts I have which have negative OS/2 xAveCharWidth as invalid fonts when I try to install them. This blocks out a few of the

Re: gdi32: pOS2->xAvgCharWidth can be negative however tmAvgCharWidth needs a positive value

2012-02-21 Thread Aric Stewart
wrote: Aric Stewart wrote: -TM.tmAveCharWidth = (pFT_MulFix(pOS2->xAvgCharWidth, x_scale) + 32)>> 6; +TM.tmAveCharWidth = (pFT_MulFix(abs(pOS2->xAvgCharWidth), x_scale) + 32)>> 6; Did you test what Windows does in that case?

Re: quartz: AMFilterData_ParseFilterData returns a pointer to a pointer to filter data

2012-02-03 Thread Aric Stewart
wrote: On Friday, February 03, 2012 2:43:57 PM Dmitry Timoshkov wrote: Aric Stewart wrote: -REGFILTER2 *prf2; +static REGFILTER2 *prf2; What's the point of this change? It returns a pointer to the pointer, so the variable needs to remain valid after the function exits. The code does

Re: quartz: If the MediaSeeking is not implemented all the way up the passthru chain fall back to the filtergraph's clock to find position.

2012-01-31 Thread Aric Stewart
ahh ok, i see what the problem is. Thanks -aric On 1/31/12 1:45 PM, Alexandre Julliard wrote: Aric Stewart writes: Resolves bug Bug 25606 --- dlls/quartz/filtergraph.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) It doesn't work: ../../../tools/runtest -q -P

Re: (try 4)winex11.drv: Strip the _L or _R from X11DRV_GetKeyNameText when approperate

2012-01-20 Thread Aric Stewart
That is why I am questioning, The one in the TRACE statement 1) is the same as used later in the code, so retains consistency. 2) generates a compiler warning if i remove it so appears to be useful. -aric On 12/01/20 10:57, Dmitry Timoshkov wrote: Aric Stewart wrote: which cast are you

Re: (try 4)winex11.drv: Strip the _L or _R from X11DRV_GetKeyNameText when approperate

2012-01-20 Thread Aric Stewart
which cast are you finding to be unneccessary? -aric On 12/01/20 10:26, Dmitry Timoshkov wrote: Aric Stewart wrote: The problem is that there is no XK keycode for just Shift, Control or Menu so X11DRV_MapVirtualKeyEx maps them to Shift_L, etc. As a result the string XKeysymToString returns

Re: winex11.drv: Strip the _XXX from X11DRV_GetKeyNameText when approperate

2012-01-18 Thread Aric Stewart
On 1/17/12 10:18 PM, Vitaliy Margolen wrote: On 01/17/2012 09:32 AM, Aric Stewart wrote: The problem is that there is no XK keycode for just Shift, Control or Menu so X11DRV_MapVirtualKeyEx maps them to Shift_L, etc. As a result the string XKeysymToString returns is a string with a _L or _R at

Re: (resend)[5/6]usp10: Devanagari danda and double danda are use for all Indic scripts

2011-11-15 Thread Aric Stewart
You are correct about the ones in is_indic, I can replace those with the Script_XX values. the other two meaning the WCHARs we are looking for? They are unicode points. In that regard they are explanatory as they are. Or i can add extra defines for them -aric On 11/15/11 10:03 AM, Henri

Please Test again, user32: use uniscribe in the single line edit control

2011-10-12 Thread Aric Stewart
Apologies I sent this to the wrong list just now. Ok, Thanks to Dan I have found and corrected the issues that this created with the tests. I believe all the tests should continue to pass with this version of the patch. Has anyone tried it live in any applications? -aric --- dlls/user32/

Re: 79794: Help Test Please: use uniscribe in the single line edit control

2011-10-12 Thread Aric Stewart
Thank Dan, I had not gotten to a full test run. I will look into those. -aric On 10/11/11 8:01 PM, Dan Kegel wrote: Hi Aric, failed again on second run, http://buildbot.kegel.com:8010/builders/runtests-default/builds/209 Failing tests are comctl32_test.exe.so listview.c comctl32_test.exe.so u

DEVELOPMENTAL: use uniscribe in the edit control

2011-10-10 Thread Aric Stewart
This patch is experimental but people had some interest in testing it and I would love some more testing. What is currently known not to be working: * Tabs * Font Fallback * Complex composed glyphs are not breaking or highlighting properly. Testing is appreceated. Send me crashes or incorrec

Re: Getting Wine's PO files on Launchpad

2011-09-07 Thread Aric Stewart
So Newman and I just got a Pootle server setup for CrossOver translations and I was going to talk here about putting winehq's po files up on it also. I am still just getting use to admin for pootle, and I am not sure if i can get it hooked up directly to git or not. But if people are interes

Re: (resend)usp10/test: test ScriptXtoX on an RTL set with differring cChars and cGlyphs

2011-08-25 Thread Aric Stewart
On 8/25/11 9:50 AM, Nicolas Le Cam wrote: 2011/8/25 Aric Stewart: Ah i see what you are seeing. I will see if that helps. However it is still strange that the tests are all working for me and when i submit tests but not when it is submitted as a patch. -aric On 8/25/11 7:47 AM, Hans

Re: (resend)usp10/test: test ScriptXtoX on an RTL set with differring cChars and cGlyphs

2011-08-25 Thread Aric Stewart
Ah i see what you are seeing. I will see if that helps. However it is still strange that the tests are all working for me and when i submit tests but not when it is submitted as a patch. -aric On 8/25/11 7:47 AM, Hans Leidekker wrote: On Thu, 2011-08-25 at 07:38 -0500, Aric Stewart wrote

Re: (resend)usp10/test: test ScriptXtoX on an RTL set with differring cChars and cGlyphs

2011-08-25 Thread Aric Stewart
Yes, it depends on if it is a RTL or LTR string. That is correct. -aric On 8/25/11 7:30 AM, Hans Leidekker wrote: On Thu, 2011-08-25 at 07:15 -0500, Aric Stewart wrote: "should return piX=0 not 0"? seems like 0 == 0 to me. They are both int values... That test doesn&#x

Re: (resend)usp10/test: test ScriptXtoX on an RTL set with differring cChars and cGlyphs

2011-08-25 Thread Aric Stewart
I don't get this. I do the test locally, they all pass. I submit it directly to testbot and they all pass. I submit the patch and i get these nonsense failures. "should return piX=0 not 0"? seems like 0 == 0 to me. They are both int values... Is this just testbot being strange? -aric On 8

Re: Hebrew: update

2011-08-23 Thread Aric Stewart
On 8/23/11 8:38 AM, Francois Gouget wrote: [...] Wineconsole does not support Hebrew or Arabic script out of the box, there are several fonts that should be installed in order to enable that, AFAIK Arabic displayed in the right order but the letters are not joined, I can check that and get back t

Re: [11/15]usp10/tests: update test_ScriptShapeOpenType framework to shape in a given font

2011-05-24 Thread Aric Stewart
Ah, I wondered if I was pushing the Macro thing too far. -aric On 11/05/24 5:26, Alexandre Julliard wrote: Aric Stewart writes: @@ -297,9 +297,13 @@ static void test_ScriptItemize( void ) test_items_ok(test10,4,&Control,&State,1,t101,FALSE,0); } -static inline void _test_

Re: ws2_32: sendmsg on OS/X and BSD returns EMSGSIZE error for size 0

2011-03-04 Thread Aric Stewart
Looks like WS2_ConnectEx is at fault. It is being called with a sendBuf of NULL which results in n_iovecs and first_iovec being set to 0 resulting in a len of 0. I see no evidence of checking for this case along that codepath. -aric On 3/4/11 10:47 AM, Alexandre Julliard wrote: Aric

Re: ws2_32: sendmsg on OS/X and BSD returns EMSGSIZE error for size 0

2011-03-04 Thread Aric Stewart
I was seeing this coming through WS2_async_send. I will investigate and give you a better code path that is resulting in this. -aric On 3/4/11 10:47 AM, Alexandre Julliard wrote: Aric Stewart writes: @@ -1781,6 +1781,9 @@ static int WS2_send( int fd, struct ws2_async *wsa

Re: wineqtdecoder: initial commit of the video decoder using Mac OS/X QuickTime Framework

2010-12-02 Thread Aric Stewart
using the Carbon framework not Cocoa we don't really have access to QTKit. We may as well use Quicktime since it is still available. -aric On 12/2/10 8:10 PM, Charles Davis wrote: On 12/2/10 7:06 PM, Aric Stewart wrote: That was true of the first set of APIs i used. But I believ

Re: wineqtdecoder: initial commit of the video decoder using Mac OS/X QuickTime Framework

2010-12-02 Thread Aric Stewart
not available on 64-bit code. I would suggest using the Objective-C QTKit, but apparently Objective-C code is a no-no in Wine. On Nov 29, 2010, at 10:31 AM, Aric Stewart wrote: --- configure |8 +- configure.ac |5 + dlls/wineqtdecoder

Re: wineqtdecoder: initial commit of the video decoder using Mac OS/X QuickTime Framework

2010-11-30 Thread Aric Stewart
6:52 AM, Alexandre Julliard wrote: Aric Stewart writes: --- configure |8 +- configure.ac |5 + dlls/wineqtdecoder/Makefile.in| 11 + dlls/wineqtdecoder/main.c | 135 + dlls/wineqtdecoder/qtvdecoder.c

Re: (resend)[2/10]winegstreamer: add gstreamer splitter filter

2010-10-25 Thread Aric Stewart
Ah yes. Working to clean up someone else's code and missed that. -aric On 10/10/25 9:00, Vitaliy Margolen wrote: On 10/25/2010 07:45 AM, Aric Stewart wrote: --- + ERR(" perform byte seek --\n"); + if (1 || This->initial) { + ERR(&quo

Re: [6/6]strmbase: Implement BaseFilter in strmbase

2010-10-07 Thread Aric Stewart
Ok I think I know what is going on. I have some later patches that i think need to be merged into this one and then separated at a different place. -aric On 10/7/10 9:07 AM, Alexandre Julliard wrote: Aric Stewart writes: --- dlls/qcap/vfwcapture.c | 134

Re: ImmReleaseContext() function implementation

2010-10-05 Thread Aric Stewart
I do not believe this is correct. You would be destroying the context every time it is released and that is clearly not what we want to be doing ass ImmGetContext and ImmReleaseContext as a pair are called over and over again in a typical application. -aric On 10/4/10 1:25 PM, Mikhail Gorbu

Re: [1/2] gdiplus: Fixed GdipFillClosedCurve2 and GdipFillClosedCurve2I in the case that count == 1 (should do nothing).

2010-07-08 Thread Aric Stewart
Wade is a new intern here at CodeWeavers that we are training how to do winehacking. We totally expect that these patches get set to deferred because of the wine 1.2 release. But I wanted to go through the process of how to send patches while the patches where fresh in his mind. So when the

Re: [2/2] kernel32/tests: add test for CT_TYPE1 of GetStringTypeW

2010-06-21 Thread Aric Stewart
. -aric James McKenzie wrote: Aric Stewart wrote: Aric: Where did you find the new values for C1_TYPE? James McKenzie

Re: comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons

2010-06-18 Thread Aric Stewart
Alexandre Julliard wrote: Aric Stewart writes: commit 87f9053ec43e0272e27280e1e7ab9674fc79b109 Author: Aric Stewart Date: Fri Jun 18 13:21:56 2010 +0900 comctl32: restore focus if it was lost during the processing of PROPSHEET_SetWizButtons It would probably be better to not

Re: usp10/tests: having numbers in the ScriptStringXtoCP tests causes unpredictable behavior

2010-06-17 Thread Aric Stewart
lats wrote: When does this unpredictability occur? The tests have always run ok for me. The issue appears to be, and I am still investigating, sometimes usp10 will reorder the numbers differently. It appears to have to do with if windows and hdcs are repeatedly created and destroyed and cann

Re: winemp3.acm: Fixes the Mac-specific code (try 2)

2010-05-19 Thread Aric Stewart
Hi, I was excited to try out this patch but now it is giving me a crash. (OS/X 10.5.8) Backtrace: =>0 0x12a9 (0x0033d81c) 1 0x086e (0x0033d838) 2 0x936f5a47 _ZN14CodecConverter14AppendNewInputEmPcmRmP28AudioStreamPacketDescription+0xb6() in audiotoolbox (0x0033d888) 3 0x936f56

Re: gdi32: use usp10 to optionally generate glyphs for bidi strings

2010-05-14 Thread Aric Stewart
ok, so the LPK calls uniscribe. Do you feel we should implement the LPK style of interface to gdi32? It seems needlessly cumbersome to me. The LPK.dll interfaces seem to be undocumented but based on names should not be to difficult to figure out. -aric Dmitry Timoshkov wrote: Aric Stewart

Re: gdi32: use usp10 to optionally generate glyphs for bidi strings

2010-05-14 Thread Aric Stewart
Windows gdi32 does not use usp10? I do not see a direct dependency but I have not traced inside to see if it is doing LoadProcAddress or the like. -aric Dmitry Timoshkov wrote: Aric Stewart wrote: allows us to be able to make use of the mirroring code and eventually the shaping code when it

Re: [Fwd: Re: winemp3.acm: Fixes the Mac-specific code]

2010-05-13 Thread Aric Stewart
There is a bug in the code i just posted, It should clearly be adsi->pwfxSrc->nSamplesPerSec not Dst. Still works great, probibly because my tests had the same nSamplesPerSec for both Src and Dst. -aric Aric Stewart wrote: Hi, I will admit that my understanding of both ACM driv

Re: [Fwd: Re: winemp3.acm: Fixes the Mac-specific code]

2010-05-13 Thread Aric Stewart
Hi, I will admit that my understanding of both ACM drivers as well as the os x audio libraries are not perfect and mostly come from work on this code itself. So i will fully admit it is most likely full of areas needing improvement. Kristofer Henriksson wrote: Aric, I may have been opera

Re: winemp3.acm: Fixes the Mac-specific code

2010-05-13 Thread Aric Stewart
Hi, It is good to see someone working on this code. But your patch makes it so that all the mp3 sound clips in the game that I was coding for stop working. trace:mpeg3:mp3_leopard_horse ndst 147456 0x2eab348 <- 19901 0x2ea657c trace:mpeg3:mp3_leopard_horse First 16 bytes to input: "\x00\

Re: imm32: rework storage of thread default contexts

2010-04-20 Thread Aric Stewart
I think for threadproc function it should be WINAPI or CALLBACK. DWORD WINAPI ThreadProc( __in LPVOID lpParameter ); yes. I should set the test to be static. -aric André Hentschel wrote: Hi Aric, You should have a second look at the Function heads in the tests (imm32.c). I doubt WINAPI sh

Re: wineaudiofile.acm: Initial commit

2010-03-12 Thread Aric Stewart
Thanks! Henri Verbeet wrote: +ERR("Feed Error %c%c%c%c\n", (char) (ret>> 24), + (char) (ret>> 16), + (char) (ret>> 8), + (char) ret); debugstr_an((const char *)&ret, 4); may be ea

winemp3.acm on the mac

2010-03-11 Thread Aric Stewart
Hello all, So I have been hacking on winemp3.acm on the mac to make use of CoreAudio for mp3 decoding and I have just gotten it working. So now I am faced with a questions. Do I setup winemp3.acm with #ifdefs to pick between the libmpg123 or CoreAudio paths, leaving us with 1 winemp3.acm

Re: shlwapi: URL_ParseUrl should not fail if there is not :\\

2010-02-15 Thread Aric Stewart
Thanks for the nudge. I am finding that there are more extensive issues with our UrlGetPart that this was just masking. I am working on a new patch and tests. -aric Nikolay Sivov wrote: On 2/15/2010 22:07, Aric Stewart wrote: allows acceptance of urls such as about:blank --- dlls/shlwapi

Re: [PATCH 4/4] msctf: Implement stubbed out TF_CreateLangBarMgr [Try 2]

2010-02-15 Thread Aric Stewart
Hi, I am really happy that you are helping with the msctf stuff I started. Very cool! 2 quick things. 1) typedef struct tagACLMulti, don't call it tagACLMulti. I am sure this is from copying from threadmgr.c where it is a copy/paste thing from when I started that framework. It has al

Re: CJK default fonts for packagers to set

2010-02-05 Thread Aric Stewart
Hin-Tak Leung wrote: --- On Fri, 5/2/10, Aric Stewart wrote: Scott Ritchie wrote: My notes from Wineconf remind me that I need to create some manual links in the registry to whatever default CJK fonts are on the system. Can someone tell me what these are supposed to look like? Thanks

Re: CJK default fonts for packagers to set

2010-02-05 Thread Aric Stewart
Scott Ritchie wrote: My notes from Wineconf remind me that I need to create some manual links in the registry to whatever default CJK fonts are on the system. Can someone tell me what these are supposed to look like? Thanks, Scott Ritchie Sure! (sorry for the delay) The important keys ar

comctl32 listview notification assert

2010-01-22 Thread Aric Stewart
Hello, I am seeing something in listview.c that really make me feel like there is something really wrong going on. So maybe it is something I am having a lack of understanding in. I have an application that is sending 'A' style notification codes to the listview header. Specifically I am

Re: oleaut32: do not crash in logging if string is NULL

2010-01-20 Thread Aric Stewart
Aric Stewart wrote: Meaning the place where I am finding this is different bug? In deserialize_param in the VT_BSTR case if the byte_length of the BSTR that we are deserializing is -1 then BSTR_UserUnmarshal places NULL into *arg. I will admit I know very little about this code but having

Re: oleaut32: do not crash in logging if string is NULL

2010-01-20 Thread Aric Stewart
to log seemed very wrong. Should I change the if (debugout) TRACE_(olerelay)("%s",relaystr(*(BSTR *)arg)); to a simple debugstr_w or is this revealing a deeper problem somewhere? thanks, -aric Alexandre Julliard wrote: Aric Stewart writes: @@ -68,10 +68,16 @@ typedef struct _mar

  1   2   3   >