On Monday 23 August 2010 13:16:07 Michael Stefaniuc wrote:
> IMHO gcc is *wrong* in emitting a warning there. sizeof(PCMWAVEFORMAT)
> is a compile time constant and gcc can see that sizeof(PCMWAVEFORMAT)
> falls well inside the number range expressible by a LONG. Logically
> there is no difference
On Sunday 18 July 2010 00:26:50 Henri Verbeet wrote:
> On 17 July 2010 09:07, Andrey Turkin wrote:
> > +#ifdef NONAMELESSUNION
> > +# define U(x) (x).u
> > +#else
> > +# define U(x) (x)
> > +#endif
>
> I think this is already done in wine/test.h?
Right.
On Sunday 18 July 2010 00:26:36 Henri Verbeet wrote:
> On 17 July 2010 09:06, Andrey Turkin wrote:
> > +if (nt->OptionalHeader.FileAlignment <= 0)
>
> I can't comment much on the changes themselves, but FileAlignment is
> unsigned, so can't be < 0.
On Saturday 17 July 2010 18:19:50 Dan Kegel wrote:
> I was worried that mapping the file will fail if you're
> low on address space and are running this function
> on a large PE file.
> It ought to be possible to write a test to see how
> the function behaves when you've used up oodles
> of address
On Sunday 04 July 2010 22:31:49 Dan Kegel wrote:
> >> the Makefile has:
> >> EXTRADLLFLAGS = -Wb,-F,KERNEL32.dll -Wl,--image-base,0x7b80
> >
> >Is there a good reason for this? Otherwise, this opens a security
> >vulnerability in Wine that does not exist in Windows
>
> This is the way Win
25.05.2010 19:58, André Hentschel wrote:
Am 25.05.2010 17:05, schrieb Andrey Turkin:
25.05.2010 18:51, André Hentschel wrote:
--- a/dlls/atl/atlwin.h
+++ b/dlls/atl/atlwin.h
@@ -43,7 +43,7 @@ typedef struct _ATL_WNDCLASSINFOW_TAG
WCHAR m_szAutoName[14];
} _ATL_WNDCLASSINFOW
25.05.2010 18:51, André Hentschel wrote:
--- a/dlls/atl/atlwin.h
+++ b/dlls/atl/atlwin.h
@@ -43,7 +43,7 @@ typedef struct _ATL_WNDCLASSINFOW_TAG
WCHAR m_szAutoName[14];
} _ATL_WNDCLASSINFOW;
-ATOM WINAPI AtlModuleRegisterWndClassInfoA(_ATL_MODULEW *pm,
_ATL_WNDCLASSINFOA *wci, WNDPROC *
10.05.2010 15:02, Jacek Caban wrote:
Hi Andrey,
On 5/9/10 9:30 PM, Andrey Turkin wrote:
---
dlls/shdocvw/tests/webbrowser.c | 27 ---
dlls/shdocvw/webbrowser.c | 24 ++--
2 files changed, 46 insertions(+), 5 deletions(-)
+if (This
08.05.2010 9:10, Henry Blum wrote:
---
dlls/kernel32/process.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c
index 9a1f2f5..6dcad8f 100644
--- a/dlls/kernel32/process.c
+++ b/dlls/kernel32/process.c
@@ -2657,7 +2657,7
Virtually any Wine program uses it (even winemine) so why not?
Jerome Leclanche wrote:
I'm unsure programs themselves should use Wine's debug channels, either way.
J. Leclanche / Adys
On Mon, Oct 26, 2009 at 10:35 AM, Andrey Turkin wrote:
Don't do this please, initia
Don't do this please, initial part was just submitted, the channel will
be used once other parts are in place.
Francois Gouget wrote:
---
programs/extrac32/extrac32.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/programs/extrac32/extrac32.c b/programs/extrac32/extr
This patch makes some tests (like urlmon's url test) to crash if Gecko isn't
installed (dereference of NULL window->nswindow in update_window_doc called
by HTMLWindow_Create(nswindow==NULL) called by HTMLDocument_Create)
Alexandre Julliard wrote:
Ilya Shpigor writes:
+/* Parse options */
+for(i = 0; i < argc; i++)
+{
+if (argv[i][0] == '/')
+{
+for(j = 0; j < sizeof(sFlags) / sizeof(sFlags[0]); j++)
+if (!strcmpiW(argv[i], sFlags[j].wFlag))
+
Austin English wrote:
2009/10/21 Ilya Shpigor :
You need to add the program to configure.ac, as well as add Makefile.in
No you don't need to (most patches do add some subset of autogenerated
files for some reason but it is not necessary).
extrac32 is not a console program; on Windows it doesn't create a
console and doesn't write anything to stdout or stderr regardless of
command line. I agree those FIXMEs you pointed out are not FIXMEs really
- some of them are errors and some should be warnings. I'll fix them.
Kirill K. Smirno
Hi Nikolay,
There are few issues:
> +.BI wineserver\ [options]
> +.SH ОПИСАНИЕ
> +.B wineserver
> +это сервис предоставляющая процессам Wine аналогичные набор функций, который
>
no comma after сервис; it should be "предоставляющий"; probably should
be "набор функций, аналогичный тому, который
Austin English wrote:
> On Mon, Jan 12, 2009 at 11:33 AM, Andrey Turkin
> wrote:
>
>> .Net 3.0 installer needs these
>> ---
>> dlls/httpapi/httpapi.spec |2 +
>> dlls/httpapi/httpapi_main.c | 42 +
>&
James Hawkins wrote:
> On Sat, Jan 3, 2009 at 3:07 PM, Andrey Turkin wrote:
>
>> I _love_ this idea, and icons look very nice, but here can be some legal
>> troubles. The icons are under Creative Commons - Share Alike 2.5 license.
>> I'm not a lawyer and not sur
Roderick Colenbrander wrote:
>> Juan Lang wrote:
>>
so I just cutted icons from other toolbars' bitmaps;
>>> Which other toolbars, specifically? You can't grab copyrighted work,
>>>
>> you know.
>>
>>> --Juan
>>>
>>>
>>>
>> Yeah, I know. All
Juan Lang wrote:
>> so I just cutted icons from other toolbars' bitmaps;
>>
>
> Which other toolbars, specifically? You can't grab copyrighted work, you
> know.
> --Juan
>
>
Yeah, I know. All bitmaps were from Wine itself (comctl32 etc).
I believe this is wrong - IoGetCurrentProcess return pointer to kernel
EPROCESS structure instance, and GetCurrentProcess return constant
(HANDLE)-1 . The structure is declared opaque so drivers must not
dereference it, but some drivers surely won't obey.
2008/12/20 Chris Wulff
> Redirect for Io
chwatcher?
>
> James McKenzie
>
> Original Message
> Subject:mpr: fix NULL pointer dereference in
> WNetGetResourceInformationW
> Date: Tue, 07 Oct 2008 20:18:00 +0400
> From: Andrey Turkin <[EMAIL PROTECTED]>
> Reply-To: wi
Dmitry Timoshkov wrote:
> "Andrey Turkin" <[EMAIL PROTECTED]> wrote:
>
>> It seems that automatic loading of string from resources in MessageBox*
>> is Wine extension. Useful and logical one but still other platform does
>> not support it.
>
> That&#x
James Hawkins wrote:
> On Fri, Oct 10, 2008 at 2:51 PM, Andrey Turkin <[EMAIL PROTECTED]> wrote:
>
>> James Hawkins wrote:
>>
>> On Fri, Oct 10, 2008 at 12:59 AM, Andrey Turkin <[EMAIL PROTECTED]>
>> wrote:
>>
>>
>> I can'
James Hawkins wrote:
> On Fri, Oct 10, 2008 at 3:17 PM, Andrey Turkin <[EMAIL PROTECTED]> wrote:
>
>> Imagine broken application which for some reason, e.g. non-allocated memory,
>> supply NULL to this function, and then catch, eat and spew an exception
>> somewhe
James Hawkins wrote:
> On Fri, Oct 10, 2008 at 12:59 AM, Andrey Turkin <[EMAIL PROTECTED]> wrote:
>
>> I can't see any value in commented out test or sort-of-meaningless code
>> comment.
>>
>>
>
> The tests serve as documentation of the A
James Hawkins wrote:
> On Thu, Oct 9, 2008 at 4:14 PM, Andrey Turkin <[EMAIL PROTECTED]> wrote:
>
>> [now with tests, fixed and reformatted as per James' suggestions]
>>
>> Implement CredReadDomainCredentialsA and CredReadDomainCredentialsW
>> stubs
2008/7/19 Michael Karcher <[EMAIL PROTECTED]>:
> Am Freitag, den 18.07.2008, 20:37 +0400 schrieb Andrey Turkin:
> > Also, please attach patches with disposition inline, not attachment
> > (git can do that) - this make review somehow easier.
> If this is an official wi
Hi Ambroz,
-
FILE_SYNCHRONOUS_IO_NONALERT );
+read_timeout ? 0 :
FILE_SYNCHRONOUS_IO_NONALERT );
This looks incorrect. You probably want to compare to -1, not zero. Zero
means reads must not block at all, an
Diff doesn't look in line with the description (I can't see any waits in the
diff :)
2008/7/15 Jon Griffiths <[EMAIL PROTECTED]>:
> Hi,
>
> In the socket tests, avoid a race by waiting for the read threads to finish
> before closing the sockets (found during TransmitFile testing).
>
> Cheers
> Jo
You should mention somewhere (FIXME or TODO or something) what the code
currently rely on socket being not used by WSAIoctl. IIRC Windows won't
let you call WSAIoctl(0, ...)
Correct way would be to retrieve both AcceptEx and GetAcceptExSockaddrs
routine addresses in AcceptEx wrapper and store lp
Hi Vladimir,
There are a few punctuation issues still left.
>Wine это программа
>реализует вызовы Windows API
>используя
>В директории содержащей
>решения проблем, прочтите
extra comma here?
>операционные системы перечисленные выше
>У FreeBSD 6.3 есть патч разрешающий
comma missed, an
to get HtmlHelpW to work correctly.
> > It was first worked on by Andrey Turkin and updated later by me.
>
>
> Please add a proper log entry describing the change.
>
> > -static inline LPWSTR strdupAtoW(LPCSTR str)
> > +static inline LPWSTR strdupnAtoW(LPCSTR str, LONG
Actually the correct way IMHO is to implement
AcceptEx/GetAcceptExSockaddrs/TransmitFile in ws2_32.dll, and use
WSAIoctl(SIO_GET_EXTENSION_FUNCTION_POINTER) to get function addresses
in mswsock.dll. I believe this is that Windows' mswsock.dll do.
Christopher Harvey wrote:
Dmitry Timoshkov wro
Alexandre Julliard wrote:
> Andrey Turkin <[EMAIL PROTECTED]> writes:
>
>
>> +if (image || addr < nt->OptionalHeader.SizeOfHeaders)
>> +{
>> +if (section)
>> +{
>> +PIMAGE_SECTION_HEADER se
Dmitry Timoshkov wrote:
> "Andrey Turkin" <[EMAIL PROTECTED]> wrote:
>
>> +dllcache_wildcard = HeapAlloc(GetProcessHeap(), 0, strlenW(
>> dllcache )*sizeof(WCHAR) * sizeof(wildcardW));
>
> Aren't there too much of multiplications?
>
Whoop
Andrey Esin wrote:
> In patch:
> Full translation of wordpad on russian.
>
> Author: Andrey Esin <[EMAIL PROTECTED]>
>
>
>
>
You've messed up indentation, and there is a typo in STRING_ALL_FILES.
Dmitry Timoshkov wrote:
> Hello,
>
> this patch should fix the problem reported in the bug 3620.
>
> winoldap.mod in Windows is a 16-bit .exe which uses its command line to load
> a 32-bit module and pass the parameters to it. Since winebuild doesn't allow
> to create a 16-bit builtin exe, I decide
Alexandre Julliard wrote:
> Robert Shearman <[EMAIL PROTECTED]> writes:
>
>
>> Andrey Turkin wrote:
>>
>>> Robert Shearman wrote:
>&g
Robert Shearman wrote:
> Andrey Turkin wrote:
>>
>> /**
>>
>> *BindIoCompletionCallback (KERNEL32.@)
>> */
>> +extern NTSTATUS WINAPI
>> RtlSetIoCompletionCallback
Marius Slyzius wrote:
>
> Hello all.
>
>
>
> I am trying to run ScimoreDB database which uses fibers, non-blocked
> IO for sockets and files, and completion port. It did started ok
> under 0.9.5 and seems it is working!!!:), so I would like to verify
> few things about async IO with completion p
>
> Let me take a wild guess. /etc/hosts resolves your hostname to a loopback
> address, like 127.0.1.1 or somesuch.
>
> If that's the case, please change /etc/hosts to make your hostname resolve
> to
> your network card's IP address.
>
> If that's not the case, please attach a +winsock log to bug
Hi Michael,
There are http://bugs.winehq.org/show_bug.cgi?id=9787 for this bug
Michael Lothian wrote:
> Hi
>
> I've noticed a problem in wine recently. When I try and join a network
> game in Warcraft I can see the game but I'm unable to join it.
>
> These errors are printing out:
>
> [EMAIL PROT
Alexander Nicolaysen Sørnes wrote:
This will be useful for the file saving code.
Regards,
Alexander N. Sørnes
+WCHAR wszCaption[MAX_PATH];
+
+if(wszNewFileName)
+{
+lstrcpyW(wszCaption, wszNewFileName);
+lstrcatW(wszCaption, wszSeparator);
+lstrcatW(wsz
James Hawkins wrote:
On 5/25/07, Mounir IDRASSI <[EMAIL PROTECTED]> wrote:
Hi,
You also have to modify other files in order to integrate your stub
implementation to the wine build chain: Makefile.in, configure and
configure.ac in the wine root directory, Makefile.in in the "dlls"
directory.
T
Sorry for jumping in, but I have some comments as well.
Dan, CopyFileA does not leaks a string (note BOOL flags). Instead first
call use static TEB-based buffer so this is OK, given that recursion is
impossible in this case.
Kevin, you are setting file size before copy starts. I'm not sure
Wind
It's something like
BOOL SetupQueryRegisteredOsComponent(IN const IID *const pIid, IN OUT
LPVOID component_data, IN OUT LPVOID exception_data, DWORD reserved1,
DWORD reserved2);
component_data structure max length is 0xDC, exception_data's is 0x454;
first argument of both is structure size.
Mike McCormack wrote:
This is the first time I've submitted a patch, so let me know if this
method of submission is incorrect. See description in the attachment.
It's best to put the description in the body of the mail, and write a
descriptive subject like "ole32: fix StgOpenStorage conforma
First thing to do is to open bug at bugs.winehq.org and describe your
problem there.
Then, please try to:
1) copy msimtf.dll from Windows to your wine's system32, register it
with regsvr32 and try if Solid Works issue persists
2) copy atl.dll from Windows to your wine's system32, register it and
Some comments inside. Sorry for over-quoting :)
Dmitry Timoshkov wrote, on 11/13/06 10:19 MSK:
> "Andrey Turkin" <[EMAIL PROTECTED]> wrote:
>
>>> What is the file alignment of the problematic PE file? Is it 512
>>> (0x200) by any chance?
>>>
>
Dmitry Timoshkov wrote:
"Andrey Turkin" <[EMAIL PROTECTED]> wrote:
if (map_file_into_view( view, fd, 0, header_size, 0,
VPROT_COMMITTED | VPROT_READ,
-removable ) != STATUS_SUCCESS) goto
error;
+TRUE ) != STATUS_SUC
Dmitry Timoshkov wrote:
"Andrey Turkin" <[EMAIL PROTECTED]> wrote:
if (map_file_into_view( view, fd, 0, header_size, 0,
VPROT_COMMITTED | VPROT_READ,
-removable ) != STATUS_SUCCESS) goto error;
+TRUE ) != STATUS_SUC
Please ignore this patch. I'll resubmit corrected version.
Francois, thanks!
Francois Gouget wrote:
On Mon, 6 Nov 2006, Andrey Turkin wrote:
[...]
The MSDN is wrong: the PSDK does not define any of SHELL_USER_SID,
SHELL_USER_PERMISSION or GetShellSecurityDescriptor(). So they shou
Francois Gouget wrote:
On Mon, 6 Nov 2006, Andrey Turkin wrote:
[...]
The patch also adds 2 structures definitions to include/shlwapi.h.
According to MSDN, one of these structures should be placed into
include/shlobj.h,
The MSDN is wrong: the PSDK does not define any of SHELL_USER_SID
Mike McCormack wrote, on 10/24/06 00:01 MSK:
>
> Matthew Kehrer wrote:
>
>> So what commands are needed to just update it?
>> I understand how to set it up from what you have said.
>
> So, assuming you created a Git tree from Wine tarball as follows:
>
> tar jxvf wine-0.9.23.tar.bz2 | sed s/^wi
Jacek Caban wrote, on 10/20/06 22:13 MSK:
> Hi Andrey,
>
> Andrey Turkin wrote:
>> Hi,
>>
>> Just found a bug in mshtml component get_body method implementation. If
>> one call it right after creation of CLSID_HTMLDocument instance, then it
>> would retu
James Hawkins wrote:
> On 7/4/06, Andrey Turkin <[EMAIL PROTECTED]> wrote:
>>
>> Hi James,
>>
>> Funny, your patch looks just identical to mine (submitted but rejected
>> by some reason) except for comments :)
>>
>
> hmm I haven't seen your
James Hawkins wrote:
> Hi,
>
> This fixes bug 5595. The Lotus Notes installer was calling
> MsiSetTargetPath after the CostFinalize action, which is where the
> target paths are originally set for installation files. Originally,
> the directories were being changed, but that doesn't trickle down
Robert Shearman wrote:
> ---
...
> @@ -603,10 +608,18 @@ static BOOL service_handle_control(HANDL
>
> TRACE("received control %ld\n", dwControl);
>
> -if (service_accepts_control(service, dwControl) && service->handler)
> +if (service_accepts_control(service, dwControl))
>
Mike McCormack wrote:
>
> Hi,
>
> Thanks for submitting the patch, and keeping the coding style consistent!
Well, i tried :)
>
> Andrey Turkin wrote:
>> This patch adds virtual _Streams table to MSI because native MSI
>> maintains such table
>>
>>
Dan Kegel wrote:
> In http://www.winehq.org/pipermail/wine-patches/2006-June/027528.html,
> Andrey Turkin wrote:
>
>> Some installers depends on _Streams built-in table
>
> Which installers?
> It'd be nice to have a bug in bugzilla to hang your MSI work on.
>
Andrew Ziem wrote:
Please use this patch instead of previous "user3.patch". Thanks to
Andrey Turkin for catching the uninitialized variable.
changelog:
user: handle special cases for SPI_SETDESKWALLPAPER
The special cases remove the wallpaper or set it to default.
Previously, t
I cannot see where emptyW initialized.
Andrew Ziem wrote:
The special cases remove the wallpaper or set it to default.
Previously, these cases were ignored, so Wine would crash.
+if (NULL == pvParam || SETWALLPAPER_DEFAULT == pvParam)
+{
+static const WCHAR empt
Andrew Ziem wrote:
Previously, SPI_GETDESKWALLPAPER was handled by default: in the
switch, so the function (an A- function) would return a W string.
5e4b86d689c899fc896d2870efaca9c335f01da0
diff --git a/dlls/user/syspara
I used nasm and hiew. There is no point in adding additional tools
dependencies. Anyway the test codes wouldn't be changed somehow often.
And anyway I'm already submitted patch :)
Detlef Riekenberg wrote:
Am Montag, den 05.06.2006, 11:58 +0100 schrieb Mike Hearn:
On 6/5/06, Robert Shearman <[E
I believe it is better to store binaries as arrays and use temporary
files than drop many small .com binaries all over the code tree (for now
I have 3 test programs about 30 bytes each). It is possible to
comment/disassemble test cases instruction by instruction, if needed.
Also, not everyone
Dan Kegel wrote:
Andrey wrote:
My opinion is that NtSetContextThread call is wrong; __wine_enter_vm86
would restore vm86 registers correctly. I think i know what is the
problem; however, I lack experience to fix it myself :)
I need help; any hints would be appreciated.
How about writing a conf
Hi all!
I think i found a bug in VM86 exception handling (must be regression, i
guess).
Short Wine function flow:
On privileged instruction __wine_enter_vm86 saves vm86 registers in
CONTEXT and starts raise_segv_exception.
raise_segv_exception routes exception to the INSTR_EmulateInstruction
Molle Bestefich wrote:
echo "=media-gfx/fontforge-20060406" >> /etc/portage/package.keywords
echo "media-gfx/fontforge ~x86" >> /etc/portage/package.keywords
Latter version is definitely preferable, as otherwise FontForge will
never again be upgraded (right?).
I believe that former version
I thought INVALID_HANDLE_VALUE==-1 and not 0. Moreover, I can't see any
code path leading to ERR where handle is allocated (or assigned to) at
all so I think there is no need to close it.
Mike Hearn wrote:
Mike Hearn <[EMAIL PROTECTED]>
Don't close uninitialized handle on VXD error path
diff
70 matches
Mail list logo
