RE: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)

2009-04-09 Thread Andreas Rosenberg
Thanks for the clarification about todo_wine, Paul Paul Vriens wrote: >Well I don't think it will be accepted as is. We usually don't add >functions that are not used anywhere especially when the comments say >that there is a bug elsewhere that should be fixed first. Well, I was thinking about d

RE: advapi32/tests

2009-04-09 Thread Andreas Rosenberg
Paul Vriens wrote: >And the subject of the mail should be a bit more than just "advapi32/tests". Oops, sry. Read the second mail after resending in the patch containing your first suggestions. But I'm a bit confused about the meaning of todo_wine. todo_wine discards output from failed tests, if I

RE: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)

2009-04-08 Thread Andreas Rosenberg
Thanks for your hints, Paul. I added some tests for the Ansi variant of the function and fixed the problem you mentioned. >I also think that your addition of _GetAccountNameFromTokenW is holding the >committing of this patch back, especially because you don't seem to use that >function. I also a

Patch regarding GetUserProfileDirectory

2009-04-06 Thread Andreas Rosenberg
Hi! I sent a patch regarding GetUserProfileDirectory last Monday. I didn't receive any comments/critics as on my previous attempts. The patch doesn't appear in wine-cvs, so I suppose something is still not correct. Can anybody give me a clue, please? Regards Andreas

RE: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)

2009-03-30 Thread Andreas Rosenberg
>Were you intending to send this to wine-patches? Yes. Sorry for posting on the wrong list.

dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)

2009-03-30 Thread Andreas Rosenberg
From acb4bf2dc4ecbd56fa54dfcbd8be2b270929d865 Mon Sep 17 00:00:00 2001 From: Andreas.Rosenberg Date: Mon, 30 Mar 2009 10:19:50 +0200 Subject: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A --- dlls/userenv/Makefile.in |2 +- dlls/userenv/tests/userenv.c | 40 ++ dlls/use

LookupAccountSidW returns "unexpected" username

2009-03-10 Thread Andreas Rosenberg
While I did some experimenting with the proposals from Vitaliy Margolen to get an accepted patch for GetUserProfileDirectoryW, I found this behavior: OpenProcessToken(hProcess,TOKEN_QUERY,&hToken); ... GetTokenInformation( hToken, TokenUser, ptiUser, cbti, &cbti ) ... LookupAccountSidW( NULL, pti

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (7)

2009-03-10 Thread Andreas Rosenberg
Vitaliy Margolen wrote: >> +res = RegOpenKeyExW( HKEY_LOCAL_MACHINE, profile_pathname, 0L, >> KEY_QUERY_VALUE, &keyProfileDir ); >> +res = RegGetValueW( keyProfileDir, profile_subkey, >> profile_keyname, RRF_RT_ANY, >> + NULL, buffer, &sizePath ); /* RegGetVa

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (6)

2009-03-06 Thread Andreas Rosenberg
On Friday 06 March 2009 14:12:11 you wrote: > Paul Vriens wrote: > > Andreas Rosenberg wrote: > >> > > > > Hi, > > > > Error during compilation: > > > > userenv_main.c:1

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (2nd try)

2009-03-06 Thread Andreas Rosenberg
Vitaliy Margolen wrote: >> "The error codes returned by a function are not part of the Windows API > > But they are. MS just made their obligation to document all of their craft > that much easer and that much more undefined. According to this logic > "Error!" is the only message you need for anyt

dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (5)

2009-03-05 Thread Andreas Rosenberg
From d59c1fe3e26e0cb41a3affe4034abc6dc9bd0556 Mon Sep 17 00:00:00 2001 From: Andreas.Rosenberg Date: Thu, 5 Mar 2009 18:41:37 +0100 Subject: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A --- dlls/userenv/Makefile.in |2 +- dlls/userenv/tests/userenv.c | 37 + dl

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (2nd try)

2009-03-05 Thread Andreas Rosenberg
Nikolay Sivov wrote: > Andreas Rosenberg wrote: > > +    if ( !lpcchSize ) { > +        SetLastError(ERROR_INVALID_PARAMETER); > +        return FALSE; > > > +                    SetLastError(ERROR_MORE_DATA); > +                } > +            

RE: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (2nd try)

2009-03-05 Thread Andreas Rosenberg
>> I don't consider it helpful writing a conformance test, for something >> that is not specified. One could simply omit the error codes, but if >> this call should fail an app may log/present a more meaningfull error >> message than without it. If the error codes should be different from >> Windo

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (2nd try)

2009-03-04 Thread Andreas Rosenberg
Nikolay Sivov wrote: > Andreas Rosenberg wrote: > > +if ( !lpcchSize ) { > +SetLastError(ERROR_INVALID_PARAMETER); > +return FALSE; > > > +SetLastError(ERROR_MORE_DATA); > +} > +

Re: dlls/userenv: fixed stubs GetUserProfileDirectoryW/A

2009-03-02 Thread Andreas Rosenberg
On Monday 02 March 2009 17:26:47 Nikolay Sivov wrote: > Andreas Rosenberg wrote: > > +TRACE("%p %s %p\n", hToken, debugstr_w(lpProfileDir), lpcchSize ); > +/* profile specific tokens not supported, so hToken ignored */ > + > +SetLastError(0);

Incompatible behavior of InvalidateRect/LB_SELITEMRANGE/SetCapture

2005-11-01 Thread Andreas Rosenberg
Hi! From time to time I'm testing our application (IQ-FMEA) with Wine. Our GUI framework is checking the return codes of most API calls, so several incompatibilities between Windows and Wine are detected while many other programs simply ignore them. So I found several things that differ between

Promoting WINE

2004-09-23 Thread Andreas Rosenberg
Hello Wine developers, perhaps some guys will remember me. I'm working for a small software company making a tool for FMEA and risk management. Late last year I managed to make our application work with Wine by submitting some patches. Our company held it's anual user meeting this week in Pforzh

Wine and non ANSI charset fonts

2004-09-10 Thread Andreas Rosenberg
Hello guys, after a long pause I'm back testing our application (http://appdb.winehq.org/appview.php?appId=1536) with WINE. In the meantime I've been working to prepare our application for the east european/asian market (UTF16, wide char API). This seems to work so far, but as soon as you enter

Re: Status of TAPI

2004-04-08 Thread Andreas Rosenberg
> Well I am the author of those patches and I'm afraid there is no chance > that they will help Andreas case. It is an extreme hackish > implementation of a data modem tailored to a single application. No > notion of drivers, certainly no support for external drivers and control > panel interface.

Status of TAPI

2004-04-06 Thread Andreas Rosenberg
Hi guys! I'd like to run a TAPI based application in Wine (updated from CVS today). I extracted the vendor specific TAPI driver and the registry keys and included both into a Wine setup. Then I tried to do setup the TAPI driver using the telephon.cpl (taken from Win98): wine rundll32.exe shell

Sending patch for bug 1848

2004-02-05 Thread Andreas Rosenberg
Hi folks, I sent a patch for bug 1848 already twice. 1st time in the first half of december. 2nd time last week. Other stuff seems to be commited into the CVS. I was wondering, why my patch is not accepted. Can't you keep the pace commiting the patch into the CVS as they are sent to you? Is so

GetCommandLine issue with Dungeon Keeper

2004-01-19 Thread Andreas Rosenberg
> From my notes (I dont have Linux to hand just now): > Trap occurs ar 0x43d4e2 > At this point in time the path/exe is in 0x552150 On windows: > This was copied from 0x12fe20 (Was already filled in at a breakpoint at > 0x43d4ba) > which in turn came from 0x141ee0 when the pgm is very first loaded

Re: Need help debugging ... Ddraw issue

2004-01-17 Thread Andreas Rosenberg
> Perhaps. I'd be willing to bet that virtually all (gui) win32 apps are > tested by running it from explorer or the shell, which seems to use full > paths though. I'd also bet 5 EUROs ;-) > So the fact that we usually run without a full path seems to > be problematic. I guess there's a slight c

Re: Need help debugging ... Ddraw issue

2004-01-17 Thread Andreas Rosenberg
Frank Schruefer wrote: > But now what to do? > Suggestions? Shouldn't the WINE exe loader imitate the behavior of an application being started by the Explorer in Windows? I don't know if this is a possible solution, but this seems to be the most "compatible" one. I think the NT behavior is tha

Re: Need help debugging ... Ddraw issue

2004-01-17 Thread Andreas Rosenberg
Hello guys, I'm watching this thread since yesterday. Perhaps I can give you a clue. > >I'm trying to investigate that GetCommandLine thing. > The one thing I couldnt answer is how the game 'gets' the command line. int WinMain( HINSTANCE hInstance, HINSTANCE hPrevInstance, L

Re: PATCH for Bugs 1844 and 1845

2003-12-11 Thread Andreas Rosenberg
I sent two patches about a week ago. The first one: "Bug 1844: Point Size in DLG_TEMPLATE may be negative" made it into the CVS (I browsed with: http://cvs.winehq.com/cvsweb) The second "Bug 1845: Return values of CharUpperA and CharLowerA" did not. Any reasons to reject this patch? I also wrot

Thoughts about fixing bug 1848

2003-12-06 Thread Andreas Rosenberg
I was thinking about fixing the bug 1848. Here are parts of the involved functions. See my comments/questions with multiple *** inside: --- BOOL WINAPI TrackPopupMenu( HMENU hMenu, UINT wFlags, INT x, INT y, INT nReserved, HWND hWnd, const R

Status of InstallShield-Setup Engine

2003-12-04 Thread Andreas Rosenberg
Hi! I'm new to this list. The company I'm working for, is developing software for Windows and as a personal Linux fan I was testing our software with Wine from time to time. The last tries (several month ago) were still pretting bad, but with the Wine from Suse 9.0 (snapshot from August 2003) ther