On 06/09/2013 16:28, Alexandre Julliard wrote:
> Amine Khaldi writes:
>
>> @@ -18,15 +18,7 @@
>> * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
>> */
>>
>> -#include "config.h"
>> -
>> -#incl
On 12/03/2013 11:27, Alexandre Julliard wrote:
> Amine Khaldi writes:
>
>> @@ -28,13 +28,10 @@
>>
>> #include "windef.h"
>> #include "winbase.h"
>> -#include "winuser.h"
>>
>> #include "objbase.h"
>&
Hello folks,
Recently we (myself and Urias from Haiku) have been working on getting
the coverity scans up and running again. I'm happy to announce that we
succeeded ! :)
I submitted a scan and the results are up online. I'll submit further
scans when necessary, like it's already done with cl
Hello folks,
I've set up a static analysis scan using clang static analyzer. The
results are available at
http://austinenglish.com/logs/clang_analyzer/index.html thanks to Austin
for the web space.
Please feel free to fix the defects. I'll run future scans when the
defects get fixed progres
Not really, it's up to you too. This is essentially a style-only
change. Alexandre generally frowns on these, but reluctantly accepts
them if the existing style is horrible, or if you're actively involved
in the code being modified. Neither appears to be true here. This is
a helpful hint to a
Hi Amine,
Hi Juan,
Um, it's called a prototype, and it's needed to compile
smtptransport.c. Have you tested this patch at all?
I knew it was a prototype, I just thought it was left over, as it wasn't
at the top of the file, and I saw no other prototype in that file. As
for testing,
It makes the code use one less variable. I don't see how is this dubious,
but I understand that it's trivial.
Yes, at the cost of potentially less readability, or, depending on the
compile settings, a little more difficulty in checking whether the
function succeeded. I don't see that the
Hi Amine,
Hi Juan,
this patch has no functional benefit. For example,
-HRESULT hr;
TRACE("\n");
-hr = SMTPTransport_ParseResponse(This, pBuffer,&response);
-if (FAILED(hr))
+if (FAILED(SMTPTransport_ParseResponse(This, pBuffer,&response)))
This has the dubious ben
Hey Chip,
I think he's using Clang. I've seen him on the LLVM bugzilla. He's
waiting for someone (e.g. me) to fix the bugs that prevent Wine from
being compiled with Clang.
That's right.
BTW, if and when you find a bug using Clang, be sure to put
"(Clang/LLVM)" in the title--or at least menti
Out of curiosity, what tool are you using to find these bugs?
Clang.
WBR,
Amine.
Hi Amine,
Hi Jacek,
r = register_clsid(&CLSID_StdHlink);
if (SUCCEEDED(r))
-r = register_clsid(&CLSID_StdHlinkBrowseContext);
+register_clsid(&CLSID_StdHlinkBrowseContext);
return S_OK;
In this case the correct fix is to return r. Please be more careful
11 matches
Mail list logo
