Re: comctl32: realloc or free and alloc

2011-05-01 Thread Alexey Fisher
On So, 2011-05-01 at 21:55 +0400, Nikolay Sivov wrote: > On 5/1/2011 21:49, Alexey Fisher wrote: > > On So, 2011-05-01 at 19:11 +0400, Nikolay Sivov wrote: > >> On 5/1/2011 13:07, Alexey Fisher wrote: > >>> There is a new patch in the attachment. > >>&g

Re: comctl32: realloc or free and alloc

2011-05-01 Thread Alexey Fisher
On So, 2011-05-01 at 19:11 +0400, Nikolay Sivov wrote: > On 5/1/2011 13:07, Alexey Fisher wrote: > > > > There is a new patch in the attachment. > > > BOOL Str_SetPtrAtoW (LPWSTR *lppDest, LPCSTR lpSrc) > > { > > -TRACE("(%p %s)\n", lppDest,

Re: comctl32: realloc or free and alloc

2011-05-01 Thread Alexey Fisher
On So, 2011-05-01 at 08:05 -0700, Dan Kegel wrote: > On Sun, May 1, 2011 at 2:07 AM, Alexey Fisher > wrote: > >> > The code looks like it assumes that pointer is always > >> > managed by Alloc/ReAlloc/Free. In what context is > >> > the destination a

re: comctl32: realloc or free and alloc

2011-05-01 Thread Alexey Fisher
On So, 2011-05-01 at 07:43 +0200, Alexey Fisher wrote: > Am Samstag, den 30.04.2011, 14:41 + schrieb Dan Kegel: > > Alexey wrote: > > > > > i currently digg in comctl32 to find why my app fails. I found that > > > string conversation AtoW in some plac

re: comctl32: realloc or free and alloc

2011-04-30 Thread Alexey Fisher
Am Samstag, den 30.04.2011, 14:41 + schrieb Dan Kegel: > Alexey wrote: > > > i currently digg in comctl32 to find why my app fails. I found that > > string conversation AtoW in some places silently fails. The problem is > > that the destination for string is just a fresh pointer (not NULL). >

comctl32: realloc or free and alloc

2011-04-29 Thread Alexey Fisher
Hallo, i currently digg in comctl32 to find why my app fails. I found that string conversation AtoW in some places silently fails. The problem is that the destination for string is just a fresh pointer (not NULL). Str_SetPtrAtoW check if it is NULL pointer and if not it trys to ReAlloc. There was

Re: [PATCH] Add undocumented function to unify MultiByteToWideChar conversation

2011-04-28 Thread Alexey Fisher
Am Donnerstag, den 28.04.2011, 09:25 +0200 schrieb Marcus Meissner: > On Thu, Apr 28, 2011 at 09:03:51AM +0200, Alexey Fisher wrote: > > Am Donnerstag, den 28.04.2011, 10:49 +0400 schrieb Nikolay Sivov: > > > On 4/28/2011 10:45, Alexey Fisher wrote: > > > > MultiByte

Re: [PATCH] Add undocumented function to unify MultiByteToWideChar conversation

2011-04-28 Thread Alexey Fisher
Am Donnerstag, den 28.04.2011, 09:25 +0200 schrieb Marcus Meissner: > On Thu, Apr 28, 2011 at 09:03:51AM +0200, Alexey Fisher wrote: > > Am Donnerstag, den 28.04.2011, 10:49 +0400 schrieb Nikolay Sivov: > > > On 4/28/2011 10:45, Alexey Fisher wrote: > > > > MultiByte

Re: [PATCH] Add undocumented function to unify MultiByteToWideChar conversation

2011-04-28 Thread Alexey Fisher
Am Donnerstag, den 28.04.2011, 10:49 +0400 schrieb Nikolay Sivov: > On 4/28/2011 10:45, Alexey Fisher wrote: > > MultiByteToWideChar are called directly only from one function. All other > > colls in comctl32 go thrue this function. > > > It was recovered with from dissa

[PATCH] Add undocumented function to unify MultiByteToWideChar conversation

2011-04-27 Thread Alexey Fisher
MultiByteToWideChar are called directly only from one function. All other colls in comctl32 go thrue this function. It was recovered with from dissassambled code. Signed-off-by: Alexey Fisher --- dlls/comctl32/comctl32undoc.c | 41 + 1 files changed, 41