Re: UNC Pathname handling

> If longpath is indeed a long path you could compare it with temppath? Yes, I can do that! Updates to follow. Kind regards Alexandre -- ------ Alexandre Hardy http://www.ahardy.za.net

Re: UNC Pathname handling

d maybe be a FIXME now? Share names are still not covered. So it is a slite improvement for UNC pathnames, but not a complete improvement. I'll follow your guidelines on this point. Kind regards Alexandre -- -- Alexandre Hardy http://www.ahardy.za.net

Re: UNC Pathname handling

Hi Paul, Here is the patch for GetLongPathNameW. Would you mind looking at it to see if it makes sense? (Forgot to bottom post in the last message :-( ) Kind regards Alexandre -- -- Alexandre Hardy http://www.ahardy.za.net From

Re: UNC Pathname handling

Hi Paul, Thanks for the help with the tests. Here is a new set of tests. I'll send the patch that makes these tests succeed shortly. I would appreciate it if you could have a look at it. Kind regards Alexandre On Fri, Dec 11, 2009 at 12:25 PM, Alexandre Hardy wrote: > Hi Paul, > >

Re: UNC Pathname handling

n you call pGetLongPathNameW with NULL? Yes, sorry, that should be GetShortPathNameW(tempfile, shortpath + 4, MAX_PATH - 4); > These are added tests but Wine crashes right now with these? Yes, wine crashes right now with these. Kind regards Alexandre -- -- Alexandre Hardy http://www.ahardy.za.net

Re: UNC Pathname handling

> A proposed patch with such tests is attached. > There is a bug, the call to GetShortPathName should be GetShortPathNameW(tempfile, shortpath + 4, MAX_PATH - 4); Kind regards Alexandre

Re: UNC Pathname handling

patch with such tests is attached. Thanks for the friendly advice! Kinf regards Alexandre -- -- Alexandre Hardy http://www.ahardy.za.net From 742e937bf945d7769b99782e21e1b5e4f567b6d0 Mon Sep 17 00:00:00 2001 From: Alexandre Hardy Date: Fri, 11 Dec 2

Re: UNC Pathname handling

d the MSDN). Kind regards Alexandre On Fri, Dec 11, 2009 at 10:56 AM, Paul Vriens wrote: > Hi Alexandre, > > On 12/11/2009 09:49 AM, Alexandre Hardy wrote: >> >> Hi Paul, >> >> I guess it could fall under bug #19807. I was actually testing it with >> Nokia Ovi In

UNC Pathname handling

or should more general sharing be implemented? The patch is included as an attachment to this message. Kind regards Alexandre -- -- Alexandre Hardy http://www.ahardy.za.net From b013419f366c83248704f444cbbb6976df740fc9 Mon Sep 17 00:00:00 2001

Re: UNC Pathname handling

fer not to work further on UNC pathnames that refer to shares, I would rather try to solve other problems... Kind regards Alexandre On Fri, Dec 11, 2009 at 10:32 AM, Paul Vriens wrote: > Hi Alexandre, > > On 12/11/2009 09:02 AM, Alexandre Hardy wrote: >> >> Hi, >> >&

Re: dlls/kernel32/path.c: Fix return values for UNC pathnames in GetLongPathNameW

ould be. I will need to read up to find an example that I can guarantee the length of. Kind regards Alexandre On Tue, Dec 1, 2009 at 12:52 PM, Paul Vriens wrote: > On 12/01/2009 08:44 AM, Alexandre Hardy wrote: >> >> +    length = (*pGetLongPathNameW)(unc_path,NULL,0); &g

dlls/kernel32/path.c: Fix return values for UNC pathnames in GetLongPathNameW

buffer. This ensures that the buffer is not written to (for UNC pathnames) if the buffer is not large enought to store the path. Kind regards Alexandre -- -- Alexandre Hardy http://www.ahardy.za.net From 84f1d7704d3f0d88654ad93ed62651ffc08e3208 Mon