Re: [1/2] wininet: Partially implement FreeUrlCacheSpaceW. (try 2)

2011-03-10 Thread Alexander Scott-Johns
On 10 March 2011 14:57, Alexandre Julliard wrote: > Alexander Scott-Johns writes: > >> @@ -1660,6 +1660,16 @@ BOOLAPI DeleteUrlCacheEntryA(LPCSTR); >>  BOOLAPI DeleteUrlCacheEntryW(LPCWSTR); >>  #define DeleteUrlCacheEntry  WINELIB_NAME_AW(DeleteUrlCacheEntry)

Re: comctl32: Fix read of uninitialized data in LISTVIEW_GetItemExtT when LVIF_TEXT is not set (Valgrind).

2011-02-19 Thread Alexander Scott-Johns
On 19 February 2011 11:42, Nikolay Sivov wrote: > I think it's enough to add a mask check here: > --- >    if (bResult && lpLVItem->pszText != pszText) > --- > > to keep a single call of GetItem. But isn't pszText = lpLVItem->pszText; undefined behaviour if lpLVItem->pszText is not initial

Re: msvcrt printf test failed on NT4,win95

2010-06-08 Thread Alexander Scott-Johns
On 8 June 2010 00:56, Alexander Scott-Johns wrote: > Thomas, > > On 7 June 2010 20:04, Thomas Heckel wrote: >> Hi Alexander, >> >> I was wondering why your patch b205fd8108eca2fd29705875e53ed852f56a6b6d >> "Proberly skip if functions are not available"

Re: msvcrt printf test failed on NT4,win95

2010-06-07 Thread Alexander Scott-Johns
Thomas, On 7 June 2010 20:04, Thomas Heckel wrote: > Hi Alexander, > > I was wondering why your patch b205fd8108eca2fd29705875e53ed852f56a6b6d > "Proberly skip if functions are not available" made test errors on NT4 > and Win95 test instead of a skip while it works on newer windows > platforms as

Re: [7/7] msvcrt/test: Add some simple _vsnwprintf_s tests. (try 2)

2010-06-06 Thread Alexander Scott-Johns
On 7 June 2010 05:39, Austin English wrote: > On Sun, Jun 6, 2010 at 11:36 PM, Alexander Scott-Johns > wrote: >> try 2: todo_wines removed since _vsnwprintf_s is fixed by patch 5. > > The todo_wine's need to be removed in the same patch in which they are > fixed, other

Fwd: [1/2] programs/notepad: Load UTF-8 codepage name from resources instead of using GetCPInfoEx.

2010-04-21 Thread Alexander Scott-Johns
Forgot to Reply All -- Forwarded message -- From: Alexander Scott-Johns Date: 21 April 2010 16:40 Subject: Re: [1/2] programs/notepad: Load UTF-8 codepage name from resources instead of using GetCPInfoEx. To: Dmitry Timoshkov On 21 April 2010 16:08, Dmitry Timoshkov wrote