Re: [1/3] xmllite: Use buffer offset instead of pointers

2013-10-07 Thread Alexandre Julliard
Nikolay Sivov writes: > On 10/6/2013 19:06, Nikolay Sivov wrote: >> It's normal to grow destination buffer, in this case all stored >> pointers will be trashed. This patch uses offsets from start of a >> buffer instead. >> > Hi, Alexandre. > > Patches list shows a build failure for this one, and

Re: msi/tests: Use BOOL type where appropriate (resend)

2013-10-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2667 Your paranoid andr

Re: msi/tests: Use BOOL type where appropriate

2013-10-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2660 Your paranoid andr

Re: [1/3] xmllite: Use buffer offset instead of pointers

2013-10-07 Thread Nikolay Sivov
On 10/6/2013 19:06, Nikolay Sivov wrote: It's normal to grow destination buffer, in this case all stored pointers will be trashed. This patch uses offsets from start of a buffer instead. Hi, Alexandre. Patches list shows a build failure for this one, and I don't see any failures on testbot

Re: mscoree: Partial implement ICLRMetaHost RequestRuntimeLoadedNotification (try 2)

2013-10-07 Thread Vincent Povirk
HRESULT CLRMetaHost_CreateInstance(REFIID riid, void **ppobj) { +GlobalCLRMetaHost.callback = NULL; return ICLRMetaHost_QueryInterface(&GlobalCLRMetaHost.ICLRMetaHost_iface, riid, ppobj); } I don't think we should be changing global state every time someone creates an instance of this

Re: riched20: Set control content in WM_CREATE message

2013-10-07 Thread Alexandre Julliard
Piotr Caban writes: > --- > dlls/riched20/editor.c | 21 + > dlls/riched20/tests/editor.c | 38 ++ > 2 files changed, 59 insertions(+) It doesn't work: ../../../tools/runtest -q -P wine -M riched20.dll -T ../../.. -p riched20_test.

Re: [PATCH 2/3] msvcrt: Add support for vcall thunks demangling (try2)

2013-10-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2651 Your paranoid andr

Re: [PATCH 2/3] msvcrt: Add support for vcall thunks demangling

2013-10-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2649 Your paranoid andr

Re: [PATCH 3/3] msvcrt: Add support for vtordispex demangling

2013-10-07 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2650 Your paranoid andr

Re: msvcrt: add support for _chsize_s (try #2)

2013-10-07 Thread Piotr Caban
Hi, On 10/06/13 00:45, morphiend wrote: + * _chsize_s (MSVCRT.@) + */ +int CDECL MSVCRT__chsize_s(int fd, __int64 size) +{ +LARGE_INTEGER cur, pos; +LARGE_INTEGER temp = { 0 }; This causes compilation warnings. There's also a trailing space in this line. +TRACE("(fd=%

Re: binfmt support

2013-10-07 Thread Henri Verbeet
On 7 October 2013 12:06, xantares 09 wrote: > ... I don't see a reason why to not include it at the wine level instead of > every linux distros, see: > https://github.com/xantares/wine/commit/76ebd5d29effaf4b6b39ceecb689f7008bf6b376 > > What do you think ? > Ignoring the discussion if we want this

binfmt support

2013-10-07 Thread xantares 09
Hello, I made a patch to add a configuration file to be picked up by binfmt to allow to associate windows executables to wine. As binfmt is now a part of systemd in most linux disttributions: http://www.freedesktop.org/software/systemd/man/systemd-binfmt.service.html ... I don't see a reason w