Re: rpcss: Convert to a service

2013-10-02 Thread Andrew Cook
Ignore this, for some reason this randomly forks a huge number of rpcss instances, and decided to not do so while i was testing it On 03/10/13 14:00, Andrew Cook wrote: > --- > dlls/rpcrt4/rpc_epmap.c | 40 --- > programs/rpcss/Makefile.in | 2 +- > programs/rpcss/rpcss_main

Re: server: Set the unix file write mode bit also for FILE_APPEND_DATA access.

2013-10-02 Thread Dmitry Timoshkov
Dmitry Timoshkov wrote: > diff --git a/server/file.c b/server/file.c > index 2ecf97c..94d3060 100644 > --- a/server/file.c > +++ b/server/file.c > @@ -459,7 +459,7 @@ static mode_t file_access_to_mode( unsigned int access ) > > access = generic_file_map_access( access ); > if (access

Looking for an icon for the Mac driver: generic program running under Wine

2013-10-02 Thread Ken Thomases
Hi, I have a need for a new icon in Wine and I'm hoping somebody with some graphics-design skills might be able to create it. The Mac driver attempts to extract an icon from the executable to use for the Dock icon of its process. This is also the icon that appears in the Command-Tab applicati

Re: [5/5] ws2_32: Always return the source address from WSAAccept.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2610 Your paranoid andr

Re: [4/5] ws2_32: Return an error from accept if the address buffer is too small.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2609 Your paranoid andr

Re: [3/5] ws2_32: Add some tests for getpeername.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2608 Your paranoid andr

Re: [2/5] ws2_32: Always clear res on error in getaddrinfo/GetAddrInfoW.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2607 Your paranoid andr

Re: [1/2] gdi32: Fix the B spacing value of empty glyph. (try 3)

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2605 Your paranoid andr

Re: [2/2] gdi32: Don't modify output glyph metrics unless the function succeeds. (resend)

2013-10-02 Thread Alexandre Julliard
Akihiro Sagawa writes: > --- > dlls/gdi32/freetype.c | 12 > dlls/gdi32/tests/font.c |5 + > 2 files changed, 13 insertions(+), 4 deletions(-) It looks like something is not quite right, this is causing strange spacing, for instance in the About dialog. -- Alexandre

Re: I'm not sure why it was rejected

2013-10-02 Thread Vincent Povirk
> I guess if you SetLastError to not implemented you cannot return S_OK too It doesn't make sense to use SetLastError at all for functions returning HRESULT.

Re: [PATCH 2/7] qedit/tests: Use the W version of FindResource().

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2455 Your paranoid andr

Re: [PATCH 4/7] msvcr90/tests: Use the W form of CreateEvent().

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2457 Your paranoid andr

Re: I'm not sure why it was rejected

2013-10-02 Thread Marcus Meissner
On Wed, Oct 02, 2013 at 12:26:51PM -0300, Bruno Jesus wrote: > On Wed, Oct 2, 2013 at 12:17 PM, Akira Nakagawa wrote: > > I cannnot make sure my patch 99266 was rejected. > > I can't really tell why it was rejected but I can tell there are mixed > space/tabs in the SetLastError lines. > > I gues

Re: I'm not sure why it was rejected

2013-10-02 Thread Bruno Jesus
On Wed, Oct 2, 2013 at 12:17 PM, Akira Nakagawa wrote: > I cannnot make sure my patch 99266 was rejected. I can't really tell why it was rejected but I can tell there are mixed space/tabs in the SetLastError lines. I guess if you SetLastError to not implemented you cannot return S_OK too Try co

I'm not sure why it was rejected

2013-10-02 Thread Akira Nakagawa
I cannnot make sure my patch 99266 was rejected.

Re: Assorted spelling fixes.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2432 Your paranoid andr

Re: Assorted spelling fixes.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2433 Your paranoid andr

Re: Assorted spelling fixes.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2430 Your paranoid andr

Re: Re: kernel32/tests: Fix the test_waittxempty() timeout.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2434 Your paranoid andr

Re: Assorted spelling fixes.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2431 Your paranoid andr

Re: Assorted spelling fixes.

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2429 Your paranoid andr

Re: [5/5] gdi32: Don't modify output glyph metrics unless the function succeeds. (resend)

2013-10-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2426 Your paranoid andr

Re: kernel32: Add tests for job objects (try 3)

2013-10-02 Thread Nikolay Sivov
On 10/2/2013 12:58, Andrew Cook wrote: +if(!pCreateJobObjectW) { +win_skip("No job object support\n"); +return; +} Once you checked that I suppose you don't need to check for pIsProcessInJob being null, or it still could happen? +if (option && strcmp(option, "wait"

Re: winemac: Reapply display modes when switching back to app after "escaping" with Command-Tab.

2013-10-02 Thread Ken Thomases
On Oct 1, 2013, at 11:24 PM, Ken Thomases wrote: > May fix bug . Should fix bug , too. -Ken