Re: Fix text rotation problem in GM_ADVANCED graphics mode caused by incorrect implementation of GetTextExtentPointW().

2013-10-01 Thread Ralf Habacker
On 01.10.2013 12:40, Alexandre Julliard wrote: > Ralf Habacker writes: > >> On 01.10.2013 12:12, Alexandre Julliard wrote: >>> Ralf Habacker writes: >>> With other patches i have been told to implement such stuff in the dib driver. Unfortunally this do not works in this case, because in

Re: Fix text rotation problem in GM_ADVANCED graphics mode caused by incorrect implementation of GetTextExtentPointW().

2013-10-01 Thread Ralf Habacker
On 01.10.2013 12:12, Alexandre Julliard wrote: > Ralf Habacker writes: > >> With other patches i have been told to implement such stuff in the dib >> driver. Unfortunally this do not works in this case, because in the top >> level function it looks like having driver specific stuff using display >

Re: mshtml: Added support for 'document' and 'window' script for attribute values.

2013-10-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2427 Your paranoid andr

Re: imm32: ImmGetCandidateWindow should not return unset data

2013-10-01 Thread Aric Stewart
Ok, fixed and resent -aric On 10/1/13 2:13 PM, Alexandre Julliard wrote: > Aric Stewart writes: > >> @@ -663,6 +663,8 @@ HIMC WINAPI ImmCreateContext(void) >> gl->dwSize = sizeof(GUIDELINE); >> ImmUnlockIMCC(new_context->IMC.hGuideLine); >> >> +memset(new_context->IMC.cfCandF

Re: imm32: ImmGetCandidateWindow should not return unset data

2013-10-01 Thread Alexandre Julliard
Aric Stewart writes: > @@ -663,6 +663,8 @@ HIMC WINAPI ImmCreateContext(void) > gl->dwSize = sizeof(GUIDELINE); > ImmUnlockIMCC(new_context->IMC.hGuideLine); > > +memset(new_context->IMC.cfCandForm, -1, > sizeof(new_context->IMC.cfCandForm)); > + That's ugly. If you are using th

Re: mscoree: Implement CreateInterface

2013-10-01 Thread Vincent Povirk
Any reason not to share code with CLRCreateInstance?

Re: [4/5] gdi32: Fix the B spacing value of empty glyph. (try 2)

2013-10-01 Thread Alexandre Julliard
Akihiro Sagawa writes: > Try 2: >- Get rid of redundant trace message in the last patch. > > --- > dlls/gdi32/freetype.c |2 +- > dlls/gdi32/tests/font.c |8 +++- > 2 files changed, 8 insertions(+), 2 deletions(-) This is causing failures here: ../../../tools/runtest -q -P wi

Re: [3/3] ws2_32: Always return the source address from WSAAccept.

2013-10-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2421 Your paranoid andr

Re: kernel32/tests: Fix the test_waittxempty() timeout.

2013-10-01 Thread Francois Gouget
On Tue, 1 Oct 2013, Francois Gouget wrote: [...] > The timeout was too short and would only work for UARTs that have a > FIFO and where the trigger level was set just right. With this patch > we calculate how much time sending the test data will actually take > and tack on a small margin to take

Re: [2/3] ws2_32: Return an error from accept if the address buffer is too small.

2013-10-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2420 Your paranoid andr

Re: [PATCH] dsound: fixup IDirectSoundCaptureBuffer_QueryInterface

2013-10-01 Thread Andrew Eikum
Seems reasonable, but could you put together some tests to show this? Andrew On Sat, Sep 28, 2013 at 10:41:15AM +0200, Maarten Lankhorst wrote: > diff --git a/dlls/dsound/capture.c b/dlls/dsound/capture.c > index 40f1702..0fe300c 100644 > --- a/dlls/dsound/capture.c > +++ b/dlls/dsound/capture.c

Re: [1/3] ws2_32: Always clear res on error in getaddrinfo/GetAddrInfoW.

2013-10-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2419 Your paranoid andr

Re: [3/3] ws2_32: Always return the source address from WSAAccept.

2013-10-01 Thread Hans Leidekker
On Tue, 2013-10-01 at 09:32 -0300, Bruno Jesus wrote: > On Tue, Oct 1, 2013 at 6:37 AM, Hans Leidekker wrote: > > --- > > dlls/ws2_32/socket.c | 9 + > > dlls/ws2_32/tests/sock.c | 6 +++--- > > 2 files changed, 4 insertions(+), 11 deletions(-) > > > > diff --git a/dlls/ws2_32/socket.

Re: [3/3] ws2_32: Always return the source address from WSAAccept.

2013-10-01 Thread Bruno Jesus
On Tue, Oct 1, 2013 at 6:37 AM, Hans Leidekker wrote: > --- > dlls/ws2_32/socket.c | 9 + > dlls/ws2_32/tests/sock.c | 6 +++--- > 2 files changed, 4 insertions(+), 11 deletions(-) > > diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c > index c34de4b..6855298 100644 > --- a/dll

Re: [PATCH 2/5] wined3d: Move location management into the resource.

2013-10-01 Thread Henri Verbeet
Please split this.

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-10-01 Thread Alexandre Julliard
Dmitry Timoshkov writes: > The tests show that this is how fully up to date Windows versions starting > from XP behave, isn't that convincing enough? If not, what else do you need > to see? An application that breaks because of this. -- Alexandre Julliard julli...@winehq.org

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-10-01 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > Do you propose to leave NtWriteFile/NtReadFile in the state when they > > return STATUS_SUCCESS for overlapped writes and reads? But that's clearly > > not how Windows implements this accordingto the tests, and that would > > require changing all the tests to accept

Re: Fix text rotation problem in GM_ADVANCED graphics mode caused by incorrect implementation of GetTextExtentPointW().

2013-10-01 Thread Alexandre Julliard
Ralf Habacker writes: > On 01.10.2013 12:12, Alexandre Julliard wrote: >> Ralf Habacker writes: >> >>> With other patches i have been told to implement such stuff in the dib >>> driver. Unfortunally this do not works in this case, because in the top >>> level function it looks like having driver

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-10-01 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Do you propose to leave NtWriteFile/NtReadFile in the state when they > return STATUS_SUCCESS for overlapped writes and reads? But that's clearly > not how Windows implements this accordingto the tests, and that would > require changing all the tests to accept both valu

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-10-01 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > >> I don't see the point. Do you actually have an app that depends on this? > > > > When I started to work on this I had an app that has one of the reasons to > > require running under Vista+ was the difference in overlapped IO behavior. > > On the other hand the tests

Re: ntdll: Fix the version reported for 64-bit Windows XP.

2013-10-01 Thread Alexandre Julliard
Hans Leidekker writes: > @@ -129,11 +129,19 @@ static const RTL_OSVERSIONINFOEXW > VersionData[NB_WINDOWS_VERSIONS] = > 4, 0, 0, VER_NT_WORKSTATION, 30 /* FIXME: Great, a reserved field > with a value! */ > }, > /* WINXP */ > +#ifdef _WIN64 > +{ > +sizeof(RTL_OSVE

Re: Fix text rotation problem in GM_ADVANCED graphics mode caused by incorrect implementation of GetTextExtentPointW().

2013-10-01 Thread Alexandre Julliard
Ralf Habacker writes: > With other patches i have been told to implement such stuff in the dib > driver. Unfortunally this do not works in this case, because in the top > level function it looks like having driver specific stuff using display > coordinates. It would still most likely have to be

mscoree: Implement CreateInterface

2013-10-01 Thread Alistair Leslie-Hughes
Hi, Changelog: mscoree: Implement CreateInterface Best Regards Alistair Leslie-Hughes >From 6e4b9aff1f2a8776be0ad3cf6e9d0404dd5bec29 Mon Sep 17 00:00:00 2001 From: Alistair Leslie-Hughes Date: Tue, 1 Oct 2013 10:17:50 +1000 Subject: [PATCH 2/2] Implement CreateInterface --- dlls/

oledb32: Implement IDataSourceLocator get/put hWnd (try 4)

2013-10-01 Thread Alistair Leslie-Hughes
Hi, Corrected warnings. Changelog: Implement IDataSourceLocator get/put hWnd Best Regards Alistair Leslie-Hughes >From 13b8466033f24db028bfed6de609c4cd5f84b14a Mon Sep 17 00:00:00 2001 From: Alistair Leslie-Hughes Date: Mon, 30 Sep 2013 14:05:01 +1000 Subject: [PATCH 1/2] Implement IDataSour

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-10-01 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> I don't see the point. Do you actually have an app that depends on this? > > When I started to work on this I had an app that has one of the reasons to > require running under Vista+ was the difference in overlapped IO behavior. > On the

Re: ws2_32: Implement WSASendMsg() (try 3)

2013-10-01 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2414 Your paranoid andr