Re: ntdll: Make asynchronous WaitCommEvent report correct number of bytes returned.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2356 Your paranoid andr

Re: [2/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 2)

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2351 Your paranoid andr

Re: [3/3] gdi32: Don't modify output glyph metrics unless the function succeeds. (try 2)

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2352 Your paranoid andr

Re: [1/3] gdi32: Return GDI_ERROR when requested empty glyph bitmaps. (try 2)

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2350 Your paranoid andr

Re: [PATCH 3/3] msvcrt: Call MSVCRT_strtoi64_l in strtoul implementation (try2)

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2349 Your paranoid andr

Re: [PATCH 1/2] gdi32: fix for rotated Arc, ArcTo, Chord and Pie drawing problem (try 2)

2013-09-26 Thread Alexandre Julliard
Daniel Wendt writes: > @@ -308,6 +308,11 @@ static int get_arc_points( PHYSDEV dev, const RECT > *rect, POINT start, POINT end > } > > memmove( points, points + count, (pos - count) * sizeof(POINT) ); > + > +if (GetGraphicsMode( dev->hdc ) == GM_ADVANCED) > +{ > +LPto

Re: imm32: ImmGetDescriptionA return does not include NULL byte

2013-09-26 Thread Alexandre Julliard
Aric Stewart writes: > @@ -1684,7 +1684,7 @@ UINT WINAPI ImmGetDescriptionA( > >HeapFree( GetProcessHeap(), 0, buf ); > > - return len; > + return min( len - 1, uBufLen ); > } This may do the right thing on failure, but in an ugly way. A few overflow tests would be a good idea. -- A

Re: [PATCH 1/6] riched20: Implement ITextDocument_fnOpen.

2013-09-26 Thread Alexandre Julliard
Jactry writes: > +chBuffer = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size+2); > +if(!chBuffer) > +{ > +CloseHandle(hFile); > +return HRESULT_FROM_WIN32(GetLastError()); > +} It's not useful to zero the buffer since you are reading into it. Also GetLastError

Re: [2/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 2)

2013-09-26 Thread Alexandre Julliard
Akihiro Sagawa writes: > @@ -6519,11 +6519,17 @@ static DWORD get_glyph_outline(GdiFont > *incoming_font, UINT glyph, UINT format, > } > > lpgm->gmBlackBoxX = (right - left) >> 6; > +if (lpgm->gmBlackBoxX == 0) > +lpgm->gmBlackBoxX = 1; > lpgm->gmBlackBoxY = (top - b

Re: (try 5)[1/4] imm32: Move thread data from TLSEntry to an internal list

2013-09-26 Thread Alexandre Julliard
Aric Stewart writes: > @@ -530,12 +591,18 @@ static BOOL CALLBACK > _ImmAssociateContextExEnumProc(HWND hwnd, LPARAM lParam) > */ > BOOL WINAPI ImmAssociateContextEx(HWND hWnd, HIMC hIMC, DWORD dwFlags) > { > +IMMThreadData* thread_data = NULL; > + > TRACE("(%p, %p, 0x%x):\n", hWnd,

Re: dlls: Replace the remaining CONSTs.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2342 Your paranoid andr

Re: [PATCH 2/2] msvcrt: Call MSVCRT_strtoi64_l in strtoul implementation

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2346 Your paranoid andr

Re: dlls: Replace the remaining CONSTs.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2340 Your paranoid andr

Re: kernel32/tests: Add DuplicateHandle test to the file access tests.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2345 Your paranoid andr

Re: dlls: Replace the remaining CONSTs.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2344 Your paranoid andr

Re: dlls: Replace the remaining CONSTs.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2343 Your paranoid andr

Re: dlls: Replace the remaining CONSTs.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2341 Your paranoid andr

Re: ntdll: Perform the offset checks in NtWriteFile also for a serial device.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2339 Your paranoid andr

Re: [2/2] oledb32: Implement IDataSourceLocator get/put hWnd (try 2)

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2338 Your paranoid andr

Re: ntdll: Perform the offset checks also for a serial device.

2013-09-26 Thread Francois Gouget
On Thu, 26 Sep 2013, Dmitry Timoshkov wrote: [...] > Obviously you need nothing to know about the test except that it works with > a COM-port, so the only thing you'd need to investigate is the difference > between VMs in COM-port setup, There's none. All the VMs, wxppro, w7u, w7pro64, etc have th